On 14/07/14 19:49, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > I already pass '-ggdb3 -O1' or '-ggdb3 -Og' for CFLAGS, and I don't want > configure to change them for me. > The topic is a rather messy and whatever we do there will always be a case where this breaks someone's setup/workflow.
In order to minimize the endless bikeshed can we just drop the switch altogether, and leave it to the builder to set these ? This way people will be able to set -O, -g and/or -DDEBUG if they are unhappy with their distro's defaults. Thanks, Emil > Signed-off-by: Ian Romanick <ian.d.roman...@intel.com> > --- > configure.ac | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 4646212..04abcc0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -308,10 +308,20 @@ AC_ARG_ENABLE([debug], > if test "x$enable_debug" = xyes; then > DEFINES="$DEFINES -DDEBUG" > if test "x$GCC" = xyes; then > - CFLAGS="$CFLAGS -g -O0" > + if ! echo "$CFLAGS" | grep -q -e '-g'; then > + CFLAGS="$CFLAGS -g" > + fi > + if ! echo "$CFLAGS" | grep -q -e '-O'; then > + CFLAGS="$CFLAGS -O0" > + fi > fi > if test "x$GXX" = xyes; then > - CXXFLAGS="$CXXFLAGS -g -O0" > + if ! echo "$CXXFLAGS" | grep -q -e '-g'; then > + CXXFLAGS="$CXXFLAGS -g" > + fi > + if ! echo "$CXXFLAGS" | grep -q -e '-O'; then > + CXXFLAGS="$CXXFLAGS -O0" > + fi > fi > fi > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
