Re: [Mesa-dev] [PATCH 4/6] i965/gen7: Don't allocate hiz miptree structure

2014-07-02 Thread Pohjolainen, Topi
On Wed, Jul 02, 2014 at 12:33:16PM -0700, Jordan Justen wrote: > On Wed, Jul 2, 2014 at 5:39 AM, Pohjolainen, Topi > wrote: > > On Tue, Jul 01, 2014 at 04:53:06PM -0700, Jordan Justen wrote: > >> We now skip allocating a hiz miptree for gen7. Instead, we calculate > >> the required hiz buffer para

Re: [Mesa-dev] [PATCH v2 5/5] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-02 Thread Pohjolainen, Topi
On Wed, Jul 02, 2014 at 07:00:06PM +0100, Neil Roberts wrote: > Adds an implementation of the ClearTexSubImage driver entry point that tries > to set up an FBO to render to the texture and then calls glClear with a > scissor to perform the actual clear. If an FBO can't be created for the > texture

[Mesa-dev] [PATCH 2/5] glsl/glcpp: Treat CR+LF pair as a single newline

2014-07-02 Thread Carl Worth
The GLSL specification says that either carriage-return, line-feed, or both together can be used to terminate lines. Further, it says that when used together, the pair of terminators shall be interpreted as a single line. This final requirement has not been respected by glcpp up until now, (it has

[Mesa-dev] [PATCH 1/5] glsl/glcpp: Add test script for testing various line-termination characters

2014-07-02 Thread Carl Worth
The GLSL specification has a very broad definition of what is a newline. Namely, it can be the carriage-return character, '\r', the newline character, '\n', or any combination of the two, (though in combination, the two are treated as a single newline). Here, we add a new test-runner, glcpp-test-c

[Mesa-dev] [PATCH 4/5] glsl/glcpp: Fix line-continuation code to handle multiple newline flavors

2014-07-02 Thread Carl Worth
Sometimes the newline separator is a single character, and sometimes it is two characters. Before we can fold away and line-continuation backslashes, we identify the flavor of line separator that is in use. With this identified, we then correctly search for backslashes followed immediately by the

[Mesa-dev] [PATCH 5/5] glsl/glcpp: Fix glcpp-test to correctly extract test-specific arguments

2014-07-02 Thread Carl Worth
The (optional) test-specific command-line arguments to be passed to glcpp are embedded within the source files of some tests, and glcpp-test uses grep to extract them. Of course, grep is line-based and looks for the native line-separator to determine line boundaries. So, for files using non-native

[Mesa-dev] [PATCH 3/5] glsl/glcpp: Don't include any newline characters in #error token

2014-07-02 Thread Carl Worth
Some tests were failing because the message printed by #error was including a '\r' character from the source file in its output. This is easily avoided by fixing the regular expression for #error to never include any of the possible newline characters, (neither '\r' nor '\n'). With this commit 2

[Mesa-dev] glsl/glcpp: Correctly handle various flavors of newlines

2014-07-02 Thread Carl Worth
This small series expands the glcpp-test test suite to be able to test all variations of newlines as allowed by the GLSL specification. It then fixes 4 bugs exposed by that testing until the entire test suite can pass with each of the 4 allowed newline variations. The new testing is not yet hooked

[Mesa-dev] [Bug 80836] [llvmpipe] [softpipe] piglit incorrect-in-layout-qualifier-repeated-prim.geom regression

2014-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80836 Samuel Iglesias changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-02 Thread Steven Newbury
On Wed, 2014-07-02 at 21:04 +0200, Andreas Boll wrote:> I'd like to make a new demos release on Friday, July 4th.> The last release was on February 24th, 2013. Additionally this> release is needed to fix the build with mesa 10.2. (fdo#78101)>  > Any objections?>  > Also I'd like to get these 3 patc

Re: [Mesa-dev] [PATCH 1/2] i965: Don't enable SOL statistics during meta operations.

2014-07-02 Thread Kristian Høgsberg
On Tue, Jul 1, 2014 at 5:25 PM, Kenneth Graunke wrote: > The GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN counter is not supposed to > increment during glGenerateMipmap(). I don't think either counter is > supposed to increment during most meta operations, so simply turn off > statistics during those

Re: [Mesa-dev] [PATCH 1/4] glsl/glcpp: Alphabetize lists of start conditions

2014-07-02 Thread Kristian Høgsberg
On Tue, Jul 1, 2014 at 5:31 PM, Kenneth Graunke wrote: > On Tuesday, July 01, 2014 03:25:49 PM Carl Worth wrote: >> There is no behavioral change here. It's just easier to verify that lists >> of start conditions include all expected conditions when they appear in a >> consistent order. >> >> The

[Mesa-dev] [PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-02 Thread Tobias Klausmann
Folding for conversions: F32/64->(U16/32, S16/32) and (U16/32, S16/32)->F32 No piglit regressions observed! Signed-off-by: Tobias Klausmann --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 74 ++ 1 file changed, 74 insertions(+) diff --git a/src/gallium/drivers/nouve

Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-02 Thread Ilia Mirkin
On Wed, Jul 2, 2014 at 4:03 PM, Roland Scheidegger wrote: > Actually on second thought, because centroid and sample are mutually > exclusive (or more generally, the "Interpolate" member determines "how" > interpolation is done, whereas these two determine the "where") > something like this might b

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-02 Thread Ilia Mirkin
On Wed, Jul 2, 2014 at 3:04 PM, Andreas Boll wrote: > I'd like to make a new demos release on Friday, July 4th. > The last release was on February 24th, 2013. Additionally this > release is needed to fix the build with mesa 10.2. (fdo#78101) > > Any objections? Not an objection, but since there's

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

2014-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #1 from Roland Scheidegger --- Sorry that trace is a bit too much to handle. I looked at it but I can't really make out any difference wrt use of glsl shader or not at all (note that for the gallium driver this cannot make a differenc

Re: [Mesa-dev] OpenGL on Wayland

2014-07-02 Thread Kalrish Bäakjen
Thank you all for your help. Finally, it works, although I have to force the OpenGL version with MESA_GL_VERSION_OVERRIDE and its GLSL partner, because KHR_create_context is not supported under LLVMpipe - if those environment variables are not set, the maximum that can be got is a 3.0 context. I su

Re: [Mesa-dev] OpenGL on Wayland

2014-07-02 Thread Thomas Daede
What Mesa version are you using? IIRC OpenGL 3.3 is only supported in llvmpipe in mesa 10.3 and newer. Using MESA_GL_VERISON_OVERRIDE just fakes the version string, it doesn't change what functions you can actually link to. Also, that also means for compatibility reasons you might want to request

[Mesa-dev] [Bug 80836] New: [llvmpipe] [softpipe] piglit incorrect-in-layout-qualifier-repeated-prim.geom regression

2014-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80836 Priority: medium Bug ID: 80836 Keywords: bisected, regression CC: i...@freedesktop.org, sigles...@igalia.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] [softpip

[Mesa-dev] [Bug 75286] make error with Gallium i915/DRM configuration

2014-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75286 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 80835] New: [llvmpipe] piglit fs-struct-pad regression

2014-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80835 Priority: medium Bug ID: 80835 Keywords: regression CC: bri...@vmware.com, srol...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit fs-struct-pad re

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-02 Thread Francisco Jerez
Tom Stellard writes: > On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: >> Tom Stellard writes: >> >> > v2: >> > - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and >> > CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. >> > - Only define cl_khr_fp64 if the exten

Re: [Mesa-dev] Mesa (master): st/mesa: fix incorrect size of UBO declarations

2014-07-02 Thread Brian Paul
On 07/02/2014 04:31 PM, Ian Romanick wrote: On 07/02/2014 07:29 AM, Brian Paul wrote: On 07/02/2014 06:49 AM, Brian Paul wrote: On 07/02/2014 06:36 AM, Brian Paul wrote: On 07/01/2014 08:43 PM, Michel Dänzer wrote: On 02.07.2014 00:43, Brian Paul wrote: Module: Mesa Branch: master Commit: f4

Re: [Mesa-dev] Mesa (master): st/mesa: fix incorrect size of UBO declarations

2014-07-02 Thread Ian Romanick
On 07/02/2014 07:29 AM, Brian Paul wrote: > On 07/02/2014 06:49 AM, Brian Paul wrote: >> On 07/02/2014 06:36 AM, Brian Paul wrote: >>> On 07/01/2014 08:43 PM, Michel Dänzer wrote: On 02.07.2014 00:43, Brian Paul wrote: > Module: Mesa > Branch: master > Commit: f4b0ab7afd83c81132921

Re: [Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-07-02 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Jun 27, 2014 at 2:21 AM, Chris Forbes wrote: > If another layout qualifier appeared to the left of `invocations` in the > GS input layout declaration, the invocation count would be dropped on > the floor. > > Fixes the piglit test: > > spec/ARB_transform_feedba

Re: [Mesa-dev] [PATCH 1/2] clover: Report a default value for CL_DEVICE_SINGLE_FP_CONFIG

2014-07-02 Thread Matt Arsenault
On Jul 2, 2014, at 12:52 PM, Matt Arsenault wrote: > > On Jul 2, 2014, at 12:48 PM, Tom Stellard wrote: > >> --- >> src/gallium/state_trackers/clover/api/device.cpp | 3 +-- >> src/gallium/state_trackers/clover/core/device.cpp | 6 ++ >> src/gallium/state_trackers/clover/core/device.hpp |

[Mesa-dev] [PATCH] radeon/llvm: Allocate space for kernel metadata operands

2014-07-02 Thread Aaron Watry
Previously, we were assuming that kernel metadata nodes only had 1 operand. Kernels which have attributes can have more than 1, e.g.: !0 = metadata !{void (i32 addrspace(1)*)* @testKernel, metadata !1} !1 = metadata !{metadata !"work_group_size_hint", i32 4, i32 1, i32 1} Attempting to get the ke

[Mesa-dev] [PATCH] glx/dri3: Use four buffers until X driver supports async flips

2014-07-02 Thread Keith Packard
A driver which doesn't have async flip support will queue up flips without any way to replace them afterwards. This means we've got a scanout buffer pinned as soon as we schedule a flip and so we need another buffer to keep from stalling. When vblank_mode=0, if there are only three buffers we do:

[Mesa-dev] [PATCH 1/2] glsl/glcpp: Swallow empty #pragma directives.

2014-07-02 Thread Carl Worth
Previously, we were passing these through, just like any other pragma. But the downstream compiler was tripping up on them. It seems easier to swallow these in the preprocessor and not pass them on at all rather than fixing the downstream compiler. This fixes the following Khronos GLES3 CTS tests:

[Mesa-dev] [PATCH 2/2] glsl/glcpp: Fix for macros that expand to include "defined" operators

2014-07-02 Thread Carl Worth
Prior to this commit, the following snippet would trigger an error in glcpp: #define FOO defined BAR #if FOO #endif The problem was that support for the "defined" operator was implemented within the grammar, (where the parser was parsing the tokens of the condition itself)

Re: [Mesa-dev] [PATCH 4/5] r600g: allow vs to write to gl_ViewportIndex

2014-07-02 Thread Alex Deucher
On Wed, Jul 2, 2014 at 4:30 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Tested-by: Tobias Droste > --- > > In addition to the existing ARB_fragment_layer_viewport piglits passing and > the new AMD_vertex_shader_viewport_index piglit that is on the list passing, > Tobias did a regressio

[Mesa-dev] Two more patches for glcpp conformance work

2014-07-02 Thread Carl Worth
I think that with these two, I've completed my recent goal to bring glcpp into conformance with the latest Khronos GLES3 conformance tests. I'll be doing some full test runs over the CTS tests to see if I've missed anything. The first patch here is a fairly trivial thing, (make glcpp emit a blank

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-07-02 Thread Andy Furniss
Grigori Goronzy wrote: On 02.07.2014 22:18, Andy Furniss wrote: Before I knew how to get field sync to use my TVs deinterlacer I had to modify mesa so that I could use the vdpau de-interlacer(s), when I did this I noticed that 422 didn't work and looked the same as it does now this has gone in

[Mesa-dev] [PATCH 1/5] mesa: add support for AMD_vertex_shader_viewport_index

2014-07-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Reviewed-by: Kenneth Graunke Tested-by: Tobias Droste --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 6f25361..92e3f0d 100644 --- a/src

[Mesa-dev] [PATCH 5/5] mesa/st: enable AMD_vertex_shader_viewport_index

2014-07-02 Thread Ilia Mirkin
The assumption is that any driver capable of emitting layer from the vertex shader and supporting viewports should be able to also handle emitting viewport index from the vertex shader. Signed-off-by: Ilia Mirkin Tested-by: Tobias Droste --- docs/relnotes/10.3.html| 2 +- src/me

[Mesa-dev] [PATCH 4/5] r600g: allow vs to write to gl_ViewportIndex

2014-07-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Tested-by: Tobias Droste --- In addition to the existing ARB_fragment_layer_viewport piglits passing and the new AMD_vertex_shader_viewport_index piglit that is on the list passing, Tobias did a regression comparison to an earlier run and found no regressions. src/ga

[Mesa-dev] [PATCH 2/5] glsl: add support for AMD_vertex_shader_viewport_index

2014-07-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Reviewed-by: Kenneth Graunke Tested-by: Tobias Droste --- src/glsl/builtin_variables.cpp | 2 ++ src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 4 files changed, 8 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 3/5] i965: expose AMD_vertex_shader_viewport_index on gen7+

2014-07-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- docs/relnotes/10.3.html | 1 + src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/10.3.html b/docs/relnotes/10.3.html index 9af7210..6090a92 100644 --- a/docs/relnot

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-07-02 Thread Grigori Goronzy
On 02.07.2014 22:18, Andy Furniss wrote: > > Before I knew how to get field sync to use my TVs deinterlacer I had to > modify mesa so that I could use the vdpau de-interlacer(s), when I did > this I noticed that 422 didn't work and looked the same as it does now > this has gone in with my si. > A

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-07-02 Thread Andy Furniss
Grigori Goronzy wrote: On 18.06.2014 13:11, Christian König wrote: @Grigori: Should I push it or did you got your account in the meantime? Bit late but I only just noticed this went in. This is a really useful feature for me, having recently got a radeonsi, as it lets me use my tvs deinterlac

Re: [Mesa-dev] [PATCH] mesa: Fix regression introduced by commit "mesa: fix packing of float texels to GL_SHORT/GL_BYTE".

2014-07-02 Thread Chris Forbes
Assuming this causes no piglit regressions, Reviewed-by: Chris Forbes Can we get some piglits which demonstrate these problems? oglconform is too secret. On Wed, Jul 2, 2014 at 10:54 PM, Popov, Pavel E wrote: > Hi Chris, > > Could you review this patch? > > Probably a better solution here is t

Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-02 Thread Roland Scheidegger
Actually on second thought, because centroid and sample are mutually exclusive (or more generally, the "Interpolate" member determines "how" interpolation is done, whereas these two determine the "where") something like this might be better: struct tgsi_declaration_interp { unsigned Interpolate

Re: [Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-02 Thread Brian Paul
On 07/02/2014 01:04 PM, Andreas Boll wrote: I'd like to make a new demos release on Friday, July 4th. The last release was on February 24th, 2013. Additionally this release is needed to fix the build with mesa 10.2. (fdo#78101) Any objections? Sounds great. Also I'd like to get these 3 patc

Re: [Mesa-dev] [PATCH 1/2] clover: Report a default value for CL_DEVICE_SINGLE_FP_CONFIG

2014-07-02 Thread Matt Arsenault
On Jul 2, 2014, at 12:48 PM, Tom Stellard wrote: > --- > src/gallium/state_trackers/clover/api/device.cpp | 3 +-- > src/gallium/state_trackers/clover/core/device.cpp | 6 ++ > src/gallium/state_trackers/clover/core/device.hpp | 1 + > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff

[Mesa-dev] [PATCH 2/2] clover: Enable cl_khr_fp64 for devices that support doubles v3

2014-07-02 Thread Tom Stellard
v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from extension string. - Rename device query function from cl_khr_fp86() to has_doubles(

[Mesa-dev] [PATCH 1/2] clover: Report a default value for CL_DEVICE_SINGLE_FP_CONFIG

2014-07-02 Thread Tom Stellard
--- src/gallium/state_trackers/clover/api/device.cpp | 3 +-- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/s

Re: [Mesa-dev] [PATCH] glsl: fix duplicated layout qualifier detection for GS

2014-07-02 Thread Jordan Justen
Reviewed-by: Jordan Justen On Wed, Jul 2, 2014 at 12:38 AM, Samuel Iglesias Gonsalvez wrote: > This patch fixes the duplicated layout qualifier detection > for geometry shader's layout qualifiers. > > Also it makes the detection code more legible by defining > allowed_duplicates_mask variable. >

Re: [Mesa-dev] [PATCH 4/6] i965/gen7: Don't allocate hiz miptree structure

2014-07-02 Thread Jordan Justen
On Wed, Jul 2, 2014 at 5:39 AM, Pohjolainen, Topi wrote: > On Tue, Jul 01, 2014 at 04:53:06PM -0700, Jordan Justen wrote: >> We now skip allocating a hiz miptree for gen7. Instead, we calculate >> the required hiz buffer parameters and allocate a bo directly. >> >> Signed-off-by: Jordan Justen >>

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

2014-07-02 Thread Tom Stellard
On Thu, Jun 26, 2014 at 04:15:39PM +0200, Francisco Jerez wrote: > Tom Stellard writes: > > > v2: > > - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and > > CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. > > - Only define cl_khr_fp64 if the extension is supported. > > - Remo

Re: [Mesa-dev] [PATCH] radeon/llvm: Use the llvm.rsq.clamped intrinsic for RSQ

2014-07-02 Thread Tom Stellard
On Wed, Jul 02, 2014 at 06:29:25PM +0200, Laurent Carlier wrote: > Le mercredi 25 juin 2014, 11:58:47 Michel Dänzer a écrit : > > On 25.06.2014 09:15, Tom Stellard wrote: > > > https://bugs.freedesktop.org/show_bug.cgi?id=80015 > > > > > > CC: "10.1 10.2" > > > --- > > > > > > src/gallium/drive

[Mesa-dev] [PATCH demos 3/3] glxinfo: Print GL_EXT_texture_array limits

2014-07-02 Thread Andreas Boll
From: Fredrik Höglund Updated patch for refactored glxinfo/wglinfo code by Andreas Boll. Signed-off-by: Andreas Boll --- src/xdemos/glinfo_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index d5d466a..1326a86 100644 --- a

[Mesa-dev] [PATCH demos 1/3] glxinfo: Print XFB, TBO, and UBO limits

2014-07-02 Thread Andreas Boll
From: Fredrik Höglund Updated patch for refactored glxinfo/wglinfo code by Brian Paul. Signed-off-by: Brian Paul Signed-off-by: Andreas Boll --- src/xdemos/glinfo_common.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinf

[Mesa-dev] [PATCH demos 2/3] glxinfo: Print GL_ARB_vertex_attrib_binding limits

2014-07-02 Thread Andreas Boll
From: Fredrik Höglund Updated patch for refactored glxinfo/wglinfo code by Andreas Boll. Signed-off-by: Andreas Boll --- src/xdemos/glinfo_common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index 0037ac7..d5d466a 100644 ---

[Mesa-dev] [PATCH demos 0/3] demos release plan and glxinfo: Print more limits

2014-07-02 Thread Andreas Boll
I'd like to make a new demos release on Friday, July 4th. The last release was on February 24th, 2013. Additionally this release is needed to fix the build with mesa 10.2. (fdo#78101) Any objections? Also I'd like to get these 3 patches included in the new release. Andreas. Fredrik Höglund (3)

Re: [Mesa-dev] [PATCH v2 1/5] mesa/main: add ARB_clear_texture entrypoints

2014-07-02 Thread Ilia Mirkin
On Wed, Jul 2, 2014 at 2:00 PM, Neil Roberts wrote: > From: Ilia Mirkin > > Signed-off-by: Ilia Mirkin > Reviewed-by: Neil Roberts > --- > src/mapi/glapi/gen/ARB_clear_texture.xml | 34 > > src/mapi/glapi/gen/gl_API.xml| 6 +- > src/mesa/main/

[Mesa-dev] [PATCH v2 1/5] mesa/main: add ARB_clear_texture entrypoints

2014-07-02 Thread Neil Roberts
From: Ilia Mirkin Signed-off-by: Ilia Mirkin Reviewed-by: Neil Roberts --- src/mapi/glapi/gen/ARB_clear_texture.xml | 34 src/mapi/glapi/gen/gl_API.xml| 6 +- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h

[Mesa-dev] [PATCH v2 4/5] texstore: Add a generic implementation of GL_ARB_clear_texture

2014-07-02 Thread Neil Roberts
Adds an implmentation of the ClearTexSubImage driver entry point that just maps the texture and writes the values in. The extension is not yet enabled by default because it doesn't work with multisample textures as they don't have a simple linear layout. Reviewed-by: Jason Ekstrand --- src/mesa/

[Mesa-dev] [PATCH v2 5/5] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-02 Thread Neil Roberts
Adds an implementation of the ClearTexSubImage driver entry point that tries to set up an FBO to render to the texture and then calls glClear with a scissor to perform the actual clear. If an FBO can't be created for the texture then it will fall back to using _mesa_store_ClearTexSubImage. When us

[Mesa-dev] [PATCH v2 3/5] mesa/main: Add generic bits of ARB_clear_texture implementation

2014-07-02 Thread Neil Roberts
This adds the driver entry point for glClearTexSubImage and fills in the _mesa_ClearTexImage and _mesa_ClearTexSubImage functions that call it. v2: Don't clear some of the images if only one of them makes an error Reviewed-by: Jason Ekstrand --- src/mesa/main/dd.h | 14 +++ src/mesa/main

[Mesa-dev] [PATCH v2 2/5] teximage: Add utility func for format/internalFormat compatibility check

2014-07-02 Thread Neil Roberts
In texture_error_check() there was a snippet of code to check whether the given format and internal format are basically compatible. This has been split out into its own static helper function so that it can be used by an implementation of glClearTexImage too. --- src/mesa/main/teximage.c | 59 +++

[Mesa-dev] [PATCH v3 0/5] Implement GL_ARB_clear_texture for i965

2014-07-02 Thread Neil Roberts
Here is version 3 of the patches to implement GL_ARB_clear_texture. The main changes are: • The extension is now only enabled for the i965 driver. I've removed the patch to add a place to enable extensions for all DRI drivers. • It now checks for potential errors that would occur when clearing

[Mesa-dev] [PATCH] Include the border size when determining the rb size from a texture

2014-07-02 Thread Neil Roberts
When attaching a texture to a framebuffer it was previously using the size of the texture minus the border when determining the renderbuffer size. However the size of the image buffer includes the border so when used with the swrast driver it would end up calculating the wrong stride and it would r

Re: [Mesa-dev] [PATCH v3 1/3] Add support for swrast to the DRM EGL platform

2014-07-02 Thread Andreas Pokorny
2014-07-02 18:48 GMT+02:00 Emil Velikov : > On 02/07/14 13:11, Andreas Pokorny wrote: > > Hi, > > Still trying the patch. Meanwhile I found two more things here: > > > > [...] > > > > The driver_name is later freed with free, so to avoid abort strdup should > > be necessary. > > > The free snuck i

Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-02 Thread Roland Scheidegger
I don't have much of an idea how the interaction with per sample shading should look like, but this looks alright to me. Roland Am 02.07.2014 03:55, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > > Not sure if this is the right approach or if I should combine it with Centroid > more

[Mesa-dev] [Bug 80821] When LIBGL_ALWAYS_SOFTWARE is set, the KHR_create_extension is not supported

2014-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80821 Kalrish Bäakjen changed: What|Removed |Added CC||kalrish.ant...@gmail.com -- You are r

Re: [Mesa-dev] [PATCH RESEND] mesa/st: enable ARB_fragment_layer_viewport

2014-07-02 Thread Roland Scheidegger
Am 02.07.2014 16:57, schrieb Ilia Mirkin: > If multiple viewports are supported, that implies the presence of a GS > and layered rendering, so we can enable ARB_fragment_layer_viewport as > well. > > Signed-off-by: Ilia Mirkin > --- > > OK... this has been fun. The r600g change has been reviewed

[Mesa-dev] [Bug 80821] New: When LIBGL_ALWAYS_SOFTWARE is set, the KHR_create_extension is not supported

2014-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80821 Priority: medium Bug ID: 80821 Assignee: mesa-dev@lists.freedesktop.org Summary: When LIBGL_ALWAYS_SOFTWARE is set, the KHR_create_extension is not supported Severity: enhanc

Re: [Mesa-dev] [PATCH v3 1/3] Add support for swrast to the DRM EGL platform

2014-07-02 Thread Emil Velikov
On 02/07/14 13:11, Andreas Pokorny wrote: > Hi, > Still trying the patch. Meanwhile I found two more things here: > > > 2014-06-15 13:49 GMT+02:00 Giovanni Campagna : > >> From: Giovanni Campagna >> [..] >> static int >> +dri_screen_create_swrast(struct gbm_dri_device *dri) >> +{ >> + int re

Re: [Mesa-dev] [PATCH] radeon/llvm: Use the llvm.rsq.clamped intrinsic for RSQ

2014-07-02 Thread Laurent Carlier
Le mercredi 25 juin 2014, 11:58:47 Michel Dänzer a écrit : > On 25.06.2014 09:15, Tom Stellard wrote: > > https://bugs.freedesktop.org/show_bug.cgi?id=80015 > > > > CC: "10.1 10.2" > > --- > > > > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +- > > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH RESEND] mesa/st: enable ARB_fragment_layer_viewport

2014-07-02 Thread Alex Deucher
On Wed, Jul 2, 2014 at 10:57 AM, Ilia Mirkin wrote: > If multiple viewports are supported, that implies the presence of a GS > and layered rendering, so we can enable ARB_fragment_layer_viewport as > well. > > Signed-off-by: Ilia Mirkin > --- > > OK... this has been fun. The r600g change has been

Re: [Mesa-dev] [PATCH 5/5] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-02 Thread Neil Roberts
Ian Romanick writes: > Every driver in Mesa supports GL_EXT_framebuffer_object and > GL_EXT_framebuffer_blit. […] > > So, I don't think this check adds any value. Ok. >> + /* This probably won't work with images that have a border */ >> + if (texImage->Border != 0) >> + return false; >

Re: [Mesa-dev] [PATCH 3/9] gallium: add PIPE_BIND_COMMAND_ARGS_BUFFER

2014-07-02 Thread Tom Stellard
On Sat, Jun 28, 2014 at 01:12:49PM +0200, Marek Olšák wrote: > The one that increases the number of input SGPRs to 22 (16 user + 6 > streamout) in the calling convention. I don't remember the name. > Please "git blame" on the calling convention. > I merged this patch into LLVM 3.4.2, which was re

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Steven Newbury
On Wed, 2014-07-02 at 15:40 +0100, Steven Newbury wrote: > On Wed, 2014-07-02 at 10:59 +0200, Iago Toral wrote: > > Oh, I just noticed there was some problem with the first reply I > > sent > > and Chris and Steven got out of the CC in my reply, so adding them > > back > > now. > > Steven: th

Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-02 Thread Ilia Mirkin
Thanks Tobias! I've pushed this change now. On Wed, Jul 2, 2014 at 12:49 AM, Tobias Droste wrote: > Hi, > > I did a piglit run with the gpu.py profile with and without the patch. > There were some switches from pass->fail and fail->pass in > spec/glsl-1.50/execution/geometry/end-primitive but the

[Mesa-dev] [PATCH RESEND] mesa/st: enable ARB_fragment_layer_viewport

2014-07-02 Thread Ilia Mirkin
If multiple viewports are supported, that implies the presence of a GS and layered rendering, so we can enable ARB_fragment_layer_viewport as well. Signed-off-by: Ilia Mirkin --- OK... this has been fun. The r600g change has been reviewed and tested, and now pushed. So all ARB_viewport_array-sup

Re: [Mesa-dev] XA tracker pipe-loader woes.

2014-07-02 Thread Ilia Mirkin
On Wed, Jul 2, 2014 at 9:42 AM, Thomas Hellstrom wrote: > On 07/02/2014 12:50 PM, Maarten Lankhorst wrote: >> op 02-07-14 12:34, Thomas Hellstrom schreef: >>> Hi, Rob >>> >>> It turns out that your patch st/xa: use pipe-loader to get screen, >>> makes the xa tracker close the X server driver's dr

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Steven Newbury
On Wed, 2014-07-02 at 10:59 +0200, Iago Toral wrote: > Oh, I just noticed there was some problem with the first reply I sent > and Chris and Steven got out of the CC in my reply, so adding them > back > now. > > Steven: the summary is that on IvyBridge Kenneth's second patch > produces > a GPU

Re: [Mesa-dev] Mesa (master): st/mesa: fix incorrect size of UBO declarations

2014-07-02 Thread Brian Paul
On 07/02/2014 06:49 AM, Brian Paul wrote: On 07/02/2014 06:36 AM, Brian Paul wrote: On 07/01/2014 08:43 PM, Michel Dänzer wrote: On 02.07.2014 00:43, Brian Paul wrote: Module: Mesa Branch: master Commit: f4b0ab7afd83c811329211eae8167c9bf238870c URL: https://urldefense.proofpoint.com/v1/url?u=h

Re: [Mesa-dev] [PATCH 01/13] i965: Use immediate storage in brw_reg for visitor regs.

2014-07-02 Thread Pohjolainen, Topi
Patches 10 and 11 are: Acked-by: Topi Pohjolainen and the rest are (with suggestions from Chris): Reviewed-by: Topi Pohjolainen ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 11/13] i965: Make backend_instruction usable from C.

2014-07-02 Thread Pohjolainen, Topi
On Mon, Jun 30, 2014 at 02:40:42PM -0700, Matt Turner wrote: > With a hack to place an exec_node in the struct in C to be at the same > location as the inherited exec_node in C++. Are you planning to eventually have one but not the other? If this is just temporary it does not make a lot difference

Re: [Mesa-dev] [PATCH 07/13] i965: Make a brw_conditional_mod enum.

2014-07-02 Thread Pohjolainen, Topi
On Mon, Jun 30, 2014 at 02:40:38PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp| 2 +- > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 7 +++--- > src/mesa/drivers/dri/i965/brw_defines.h| 26 > -- > src/mesa/drivers

Re: [Mesa-dev] XA tracker pipe-loader woes.

2014-07-02 Thread Thomas Hellstrom
On 07/02/2014 12:50 PM, Maarten Lankhorst wrote: > op 02-07-14 12:34, Thomas Hellstrom schreef: >> Hi, Rob >> >> It turns out that your patch st/xa: use pipe-loader to get screen, >> makes the xa tracker close the X server driver's drm file descriptor when >> XA initialization fails or when XA is

Re: [Mesa-dev] Mesa (master): st/mesa: fix incorrect size of UBO declarations

2014-07-02 Thread Brian Paul
On 07/02/2014 06:36 AM, Brian Paul wrote: On 07/01/2014 08:43 PM, Michel Dänzer wrote: On 02.07.2014 00:43, Brian Paul wrote: Module: Mesa Branch: master Commit: f4b0ab7afd83c811329211eae8167c9bf238870c URL: https://urldefense.proofpoint.com/v1/url?u=http://cgit.freedesktop.org/mesa/mesa/commit

Re: [Mesa-dev] [PATCH 3/6] i965/gen8: Don't rely directly on the hiz miptree structure

2014-07-02 Thread Pohjolainen, Topi
On Tue, Jul 01, 2014 at 04:53:05PM -0700, Jordan Justen wrote: > We are still allocating a miptree for hiz, but we only use fields from > intel_miptree_aux_buffer. This will allow us to switch over to not > allocating a miptree. > > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 4/6] i965/gen7: Don't allocate hiz miptree structure

2014-07-02 Thread Pohjolainen, Topi
On Tue, Jul 01, 2014 at 04:53:06PM -0700, Jordan Justen wrote: > We now skip allocating a hiz miptree for gen7. Instead, we calculate > the required hiz buffer parameters and allocate a bo directly. > > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 67 > ++

Re: [Mesa-dev] Mesa (master): st/mesa: fix incorrect size of UBO declarations

2014-07-02 Thread Brian Paul
On 07/01/2014 08:43 PM, Michel Dänzer wrote: On 02.07.2014 00:43, Brian Paul wrote: Module: Mesa Branch: master Commit: f4b0ab7afd83c811329211eae8167c9bf238870c URL: https://urldefense.proofpoint.com/v1/url?u=http://cgit.freedesktop.org/mesa/mesa/commit/?id%3Df4b0ab7afd83c811329211eae8167c9b

Re: [Mesa-dev] [PATCH v2] glsl: Fix aggregates with dynamic initializers.

2014-07-02 Thread Timothy Arceri
On Tue, 2014-07-01 at 14:45 -0700, Kenneth Graunke wrote: > From: Cody Northrop > > Vectors are falling in to the ir_dereference_array() path. > > Without this change, the following glsl aborts the debug driver, > or gets the wrong answer in release: > > mat2x2 a = mat2( vec2( 1.0, vertex.x ),

Re: [Mesa-dev] [PATCH v3 1/3] Add support for swrast to the DRM EGL platform

2014-07-02 Thread Andreas Pokorny
Hi, Still trying the patch. Meanwhile I found two more things here: 2014-06-15 13:49 GMT+02:00 Giovanni Campagna : > From: Giovanni Campagna > [..] > static int > +dri_screen_create_swrast(struct gbm_dri_device *dri) > +{ > + int ret = 0; > + > + dri->base.driver_name = "swrast"; > + > +

Re: [Mesa-dev] [PATCH 5/5] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-02 Thread Pohjolainen, Topi
On Sat, Jun 14, 2014 at 01:59:31AM +0100, Neil Roberts wrote: > Adds an implementation of the ClearTexSubImage driver entry point that tries > to set up an FBO to render to the texture and then calls glClear with a > scissor to perform the actual clear. If an FBO can't be created for the > texture

Re: [Mesa-dev] [PATCH] mesa: Fix regression introduced by commit "mesa: fix packing of float texels to GL_SHORT/GL_BYTE".

2014-07-02 Thread Popov, Pavel E
Hi Chris, Could you review this patch? Probably a better solution here is to use only one type of conversion formulas to avoid issues like this. We can remove old formulas ("BYTE_TO_FLOAT", "FLOAT_TO_BYTE", etc.) and use only formulas which were recently added in spec ("BYTE_TO_FLOAT_TEX", "F

Re: [Mesa-dev] XA tracker pipe-loader woes.

2014-07-02 Thread Maarten Lankhorst
op 02-07-14 12:34, Thomas Hellstrom schreef: > Hi, Rob > > It turns out that your patch st/xa: use pipe-loader to get screen, > makes the xa tracker close the X server driver's drm file descriptor when > XA initialization fails or when XA is closed. > > This breaks X for example on Ubuntu 14.10 if

[Mesa-dev] XA tracker pipe-loader woes.

2014-07-02 Thread Thomas Hellstrom
Hi, Rob It turns out that your patch st/xa: use pipe-loader to get screen, makes the xa tracker close the X server driver's drm file descriptor when XA initialization fails or when XA is closed. This breaks X for example on Ubuntu 14.10 if 3D is disabled (typically on ESX). Pretty nasty bug for

Re: [Mesa-dev] [PATCH v3 2/3] Add a dumb drm/kms winsys for software rendering

2014-07-02 Thread Andreas Pokorny
Hi, Nice patches! I found one minor issue below. I currently try to integrate and use that locally within kvm, currently on top of 10.2. 2014-06-15 13:49 GMT+02:00 Giovanni Campagna : > From: Giovanni Campagna > > Add a new winsys and target that can be used with a dri2 state tracker and > [..]

Re: [Mesa-dev] [PATCH 4/5] texstore: Add a generic implementation of GL_ARB_clear_texture

2014-07-02 Thread Neil Roberts
Ilia Mirkin writes: > Not entirely sure how to interpret what the spec says, but something > to potentially consider is MESA_ycbcr_texture (supported by swrast). > RGBA 0 (black) != 0 in ycbcr... all 0's there are a green color. The spec for the extension says: “If is NULL, then the pointer is

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Iago Toral
Oh, I just noticed there was some problem with the first reply I sent and Chris and Steven got out of the CC in my reply, so adding them back now. Steven: the summary is that on IvyBridge Kenneth's second patch produces a GPU hang in some cases so if you are going to test it try this version bette

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Iago Toral
On Wed, 2014-07-02 at 08:49 +0200, Iago Toral wrote: > Hello Kenneth, Steven: > > On Tue, 2014-07-01 at 17:25 -0700, Kenneth Graunke wrote: > > Previously, we only emitted 3DSTATE_SO_BUFFER and 3DSTATE_SO_DECL_LIST > > when transform feedback was active. When it was inactive, we disabled > > the

[Mesa-dev] [PATCH] glsl: fix duplicated layout qualifier detection for GS

2014-07-02 Thread Samuel Iglesias Gonsalvez
This patch fixes the duplicated layout qualifier detection for geometry shader's layout qualifiers. Also it makes the detection code more legible by defining allowed_duplicates_mask variable. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80778 Signed-off-by: Samuel Iglesias Gonsalvez -