Re: [Mesa-dev] [PATCH] gallium: reflect likely outcome in execution flow

2014-05-21 Thread Timothy Arceri
On Wed, 2014-05-21 at 18:05 -0400, Ilia Mirkin wrote: > On Wed, May 21, 2014 at 6:02 PM, Timothy Arceri wrote: > > Unless we run out of memory the old if statement would always fail so > > reflect the more likely outcome. Should be be faster most of the time and > > slightly cleaner looking cod

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Pohjolainen, Topi
On Wed, May 21, 2014 at 01:47:05PM -0700, Eric Anholt wrote: > "Pohjolainen, Topi" writes: > > > On Wed, May 21, 2014 at 12:51:07PM -0700, Eric Anholt wrote: > >> "Pohjolainen, Topi" writes: > >> > >> > On Wed, May 21, 2014 at 09:41:39PM +0300, Pohjolainen, Topi wrote: > >> >> On Wed, May 21, 2

[Mesa-dev] [v2 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen Cc: "10.2" v2 (Ken): Only restore the mode if it has changed. --- src/mesa/drivers/common/meta.h | 4 ++-- src/mesa/drivers/common/meta_blit.c | 13 - 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/meta.h

[Mesa-dev] [PATCH 2/2] loader: add optional /sys filesystem method for PCI identification.

2014-05-21 Thread Gary Wong
Introduce a simple PCI identification method of looking up the answer the /sys filesystem (available on Linux). Attempted after libudev, but before DRM. Disabled by default (available only when the --enable-sysfs configure option is specified). Signed-off-by: Gary Wong --- configure.ac

[Mesa-dev] [PATCH 1/2] loader: allow attempting more than one method of PCI identification.

2014-05-21 Thread Gary Wong
loader_get_pci_id_for_fd() and loader_get_device_name_for_fd() now attempt all available strategies to identify the hardware, instead of conditionally compiling in a single test. The existing libudev and DRM approaches have been retained, attempting first libudev (if available) and then DRM (if ne

[Mesa-dev] [PATCH 0/2] loader: allow alternative methods for PCI identification.

2014-05-21 Thread Gary Wong
loader_get_pci_id_for_fd() and loader_get_device_name_for_fd() now attempt all available strategies to identify the hardware, instead of conditionally compiling in a single test. The existing libudev and DRM approaches have been retained, and another simple alternative of looking up the answer in

Re: [Mesa-dev] [PATCH 2/2] loader: add optional /sys filesystem method for PCI identification.

2014-05-21 Thread Gary Wong
On Wed, May 21, 2014 at 07:46:52PM +0100, Emil Velikov wrote: > On 21/05/14 02:40, Gary Wong wrote: > > Introduce a simple PCI identification method of looking up the answer > > the /sys filesystem (available on Linux). Attempted after libudev, but > > before DRM. > > > > Disabled by default (ava

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta blit: Set Z texcoord during meta blit to sample the right layer

2014-05-21 Thread Anuj Phogat
On Wed, May 21, 2014 at 4:18 PM, Jordan Justen wrote: > If the source renderbuffer has a depth > 0, then send a Z texcoord > which is set to the source attachment Z index. > > This fixes piglit's gl-3.2-layered-rendering-gl-layer-render with the > GL_TEXTURE_2D_MULTISAMPLE_ARRAY case test on i965/

Re: [Mesa-dev] [PATCH 00/23] i965: Instruction compaction improvements.

2014-05-21 Thread Matt Turner
On Wed, May 21, 2014 at 4:26 PM, Eric Anholt wrote: > Matt Turner writes: > >> Available from >> >>git://people.freedesktop.org/~mattst88/mesa compaction >> >> Highlights >> >>- Print disassembly after instruction compaction, while still >> having control-flow graph information and h

[Mesa-dev] [Bug 77161] [softpipe] piglit fbo-generatemipmap-cubemap S3TC_DXT1 regression

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77161 --- Comment #3 from Marek Olšák --- FWIW, ARB_texture_view allows changing to the texture target to a compatible texture target, e.g. cubemap <-> texture 2D array. -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [Bug 77161] [softpipe] piglit fbo-generatemipmap-cubemap S3TC_DXT1 regression

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77161 --- Comment #2 from Roland Scheidegger --- I don't think this qualifies as a blocker. Cubemaps aren't quite right on softpipe anyway due to doing face selection per quad (which I suspect is also what's causing this bug, probably pick the wrong fa

Re: [Mesa-dev] [PATCH 00/23] i965: Instruction compaction improvements.

2014-05-21 Thread Eric Anholt
Matt Turner writes: > Available from > >git://people.freedesktop.org/~mattst88/mesa compaction > > Highlights > >- Print disassembly after instruction compaction, while still > having control-flow graph information and higher-level IR > annotations. > >- Three improvements t

[Mesa-dev] [PATCH] meta blit: Set Z texcoord during meta blit to sample the right layer

2014-05-21 Thread Jordan Justen
If the source renderbuffer has a depth > 0, then send a Z texcoord which is set to the source attachment Z index. This fixes piglit's gl-3.2-layered-rendering-gl-layer-render with the GL_TEXTURE_2D_MULTISAMPLE_ARRAY case test on i965/gen8. Signed-off-by: Jordan Justen Cc: "10.2" --- No piglit

Re: [Mesa-dev] [PATCH 17/23] i965: Switch types D->UD when possible to allow compaction.

2014-05-21 Thread Eric Anholt
Matt Turner writes: > Number of compacted instructions: 827404 -> 833045 (0.68%) > --- > src/mesa/drivers/dri/i965/brw_eu_emit.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c > b/src/mesa/drivers/dri/i965/brw_eu_emit.c > i

Re: [Mesa-dev] [PATCH 18/23] i965: Print IR annotations only with INTEL_DEBUG=annotation.

2014-05-21 Thread Matt Turner
On Wed, May 21, 2014 at 3:37 PM, Eric Anholt wrote: > Matt Turner writes: > >> Running shader-db without INTEL_DEBUG=annotation reduces the runtime >> from ~90 to ~80 seconds on my machine. It also reduces the disk space >> consumed by the .out files from 660 MB (676 on disk) to 343 MB (358 on >>

Re: [Mesa-dev] [PATCH 03/23] i965/fs: Don't hardcode DEBUG_WM in generic fs code.

2014-05-21 Thread Eric Anholt
Matt Turner writes: > Similar to Paul's commit e9fa3a944 except brw_fs_generator's debug_flag > is for DEBUG_WM and DEBUG_BLORP. > @@ -2160,7 +2162,6 @@ brw_blorp_blit_test_compile(struct brw_context *brw, > FILE *out) > { > GLuint program_size; > - brw_blorp_

[Mesa-dev] [Bug 77161] [softpipe] piglit fbo-generatemipmap-cubemap S3TC_DXT1 regression

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77161 --- Comment #1 from Marek Olšák --- There may be precision issues in cubemap texture addressing in softpipe. I haven't seen any failures with r600g and radeonsi. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 18/23] i965: Print IR annotations only with INTEL_DEBUG=annotation.

2014-05-21 Thread Eric Anholt
Matt Turner writes: > Running shader-db without INTEL_DEBUG=annotation reduces the runtime > from ~90 to ~80 seconds on my machine. It also reduces the disk space > consumed by the .out files from 660 MB (676 on disk) to 343 MB (358 on > disk). I'd prefer to invert the debug flag here: people ha

Re: [Mesa-dev] [PATCH 3/4] targets/osmesa: limit the amount of exported symbols

2014-05-21 Thread Brian Paul
The original patch below works for me. Tested-by: Brian Paul On 05/20/2014 06:07 PM, Emil Velikov wrote: Just realised that I had forgotten about mangled gl. So this patch will need an extra line in the global symbols list. mgl*; I would still appreciate if someone familiar with OSMesa'

[Mesa-dev] [Bug 77161] [softpipe] piglit fbo-generatemipmap-cubemap S3TC_DXT1 regression

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77161 Vinson Lee changed: What|Removed |Added Blocks||79039 -- You are receiving this mail becau

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Vinson Lee changed: What|Removed |Added Depends on||77161 -- You are receiving this mail becau

Re: [Mesa-dev] [PATCH 0/1] Another small optimisation tweek

2014-05-21 Thread Matt Turner
On Wed, May 21, 2014 at 3:02 PM, Timothy Arceri wrote: > Again probably wont make a huge difference but > u_upload_data() is hit around 1.7 million times in 20 seconds during the > Nexuiz PTS benchmark so implement the most likely flow Instead of sending separate emails, you can use git send-em

[Mesa-dev] [Bug 78318] [swrast] piglit glsl-kwin-blur-1 regression

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78318 Vinson Lee changed: What|Removed |Added Blocks||79039 -- You are receiving this mail becau

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Vinson Lee changed: What|Removed |Added Depends on||78318 -- You are receiving this mail becau

Re: [Mesa-dev] [PATCH] gallium: reflect likely outcome in execution flow

2014-05-21 Thread Ilia Mirkin
On Wed, May 21, 2014 at 6:02 PM, Timothy Arceri wrote: > Unless we run out of memory the old if statement would always fail so reflect > the more likely outcome. Should be be faster most of the time and slightly > cleaner looking code. > > Signed-off-by: Timothy Arceri > --- > src/gallium/auxi

[Mesa-dev] [PATCH 10/11] i965: Add a comment about null renderbuffer surfaces and why they exist.

2014-05-21 Thread Eric Anholt
I noticed this when trying to find comments about pull constant buffers. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 8 src/mesa/drivers/dri/i965/gen8_surface_state.c| 8 ++-- 3 files changed, 22 insertion

[Mesa-dev] [PATCH 08/11] i965: Merge VS/GS and WM pull constant buffer upload paths.

2014-05-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 6 ++-- src/mesa/drivers/dri/i965/brw_state.h| 11 +++--- src/mesa/drivers/dri/i965/brw_vs_surface_state.c | 45 +++- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 33 +++-- 4 files changed, 42

[Mesa-dev] [PATCH 05/11] i965: Fix state flags for gen4/5 CURBE.

2014-05-21 Thread Eric Anholt
If we had some NOS affecting VS compilation that resulted in optimization changing the set of constants to be uploaded, we might not have reuploaded the constants. --- src/mesa/drivers/dri/i965/brw_curbe.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mes

[Mesa-dev] [PATCH 06/11] i965: Move dispatch_grf_start_reg and first_curbe_grf into stage_prog_data.

2014-05-21 Thread Eric Anholt
I wanted to access this value from stage-generic code, so stop storing it under two different names. --- src/mesa/drivers/dri/i965/brw_context.h | 15 +++ src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4.cpp | 4 ++-- sr

[Mesa-dev] [PATCH 07/11] i965/gen6+: Merge VS/GS and WM push constant buffer upload paths.

2014-05-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_context.h | 10 ++--- src/mesa/drivers/dri/i965/gen6_vs_state.c | 61 +-- src/mesa/drivers/dri/i965/gen6_wm_state.c | 41 ++--- src/mesa/drivers/dri/i965/gen7_gs_state.c | 6 +-- 4 files changed, 52 insertions(+), 66

[Mesa-dev] i965: Adding comments and cleaning up push/pull constants

2014-05-21 Thread Eric Anholt
Since I'm leaving Intel in a couple weeks, I figured the best thing I could do for the driver in that time would be to take a pass over the whole codebase and braindump into the comments. I didn't make it very far without finding a lot of silly code that ought to be cleaned up, so I went ahead and

[Mesa-dev] [PATCH 11/11] i965/gen6: Add a spec citation about push constant packet requirements.

2014-05-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/gen6_wm_state.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen6_wm_state.c b/src/mesa/drivers/dri/i965/gen6_wm_state.c index db0e3aa..047e036 100644 --- a/src/mesa/drivers/dri/i965/gen6_wm_state.c +++ b/src/m

[Mesa-dev] [PATCH 09/11] i965: Update a ton of comments about constant buffers.

2014-05-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_curbe.c | 86 +++ src/mesa/drivers/dri/i965/brw_fs.cpp | 3 ++ src/mesa/drivers/dri/i965/brw_vec4.cpp| 3 ++ src/mesa/drivers/dri/i965/gen6_vs_state.c | 14 + 4 files changed, 74 insertions(+), 32 deletions(-) diff -

[Mesa-dev] [PATCH 03/11] i965: Reuse libdrm's header for AUB definitions.

2014-05-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_context.h | 70 ++--- src/mesa/drivers/dri/i965/brw_state.h | 2 +- src/mesa/drivers/dri/i965/brw_state_batch.c | 4 +- src/mesa/drivers/dri/i965/gen6_vs_state.c | 2 +- 4 files changed, 7 insertions(+), 71 deletions(-) diff

[Mesa-dev] [PATCH 02/11] i965: Fix stale comments about the state cache.

2014-05-21 Thread Eric Anholt
This changed in the state streaming work years ago. --- src/mesa/drivers/dri/i965/brw_cc.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cc.c b/src/mesa/drivers/dri/i965/brw_cc.c ind

[Mesa-dev] [PATCH 04/11] i965: Remove a dead define.

2014-05-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_context.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index 5b0328f..89d8d9f 100644 --- a/src/mesa/drivers/dri/i965/brw_context.h +++ b/src/mesa/drivers/dri/i965/brw_contex

[Mesa-dev] [PATCH 01/11] i965: Fix stale binding table comment.

2014-05-21 Thread Eric Anholt
I recently moved the code from the mentioned location right into this file. --- src/mesa/drivers/dri/i965/brw_binding_tables.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_binding_tables.c b/src/mesa/drivers/dri/i965/brw_binding_tables.c index 1cd4bba..30a54e

[Mesa-dev] [PATCH] gallium: reflect likely outcome in execution flow

2014-05-21 Thread Timothy Arceri
Unless we run out of memory the old if statement would always fail so reflect the more likely outcome. Should be be faster most of the time and slightly cleaner looking code. Signed-off-by: Timothy Arceri --- src/gallium/auxiliary/util/u_upload_mgr.c | 7 +++ 1 file changed, 3 insertions(+

[Mesa-dev] [PATCH 0/1] Another small optimisation tweek

2014-05-21 Thread Timothy Arceri
Again probably wont make a huge difference but u_upload_data() is hit around 1.7 million times in 20 seconds during the Nexuiz PTS benchmark so implement the most likely flow ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freede

[Mesa-dev] [Bug 77288] [swrast] piglit glean glsl1 regression

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77288 Vinson Lee changed: What|Removed |Added Blocks||79039 -- You are receiving this mail becau

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Vinson Lee changed: What|Removed |Added CC||v...@freedesktop.org Depends on|

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Vinson Lee changed: What|Removed |Added Depends on||49713 -- You are receiving this mail becau

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Matt Turner changed: What|Removed |Added Depends on|7770|77704 -- You are receiving this mail beca

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Kenneth Graunke
On 05/21/2014 02:57 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > Cc: "10.2" > --- > src/mesa/drivers/common/meta.h | 4 ++-- > src/mesa/drivers/common/meta_blit.c | 15 ++- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers

[Mesa-dev] [Bug 79039] New: [TRACKER] Mesa 10.2 release tracker

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Priority: medium Bug ID: 79039 CC: intel-3d-b...@lists.freedesktop.org Assignee: mesa-dev@lists.freedesktop.org Summary: [TRACKER] Mesa 10.2 release tracker Severity: normal

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Eric Anholt
"Pohjolainen, Topi" writes: > On Wed, May 21, 2014 at 12:51:07PM -0700, Eric Anholt wrote: >> "Pohjolainen, Topi" writes: >> >> > On Wed, May 21, 2014 at 09:41:39PM +0300, Pohjolainen, Topi wrote: >> >> On Wed, May 21, 2014 at 09:37:30PM +0300, Pohjolainen, Topi wrote: >> >> > On Wed, May 21, 2

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Pohjolainen, Topi
On Wed, May 21, 2014 at 12:51:07PM -0700, Eric Anholt wrote: > "Pohjolainen, Topi" writes: > > > On Wed, May 21, 2014 at 09:41:39PM +0300, Pohjolainen, Topi wrote: > >> On Wed, May 21, 2014 at 09:37:30PM +0300, Pohjolainen, Topi wrote: > >> > On Wed, May 21, 2014 at 11:29:02AM -0700, Eric Anholt

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Eric Anholt
"Pohjolainen, Topi" writes: > On Wed, May 21, 2014 at 09:41:39PM +0300, Pohjolainen, Topi wrote: >> On Wed, May 21, 2014 at 09:37:30PM +0300, Pohjolainen, Topi wrote: >> > On Wed, May 21, 2014 at 11:29:02AM -0700, Eric Anholt wrote: >> > > Topi Pohjolainen writes: >> > > >> > > > Signed-off-by:

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Pohjolainen, Topi
On Wed, May 21, 2014 at 09:41:39PM +0300, Pohjolainen, Topi wrote: > On Wed, May 21, 2014 at 09:37:30PM +0300, Pohjolainen, Topi wrote: > > On Wed, May 21, 2014 at 11:29:02AM -0700, Eric Anholt wrote: > > > Topi Pohjolainen writes: > > > > > > > Signed-off-by: Topi Pohjolainen > > > > Cc: "10.2"

Re: [Mesa-dev] [PATCH 02/12] nv50: setup scissors on clear_render_target/depth_stencil

2014-05-21 Thread Emil Velikov
On 21/05/14 19:59, Ilia Mirkin wrote: > On Wed, May 21, 2014 at 2:57 PM, Emil Velikov > wrote: >> On 21/05/14 00:39, Ilia Mirkin wrote: >>> From: Christoph Bumiller >>> >>> [imirkin: add logic to also clear the "regular" scissors] >> Can you please share why are you've added the "regular" scisso

Re: [Mesa-dev] [PATCH 04/12] nv50/ir/tgsi: TGSI_OPCODE_POW replicates its result

2014-05-21 Thread Ilia Mirkin
On Wed, May 21, 2014 at 3:03 PM, Ilia Mirkin wrote: > On Wed, May 21, 2014 at 3:01 PM, Emil Velikov > wrote: >> On 21/05/14 19:53, Ilia Mirkin wrote: >>> On Wed, May 21, 2014 at 2:51 PM, Emil Velikov >>> wrote: On 21/05/14 00:39, Ilia Mirkin wrote: > From: Christoph Bumiller > >>

Re: [Mesa-dev] [PATCH 04/12] nv50/ir/tgsi: TGSI_OPCODE_POW replicates its result

2014-05-21 Thread Ilia Mirkin
On Wed, May 21, 2014 at 3:01 PM, Emil Velikov wrote: > On 21/05/14 19:53, Ilia Mirkin wrote: >> On Wed, May 21, 2014 at 2:51 PM, Emil Velikov >> wrote: >>> On 21/05/14 00:39, Ilia Mirkin wrote: From: Christoph Bumiller Reviewed-by: Ilia Mirkin Cc: "10.2" --- src

Re: [Mesa-dev] [PATCH 04/12] nv50/ir/tgsi: TGSI_OPCODE_POW replicates its result

2014-05-21 Thread Emil Velikov
On 21/05/14 19:53, Ilia Mirkin wrote: > On Wed, May 21, 2014 at 2:51 PM, Emil Velikov > wrote: >> On 21/05/14 00:39, Ilia Mirkin wrote: >>> From: Christoph Bumiller >>> >>> Reviewed-by: Ilia Mirkin >>> Cc: "10.2" >>> --- >>> src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 6 +-

Re: [Mesa-dev] [PATCH 02/12] nv50: setup scissors on clear_render_target/depth_stencil

2014-05-21 Thread Ilia Mirkin
On Wed, May 21, 2014 at 2:57 PM, Emil Velikov wrote: > On 21/05/14 00:39, Ilia Mirkin wrote: >> From: Christoph Bumiller >> >> [imirkin: add logic to also clear the "regular" scissors] > Can you please share why are you've added the "regular" scissors ? Because I had to when I was implementing t

Re: [Mesa-dev] [PATCH 02/12] nv50: setup scissors on clear_render_target/depth_stencil

2014-05-21 Thread Emil Velikov
On 21/05/14 00:39, Ilia Mirkin wrote: > From: Christoph Bumiller > > [imirkin: add logic to also clear the "regular" scissors] Can you please share why are you've added the "regular" scissors ? Does it matter if we set the screen scissors before the render target params? Thanks Emil > Reviewed-

Re: [Mesa-dev] [PATCH 04/12] nv50/ir/tgsi: TGSI_OPCODE_POW replicates its result

2014-05-21 Thread Ilia Mirkin
On Wed, May 21, 2014 at 2:51 PM, Emil Velikov wrote: > On 21/05/14 00:39, Ilia Mirkin wrote: >> From: Christoph Bumiller >> >> Reviewed-by: Ilia Mirkin >> Cc: "10.2" >> --- >> src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-

Re: [Mesa-dev] [PATCH 04/12] nv50/ir/tgsi: TGSI_OPCODE_POW replicates its result

2014-05-21 Thread Emil Velikov
On 21/05/14 00:39, Ilia Mirkin wrote: > From: Christoph Bumiller > > Reviewed-by: Ilia Mirkin > Cc: "10.2" > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_i

Re: [Mesa-dev] [PATCH 2/2] loader: add optional /sys filesystem method for PCI identification.

2014-05-21 Thread Emil Velikov
On 21/05/14 02:40, Gary Wong wrote: > Introduce a simple PCI identification method of looking up the answer > the /sys filesystem (available on Linux). Attempted after libudev, but > before DRM. > > Disabled by default (available only when the --enable-sysfs configure > option is specified). >

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Pohjolainen, Topi
On Wed, May 21, 2014 at 09:37:30PM +0300, Pohjolainen, Topi wrote: > On Wed, May 21, 2014 at 11:29:02AM -0700, Eric Anholt wrote: > > Topi Pohjolainen writes: > > > > > Signed-off-by: Topi Pohjolainen > > > Cc: "10.2" > > > --- > > > src/mesa/drivers/common/meta.h | 4 ++-- > > > src/mes

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Pohjolainen, Topi
On Wed, May 21, 2014 at 11:29:02AM -0700, Eric Anholt wrote: > Topi Pohjolainen writes: > > > Signed-off-by: Topi Pohjolainen > > Cc: "10.2" > > --- > > src/mesa/drivers/common/meta.h | 4 ++-- > > src/mesa/drivers/common/meta_blit.c | 15 ++- > > 2 files changed, 16 insertio

Re: [Mesa-dev] [PATCH 1/2] i965: Use WE_all for FB write header setup on Broadwell.

2014-05-21 Thread Eric Anholt
Kenneth Graunke writes: > I forgot to disable writemasking on the OR and MOV which set the render > target index and "source 0 alpha present to render target" bit. These two are: Reviewed-by: Eric Anholt pgpjJzUjzrrlv.pgp Description: PGP signature ___

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Eric Anholt
Topi Pohjolainen writes: > Signed-off-by: Topi Pohjolainen > Cc: "10.2" > --- > src/mesa/drivers/common/meta.h | 4 ++-- > src/mesa/drivers/common/meta_blit.c | 15 ++- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.h b/src/m

Re: [Mesa-dev] [PATCH] i965: Ask the VBO module to actually use VBOs.

2014-05-21 Thread Eric Anholt
Matt Turner writes: > On Tue, May 20, 2014 at 11:00 AM, Eric Anholt wrote: >> Note that this covers the Begin/End rendering path, but not user vertex >> arrays (so we can't drop copy_array_to_vbo_array() code). Improves >> performance of isosurf GLVERTEX|TRIANGLES by 16.7506% +/- 4.98934% >> (n

Re: [Mesa-dev] [PATCH 07/23] i965/fs: Print disassembly after compaction.

2014-05-21 Thread Matt Turner
On Wed, May 21, 2014 at 9:52 AM, Juha-Pekka Heikkilä wrote: > On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.h | 4 +- >> src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 156 >> - >> 2 files changed, 77 inser

Re: [Mesa-dev] [PATCH 1/2] loader: allow attempting more than one method of PCI identification.

2014-05-21 Thread Emil Velikov
On 21/05/14 02:39, Gary Wong wrote: > loader_get_pci_id_for_fd() and loader_get_device_name_for_fd() now attempt > all available strategies to identify the hardware, instead of conditionally > compiling in a single test. The existing libudev and DRM approaches have > been retained, attempting firs

Re: [Mesa-dev] [PATCH 08/23] i965/vec4: Print disassembly after compaction.

2014-05-21 Thread Juha-Pekka Heikkilä
On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_vec4.h | 4 +- > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 109 > +-- > 2 files changed, 66 insertions(+), 47 deletions(-) > > diff --git a/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH 08/10] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-05-21 Thread Ian Romanick
On 05/21/2014 08:11 AM, Tapani wrote: > On 05/21/2014 05:43 PM, Tapani wrote: >> On 05/21/2014 01:27 AM, Ian Romanick wrote: >>> On 05/19/2014 10:08 PM, Tapani wrote: On 05/19/2014 08:18 PM, Ian Romanick wrote: > On 04/09/2014 02:56 AM, Tapani Pälli wrote: >> diff --git a/src/glsl/glsl

Re: [Mesa-dev] [PATCH 07/23] i965/fs: Print disassembly after compaction.

2014-05-21 Thread Juha-Pekka Heikkilä
On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.h | 4 +- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 156 > - > 2 files changed, 77 insertions(+), 83 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 06/23] i965/fs: Make patch_discard_jumps_to_fb_writes return bool.

2014-05-21 Thread Juha-Pekka Heikkilä
Reviewed-by: Juha-Pekka Heikkila On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote: > ... to tell us whether it emitted any code. Will be used to determine > whether we need to skip an annotation for it. > --- > src/mesa/drivers/dri/i965/brw_fs.h | 4 ++-- > src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH 04/23] i965/fs+blorp: Remove left over dump_file arguments.

2014-05-21 Thread Juha-Pekka Heikkilä
Reviewed-by: Juha-Pekka Heikkila On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote: > Were used by the blorp unit test programs. > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 20 > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 4 ++-- > src/mesa/drivers/dr

[Mesa-dev] [Bug 79016] [REGRESSION] "st/mesa: drop the lowering of quad strips to triangle strips"

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79016 --- Comment #5 from Marek Olšák --- If you add "-auto", what's the piglit result? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.fre

Re: [Mesa-dev] [PATCH 08/10] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-05-21 Thread Tapani
On 05/21/2014 05:43 PM, Tapani wrote: On 05/21/2014 01:27 AM, Ian Romanick wrote: On 05/19/2014 10:08 PM, Tapani wrote: On 05/19/2014 08:18 PM, Ian Romanick wrote: On 04/09/2014 02:56 AM, Tapani Pälli wrote: Patch adds a preprocessor define for the extension and stores explicit location data

Re: [Mesa-dev] [PATCH 08/10] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-05-21 Thread Tapani
On 05/21/2014 01:27 AM, Ian Romanick wrote: On 05/19/2014 10:08 PM, Tapani wrote: On 05/19/2014 08:18 PM, Ian Romanick wrote: On 04/09/2014 02:56 AM, Tapani Pälli wrote: Patch adds a preprocessor define for the extension and stores explicit location data for uniforms during AST->HIR conversion

[Mesa-dev] [Bug 79016] [REGRESSION] "st/mesa: drop the lowering of quad strips to triangle strips"

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79016 --- Comment #4 from Maarten Lankhorst --- Created attachment 99515 --> https://bugs.freedesktop.org/attachment.cgi?id=99515&action=edit commit generating warnings -- You are receiving this mail because: You are the assignee for the bug. _

[Mesa-dev] [Bug 79016] [REGRESSION] "st/mesa: drop the lowering of quad strips to triangle strips"

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79016 --- Comment #3 from Maarten Lankhorst --- Created attachment 99514 --> https://bugs.freedesktop.org/attachment.cgi?id=99514&action=edit screenshot with commit reverted, appears to be identical to i915/llvmpipe/nouveau -- You are receiving thi

[Mesa-dev] [Bug 79016] [REGRESSION] "st/mesa: drop the lowering of quad strips to triangle strips"

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79016 --- Comment #2 from Maarten Lankhorst --- Correction, meant e5f6b6d0feb9b9ad7132d5f236959ef088237347 as pointed out on irc. -- You are receiving this mail because: You are the assignee for the bug. __

Re: [Mesa-dev] [PATCH] haiku: Add missing u_memory.h for FREE()

2014-05-21 Thread Brian Paul
On 05/20/2014 06:30 PM, Alexander von Gluck IV wrote: --- .../targets/haiku-softpipe/GalliumContext.cpp |1 + .../targets/haiku-softpipe/GalliumFramebuffer.cpp |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gallium/targets/haiku-softpipe/GalliumContext.

Re: [Mesa-dev] [PATCH] mesa: check constant before null check

2014-05-21 Thread Brian Paul
On 05/21/2014 06:12 AM, Timothy Arceri wrote: For most drivers this if statement is always going to fail so check the constant value first. Signed-off-by: Timothy Arceri --- src/mesa/vbo/vbo_exec_array.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/

[Mesa-dev] [PATCH 2/3] Make DRI dependencies and build depend on the target

2014-05-21 Thread Jon TURNEY
- Don't require xcb-dri[23] etc. if we aren't building for a target with DRM, as we won't be using dri[23] - Enable a more fine-grained control of what DRI code is built, so that a libGL using direct swrast can be built on targets which don't have DRM. The HAVE_DRI automake conditional is retired

[Mesa-dev] [PATCH 1/3] Fix build for darwin

2014-05-21 Thread Jon TURNEY
Fix build for darwin, when ./configured --disable-driglx-direct - darwin ld doesn't support -Bsymbolic or --version-script, so check if ld supports those options before using them - define GLX_ALIAS_UNSUPPORTED as config/darwin used to, as aliasing of non-weak symbols isn't supported - default to

[Mesa-dev] [PATCH 3/3] Fix build of appleglx

2014-05-21 Thread Jon TURNEY
Define GLX_USE_APPLEGL, as config/darwin used to, to turn on specific code to use the applegl direct renderer Convert src/glx/apple/Makefile to automake Since the applegl libGL is now built by linking libappleglx into libGL, rather than by linking selected files into a special libGL: - Remove du

[Mesa-dev] [PATCH 0/3] Fix Apple-DRI GLX (v2)

2014-05-21 Thread Jon TURNEY
This updates this patch set for master and makes the following minor chages: Use -Wl,-Bsymbolic, as before, not -Bsymbolic Test that ld --version-script works, rather than just looking for it in ld --help darwin's ld doesn't support -Wl,--no-undefined, so don't use it on darwin Put a 'make check'

[Mesa-dev] [Bug 79016] [REGRESSION] "st/mesa: drop the lowering of quad strips to triangle strips"

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79016 --- Comment #1 from Marek Olšák --- Yes, I know about that, but does it really break it? The status "warn" doesn't mean broken. The commit also fixes other tests and it's just the correct thing to do. -- You are receiving this mail because: Yo

Re: [Mesa-dev] [PATCH] rbug: add missing pipe->blit() entrypoint

2014-05-21 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz On Wed, May 21, 2014 at 1:44 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/rbug/rbug_context.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/src/gallium/drivers/rbug/rbug_context

[Mesa-dev] [PATCH] rbug: add missing pipe->blit() entrypoint

2014-05-21 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/drivers/rbug/rbug_context.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index 0e7badb..2b99ddd 100644 --- a/src/gallium/driv

[Mesa-dev] [Bug 79016] New: [REGRESSION] "st/mesa: drop the lowering of quad strips to triangle strips"

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79016 Priority: medium Bug ID: 79016 Assignee: mesa-dev@lists.freedesktop.org Summary: [REGRESSION] "st/mesa: drop the lowering of quad strips to triangle strips" Severity: normal

[Mesa-dev] [PATCH] mesa: check constant before null check

2014-05-21 Thread Timothy Arceri
For most drivers this if statement is always going to fail so check the constant value first. Signed-off-by: Timothy Arceri --- src/mesa/vbo/vbo_exec_array.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c i

[Mesa-dev] [PATCH 0/1] optimise if statement

2014-05-21 Thread Timothy Arceri
Probably not going to make any difference but callgrind shows this being hit 600,000+ times in 20 seconds during the Nexuiz PTS benchmark so I thought it wouldn't hurt. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.o

Re: [Mesa-dev] [PATCH 7/8] gallium: create TGSI_PROPERTY to disable viewport and clipping

2014-05-21 Thread Marek Olšák
Now I understand. Yes, I'll add a CAP. Marek On Wed, May 21, 2014 at 1:11 PM, Roland Scheidegger wrote: > Yes but I'm saying you need to translate it away in the state tracker, cause > you can't really require all drivers to implement it, because this is a > feature where I really don't think yo

Re: [Mesa-dev] [PATCH 7/8] gallium: create TGSI_PROPERTY to disable viewport and clipping

2014-05-21 Thread Roland Scheidegger
Yes but I'm saying you need to translate it away in the state tracker, cause you can't really require all drivers to implement it, because this is a feature where I really don't think you can say it's the drivers fault if it's not implemented. Roland On 05/21/2014 11:54 AM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 7/8] gallium: create TGSI_PROPERTY to disable viewport and clipping

2014-05-21 Thread Marek Olšák
We don't translate it away. The property does 2 things not available in the pipe interface: - It disables viewport clipping, so that window coordinates can pass through untouched. - It disables viewport transformation. Our hardware is capable of both, however, some APIs are not. Marek On Wed, Ma

Re: [Mesa-dev] [PATCH 7/8] gallium: create TGSI_PROPERTY to disable viewport and clipping

2014-05-21 Thread Roland Scheidegger
On 05/21/2014 12:49 AM, Marek Olšák wrote: Hi, Could somebody from VMWare please review this patch? It's for st/nine (open d3d9 state tracker). Thanks, Marek On Sat, May 17, 2014 at 1:20 AM, Automated rebase wrote: From: Christoph Bumiller --- src/gallium/auxiliary/tgsi/tgsi_strings.c

[Mesa-dev] [PATCH 2/2] i965/meta: Store stencil texturing mode

2014-05-21 Thread Topi Pohjolainen
Meta path needs to keep the current texture object's state. Fixes the following gles3 cts tests on bdw: framebuffer_blit_functionality_negative_width_blit.test: fail framebuffer_blit_functionality_all_buffer_blit.test: fail framebuffer_blit_functionality_negative_height_blit.test: fail framebuffer

[Mesa-dev] [PATCH 1/2] meta/blit: Add stencil texturing mode save and restore

2014-05-21 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen Cc: "10.2" --- src/mesa/drivers/common/meta.h | 4 ++-- src/mesa/drivers/common/meta_blit.c | 15 ++- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/meta.h b/src/mesa/drivers/common/meta.h index 007f104..7

Re: [Mesa-dev] RFC: Fixing nv30 fbo attachments

2014-05-21 Thread Marek Olšák
Not in OpenGL. Marek On Wed, May 21, 2014 at 3:05 AM, Ilia Mirkin wrote: > Can you not render to a texture buffer? That might not be supported by > nv30 actually. > > On Tue, May 20, 2014 at 8:49 PM, Marek Olšák wrote: >> ARB_buffer_storage doesn't have anything to do with framebuffers. >> >> M

Re: [Mesa-dev] [PATCH 2/4] targets/xa: limit the amount of exported symbols

2014-05-21 Thread Thomas Hellstrom
Reviewed-by: Thomas Hellstrom On 05/02/2014 10:02 PM, Emil Velikov wrote: > In the presence of LLVM the final library exports every symbol from > the llvm namespace. Resolve this by using a version script (w/o the > version/name tag). > > Considering that there are only ~35 symbols, explicitly li

[Mesa-dev] [Bug 78914] [llvmpipe] Front/Backfaces do not cover the same pixels when rasterized

2014-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78914 --- Comment #8 from Florian Link --- I noticed that the same problem happens if I always use GL_CULL_BACK and change the winding so that the back faces are front facing when I need the back faces. So it seems to depend on the winding of the tri