[Mesa-dev] [PATCH] i965: Set miptree target field when creating from a BO.

2014-05-01 Thread Kenneth Graunke
Prior to commit 8435b60a3577d2d905eae189cd7e770500177e99, the region equivalent of this function called intel_miptree_create_layout, which set mt->target to target. With that commit, it no longer copied target. Piglit's ext_image_dma_buf_import-sample_[xa]rgb tests would then hit an assertion

[Mesa-dev] [Bug 77966] Trails / Tracks when rendering OpenGL ES 2 moving objects (Android-x86 / Mesa 10.0.4/5)

2014-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77966 Michel Dänzer changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCHES 0/9] Draw Indirect and Cube Map Arrays for RadeonSI

2014-05-01 Thread Ilia Mirkin
On Thu, May 1, 2014 at 10:56 PM, Michel Dänzer wrote: > On 26.04.2014 22:27, Marek Olšák wrote: >> >> This series adds support for ARB_texture_cube_map_array and >> ARB_draw_indirect to the radeonsi driver. There is also Gallium >> infrastructure support for ARB_draw_indirect. As usual, the first

Re: [Mesa-dev] [PATCHES 0/9] Draw Indirect and Cube Map Arrays for RadeonSI

2014-05-01 Thread Michel Dänzer
On 26.04.2014 22:27, Marek Olšák wrote: > > This series adds support for ARB_texture_cube_map_array and > ARB_draw_indirect to the radeonsi driver. There is also Gallium > infrastructure support for ARB_draw_indirect. As usual, the first > patch is unrelated to the rest of the series. ;) While th

[Mesa-dev] [PATCH1/2] radeonsi: add support for Mullins asics.

2014-05-01 Thread Samuel Li
v2: name defaults to kabini for older llvm Signed-off-by: Samuel Li Signed-off-by: Alex Deucher Signed-off-by: Leo Liu Reviewed-by: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 7 +++ src/gallium/drivers/radeonsi/si_state.c | 2 ++ src/gallium/winsys/rade

[Mesa-dev] XDC2014: Call for paper

2014-05-01 Thread Martin Peres
Hello, I have the pleasure to announce that the X.org Developer Conference 2014 will be held in Bordeaux, France from October 8th to October 10th. The venue is located in the campus of the University of Bordeaux 1, in the computer science research lab called LaBRI. The official page for the

Re: [Mesa-dev] [PATCH 05/21 v3] meta: Fix saving the program pipeline state

2014-05-01 Thread Chia-I Wu
On Fri, May 2, 2014 at 7:38 AM, Ian Romanick wrote: > From: Ian Romanick > > This code was broken in some odd ways before. Too much state was being > saved, it was being restored in the wrong order, and in the wrong way. > The biggest problem was that the pipeline object was restored before > re

Re: [Mesa-dev] [Mesa-stable] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
Carl Worth writes: > At this point, I'm just waiting for Anuj to backport two patches, then > I'll test and push out the latest state as reflected here: Anuj gave me the updated patches, and testing looks good. I've pushed out this state now: http://cworth.org/~cworth/mesa-stable-queue/

Re: [Mesa-dev] [Mesa-stable] A candidate branch for the next stable release

2014-05-01 Thread Anuj Phogat
On Thu, May 1, 2014 at 3:05 PM, Carl Worth wrote: > Carl Worth writes: >> * There are 23 patches that have been sent to the mesa-stable mailing >> list, but have not yet been merged to master. The oldest of these is >> from February 20 (10 weeks ago!). > > With the recent updates, I'm h

Re: [Mesa-dev] [PATCH] swrast: Fix vertex color in _swsetup_Translate()

2014-05-01 Thread Carl Worth
Ville Syrjälä writes: > but I guess 10.1 is the only still active stable branch? Yes. I'm performing releases based on the preceding major release. And I continue these through one overlap of a stable release on the new major release. That is, the last release I'll perform in the 10.1.x series

[Mesa-dev] [PATCH 05/21 v3] meta: Fix saving the program pipeline state

2014-05-01 Thread Ian Romanick
From: Ian Romanick This code was broken in some odd ways before. Too much state was being saved, it was being restored in the wrong order, and in the wrong way. The biggest problem was that the pipeline object was restored before restoring the programs attached to the default pipeline. Fixes a

Re: [Mesa-dev] [PATCH 15/18] i965: Drop region usage from DRI2 winsys-allocated buffers.

2014-05-01 Thread Chad Versace
On Thu, May 01, 2014 at 02:10:39PM -0700, Eric Anholt wrote: > Chad Versace writes: > > >> On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > > > >> > - intel_region_release(&intelBuffer->region); > >> > + drm_intel_bo_unreference(&intelBuffer->bo); > >> > free(intelBuffer); > > > > T

Re: [Mesa-dev] [PATCH 05/21] meta: Fix saving the program pipeline state

2014-05-01 Thread Ian Romanick
On 04/30/2014 06:59 PM, Chia-I Wu wrote: > On Thu, May 1, 2014 at 12:11 AM, Ian Romanick wrote: >> On 04/29/2014 08:43 PM, Chia-I Wu wrote: >>> On Wed, Apr 30, 2014 at 8:52 AM, Ian Romanick wrote: From: Ian Romanick This code was broken in some odd ways before. Too much state was

Re: [Mesa-dev] [PATCH 03/11] i965: Move has_hiz from the slice to the level.

2014-05-01 Thread Kenneth Graunke
On 05/01/2014 02:21 PM, Eric Anholt wrote: > The value depends only on the level, so no need to store the bool per slice. > Shrinks intel_mipmap_slice from 24 bytes to 16, while slotting into an > existing hole in intel_mipmap_level. Huh. I thought that we needed to disable HiZ for array slices t

Re: [Mesa-dev] [PATCH 07/11] i965/gen7+: Move sampler state packets to the stage sampler state table update.

2014-05-01 Thread Kenneth Graunke
On 05/01/2014 02:21 PM, Eric Anholt wrote: > Now that we have the stage state coming into our setup of sampler states, > it's easy to drop an identifier into it of which stage the stage_state is, > and then look up which packet to emit in a little table. > > No performance difference on cairo on g

Re: [Mesa-dev] i965: no more regions!

2014-05-01 Thread Chad Versace
On Thu, May 01, 2014 at 02:12:00PM -0700, Eric Anholt wrote: > Chad Versace writes: > > > On Tue, Apr 29, 2014 at 04:34:25PM -0700, Eric Anholt wrote: > >> Here's the series for removing struct intel_region from the i965 driver. > >> I think it's worth it for the code savings and reduced steps in

Re: [Mesa-dev] [00/21] Last of SSO, take 47

2014-05-01 Thread Eric Anholt
Ian Romanick writes: > On 04/30/2014 05:13 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> On 04/30/2014 12:41 PM, Eric Anholt wrote: Ian Romanick writes: > A lot the patches in this series were slightly reworked to incorporate > Eric's feedback (remove ir_variable::use

Re: [Mesa-dev] [Mesa-stable] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
Carl Worth writes: > * There are 23 patches that have been sent to the mesa-stable mailing > list, but have not yet been merged to master. The oldest of these is > from February 20 (10 weeks ago!). With the recent updates, I'm happy to say that this list is now down to only 8 patches, (

Re: [Mesa-dev] [PATCH] clover: Add a stub implementation of clCreateImage() v3

2014-05-01 Thread Francisco Jerez
Tom Stellard writes: > Now that we are uisng the OpenCL 1.2 headers, applications expect all > the OpenCL 1.2 functions to be implemented. > > This fixes linking errors with the piglit CL tests. > > v2: > - Use c++ features > - Fix error code handling > > v3: > - Move into api/util.hpp >

Re: [Mesa-dev] [00/21] Last of SSO, take 47

2014-05-01 Thread Ian Romanick
On 04/30/2014 05:13 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 04/30/2014 12:41 PM, Eric Anholt wrote: >>> Ian Romanick writes: >>> A lot the patches in this series were slightly reworked to incorporate Eric's feedback (remove ir_variable::user_location) on the previous

Re: [Mesa-dev] [PATCH 15/18] i965: Drop region usage from DRI2 winsys-allocated buffers.

2014-05-01 Thread Eric Anholt
Chad Versace writes: >> On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > >> > - intel_region_release(&intelBuffer->region); >> > + drm_intel_bo_unreference(&intelBuffer->bo); >> > free(intelBuffer); > > This hunk passes garbage to drm_intel_bo_unreference(). Here's the GCC > warnin

[Mesa-dev] [PATCH 11/11] i965: Move push constant state packets to push constant update time.

2014-05-01 Thread Eric Anholt
-0.553779% +/- 0.423394% effect on cairo-perf-trace runtime on glamor (n=612) --- src/mesa/drivers/dri/i965/gen6_vs_state.c | 11 ++- src/mesa/drivers/dri/i965/gen6_wm_state.c | 8 +++- src/mesa/drivers/dri/i965/gen7_gs_state.c | 29 +++-- src/mesa/drivers/dri/

[Mesa-dev] [PATCH 07/11] i965/gen7+: Move sampler state packets to the stage sampler state table update.

2014-05-01 Thread Eric Anholt
Now that we have the stage state coming into our setup of sampler states, it's easy to drop an identifier into it of which stage the stage_state is, and then look up which packet to emit in a little table. No performance difference on cairo on glamor (n=492). --- src/mesa/drivers/dri/i965/brw_con

[Mesa-dev] glamor-fixes cleanups

2014-05-01 Thread Eric Anholt
Here's what's left of my glamor-fixes branch of mesa, which is a bunch of little changes that were motivated by digging through sysprof of cairo on glamor. No individual thing here is big, but I think they're all at least non-harmful, and it's +123, -210 lines anyway.

Re: [Mesa-dev] i965: no more regions!

2014-05-01 Thread Eric Anholt
Chad Versace writes: > On Tue, Apr 29, 2014 at 04:34:25PM -0700, Eric Anholt wrote: >> Here's the series for removing struct intel_region from the i965 driver. >> I think it's worth it for the code savings and reduced steps in allocating >> a miptree. Plus, it gave me a chance to rewrite some co

[Mesa-dev] [PATCH 09/11] i965: Refactor gen7_upload_constant_state to look more like gen8.

2014-05-01 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/gen7_vs_state.c | 40 --- 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_vs_state.c b/src/mesa/drivers/dri/i965/gen7_vs_state.c index e7fd4b5..ba4a36e 100644 --- a/src/mesa/drivers/dri/i965/g

[Mesa-dev] [PATCH 06/11] i965/gen6: Don't update unit state when samplers change.

2014-05-01 Thread Eric Anholt
There's no remaining dependency between these two packets that I can find. --- src/mesa/drivers/dri/i965/gen6_vs_state.c | 2 +- src/mesa/drivers/dri/i965/gen6_wm_state.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_vs_state.c b/src/mesa/d

[Mesa-dev] [PATCH 04/11] i965: Simplify sampler setup by passing the stage state.

2014-05-01 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_context.h | 4 +--- src/mesa/drivers/dri/i965/brw_wm_sampler_state.c | 29 +++- src/mesa/drivers/dri/i965/gen7_sampler_state.c | 9 3 files changed, 13 insertions(+), 29 deletions(-) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 01/11] i965: Fix a stale comment reference

2014-05-01 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index 78ccfc6..c46df17 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h +++

[Mesa-dev] [PATCH 02/11] i965: Make batch dumping go to stderr, too.

2014-05-01 Thread Eric Anholt
All our other debug goes there. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c index 5a7cfcb..818ac61 100644 --- a/src/mesa/drivers/dri/i965/intel_b

[Mesa-dev] [PATCH 08/11] i965: Drop unnecessary state flag for units on NEW_BINDING_TABLE.

2014-05-01 Thread Eric Anholt
Commit 30259856a8a82a55c030df1ad052e505c61144bc moved the state packets to table generation time, but forgot to make this change. Apparently the performance win there was about not reemitting the table pointers on unrelated state changes. No performance difference on cairo on glamor (n=118). ---

[Mesa-dev] [PATCH 03/11] i965: Move has_hiz from the slice to the level.

2014-05-01 Thread Eric Anholt
The value depends only on the level, so no need to store the bool per slice. Shrinks intel_mipmap_slice from 24 bytes to 16, while slotting into an existing hole in intel_mipmap_level. --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 2 +- src/mesa/drivers/dri/i965/brw_misc_state.c| 2 +-

[Mesa-dev] [PATCH 10/11] i965: Merge gen8_upload_constant_state into gen7_upload_constant_state.

2014-05-01 Thread Eric Anholt
The two paths are really similar, and the extra conditionals will be dwarfed by the cost of the actual upload. --- src/mesa/drivers/dri/i965/brw_state.h | 5 - src/mesa/drivers/dri/i965/gen7_vs_state.c | 16 +--- src/mesa/drivers/dri/i965/gen8_gs_state.c | 2 +- src/mesa/driv

[Mesa-dev] [PATCH 05/11] i965: Drop a NEW_SAMPLER annotation for use of sampler_count.

2014-05-01 Thread Eric Anholt
The sampler count is set up from the gl_program at draw time, not at sampler change time. --- src/mesa/drivers/dri/i965/gen6_wm_state.c | 1 - src/mesa/drivers/dri/i965/gen7_wm_state.c | 1 - src/mesa/drivers/dri/i965/gen8_ps_state.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/mesa/dr

Re: [Mesa-dev] [PATCH] mesa: move declarations before code in texstore.c

2014-05-01 Thread Anuj Phogat
On Thu, May 1, 2014 at 12:05 PM, Brian Paul wrote: > To fix MSVC build. > --- > src/mesa/main/texstore.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c > index 436e5a8..7642146 100644 > --- a/src/mesa/

Re: [Mesa-dev] [Mesa-stable] [PATCH V4 3/4] glsl: Link error if fs defines conflicting qualifiers for gl_FragCoord

2014-05-01 Thread Carl Worth
Anuj Phogat writes: > This patch causes the shader link to fail if we have multiple fragment > shaders with conflicting layout qualifiers for gl_FragCoord. Anuj, This one has a non-trivial conflict on the 10.1 branch. Can you either recommend skipping this one or else provide a backported patch

Re: [Mesa-dev] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
Anuj Phogat writes: > Today morning, I've pushed a series of patches marked for stable releases. > It would be nice to pick them as well. Sorry for the last minute > commits. No problem. I'll pick these all and push as quick as I can so we can still have 24 hours before I cut the actual release.

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix redeclaration rules for gl_FragCoord.

2014-05-01 Thread Chris Forbes
OK, sounds good to me. On Fri, May 2, 2014 at 5:55 AM, Anuj Phogat wrote: > On Thu, Apr 17, 2014 at 1:05 AM, Chris Forbes wrote: >> Correct, this doesn't try to tackle the link-time cases at all. >> >> After sending these out, Anuj told me that he had similar patches >> pending review. Unfortuna

[Mesa-dev] [PATCH] mesa: move declarations before code in texstore.c

2014-05-01 Thread Brian Paul
To fix MSVC build. --- src/mesa/main/texstore.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index 436e5a8..7642146 100644 --- a/src/mesa/main/texstore.c +++ b/src/mesa/main/texstore.c @@ -2473,6 +2473,8 @

Re: [Mesa-dev] A candidate branch for the next stable release

2014-05-01 Thread Anuj Phogat
On Thu, May 1, 2014 at 10:44 AM, Carl Worth wrote: > I've recently pushed an update to the 10.1 branch. I anticipate making a > release from this branch tomorrow. The state of this branch is > summarized here: > > > http://cworth.org/~cworth/mesa-stable-queue/ > > As always, please let me

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix redeclaration rules for gl_FragCoord.

2014-05-01 Thread Anuj Phogat
On Thu, Apr 17, 2014 at 1:05 AM, Chris Forbes wrote: > Correct, this doesn't try to tackle the link-time cases at all. > > After sending these out, Anuj told me that he had similar patches > pending review. Unfortunate to duplicate effort, but it's what I get > for doing a bunch of random bug-stom

Re: [Mesa-dev] i965: no more regions!

2014-05-01 Thread Chad Versace
On Tue, Apr 29, 2014 at 04:34:25PM -0700, Eric Anholt wrote: > Here's the series for removing struct intel_region from the i965 driver. > I think it's worth it for the code savings and reduced steps in allocating > a miptree. Plus, it gave me a chance to rewrite some comments about the > driver. >

Re: [Mesa-dev] [PATCH 18/18] i965: Fix the file comment for intel_image.h

2014-05-01 Thread Chad Versace
On Tue, Apr 29, 2014 at 04:34:43PM -0700, Eric Anholt wrote: > --- > src/mesa/drivers/dri/i965/intel_image.h | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_image.h > b/src/mesa/drivers/dri/i965/intel_image.h > index ba3ed27.

Re: [Mesa-dev] [PATCH 17/18] i965: Rename intel_regions.h to something more appropriate now.

2014-05-01 Thread Chad Versace
On Tue, Apr 29, 2014 at 04:34:42PM -0700, Eric Anholt wrote: > +/** @file intel_image.h > + * > + * Structure definitions and prototypes for intel_region handling, > + * which is the basic structure for rectangular collections of pixels > + * stored in a drm_intel_bo. > + */ The @file comment is

Re: [Mesa-dev] [PATCH 15/18] i965: Drop region usage from DRI2 winsys-allocated buffers.

2014-05-01 Thread Chad Versace
> On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > > - intel_region_release(&intelBuffer->region); > > + drm_intel_bo_unreference(&intelBuffer->bo); > > free(intelBuffer); This hunk passes garbage to drm_intel_bo_unreference(). Here's the GCC warning. intel_screen.c: In functio

[Mesa-dev] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
I've recently pushed an update to the 10.1 branch. I anticipate making a release from this branch tomorrow. The state of this branch is summarized here: http://cworth.org/~cworth/mesa-stable-queue/ As always, please let me know if I have missed something that should be picked over to the

Re: [Mesa-dev] [PATCH 16/18] i965: Delete the intel_regions.c code.

2014-05-01 Thread Chad Versace
On Tue, Apr 29, 2014 at 04:34:41PM -0700, Eric Anholt wrote: > src/mesa/drivers/dri/i965/intel_regions.c | 198 > -- Whoo! Patches up to here are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] [PATCH 12/18] i965: Drop use of intel_region from miptrees.

2014-05-01 Thread Chad Versace
On Tue, Apr 29, 2014 at 04:34:37PM -0700, Eric Anholt wrote: > Note: region->width used to reflect the total_width/height padding of > separate stencil, and mt->total_width doesn't. The note scares me. It tells me the patch has a known, potential bug regarding stencil buffers... but after some di

[Mesa-dev] [PATCH] clover: Add a stub implementation of clCreateImage() v3

2014-05-01 Thread Tom Stellard
Now that we are uisng the OpenCL 1.2 headers, applications expect all the OpenCL 1.2 functions to be implemented. This fixes linking errors with the piglit CL tests. v2: - Use c++ features - Fix error code handling v3: - Move into api/util.hpp - Fix indentation --- src/gallium/state_tr

[Mesa-dev] [PATCH] clover: Add a stub implementation of clCreateImage() v2

2014-05-01 Thread Tom Stellard
Now that we are uisng the OpenCL 1.2 headers, applications expect all the OpenCL 1.2 functions to be implemented. This fixes linking errors with the piglit CL tests. v2: - Use c++ features - Fix error code handling --- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/s

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for Mullins asics.

2014-05-01 Thread Tom Stellard
On Wed, Apr 30, 2014 at 07:30:15PM -0400, Alex Deucher wrote: > From: Samuel Li > > Signed-off-by: Samuel Li > Signed-off-by: Alex Deucher > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 2 ++ > src/gallium/drivers/radeonsi/si_state.c | 2 ++ > src/gallium/winsys/radeon/d

Re: [Mesa-dev] [PATCH] clover: Add a stub implementation of clCreateImage()

2014-05-01 Thread Francisco Jerez
Francisco Jerez writes: > Tom Stellard writes: > >> Now that we are uisng the OpenCL 1.2 headers, applications expect all >> the OpenCL 1.2 functions to be implemented. >> >> This fixes linking errors with the piglit CL tests. >> --- >> src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-

Re: [Mesa-dev] [PATCH] clover: Add a stub implementation of clCreateImage()

2014-05-01 Thread Francisco Jerez
Tom Stellard writes: > Now that we are uisng the OpenCL 1.2 headers, applications expect all > the OpenCL 1.2 functions to be implemented. > > This fixes linking errors with the piglit CL tests. > --- > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- > src/gallium/state_trackers/clov

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Add support for fs_inst::force_writemask_all on Broadwell.

2014-05-01 Thread Kenneth Graunke
On 04/30/2014 01:37 PM, Eric Anholt wrote: > Kenneth Graunke writes: > >> This must not have existed when I wrote the original code. The atomic >> operation header setup code uses this. > > Other than the tiny comments I had, this series is: > > Reviewed-by: Eric Anholt As usual, you were ri