Chad Versace <chad.vers...@linux.intel.com> writes: > On Tue, Apr 29, 2014 at 04:34:25PM -0700, Eric Anholt wrote: >> Here's the series for removing struct intel_region from the i965 driver. >> I think it's worth it for the code savings and reduced steps in allocating >> a miptree. Plus, it gave me a chance to rewrite some comments about the >> driver. >> >> It's a longer series than I wanted, but there are some nice little >> cleanups in it that hopefully make it easier to review than 18 patches >> would usually be. > > The series was very easy to review in the bite-sized patches. Thanks for > breaking it up that way. > > Miptrees and regions and bo's are hot data structures. Now that the > region is gone, do you expect any reduction in cache misses? Any > measurable gain in CPU-bound workloads?
That was the motivation, but I haven't done the performance testing on it -- lunch was long enough to barely detect a .5% change, and I expect this to be <.5%.
pgp7Ri408eAHd.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
