On 04/24/2014 06:21 PM, Eric Anholt wrote:
> -1.1372% +/- 0.858033% effect on cairo runtime on glamor (n=175).
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/me
On Fri, Apr 25, 2014 at 1:05 AM, Ilia Mirkin wrote:
> bitfield_insert expects glsl_type::int_type arguments, not uint vectors
>
> Signed-off-by: Ilia Mirkin
> ---
>
> fs-ldexp still fails with this with my patches to add this to
> gallium/softpipe, but I very well might have messed something up (
bitfield_insert expects glsl_type::int_type arguments, not uint vectors
Signed-off-by: Ilia Mirkin
---
fs-ldexp still fails with this with my patches to add this to
gallium/softpipe, but I very well might have messed something up (like the
bitfield_insert impl). But I no longer get an assert in
From: Michel Dänzer
This can happen with glamor, which uses EGL_KHR_surfaceless_context and
only explicitly binds GL_READ_FRAMEBUFFER for glReadPixels.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Michel Dänzer
---
src/mesa/state_tracker/st_manager.c | 7 ++-
1 file changed, 6 inse
-1.1372% +/- 0.858033% effect on cairo runtime on glamor (n=175).
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 59700ed..c2
---
src/mapi/glapi/gen/gl_table.py | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_table.py b/src/mapi/glapi/gen/gl_table.py
index fd38468..d4075ff 100644
--- a/src/mapi/glapi/gen/gl_table.py
+++ b/src/mapi/glapi/gen/gl_table.py
@@ -101,10 +
_EnabledUnits is all of the first 32 image units that are used by fixed
function or programs, while _EnabledCoordUnits is just which fixed function
fragment shader texcoords need to be generated. This is a theoretical bugfix
in the case of a vertex shader texturing from large texture image unit nu
The _MaxEnabledTexImageUnit check assures us that Unit[0].Current != NULL.
This is the last consumer of _ReallyEnabled outside of the radeons.
---
src/mesa/swrast/s_triangle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/swrast/s_triangle.c b/src/mesa/swrast/s_trian
Here's a series I got built when profiling to see why glamor's FBO cache
is necessary. It turns out the worst spots in the no-cache profile were
present even with the cache, and they were about walking the 96 texture
units we've got these days. Thanks to Chris Forbes's
_MaxEnabledTexImageUnit, I
I want to avoid walking the entire long array texture image units, but the
obvious way to do so means walking program samplers, and thus hitting the
units in a random order.
This change replaces the previous behavior of only setting up the fallback
texture for a fragment shader with setting up the
I'm probably not the only person that has tried to kill _ReallyEnabled.
This does the mechanical part of the work, and cleans _ReallyEnabled from
i965.
I think that using _Current makes texture management clearer: You can't
have multiple targets in use in the same texture image unit at the same
ti
The field wasn't really valid, since we've got more than 32 units now. It
turns out it was mostly just used for checking != 0, or checking for fixed
function coordinates, though.
---
src/mesa/drivers/common/meta.c | 2 +-
src/mesa/drivers/dri/i915/intel_pixel.c| 2 +-
sr
I'm going to try to delete _ReallyEnabled, which is this weird bitfield
with either 0 or 1 bits set with just the reference to _Current.
---
src/mesa/main/texstate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c
index 36c543b..5cbf791 100
---
src/mesa/main/ff_fragment_shader.cpp | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/src/mesa/main/ff_fragment_shader.cpp
b/src/mesa/main/ff_fragment_shader.cpp
index f1ef38e..605f371 100644
--- a/src/mesa/main/ff_fragment_shader.cpp
+++ b/src/mesa/main/
We now know what the max unit is in the context state.
---
src/mesa/drivers/dri/i915/i830_texblend.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/i830_texblend.c
b/src/mesa/drivers/dri/i915/i830_texblend.c
index c08b2b0..e5542af 1
---
src/mesa/drivers/dri/i915/i915_context.h| 1 -
src/mesa/drivers/dri/radeon/radeon_context.h| 1 -
src/mesa/drivers/dri/radeon/radeon_state_init.c | 2 --
3 files changed, 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/i915_context.h
b/src/mesa/drivers/dri/i915/i915_context
We can just look at _Current's target.
---
src/mesa/drivers/dri/i915/i830_texstate.c | 44 +++---
src/mesa/drivers/dri/i915/i915_texstate.c | 45 +++
2 files changed, 44 insertions(+), 45 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/i830_
---
src/mesa/main/mtypes.h | 4 +---
src/mesa/main/texstate.c | 6 +-
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 31e3033..4c619ba 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -1085,7 +1085,6 @@ t
---
src/mesa/state_tracker/st_cb_drawtex.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_drawtex.c
b/src/mesa/state_tracker/st_cb_drawtex.c
index b0a44fd..f997e6b 100644
--- a/src/mesa/state_tracker/st_cb_drawtex.c
+++ b/src/mesa/state_trac
Instead of walking 6 shader stages for each of the 96 combined texture
image units, now we just walk the samplers used in each shader stage.
With cairo-perf-trace on Xephyr with glamor, I'm seeing a -6.50518% +/-
2.55601% effect on runtime (n=22) since the "drop _EnabledUnits" change.
No significa
This is kind of ugly, but I think it's worth it to finish off the last
consumers of _ReallyEnabled.
---
src/mesa/drivers/dri/r200/r200_fragshader.c | 24
src/mesa/drivers/dri/r200/r200_tex.c | 2 +-
src/mesa/drivers/dri/r200/r200_texstate.c| 9 ++
Thanks. Roland, mind taking a look, IIRC you're the one who had the
most objections last time around.
On Thu, Apr 24, 2014 at 5:44 PM, Marek Olšák wrote:
> Patch 1 & 2:
>
> Reviewed-by: Marek Olšák
>
> Marek
>
> On Thu, Apr 24, 2014 at 3:56 AM, Ilia Mirkin wrote:
>> This is my latest iteration
Reviewed-by: Marek Olšák
Marek
On Tue, Apr 22, 2014 at 6:47 PM, Adam Jackson wrote:
> I'm somewhat impressed that current gccs will let you do this, but
> sufficiently old ones (including 4.4.7 in RHEL6) won't.
>
> Signed-off-by: Adam Jackson
> ---
> src/gallium/drivers/radeonsi/si_descriptor
In order to support the (currently unregistered) Chromium-specific EGL
extension eglGetSyncValuesCHROMIUM on Intel systems, we need to import
the Chromium header that defines it. The file was downloaded from
https://chromium.googlesource.com/chromium/chromium/+/trunk/ui/gl/EGL/eglextchromium.h
I
Chromium defined a new GL extension (that isn't registered with Khronos).
We need to add an EGL extension for it, so we can migrate ChromeOS on
Intel systems to use EGL instead of GLX.
http://git.chromium.org/gitweb/?p=chromium/src/third_party/khronos.git;a=commitdiff;h=27cbfdab35c601f70aa150581ad
On Thu, Apr 24, 2014 at 6:20 PM, Ilia Mirkin wrote:
> On Thu, Apr 24, 2014 at 6:18 PM, Marek Olšák wrote:
>> I think GS_INVOCATIONS should be documented in the docs. Other than
>
> I agree with you in theory. In practice, I could not find such a place
> where properties were documented.
Actually
On Thu, Apr 24, 2014 at 6:18 PM, Marek Olšák wrote:
> I think GS_INVOCATIONS should be documented in the docs. Other than
I agree with you in theory. In practice, I could not find such a place
where properties were documented.
> that, patches 1, 2, 3, 4:
>
> Reviewed-by: Marek Olšák
>
> Marek
>
I think GS_INVOCATIONS should be documented in the docs. Other than
that, patches 1, 2, 3, 4:
Reviewed-by: Marek Olšák
Marek
On Thu, Apr 24, 2014 at 5:48 AM, Ilia Mirkin wrote:
> This adds support for gl_SampleMaskIn and gl_InvocationID system values to
> gallium, mesa/st, and nvc0. The releva
Patch 1 & 2:
Reviewed-by: Marek Olšák
Marek
On Thu, Apr 24, 2014 at 3:56 AM, Ilia Mirkin wrote:
> This is my latest iteration of the ARB_sample_shading implementation. The only
> known defect is that gl_SampleMask doesn't appear to work on nv50 nor
> nvc0. I'm fairly sure it's due to some bit
The original GL_EXT_texture_swizzle extensions said GL_INVALID_OPERATION
was to be generated when the an invalid swizzle was passed to
glTexParameter(). But in OpenGL 3.3 and later, the error should be
GL_INVALID_ENUM.
---
src/mesa/main/texparam.c |4 ++--
1 file changed, 2 insertions(+), 2 d
Signed-off-by: Jan Vesely
---
Hi,
this is the alternative (power of 2) approach to hadling kernel args,
as discussed in this thread:
http://lists.freedesktop.org/archives/mesa-dev/2014-April/thread.html#58209
Jan
src/gallium/state_trackers/clover/llvm/invocation.cpp | 4
1 file changed,
https://bugs.freedesktop.org/show_bug.cgi?id=77749
tha...@chromium.org changed:
What|Removed |Added
Attachment #97758|0 |1
is obsolete|
On 25 April 2014 01:44, Roland Scheidegger wrote:
> Am 24.04.2014 16:24, schrieb jfons...@vmware.com:
>> From: José Fonseca
>>
>> According to Roland all TGSI support is there in theory.
>>
>> In practice there are a few piglit failures and crashes, as this hadn't
>> been tested before.
Reviewed
On Thu, Apr 24, 2014 at 10:33 AM, Matt Turner wrote:
> On Thu, Apr 24, 2014 at 10:30 AM, Kenneth Graunke
> wrote:
>> On 04/24/2014 08:40 AM, Matt Turner wrote:
>>> On Wed, Apr 23, 2014 at 11:19 PM, Kenneth Graunke
>>> wrote:
On 04/18/2014 11:56 AM, Matt Turner wrote:
> ---
> src/
On 04/24/2014 08:40 AM, Matt Turner wrote:
> On Wed, Apr 23, 2014 at 11:19 PM, Kenneth Graunke
> wrote:
>> On 04/18/2014 11:56 AM, Matt Turner wrote:
>>> ---
>>> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 135
>>> +++
>>> 1 file changed, 73 insertions(+), 62 deletion
On Thu, Apr 24, 2014 at 10:30 AM, Kenneth Graunke wrote:
> On 04/24/2014 08:40 AM, Matt Turner wrote:
>> On Wed, Apr 23, 2014 at 11:19 PM, Kenneth Graunke
>> wrote:
>>> On 04/18/2014 11:56 AM, Matt Turner wrote:
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 135
Looks great to me. Thanks Zack.
Jose
- Original Message -
> Lets make draw_get_option_use_llvm function available unconditionally
> and use it to avoid useless allocations when LLVM paths are active.
> TGSI machine is never used when we're using LLVM.
>
> Signed-off-by: Zack Rusin
> ---
On Thu, 2014-04-24 at 17:53 +0200, Francisco Jerez wrote:
> Jan Vesely writes:
>
> > On Thu, 2014-04-24 at 12:05 +0200, Francisco Jerez wrote:
> >
> >> >>>
> >> >>> I don't think that using getTypeAllocSize() instead of
> >> >>> getTypeStoreSize() to calculate clover::argument::size would be a
Jan Vesely writes:
> On Thu, 2014-04-24 at 12:05 +0200, Francisco Jerez wrote:
>
>> >>>
>> >>> I don't think that using getTypeAllocSize() instead of
>> >>> getTypeStoreSize() to calculate clover::argument::size would be a
>> >>> satisfactory solution. By doing that you'd redefine the API argu
On 04/24/2014 08:51 AM, jfons...@vmware.com wrote:
From: José Fonseca
The current version checking is wrongly refusing to create 3.3 contexts;
unsupported version are checked elsewhere; and the DRI path doesn't do
this sort of checking neither.
This enables piglit glsl 3.30 tests to run withou
On 04/24/2014 08:24 AM, jfons...@vmware.com wrote:
From: José Fonseca
The GLX_ARB_create_context_profile spec says:
"If version 3.1 is requested, the context returned may implement
any of the following versions:
* Version 3.1. The GL_ARB_compatibility extension may or may not
Am 24.04.2014 16:24, schrieb jfons...@vmware.com:
> From: José Fonseca
>
> According to Roland all TGSI support is there in theory.
>
> In practice there are a few piglit failures and crashes, as this hadn't
> been tested before.
> ---
> src/gallium/drivers/llvmpipe/lp_screen.c | 2 +-
> 1 file
Am 24.04.2014 16:24, schrieb jfons...@vmware.com:
> From: José Fonseca
>
> The GLX_ARB_create_context_profile spec says:
>
> "If version 3.1 is requested, the context returned may implement
> any of the following versions:
>
> * Version 3.1. The GL_ARB_compatibility extension may
On Wed, Apr 23, 2014 at 11:19 PM, Kenneth Graunke wrote:
> On 04/18/2014 11:56 AM, Matt Turner wrote:
>> ---
>> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 135
>> +++
>> 1 file changed, 73 insertions(+), 62 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw
On Wed, Apr 23, 2014 at 10:55 PM, Kenneth Graunke wrote:
> On 04/18/2014 11:56 AM, Matt Turner wrote:
>> Clean up with with register_coalesce()/dead_code_eliminate().
>> ---
>> src/mesa/drivers/dri/i965/brw_fs.cpp | 37
>>
>> src/mesa/drivers/dri/i965/brw_fs.
On Wed, Apr 23, 2014 at 11:56 PM, Kenneth Graunke wrote:
> At any rate, adding the assertion makes it obvious that this code is
> correct by design, and we didn't just forget to update it for
> arbitrary-length source lists...I don't think it's an unreasonable
> request...
If we want to document
On Thu, 2014-04-24 at 12:05 +0200, Francisco Jerez wrote:
> >>>
> >>> I don't think that using getTypeAllocSize() instead of
> >>> getTypeStoreSize() to calculate clover::argument::size would be a
> >>> satisfactory solution. By doing that you'd redefine the API argument
> >>> size exposed to th
From: José Fonseca
The current version checking is wrongly refusing to create 3.3 contexts;
unsupported version are checked elsewhere; and the DRI path doesn't do
this sort of checking neither.
This enables piglit glsl 3.30 tests to run without skipping.
---
src/gallium/state_trackers/glx/xlib/
NP, thanks for the review Jose. Please could someone commit the
series for me? I'll follow up with patches to fix other formats for BE.
Thanks,
Richard
Jose Fonseca writes:
> Richard, Michel,
>
> Apologies for the long silence. I flagged this thread as worth
> following, but I failed to notic
From: José Fonseca
According to Roland all TGSI support is there in theory.
In practice there are a few piglit failures and crashes, as this hadn't
been tested before.
---
src/gallium/drivers/llvmpipe/lp_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/dr
From: José Fonseca
The GLX_ARB_create_context_profile spec says:
"If version 3.1 is requested, the context returned may implement
any of the following versions:
* Version 3.1. The GL_ARB_compatibility extension may or may not
be implemented, as determined by the implementa
Oop. Please ignore that. I forgot to specify the filename when producing the
diff.
Jose
- Original Message -
> The patch fixes the issue, but it also contains some unrelated drisw changes.
>
> Marek
>
> On Thu, Apr 24, 2014 at 2:37 PM, Jose Fonseca wrote:
> > No idea why I can't see i
The patch fixes the issue, but it also contains some unrelated drisw changes.
Marek
On Thu, Apr 24, 2014 at 2:37 PM, Jose Fonseca wrote:
> No idea why I can't see it here then. My assertions are fine (assert(0)
> triggers).
>
> Does my patch fix it? If so I'll push it, and strip the comment abo
No idea why I can't see it here then. My assertions are fine (assert(0)
triggers).
Does my patch fix it? If so I'll push it, and strip the comment about being
unexpected.
Jose
- Original Message -
> Jose,
>
> Your assertions are disabled or something else is. The test binds a
> frameb
Typically we want swaps to occur during vertical blank to avoid
tearing. However, when the swap interval is 0 we want to go
as quickly as possible even if this results in tearing.
Indicate to the X server that it should attempt to do an
asynchronise swap when the swap interval is 0.
Signed-off-by
Jose,
Your assertions are disabled or something else is. The test binds a
framebuffer which has no attachments. You can do that with the default
framebuffer, so the FBO completeness rules don't apply here.
There is also GL_ARB_framebuffer_no_attachments, which allows it for
FBOs, though Mesa does
Series looks good to me.
Jose
- Original Message -
> ---
> src/mesa/swrast/s_texture.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/swrast/s_texture.c b/src/mesa/swrast/s_texture.c
> index 9273e94..5fd80ca 100644
> --- a/src/mesa/swras
- Original Message -
> On 24.04.2014 03:12, Jose Fonseca wrote:
> > Module: Mesa
> > Branch: master
> > Commit: fd92346c53ed32709c7b56ce58fb9c9bf43ce9a8
> > URL:
> > https://urldefense.proofpoint.com/v1/url?u=http://cgit.freedesktop.org/mesa/mesa/commit/?id%3Dfd92346c53ed32709c7b56ce58fb9
From: Ville Syrjälä
intel_alloc_renderbuffer_storage() will clobber rb->Format which was
already set up by intel_create_renderbuffer(). This causes the driver
to potentially create the depth buffer in the wrong format.
In practice this makes the depth buffer Z24 even if the visual has
depthBits=
From: Ville Syrjälä
intel_alloc_renderbuffer_storage() will clobber rb->Format which was
already set up by intel_create_renderbuffer(). This causes the driver
to potentially create the depth buffer in the wrong format.
Long time ago things worked by accident because
_mesa_choose_tex_format() che
From: Ville Syrjälä
Gen2 doesn't support texturing from Z formats, so state as much.
Signed-off-by: Ville Syrjälä
---
src/mesa/drivers/dri/i915/i915_context.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/i915_conte
From: Ville Syrjälä
I was a bit annoyed when chromium-bsu stopped rendering the spinning
title text on my gen2 machine. So I bisected it down and found the
problem with the renderbuffer code overwriting the selected depth
buffer format.
This series fixes that particular problem, and I included t
On Wed, 2014-03-26 at 16:27 -0700, Felipe Tonello wrote:
> Hi Timothy,
>
> On Sun, Mar 23, 2014 at 2:11 PM, Timothy Arceri wrote:
> > On Mon, 2014-03-17 at 11:42 -0700, Felipe Tonello wrote:
> >> Hi all,
> >>
> >> I'm working on the KHR_debug for OpenGL ES junior job. I recently
> >> submitted pa
Francisco Jerez writes:
> Jan Vesely writes:
>
>> On Wed, 2014-04-23 at 19:49 +0200, Francisco Jerez wrote:
>>> Jan Vesely writes:
>>>
>>> > On Tue, 2014-04-22 at 17:50 -0700, Matt Arsenault wrote:
>>> >
>>> >
>>> >> >> I think this is what v96:128 is for
>>> >> > according to [0], it specifi
Jan Vesely writes:
> On Wed, 2014-04-23 at 19:49 +0200, Francisco Jerez wrote:
>> Jan Vesely writes:
>>
>> > On Tue, 2014-04-22 at 17:50 -0700, Matt Arsenault wrote:
>> >
>> >
>> >> >> I think this is what v96:128 is for
>> >> > according to [0], it specifies only alignment, not size. I could
On 24.04.2014 03:12, Jose Fonseca wrote:
> Module: Mesa
> Branch: master
> Commit: fd92346c53ed32709c7b56ce58fb9c9bf43ce9a8
> URL:
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd92346c53ed32709c7b56ce58fb9c9bf43ce9a8
>
> Author: José Fonseca
> Date: Thu Apr 3 15:56:46 2014 +0100
>
>
66 matches
Mail list logo
