On Wed, Apr 23, 2014 at 11:56 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > At any rate, adding the assertion makes it obvious that this code is > correct by design, and we didn't just forget to update it for > arbitrary-length source lists...I don't think it's an unreasonable > request...
If we want to document that all commutative operations are binary, that's okay. I just don't see anything in this patch that increases the need for the assertion. The patch is just changing the non-commutative case to check 1-n arguments instead of 1-3. If I'd seen this patch and it added the assertion I would have wondered why it did two unrelated things. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
