NP, thanks for the review Jose. Please could someone commit the series for me? I'll follow up with patches to fix other formats for BE.
Thanks, Richard Jose Fonseca <jfons...@vmware.com> writes: > Richard, Michel, > > Apologies for the long silence. I flagged this thread as worth > following, but I failed to noticed the RFC to me. > > I glanced over it and the series looks good to me AFAICT. I agree that > it is a better to defer the endianess to C-preprocessing time. > > Jose > > ----- Original Message ----- >> Ping >> >> Richard Sandiford <rsand...@linux.vnet.ibm.com> writes: >> > Ping (with fixed subject) >> > >> > Richard Sandiford <rsand...@linux.vnet.ibm.com> writes: >> >> This is a refresh of: >> >> >> >> >> >> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/archives/mesa-dev/2013-June/040594.html&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=qNJxBmC8T0UJrxq1t6ovCuRj4qWejx24a49GkVAHnuk%3D%0A&s=791bcf25d17824bc574aec7183fe264a488fd5b311f6726973a81f52cf580a02 >> >> >> >> At the moment the python code uses sys.byteorder to decide whether >> >> u_format_table.c should be for big or little endian. With this series >> >> it instead generates both forms, using blocks like: >> >> >> >> #ifdef PIPE_ARCH_BIG_ENDIAN >> >> ... >> >> #else >> >> ... >> >> #endif >> >> >> >> in cases where endianness matters. >> >> >> >> Doing it this way is more cross-compiler-friendly. It also means people >> >> working on LE systems can see what the differences would be for BE. >> >> >> >> Tested on x86_64 and z. I don't have commit access so please apply if OK. >> >> >> >> Thanks, >> >> Richard >> >> >> >> _______________________________________________ >> >> mesa-dev mailing list >> >> mesa-dev@lists.freedesktop.org >> >> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=qNJxBmC8T0UJrxq1t6ovCuRj4qWejx24a49GkVAHnuk%3D%0A&s=d03e30542dd6de0bfb0bb613d160a4128997a7be4c52d89f34a970092856ef93 >> > >> > _______________________________________________ >> > mesa-dev mailing list >> > mesa-dev@lists.freedesktop.org >> > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=qNJxBmC8T0UJrxq1t6ovCuRj4qWejx24a49GkVAHnuk%3D%0A&s=d03e30542dd6de0bfb0bb613d160a4128997a7be4c52d89f34a970092856ef93 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=qNJxBmC8T0UJrxq1t6ovCuRj4qWejx24a49GkVAHnuk%3D%0A&s=d03e30542dd6de0bfb0bb613d160a4128997a7be4c52d89f34a970092856ef93 >> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
