https://bugs.freedesktop.org/show_bug.cgi?id=77263
Priority: medium
Bug ID: 77263
Assignee: mesa-dev@lists.freedesktop.org
Summary: [BDW GT3]System hangs while running glxgear with SNA
Severity: normal
Classification: Unclassified
So I wanted to implement ARB_texture_query_levels, in order to get the
right answers I had to make sure the gallium texture has the same levels
as the mesa one, so the hw is programmed correctly.
This led to some fallout as we were suddenly hitting the finalize texture
reallocation path in cases w
Defaults to providing the same offsets as MIN/MAX_TEXEL_OFFSET. For
nvc0, the offset can be -32/31.
Signed-off-by: Ilia Mirkin
---
src/gallium/docs/source/screen.rst | 4
src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++
src/gallium/drivers/i915/i915_screen.c
It was always getting set to -8/7 unconditionally. Use the
driver-reported value instead.
Signed-off-by: Ilia Mirkin
---
src/mesa/state_tracker/st_extensions.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa/state_tracker/st_extensions.c
On 04/09/2014 06:39 PM, Brian Paul wrote:
> We moved away from MALLOC/FREE in the rest of core Mesa a while ago.
> ---
> src/mesa/main/attrib.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
Series is:
Reviewed-by: Kenneth Graunke
signature.asc
Description:
---
src/xdemos/glxinfo.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
index a77e808..f97ba3e 100644
--- a/src/xdemos/glxinfo.c
+++ b/src/xdemos/glxinfo.c
@@ -681,6 +681,11 @@ print_limits(const char *extensions, const char *oglstring)
The suffix is only removed from the printed names in case someone
wants to build glxinfo against an old implementation.
---
src/xdemos/glxinfo.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
inde
---
src/xdemos/glxinfo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
index f97ba3e..f8a4e51 100644
--- a/src/xdemos/glxinfo.c
+++ b/src/xdemos/glxinfo.c
@@ -628,6 +628,9 @@ print_limits(const char *extensions, const char *oglstring)
{ 1
---
src/xdemos/glxinfo.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
index a116e4a..a77e808 100644
--- a/src/xdemos/glxinfo.c
+++ b/src/xdemos/glxinfo.c
@@ -659,6 +659,28 @@ print_limits(const char *extensions, const char
We moved away from MALLOC/FREE in the rest of core Mesa a while ago.
---
src/mesa/main/attrib.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c
index 5a626f2..c656845 100644
--- a/src/mesa/main/attrib.c
++
No longer used anywhere. These also caused trouble in the Gallium
state tracker code where we include both core Mesa and Gallium util
headers (and the macros were defined differently in each world.)
Removing these macros should help avoid macro mix-ups in the future.
---
src/mesa/main/imports.h |
---
src/mesa/drivers/x11/xm_api.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c
index 4779595..d860569 100644
--- a/src/mesa/drivers/x11/xm_api.c
+++ b/src/mesa/drivers/x11/xm_api.c
@@ -855,7 +855,7 @@ XMesaVisu
---
src/mesa/main/errors.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c
index 9151718..d80fda0 100644
--- a/src/mesa/main/errors.c
+++ b/src/mesa/main/errors.c
@@ -980,7 +980,7 @@ _mesa_free_errors_data(struct gl_context *ct
---
src/mesa/main/vdpau.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c
index c2cf206..d974593 100644
--- a/src/mesa/main/vdpau.c
+++ b/src/mesa/main/vdpau.c
@@ -88,7 +88,7 @@ unregister_surface(struct set_entry *entry)
We were using REALLOC() from u_memory.h but FREE() from imports.h.
This mismatch caused us to trash the heap on Windows after we
deleted a texture object.
This fixes a regression from commit 6c59be7776e4d.
---
src/mesa/state_tracker/st_cb_texture.c |2 +-
src/mesa/state_tracker/st_texture.c
So I was looking at adding ARB_texture_query_levels support to
gallium, and hit a bit of a saga in the state tracker texture
finalising code.
commits involved in this are below,
So to fix the query levels test I essentially wanted to revert
529b7b355d392b1534ccd8ff7b428dc21cbfdc21 so that the hw
---
Eric, how about this squashed in?
On Gen < 6 any accumulator use, with the exception of the "implied
update" that nearly every instruction does causes a barrier dep.
Implicit writes, noted by ::writes_accumulator, causes a barrier dep.
On Gen >= 6, we just track the accumulator dependencies w
On Tuesday 08 April 2014, Kenneth Graunke wrote:
> On 01/21/2014 03:35 PM, Fredrik Höglund wrote:
> > So here is my take on GL_ARB_multi_bind.
> >
> > I tried to come up with names for the new hash table functions that
> > don't suggest that they should be used to do unlocked insertions/lookups.
>
The generator uses its destination as a source implicitly, which breaks
some assumptions in dead code elimination. Giving the instruction a
source allows us to reason about it better.
Reviewed-by: Eric Anholt
---
I can't use the source in the generator because a shl(1) instruction
is emitted from
Not setting this would prevented coalescing after a failed attempt if
the sources for both MOVs were the same.
total instructions in shared programs: 1654531 -> 1650224 (-0.26%)
instructions in affected programs: 423167 -> 418860 (-1.02%)
GAINED:2
LOST:
On Wed, Apr 9, 2014 at 3:13 PM, Kenneth Graunke wrote:
> On 04/09/2014 01:47 PM, Matt Turner wrote:
>> From: Juha-Pekka Heikkila
>>
>> Reviewed-by: Matt Turner
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> As a follow-on patch series, we should move common fields from fs_reg
>> and vec4's reg
On 04/09/2014 01:47 PM, Matt Turner wrote:
> From: Juha-Pekka Heikkila
>
> Our hardware has an "accumulator" register, which can be used to store
> intermediate results across multiple instructions. Many instructions
> can implicitly write a value to the accumulator in addition to their
> normal
On Wed, Apr 9, 2014 at 3:06 PM, Eric Anholt wrote:
> Matt Turner writes:
>
>> ---
>> src/mesa/drivers/dri/i965/brw_shader.cpp | 16
>> src/mesa/drivers/dri/i965/brw_shader.h | 1 +
>> 2 files changed, 17 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cp
On 04/09/2014 01:47 PM, Matt Turner wrote:
> From: Juha-Pekka Heikkila
>
> Reviewed-by: Matt Turner
> Signed-off-by: Juha-Pekka Heikkila
> ---
> As a follow-on patch series, we should move common fields from fs_reg
> and vec4's reg into a backend_reg and consolidate these functions.
Yeah, ther
Matt Turner writes:
> ---
> src/mesa/drivers/dri/i965/brw_shader.cpp | 16
> src/mesa/drivers/dri/i965/brw_shader.h | 1 +
> 2 files changed, 17 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
> b/src/mesa/drivers/dri/i965/brw_shader.cpp
> index f1944
Now that we properly track accumulator dependencies, the scheduler is
able to schedule instructions between the mach and mov in the common
the integer multiplication pattern:
mul acc0, x, y
mach null, x, y
mov dest, acc0
Since a null destination implies no dependency on the destination
On Wed, Apr 9, 2014 at 5:12 PM, Rob Clark wrote:
> On Wed, Apr 9, 2014 at 1:59 PM, Thomas Hellstrom
> wrote:
>> Hi, Rob!
>>
>> On 04/08/2014 10:48 PM, Rob Clark wrote:
>>> From: Rob Clark
>>>
>>> Add support to property handle solid-fill src and/or mask. Without this
>>> we fallback to sw a lo
On Wed, Apr 9, 2014 at 1:59 PM, Thomas Hellstrom wrote:
> Hi, Rob!
>
> On 04/08/2014 10:48 PM, Rob Clark wrote:
>> From: Rob Clark
>>
>> Add support to property handle solid-fill src and/or mask. Without this
>> we fallback to sw a lot for common things like text rendering.
>>
>> Signed-off-by:
On Fri, Apr 4, 2014 at 6:51 AM, Juha-Pekka Heikkila
wrote:
> diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> index a951459..92f82fd 100644
> --- a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> +++ b/src
From: Juha-Pekka Heikkila
Our hardware has an "accumulator" register, which can be used to store
intermediate results across multiple instructions. Many instructions
can implicitly write a value to the accumulator in addition to their
normal destination register. This is enabled by the "AccWrEn
From: Juha-Pekka Heikkila
Reviewed-by: Matt Turner
Signed-off-by: Juha-Pekka Heikkila
---
As a follow-on patch series, we should move common fields from fs_reg
and vec4's reg into a backend_reg and consolidate these functions.
src/mesa/drivers/dri/i965/brw_fs.cpp | 8
src/mesa/dri
---
src/mesa/drivers/dri/i965/brw_shader.cpp | 16
src/mesa/drivers/dri/i965/brw_shader.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
b/src/mesa/drivers/dri/i965/brw_shader.cpp
index f194437..c8796b3 100644
--- a/src/mesa/dri
On Wed, Apr 9, 2014 at 1:59 PM, Thomas Hellstrom wrote:
> Hi, Rob!
>
> On 04/08/2014 10:48 PM, Rob Clark wrote:
>> From: Rob Clark
>>
>> Add support to property handle solid-fill src and/or mask. Without this
>> we fallback to sw a lot for common things like text rendering.
>>
>> Signed-off-by:
On 03/16/2014 07:10 AM, Emil Velikov wrote:
> With commit 1f1928db001(glx: Drop _Xglobal_lock while we create and
> initialize glx display) we've split the big _Xglobal_lock handling in
> a more fine grained manner.
>
> Unfortunatelly we forgot to drop the unlock_mutex on the error paths,
> leadin
On 04/09/2014 11:50 AM, Thomas Hellstrom wrote:
On 04/03/2014 04:07 PM, Brian Paul wrote:
On 04/02/2014 11:17 PM, Thomas Hellstrom wrote:
On 04/01/2014 05:04 PM, Rob Clark wrote:
From: Rob Clark
Add support to property handle solid-fill src and/or mask. Without
this
we fallback to sw a lot
Hi, Rob!
On 04/08/2014 10:48 PM, Rob Clark wrote:
> From: Rob Clark
>
> Add support to property handle solid-fill src and/or mask. Without this
> we fallback to sw a lot for common things like text rendering.
>
> Signed-off-by: Rob Clark
> ---
> src/gallium/state_trackers/xa/xa_composite.c | 1
On Wed, Apr 9, 2014 at 7:40 PM, Brian Paul wrote:
> Fixes a crash in svga_context_flush_buffers() if we use the 'draw' module
> for AA lines (when the device doesn't support that feature). We need to
> initialize this list before we setup the swtnl pieces.
>
> Found/fixed by Charmaine Lee.
>
> Cc
Reviewed-by: Thomas Hellstrom
On 04/09/2014 07:40 PM, Brian Paul wrote:
> Fixes a crash in svga_context_flush_buffers() if we use the 'draw' module
> for AA lines (when the device doesn't support that feature). We need to
> initialize this list before we setup the swtnl pieces.
>
> Found/fixed b
On 04/03/2014 04:07 PM, Brian Paul wrote:
> On 04/02/2014 11:17 PM, Thomas Hellstrom wrote:
>> On 04/01/2014 05:04 PM, Rob Clark wrote:
>>> From: Rob Clark
>>>
>>> Add support to property handle solid-fill src and/or mask. Without
>>> this
>>> we fallback to sw a lot for common things like text r
Fixes a crash in svga_context_flush_buffers() if we use the 'draw' module
for AA lines (when the device doesn't support that feature). We need to
initialize this list before we setup the swtnl pieces.
Found/fixed by Charmaine Lee.
Cc: "10.0"
---
src/gallium/drivers/svga/svga_context.c |4 +
On 04/04/2014 02:01 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> The two code paths are quite different, and there are some problems in
> the handling of uniform blocks. Future changes will cause these paths
> to diverge further. Ultimately, selecting between the two functions
> will happen
On 04/08/2014 09:20 PM, Kenneth Graunke wrote:
> Many shaders use a pattern such as:
>
> for (int i = 0; i < NUM_LIGHTS; i++) {
>...access a uniform array, or shader input/output array...
> }
>
> where NUM_LIGHTS is a small constant (such as 2, 4, or 8).
>
> The expectation is that the compi
On 04/04/2014 02:01 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> For blocks, gl_shader_program::UniformStorage isn't very useful. The
> names stored there are the names of the elements of the block, so
> finding blocks with an instance name is hard. There is also only one
> entry in ::Unifo
On 04/04/2014 02:01 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> In the next patch, we'll see that using
> gl_shader_program::UniformStorage is not correct for uniform blocks.
> That means we can't use ::UniformStorage to select between the sampler
> path and the block path. Instead we want
On 16/03/14 14:10, Emil Velikov wrote:
> With commit 1f1928db001(glx: Drop _Xglobal_lock while we create and
> initialize glx display) we've split the big _Xglobal_lock handling in
> a more fine grained manner.
>
> Unfortunatelly we forgot to drop the unlock_mutex on the error paths,
> leading to
https://bugs.freedesktop.org/show_bug.cgi?id=76377
Emil Velikov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=76856
Emil Velikov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=77208
--- Comment #3 from Andy Furniss ---
(In reply to comment #1)
> Oh, it seems the pausing issue could be caused by interaction with power
> management. This is what a user posted:
>
> >When polling '/sys/kernel/debug/dri/0/radeon_pm_info' you can
https://bugs.freedesktop.org/show_bug.cgi?id=77240
Priority: medium
Bug ID: 77240
Assignee: mesa-dev@lists.freedesktop.org
Summary: khrplatform.h not installed if EGL is disabled
Severity: normal
Classification: Unclassified
Reviewed-by: Marek Olšák
Marek
On Wed, Apr 9, 2014 at 8:39 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74868
>
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Michel Dänzer
> ---
> src/gallium/drivers/r600/r600_shader.c |
On 04/09/2014 12:56 PM, Tapani Pälli wrote:
diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
index 06d0bba..5709d42 100644
--- a/src/mesa/main/get_hash_params.py
+++ b/src/mesa/main/get_hash_params.py
@@ -474,6 +474,7 @@ descriptor=[
[ "MAX_LIST_NESTING", "CONS
Patch adds a preprocessor define for the extension and stores explicit
location data for uniforms during AST->HIR conversion. It also sets
layout token to be available when having the extension in place.
Signed-off-by: Tapani Pälli
---
src/glsl/ast_to_hir.cpp | 37 +
Patch refactors the existing uniform processing so explicit locations
are taken in to account during variable processing. These locations
are temporarily stored in gl_uniform_storage before actual locations
are set.
The 'remap_location' variable in gl_uniform_storage is changed to be
signed so tha
Signed-off-by: Tapani Pälli
---
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index bf51e3a..245a045 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -148,7 +148,7 @@ GL 4.3:
GL_ARB_compute_shaderstar
Support inactive uniforms that have explicit location set in
glUniform* functions.
Signed-off-by: Tapani Pälli
---
src/mesa/main/uniform_query.cpp | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp
index 5f1af08.
Signed-off-by: Tapani Pälli
---
src/glsl/glsl_parser_extras.cpp | 1 +
src/glsl/glsl_parser_extras.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp
index a42f3d2..d6415ab 100644
--- a/src/glsl/glsl_parser_extras.cpp
+++ b
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
src/mesa/state_tracker/st_extensions.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index 15fcd30..f8abf9
Patch initializes the UniformRemapTable for explicit locations. This
needs to happen before optimizations to make sure all inactive uniforms
get their explicit locations correctly.
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 99 +
1 f
Hi;
Patches implement the extension, no Piglit regressions and all the tests
for the extension pass. Location initialization and assignment is done
like Ian suggested, this removed quite a bit of code since now there is
no need to store inactive uniforms temporarily.
Here's a branch with the patc
Patch adds new implementation dependent value required by the
GL_ARB_explicit_uniform_location extension. Default value for user
assignable locations is calculated as sum of MaxUniformComponents
for each stage.
Signed-off-by: Tapani Pälli
---
src/mesa/main/context.c | 10 +-
Signed-off-by: Tapani Pälli
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index a72284c..8605189 100644
--- a/src/mesa/main/extensions.c
+++ b/src/mesa/main/extensions.
Signed-off-by: Tapani Pälli
---
src/mapi/glapi/gen/gl_API.xml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
index 9200cd6..d269d7d 100644
--- a/src/mapi/glapi/gen/gl_API.xml
+++ b/src/mapi/glapi/gen/gl_API.xml
@@ -8312,6 +8
From: Christian König
Signed-off-by: Christian König
---
src/gallium/state_trackers/omx/vid_enc.c | 10 +++---
src/gallium/state_trackers/omx/vid_enc.h | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/omx/vid_enc.c
b/src/gallium/state_tracke
From: Christian König
Signed-off-by: Christian König
---
src/gallium/state_trackers/omx/vid_enc.c | 91 +---
src/gallium/state_trackers/omx/vid_enc.h | 5 +-
2 files changed, 76 insertions(+), 20 deletions(-)
diff --git a/src/gallium/state_trackers/omx/vid_enc.c
b
From: Christian König
Doesn't seems to be needed any more.
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/radeon_vce.c| 2 +-
src/gallium/drivers/radeon/radeon_vce.h| 1 -
src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 3 +--
3 files changed, 2 insertions(+), 4
From: Christian König
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 11 ++-
src/gallium/include/pipe/p_video_state.h | 3 +++
src/gallium/state_trackers/omx/vid_enc.c | 8 +++-
3 files changed, 16 insertions(+), 6 deletions(-)
dif
From: Christian König
Remember what frames we encoded at which position.
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/radeon_vce.c| 87 --
src/gallium/drivers/radeon/radeon_vce.h| 15 +
src/gallium/drivers/radeon/radeon_vce_40_2_2.c
From: Christian König
Signed-off-by: Slava Grigorev
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/radeon_vce.h| 2 +-
src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 73 ++
2 files changed, 53 insertions(+), 22 deletions(-)
diff --git a/src/ga
From: Christian König
Keep tasks as linked list, this way we can associate
more than one encoding task with each buffer.
Signed-off-by: Christian König
---
src/gallium/state_trackers/omx/vid_enc.c | 182 +--
src/gallium/state_trackers/omx/vid_enc.h | 4 +
2 files
Am 09.04.2014 05:44, schrieb Michel Dänzer:
On Mit, 2014-04-09 at 02:15 +0200, Marek Olšák wrote:
From: Marek Olšák
Create the screen in the winsys while the mutex is locked.
This also results in a nice code cleanup!
[...]
diff --git a/src/gallium/targets/egl-static/egl_pipe.c
b/src/gallium
On Wed, Apr 9, 2014 at 7:23 AM, Ian Romanick wrote:
> I believe UBO array indices are also dynamically uniform.
I was surprised to find this when building the list too, but I believe
it's unrestricted.
The GLSL 4.0 spec, 4.3.7 p43 (bottom of) says:
"Any integral expression can be used to i
https://bugs.freedesktop.org/show_bug.cgi?id=77208
Christian König changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
José, any chance you could work Richard to get this in?
On Mon, 2014-04-07 at 11:35 +0100, Richard Sandiford wrote:
> Ping.
>
> Richard Sandiford writes:
> > Ping (with fixed subject)
> >
> > Richard Sandiford writes:
> >> This is a refresh of:
> >>
> >>http://lists.freedesktop.org/archiv
73 matches
Mail list logo
