On 04/03/2014 04:07 PM, Brian Paul wrote: > On 04/02/2014 11:17 PM, Thomas Hellstrom wrote: >> On 04/01/2014 05:04 PM, Rob Clark wrote: >>> From: Rob Clark <robcl...@freedesktop.org> >>> >>> Add support to property handle solid-fill src and/or mask. Without >>> this >>> we fallback to sw a lot for common things like text rendering. >>> >>> Signed-off-by: Rob Clark <robcl...@freedesktop.org> >>> --- >>> src/gallium/state_trackers/xa/xa_composite.c | 88 ++++---- >>> src/gallium/state_trackers/xa/xa_priv.h | 7 +- >>> src/gallium/state_trackers/xa/xa_renderer.c | 289 >>> ++++++++++++++++----------- >>> src/gallium/state_trackers/xa/xa_tgsi.c | 31 ++- >>> 4 files changed, 242 insertions(+), 173 deletions(-) >> >> Rob, >> While testing this patch it looks like we sometimes set two samplers, >> and the first one is NULL. >> The SVGA driver asserts on that condition. >> We might need to move the active sampler to the first entry in that >> case, and adjust tex coords and shader accordingly. >> >> I'll discuss with BrianP. > > I think the root problem is a disagreement between texture samplers > and sampler views. If a texture sampler is non-null, the > corresponding sampler view be should be non-null too, and vice versa. > > We're tripping over an assertion when a a sampler view is non-null but > the corresponding sampler is NULL. > > I'm going to write a patch for the driver to be more resilient in that > situation. > > -Brian
Brian, This is a different problem. Here, the state tracker sets up sampler[0] and sampler_view[0] to NULL, but sampler[1] and sampler_view[1] to NON-NULL, but samplers and sampler views are consistent. The question is whether that's OK, or whether that's not allowed. /Thomas > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=l5Ago9ekmVFZ3c4M6eauqrJWGwjf6fTb%2BP3CxbBFkVM%3D%0A&m=VGqKhmPosyC9QpnoVvQFOszMOE3eB%2B956me7wcCEnEs%3D%0A&s=5dd06c74671afd42afbd55b02f0c81895463044783e8d6f7a692963750b02123 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
