Re: [Mesa-dev] [PATCH 00/18] Consolidating r600_texture.c

2013-09-25 Thread Christian König
Am 26.09.2013 03:35, schrieb Marek Olšák: Nothing too exciting, I'm just consolidating some code between r600g and radeonsi. There are some small improvements though: 1) The CMASK buffer for MSAA colorbuffers is cleared with CP DMA instead of using the CPU. 2) This series enables 2D tiling for

Re: [Mesa-dev] [PATCH] i965: Fix cube array coordinate normalization

2013-09-25 Thread Chris Forbes
Fixed and landed on master now. On Mon, Sep 23, 2013 at 8:05 AM, Eric Anholt wrote: > Chris Forbes writes: > >> Hardware requires the magnitude of the largest component to not exceed >> 1; brw_cubemap_normalize ensures that this is the case. >> >> Unfortunately, we would previously multiply the

[Mesa-dev] [PATCH 2/2] i965: Generate code for ir_binop_mul64.

2013-09-25 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 1 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 ++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 7 +++ 3 files changed, 18 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_cha

[Mesa-dev] [PATCH 1/2] glsl: Implement [iu]mulExtended() built-ins for ARB_gpu_shader5.

2013-09-25 Thread Matt Turner
These built-ins have two "out" parameters, which makes implementing them efficiently with our current compiler infrastructure difficult. Instead, implement them in terms of the existing ir_binop_mul IR (to return the low 32-bits) and a new ir_binop_mul64 which returns the high 32-bits. --- Depends

Re: [Mesa-dev] [PATCH] mesa: Remove some remaining FEATURE_* detritus.

2013-09-25 Thread Kenneth Graunke
On 09/25/2013 04:28 PM, Eric Anholt wrote: > --- > src/mesa/Android.libmesa_dricore.mk | 3 --- > src/mesa/drivers/dri/Android.mk | 3 --- > src/mesa/drivers/dri/i915/Makefile.am| 10 -- > src/mesa/drivers/dri/i915/intel_screen.c | 8 > src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 18/18] radeon: make texture logging more useful

2013-09-25 Thread Marek Olšák
From: Marek Olšák This has been very useful for tracking down bugs in libdrm. The *_PRINT_TEXDEPTH environment variables were probably never used, so I removed them. --- src/gallium/drivers/r600/r600_pipe.c | 2 -- src/gallium/drivers/radeon/r600_pipe_common.c | 3 ++- src/gallium/dr

[Mesa-dev] [PATCH 16/18] r600g: remove compute_global_transfer_* calls from texture_transfer_map/unmap

2013-09-25 Thread Marek Olšák
From: Marek Olšák Textures can never have target==PIPE_BUFFER. --- src/gallium/drivers/r600/r600_texture.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/gallium/drivers/r600/r600_texture.c b/src/gallium/drivers/r600/r600_texture.c index d505d6b..dcceda3 100644 --- a/src/galliu

[Mesa-dev] [PATCH 15/18] r600g: move the low-level buffer functions for multiple rings to drivers/radeon

2013-09-25 Thread Marek Olšák
From: Marek Olšák Also slightly optimize r600_buffer_map_sync_with_rings. --- src/gallium/drivers/r600/r600_asm.c | 2 +- src/gallium/drivers/r600/r600_blit.c | 2 +- src/gallium/drivers/r600/r600_buffer.c| 6 +-- src/gallium/drivers/r600/r600_hw_context.c| 4 +

[Mesa-dev] [PATCH 14/18] r600g, radeonsi: consolidate tiling_info initialization

2013-09-25 Thread Marek Olšák
From: Marek Olšák and the util_format_s3tc_init calls too. --- src/gallium/drivers/r600/evergreen_state.c| 10 +-- src/gallium/drivers/r600/r600_pipe.c | 123 +- src/gallium/drivers/r600/r600_pipe.h | 7 -- src/gallium/drivers/r600/r600_texture.c

[Mesa-dev] [PATCH 13/18] radeonsi: implement clear_buffer using CP DMA, initialize CMASK with it

2013-09-25 Thread Marek Olšák
From: Marek Olšák More work needs to be done for this to be entirely shared with r600g. I'm just trying to share r600_texture.c now. The reason I put the implementation to si_descriptors.c is that the emit function had already been there. --- src/gallium/drivers/radeonsi/r600_texture.c | 5 +

[Mesa-dev] [PATCH 12/18] r600g: move aux_context and r600_screen_clear_buffer to drivers/radeon

2013-09-25 Thread Marek Olšák
From: Marek Olšák This will be used in the next commit. --- src/gallium/drivers/r600/r600_blit.c | 30 + src/gallium/drivers/r600/r600_pipe.c | 65 --- src/gallium/drivers/r600/r600_pipe.h | 7 --- src/gallium/drivers/r600/r600_text

[Mesa-dev] [PATCH 11/18] radeonsi: move debug options to R600_DEBUG

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_shader.c | 31 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 29 src/gallium/drivers/radeon/r600_pipe_common.h | 2 ++ src/gallium/drivers/radeonsi/r600_texture.c| 4 +--- sr

[Mesa-dev] [PATCH 10/18] r600g: move some debug options to drivers/radeon

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/evergreen_compute.h | 2 +- src/gallium/drivers/r600/r600_asm.c | 6 ++--- src/gallium/drivers/r600/r600_buffer.c| 4 ++-- src/gallium/drivers/r600/r600_pipe.c | 33 --- src/gallium/drivers/r600

[Mesa-dev] [PATCH 09/18] r600g, radeonsi: share the async dma interface

2013-09-25 Thread Marek Olšák
From: Marek Olšák r600_texture.c is one step closer to r600g. --- src/gallium/drivers/r600/evergreen_state.c| 16 +--- src/gallium/drivers/r600/r600_pipe.c | 2 -- src/gallium/drivers/r600/r600_pipe.h | 23 --- src/gallium/drivers/r600/r600_

[Mesa-dev] [PATCH 08/18] radeonsi: move radeonsi-specific functions out of r600_texture.c

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/r600_texture.c | 42 src/gallium/drivers/radeonsi/radeonsi_pipe.c | 1 - src/gallium/drivers/radeonsi/radeonsi_pipe.h | 3 -- src/gallium/drivers/radeonsi/si_state.c | 38 + 4 files ch

[Mesa-dev] [PATCH 07/18] r600g,radeonsi: remove unused code

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.h | 3 --- src/gallium/drivers/radeonsi/radeonsi_pipe.h | 1 - 2 files changed, 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.h b/src/gallium/drivers/r600/r600_pipe.h index 36132f2..fc13860 100644 --- a/src/galli

[Mesa-dev] [PATCH 06/18] r600g: move r600g-specific functions out of r600_texture.c

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 1 - src/gallium/drivers/r600/r600_pipe.h | 22 +- src/gallium/drivers/r600/r600_state_common.c | 451 ++ src/gallium/drivers/r600/r600_texture.c | 454 --- 4 file

[Mesa-dev] [PATCH 05/18] r600g, radeonsi: consolidate r600_texture structures

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_resource.h | 24 src/gallium/drivers/radeon/r600_pipe_common.h | 25 + src/gallium/drivers/radeonsi/r600_resource.h | 19 +-- 3 files changed, 26 insertions(+), 42 deletions

[Mesa-dev] [PATCH 04/18] r600g: get rid of r600_texture::is_rat

2013-09-25 Thread Marek Olšák
From: Marek Olšák It's always 0. --- src/gallium/drivers/r600/evergreen_state.c | 8 +--- src/gallium/drivers/r600/r600_resource.h | 1 - 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c i

[Mesa-dev] [PATCH 03/18] r600g: get rid of r600_texture::array_mode

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_blit.c | 2 +- src/gallium/drivers/r600/r600_resource.h | 3 --- src/gallium/drivers/r600/r600_texture.c | 24 +++- 3 files changed, 4 insertions(+), 25 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c

[Mesa-dev] [PATCH 02/18] r600g, radeonsi: consolidate transfer, cmask, and fmask structures

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c| 30 src/gallium/drivers/r600/r600_blit.c | 24 ++--- src/gallium/drivers/r600/r600_hw_context.c| 4 +-- src/gallium/drivers/r600/r600_resource.h | 36 +++ src/gallium

[Mesa-dev] [PATCH 01/18] radeon drivers: handle PIPE_CAP_MAX_VIEWPORTS

2013-09-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r300/r300_screen.c | 3 +++ src/gallium/drivers/r600/r600_pipe.c | 3 +++ src/gallium/drivers/radeonsi/radeonsi_pipe.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r30

[Mesa-dev] [PATCH 00/18] Consolidating r600_texture.c

2013-09-25 Thread Marek Olšák
Nothing too exciting, I'm just consolidating some code between r600g and radeonsi. There are some small improvements though: 1) The CMASK buffer for MSAA colorbuffers is cleared with CP DMA instead of using the CPU. 2) This series enables 2D tiling for compressed textures on SI. I think it was d

Re: [Mesa-dev] [PATCH] mesa: Remove some remaining FEATURE_* detritus.

2013-09-25 Thread Matt Turner
On Wed, Sep 25, 2013 at 4:28 PM, Eric Anholt wrote: > --- > src/mesa/Android.libmesa_dricore.mk | 3 --- > src/mesa/drivers/dri/Android.mk | 3 --- > src/mesa/drivers/dri/i915/Makefile.am| 10 -- > src/mesa/drivers/dri/i915/intel_screen.c | 8 > src/mesa/driv

Re: [Mesa-dev] [PATCH 07/10] i965: Don't copy prop source mods into instructions that can't take them.

2013-09-25 Thread Matt Turner
On Mon, Sep 23, 2013 at 8:06 PM, Kenneth Graunke wrote: > On 09/23/2013 04:13 PM, Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ >> src/mesa/drivers/dri/i965/brw_shader.cpp | 19 +++ >> src/mesa/drivers/dri/i965/brw_shader.h | 1 + >> src/mesa/d

[Mesa-dev] [PATCH] mesa: Remove some remaining FEATURE_* detritus.

2013-09-25 Thread Eric Anholt
--- src/mesa/Android.libmesa_dricore.mk | 3 --- src/mesa/drivers/dri/Android.mk | 3 --- src/mesa/drivers/dri/i915/Makefile.am| 10 -- src/mesa/drivers/dri/i915/intel_screen.c | 8 src/mesa/drivers/dri/i965/Makefile.am| 10 -- src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] add LIBGL_NEVER_INDIRECT env var to disable fallback to indirect

2013-09-25 Thread Eric Anholt
Chris Forbes writes: > This is useful when working on the drivers, since falling back to > indirect rendering means we broke our driver's ability to load somehow. How about just making unresolved symbols at dlopen() time fatal? I didn't quite find a way to do so last time I looked, but I think

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix GLSL mix(.., .., bvecN)

2013-09-25 Thread Matt Turner
On Wed, Sep 25, 2013 at 10:48 AM, Marek Olšák wrote: > It's more of a question of what the GLSL compiler did before the > introduction of ir_triop_csel. I guess it used LRP. It used conditional assignments for the boolean-selector versions (see fd183fa02c4) and LRP for the others. ___

Re: [Mesa-dev] [PATCH 09/10] i965/fs: Add a peephole pass to combine ADD with ADDC/SUBB.

2013-09-25 Thread Ian Romanick
On 09/24/2013 04:13 PM, Kenneth Graunke wrote: > On 09/24/2013 03:42 PM, Ian Romanick wrote: >> On 09/24/2013 03:38 PM, Matt Turner wrote: >>> On Tue, Sep 24, 2013 at 2:41 PM, Ian Romanick wrote: For our own edification, we should add some feedback in the INTEL_DEBUG=perf case. If there

Re: [Mesa-dev] [PATCH] add LIBGL_NEVER_INDIRECT env var to disable fallback to indirect

2013-09-25 Thread Kenneth Graunke
On 09/25/2013 01:00 PM, Chris Forbes wrote: > This is useful when working on the drivers, since falling back to > indirect rendering means we broke our driver's ability to load somehow. > > Signed-off-by: Chris Forbes > --- > docs/envvars.html | 1 + > src/glx/glxext.c | 10 -- > 2 fil

[Mesa-dev] [PATCH] add LIBGL_NEVER_INDIRECT env var to disable fallback to indirect

2013-09-25 Thread Chris Forbes
This is useful when working on the drivers, since falling back to indirect rendering means we broke our driver's ability to load somehow. Signed-off-by: Chris Forbes --- docs/envvars.html | 1 + src/glx/glxext.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/do

[Mesa-dev] [PATCH] radeon/llvm: fix TGSI_OPCODE_UCMP

2013-09-25 Thread Marek Olšák
From: Marek Olšák This doesn't fix any known issue (I haven't run piglit with this yet), but the code was obviously completely wrong. It looks like copy-pasted from CMP. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 1/3] st/mesa: fix GLSL mix(.., .., bvecN)

2013-09-25 Thread Marek Olšák
From: Marek Olšák v2: use CMP on drivers without native integer support --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 271cf0

Re: [Mesa-dev] [PATCH] i965: extend fast texture upload

2013-09-25 Thread Chad Versace
On 09/25/2013 10:40 AM, Paul Berry wrote: On 25 September 2013 10:18, Chad Versace mailto:chad.vers...@linux.intel.com>> wrote: On 07/22/2013 03:54 PM, Frank Henigman wrote:> Extend the fast texture upload from BGRA X-tiled to include RGBA, > diff --git a/src/mesa/drivers/dri/i965/inte

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix GLSL mix(.., .., bvecN)

2013-09-25 Thread Marek Olšák
It's more of a question of what the GLSL compiler did before the introduction of ir_triop_csel. I guess it used LRP. Marek On Tue, Sep 24, 2013 at 8:12 PM, Ian Romanick wrote: > On 09/23/2013 05:37 PM, mar...@gmail.com wrote: >> From: Marek Olšák >> >> --- >> src/mesa/state_tracker/st_glsl_to_

Re: [Mesa-dev] [PATCH] i965: extend fast texture upload

2013-09-25 Thread Paul Berry
On 25 September 2013 10:18, Chad Versace wrote: > On 07/22/2013 03:54 PM, Frank Henigman wrote:> Extend the fast texture > upload from BGRA X-tiled to include RGBA, > > diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c > b/src/mesa/drivers/dri/i965/intel_tex_subimage.c > > index 05e684c.

Re: [Mesa-dev] [PATCH] i965: extend fast texture upload

2013-09-25 Thread Chad Versace
On 07/22/2013 03:54 PM, Frank Henigman wrote:> Extend the fast texture upload from BGRA X-tiled to include RGBA, > Alpha/Luminance, and Y-tiled. Speed improvements, measured with > mesa demos teximage program, on 256 x 256 texture, in MB/s, on a > Sandy Bridge (Ivy is comparable): > >

Re: [Mesa-dev] [PATCH] llvmpipe: we need to subdivide if fb is bigger in either direction

2013-09-25 Thread Brian Paul
On Tue, Sep 24, 2013 at 2:26 PM, Zack Rusin wrote: > We need to subdivide triangles if either of the dimensions is > larger than the max edge length, not when both of them are larger. > > Signed-off-by: Zack Rusin > --- > src/gallium/drivers/llvmpipe/lp_setup.c | 2 +- > 1 file changed, 1 insert

Re: [Mesa-dev] [PATCH 4/4] radeon/winsys: keep screen pointer in winsys v2

2013-09-25 Thread Marek Olšák
For this patch: Reviewed-by: Marek Olšák For the rest: Acked-by: Marek Olšák I don't know much about the build system, so I can't say if the patches are correct. If all the targets build successfully, then it's probably fine. Marek On Wed, Sep 25, 2013 at 2:31 PM, Christian König wrote: >

[Mesa-dev] [Bug 69682] mesa-9.2.0 and glamor-0.5.1 crash X - (?) _mesa_GetVertexAttribdv (?)

2013-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69682 Michel Dänzer changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] llvmpipe: we need to subdivide if fb is bigger in either direction

2013-09-25 Thread Jose Fonseca
- Original Message - > Am 24.09.2013 22:26, schrieb Zack Rusin: > > We need to subdivide triangles if either of the dimensions is > > larger than the max edge length, not when both of them are larger. > > > > Signed-off-by: Zack Rusin > > --- > > src/gallium/drivers/llvmpipe/lp_setup.c

[Mesa-dev] [PATCH 3/4] build/radeonsi: group all targets in common subdir

2013-09-25 Thread Christian König
From: Christian König Allows us to share more code between different targets. Signed-off-by: Christian König --- configure.ac | 8 +- src/gallium/targets/Makefile.am| 6 +- src/gallium/targets/dri-radeonsi/Makefile.am | 72

[Mesa-dev] [PATCH 4/4] radeon/winsys: keep screen pointer in winsys v2

2013-09-25 Thread Christian König
From: Christian König Only create one screen for each winsys instance. This helps with buffer sharing and interop handling. v2: rebased and some minor cleanup Signed-off-by: Christian König --- src/gallium/drivers/r300/r300_screen.c| 3 +++ src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 1/4] build/r300: group build target in common subdir

2013-09-25 Thread Christian König
From: Christian König Allows us to share more code between different targets. Signed-off-by: Christian König --- configure.ac | 8 ++-- src/gallium/targets/Makefile.am| 6 +-- src/gallium/targets/dri-r300/Makefile.am | 72 --

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

2013-09-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50317 Marc Dietrich changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED