Re: [Mesa-dev] Trying MSAAx2 (r300g) on RS690

2013-07-26 Thread Björn Beutel
Hi Marek, for me, MSAAx2, MSAAx4 and MSAAx6 work perfectly on RS690 using r300g (git) when I set "RADEON_DEBUG=nocmask". I've tested the driver on glxgears, SuperTuxKart, Torcs, FooBillard, and some other games. Without "RADEON_DEBUG=nocmask", I see corruptions, as in the attached picture für g

[Mesa-dev] [PATCH] glsl: Less const for glsl_type convenience accessors

2013-07-26 Thread Ian Romanick
From: Ian Romanick The second 'const' says that the pointer itself is constant. This in unenforcible in C++, so GCC emits a warning (see) below for each of these functions in every file that includes glsl_types.h. It's a lot of warning spam. ../../../src/glsl/glsl_types.h:176:58: warning: type

[Mesa-dev] [PATCH 1/2] mesa: Treat glBindRenderbuffer and glBindRenderbufferEXT correctly

2013-07-26 Thread Ian Romanick
From: Ian Romanick Allow user-generated names for glBindRenderbufferEXT on desktop GL. Disallow its use altogether for core profiles. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 32 +--- 1 file changed, 25 inserti

[Mesa-dev] [PATCH 2/2] mesa: Treat glBindFramebuffer and glBindFramebufferEXT more correctly

2013-07-26 Thread Ian Romanick
From: Ian Romanick Allow user-generated names for glBindFramebufferEXT on desktop GL. Disallow its use altogether for core profiles. Names bound with glBindFramebuffer in desktop OpenGL are still (incorrectly) shared across the share group instead of being per-context. This gets us a bit closer

Re: [Mesa-dev] [PATCH] glsl: Disallow auxiliary storage qualifiers on FS outputs.

2013-07-26 Thread Matt Turner
On Fri, Jul 26, 2013 at 9:25 PM, Kenneth Graunke wrote: > This has always been an error; we just forgot to check for it. > > Fixes Piglit's no-aux-qual-on-fs-output.frag. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67333 > Signed-off-by: Kenneth Graunke > --- > src/glsl/ast_to_hir

Re: [Mesa-dev] [PATCH] i965: Initialize brw_blorp_const_color_program::prog_data.

2013-07-26 Thread Kenneth Graunke
On 07/26/2013 09:53 PM, Vinson Lee wrote: On Thu, Jul 25, 2013 at 11:19 PM, Kenneth Graunke wrote: On 07/25/2013 10:48 PM, Vinson Lee wrote: Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++-

Re: [Mesa-dev] [PATCH] i965: Initialize brw_blorp_const_color_program::prog_data.

2013-07-26 Thread Vinson Lee
On Thu, Jul 25, 2013 at 11:19 PM, Kenneth Graunke wrote: > On 07/25/2013 10:48 PM, Vinson Lee wrote: >> >> Fixes "Uninitialized scalar field" defect reported by Coverity. >> >> Signed-off-by: Vinson Lee >> --- >> src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++- >> 1 file changed, 2 inser

[Mesa-dev] [PATCH] glsl: Disallow auxiliary storage qualifiers on FS outputs.

2013-07-26 Thread Kenneth Graunke
This has always been an error; we just forgot to check for it. Fixes Piglit's no-aux-qual-on-fs-output.frag. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67333 Signed-off-by: Kenneth Graunke --- src/glsl/ast_to_hir.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git

[Mesa-dev] [PATCH 2/2] gallivm: fix float->SNORM conversion

2013-07-26 Thread sroland
From: Roland Scheidegger Just like the UNORM case we need to use round to nearest, not trunc. (There's also another problem, we're using the formula for SNORM->float which will produce a value below -1.0 for the most negative value which according to both OpenGL and d3d10 would need clamping. How

[Mesa-dev] [PATCH 1/2] util: don't flush overflowing values to infinity in half-float conversion

2013-07-26 Thread sroland
From: Roland Scheidegger I am not able to find _any_ rounding behavior specified for OpenGL for float to half-float conversions. However, it is specified for fp11/fp10 which suggests round to next finite value but round-to-zero would also be allowed, but finite values must not be flushed to infin

[Mesa-dev] Mesa Library questions

2013-07-26 Thread ZhiLi
Hello everyone, I am an university student working on school project related to OpenGL. Now I am using mesa library (version 9.0.3) as an implementation of OpenGL. I have a few questions about Mesa library. glBegin()/glEnd() pair is used for immediate mode rendering, so I study the source co

Re: [Mesa-dev] [PATCH 1/4] gles: Update glext.h to revision 20798.

2013-07-26 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Fri, Jul 26, 2013 at 4:33 PM, Matt Turner wrote: > --- > include/GLES/glext.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/GLES/glext.h b/include/GLES/glext.h > index 5b46ae6..67092fd 100644 > --- a/include/GLES/glex

[Mesa-dev] [PATCH 2/2] mesa: Expose OES_surfaceless_context.

2013-07-26 Thread Matt Turner
EGL_KHR_surfaceless_context extension allows contexts to be made current without a default winsys fbo. This extension specifies what ES 1.1 and 2.0 should do (the ES 3.0 spec already does). --- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.

[Mesa-dev] [PATCH 1/2] mesa: Return GL_FRAMEBUFFER_UNDEFINED if the winsys fbo is incomplete.

2013-07-26 Thread Matt Turner
Specified by ARB_framebuffer_object, GL 3.0, and ES 3.0. --- src/mesa/main/fbobject.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index a29f1ab..bf7e85c 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbo

[Mesa-dev] [PATCH 4/4] gles3: Update gl3.h to 2013-02-12.

2013-07-26 Thread Matt Turner
--- include/GLES3/gl3.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/GLES3/gl3.h b/include/GLES3/gl3.h index 09f2b53..9c79862 100644 --- a/include/GLES3/gl3.h +++ b/include/GLES3/gl3.h @@ -2,7 +2,7 @@ #define __gl3_h_ /* - * gl3.h last updated on $Date:

[Mesa-dev] [PATCH 3/4] gles2: Update gl2ext.h to revision 22161.

2013-07-26 Thread Matt Turner
--- include/GLES2/gl2ext.h | 471 + 1 file changed, 357 insertions(+), 114 deletions(-) diff --git a/include/GLES2/gl2ext.h b/include/GLES2/gl2ext.h index 65b8e80..4ac971a 100644 --- a/include/GLES2/gl2ext.h +++ b/include/GLES2/gl2ext.h @@ -1,7 +1,7

[Mesa-dev] [PATCH 2/4] gles2: Update gl2.h to revision 20555.

2013-07-26 Thread Matt Turner
--- include/GLES2/gl2.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/GLES2/gl2.h b/include/GLES2/gl2.h index b7fe76e..c2d8357 100644 --- a/include/GLES2/gl2.h +++ b/include/GLES2/gl2.h @@ -1,7 +1,7 @@ #ifndef __gl2_h_ #define __gl2_h_ -/* $Revision: 16803 $

[Mesa-dev] [PATCH 1/4] gles: Update glext.h to revision 20798.

2013-07-26 Thread Matt Turner
--- include/GLES/glext.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/GLES/glext.h b/include/GLES/glext.h index 5b46ae6..67092fd 100644 --- a/include/GLES/glext.h +++ b/include/GLES/glext.h @@ -1,7 +1,7 @@ #ifndef __glext_h_ #define __glext_h_ -/* $Revision

Re: [Mesa-dev] SNORM conversion equation woes

2013-07-26 Thread Marek Olšák
On R600 (GL3-class), we can choose which equation will be used, because it's a state that is part of the resource descriptor. Not sure about later chipsets, but the vertex fetching must be done in a shader anyway, therefore we can quite easily implement any format conversion. As far as OpenGL is c

Re: [Mesa-dev] SNORM conversion equation woes

2013-07-26 Thread Chris Forbes
What are other implementations doing? IIRC, GL3-class NV hardware passes the current piglit tests. On Sat, Jul 27, 2013 at 9:20 AM, Kenneth Graunke wrote: > Hello all, > > I've been looking at https://bugs.freedesktop.org/show_bug.cgi?id=59150 and > could use your opinion. > > OpenGL defines two

[Mesa-dev] SNORM conversion equation woes

2013-07-26 Thread Kenneth Graunke
Hello all, I've been looking at https://bugs.freedesktop.org/show_bug.cgi?id=59150 and could use your opinion. OpenGL defines two equations for converting from SNORM to floating point data. These are: f = (2c + 1)/(2^b - 1)(equation 2.2) f = max{c/2^(b-1) - 1), -1.0}

Re: [Mesa-dev] [PATCH] glsl: Classify "layout" like other identifiers.

2013-07-26 Thread Matt Turner
On Fri, Jul 26, 2013 at 12:34 PM, Kenneth Graunke wrote: > When "layout" isn't being lexed as LAYOUT_TOK, we should treat it like > an ordinary identifier. This means we need to classify it to determine > whether we should return IDENTIFIER, TYPE_IDENTIFIER, or NEW_IDENTIFIER. > > Fixes the WebGL

Re: [Mesa-dev] Introducing Virgil - 3D virtual GPU for qemu

2013-07-26 Thread Dave Airlie
On Sat, Jul 27, 2013 at 5:49 AM, Dragomir Ivanov wrote: > Dave, what is your motivation to use OpenGL renderer/translator, and not > native Gallium3D interface? > Yes, I know about the blobs performance/features, but wasn't the idea to > push even harder, so everyone uses FOSS drivers? > I have al

Re: [Mesa-dev] Introducing Virgil - 3D virtual GPU for qemu

2013-07-26 Thread Dragomir Ivanov
Dave, what is your motivation to use OpenGL renderer/translator, and not native Gallium3D interface? Yes, I know about the blobs performance/features, but wasn't the idea to push even harder, so everyone uses FOSS drivers? I have always asked myself, "Why the heck virual 3D is so hard to do? Couldn

[Mesa-dev] [PATCH 2/2] tgsi: handle texel swizzles correctly for d3d10-style sample opcodes

2013-07-26 Thread sroland
From: Roland Scheidegger Same as for gallivm (though these don't quite work correctly in softpipe, so untested). --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 40 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec

[Mesa-dev] [PATCH 1/2] gallivm: handle texel swizzles correctly for d3d10-style sample opcodes

2013-07-26 Thread sroland
From: Roland Scheidegger unlike OpenGL, the texel swizzle is embedded in the instruction, so honor that. (Technically we now execute both the sampler_view swizzle and the per-instruction swizzle but this should be quite ok.) --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 27

[Mesa-dev] [PATCH] glsl: Classify "layout" like other identifiers.

2013-07-26 Thread Kenneth Graunke
When "layout" isn't being lexed as LAYOUT_TOK, we should treat it like an ordinary identifier. This means we need to classify it to determine whether we should return IDENTIFIER, TYPE_IDENTIFIER, or NEW_IDENTIFIER. Fixes the WebGL conformance test "shader-with-non-reserved-words." Bugzilla: http

Re: [Mesa-dev] [v2] glsl: disable ARB_texture_cube_map_array_enable keywords for glsl es

2013-07-26 Thread Kenneth Graunke
On 07/26/2013 12:21 AM, Tapani Pälli wrote: Patch fixes a crash with Webgl 'shader-with-non-reserved-words' conformance test by ignoring desktop extension keywords on GLSL ES. v2: fix reserved and allowed desktop glsl versions (Chris) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64087

[Mesa-dev] [PATCH] mesa: improve free() cleanup in generate_mipmap_compressed()

2013-07-26 Thread Brian Paul
Free all our temporary buffers in one place at the end of the function. Fixes memory leak detected by Coverity. Note: This is a candidate for the 9.x branches Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/mipmap.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(

Re: [Mesa-dev] [PATCH] Fix generate_mipmap_compressed memory leaks.

2013-07-26 Thread Brian Paul
On 07/25/2013 11:30 PM, Vinson Lee wrote: Fixes "Resource leak" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/main/mipmap.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c index 5839632..0ef6536 100644 --- a/src/m

[Mesa-dev] [Bug 63132] [r600/llvm] src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c:1887:lp_emit_declaration_soa: Assertion `idx < 256' failed.

2013-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63132 Johannes Obermayr changed: What|Removed |Added CC||lordhea...@gmail.com --- Comment #6

[Mesa-dev] [Bug 67046] [radeonsi] pixmark_piano benchmark from geeks3D gputest fail with a llvm error output

2013-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67046 Johannes Obermayr changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] gallium/util: comments, var renaming in u_inlines.h

2013-07-26 Thread Brian Paul
On 07/25/2013 06:01 PM, Roland Scheidegger wrote: Am 25.07.2013 19:37, schrieb Brian Paul: The variable 'usage' was being used for two different things. Sometimes for PIPE_USAGE_x and other times for PIPE_TRANSFER_x. This renames usage to access when we're talking about PIPE_TRANSFER_x flags. P

[Mesa-dev] [v2] glsl: disable ARB_texture_cube_map_array_enable keywords for glsl es

2013-07-26 Thread Tapani Pälli
Patch fixes a crash with Webgl 'shader-with-non-reserved-words' conformance test by ignoring desktop extension keywords on GLSL ES. v2: fix reserved and allowed desktop glsl versions (Chris) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64087 Signed-off-by: Tapani Pälli Reviewed-by: Chr

Re: [Mesa-dev] [PATCH] glsl: disable ARB_texture_cube_map_array_enable keywords for glsl es

2013-07-26 Thread Tapani Pälli
On 07/26/2013 09:47 AM, Chris Forbes wrote: +samplerCubeArray KEYWORD_WITH_ALT(130, 0, 150, 0, yyextra->ARB_texture_cube_map_array_enable, SAMPLERCUBEARRAY); +isamplerCubeArray KEYWORD_WITH_ALT(130, 0, 150, 0, yyextra->ARB_texture_cube_map_array_enable, ISAMPLERCUBEARRAY); +usamplerCubeArray