On 07/26/2013 09:47 AM, Chris Forbes wrote:
+samplerCubeArray   KEYWORD_WITH_ALT(130, 0, 150, 0, 
yyextra->ARB_texture_cube_map_array_enable, SAMPLERCUBEARRAY);
+isamplerCubeArray KEYWORD_WITH_ALT(130, 0, 150, 0, 
yyextra->ARB_texture_cube_map_array_enable, ISAMPLERCUBEARRAY);
+usamplerCubeArray KEYWORD_WITH_ALT(130, 0, 150, 0, 
yyextra->ARB_texture_cube_map_array_enable, USAMPLERCUBEARRAY);
+samplerCubeArrayShadow   KEYWORD_WITH_ALT(130, 0, 150, 0, 
yyextra->ARB_texture_cube_map_array_enable, SAMPLERCUBEARRAYSHADOW);
These aren't quite right. They become keywords in 4.0, and are not
reserved in any earlier spec, so you want

It seems I misunderstood KEYWORD_WITH_ALT macro to always require the extension but it has 'or'. You are correct, it should be a keyword only if extension is enabled or if version is >=4.0. I'll correct this and sent another patch, thanks.


    KEYWORD_WITH_ALT(400, 0, 400, 0, yyextra-> ....

With that fixed,

Reviewed-by: Chris Forbes <chr...@ijw.co.nz>

-- Chris

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to