On 07/25/2013 06:01 PM, Roland Scheidegger wrote:
Am 25.07.2013 19:37, schrieb Brian Paul:
The variable 'usage' was being used for two different things.
Sometimes for PIPE_USAGE_x and other times for PIPE_TRANSFER_x.
This renames usage to access when we're talking about PIPE_TRANSFER_x
flags.  Plus, add a bunch of comments to remind us what's going on.

Also, use unsigned for PIPE_TRANSFER_x bitmask to be consistent with
other places.  And add a missing const qualifier.
---
  src/gallium/auxiliary/util/u_inlines.h |   61 +++++++++++++++++++++++++-------
  1 file changed, 48 insertions(+), 13 deletions(-)


Do you plan to change the callers too which use usage?

No. There's too many and I just wanted to clean up the header file since that's where we look to remind us of what the parameters are.


Either way though
series looks good to me.

Thanks.

-Brian


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to