Re: [Mesa-dev] [PATCH] glsl: store read vector in a temp in vec_index_to_cond

2012-11-08 Thread Kenneth Graunke
On 11/06/2012 07:12 AM, Vincent Lejeune wrote: Vector indexing on matrixes generates several copy of the constant matrix, for instance vec=mat4[i][j] generates : vec=mat4[i].x; vec=(j==1)?mat4[i].y; vec=(j==2)?mat4[i].z; vec=(j==3)?mat4[i].w; In the case of constant matrixes, the mat4[i] expressi

Re: [Mesa-dev] [PATCH 2/7] glcpp: don't push #line directives into next line

2012-11-08 Thread Kenneth Graunke
On 11/08/2012 05:26 PM, Matt Turner wrote: From: Fabian Bieler mattst88: Carl and I determined independently of Fabian that the 091 test needed to be modified identically to this, and our patch to fix the test was more complicated. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51506 R

[Mesa-dev] [PATCH 1/1] mesa : OpenGL ES 3 support improvement regarding seamless cubemap state

2012-11-08 Thread Maxence Le Doré
Hi everyone, I took a look at OpenGl ES 3.0 this summer and noticed a little something than seems to still lack to the current implementation in mesa. It's about the support of seamless cube maps. The spec seems to suggest that linearly flltered cube maps should always be seamless, regarless of an

Re: [Mesa-dev] Mesa 9.0.1 release

2012-11-08 Thread Kenneth Graunke
On 11/08/2012 04:27 PM, Mario Kleiner wrote: On 09.11.12 01:21, Ian Romanick wrote: On 11/08/2012 03:03 PM, Mario Kleiner wrote: Is this one: "mesa: Don't glPopAttrib() GL_POINT_SPRITE_COORD_ORIGIN on < OpenGL-2.0" already integrated somewhere? Eh... it doesn't look like that ever got committ

[Mesa-dev] [Bug 56906] New: src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c:135:analyse_tex: Assertion `0' failed.

2012-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56906 Priority: medium Bug ID: 56906 CC: airl...@freedesktop.org Assignee: mesa-dev@lists.freedesktop.org Summary: src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c:135:a naly

[Mesa-dev] GL_ARB_texture_query_lod

2012-11-08 Thread Dave Airlie
In case anyone is interested I've implemented the GLSL and some gallium bits in a branch in my repo. I'm not really sure there is much point in pushing forward with this until we are bit closer to GLSL 4.00. The main problem is the spec uses the shader function textureQueryLOD, and GLSL 4.00 uses

[Mesa-dev] [PATCH] r600g: add initial cube map array support (v2)

2012-11-08 Thread Dave Airlie
This contains the evergreen support. Support is possible on rv670 upwards and the code in here should work, but it doesn't and I haven't debugged it to figure out why. Beyond just adding support for the cube map array sampling, r600 resinfo isn't conformant with the GL specification, which states

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Marek Olšák
On Fri, Nov 9, 2012 at 1:23 AM, Dave Airlie wrote: + >>> >>> I would prefer if the constant buffers were updated only if the >>> sampler views were updated as well, so that it's not updated in every >>> draw command that has a shader querying the array size. >> >> probably makes sense, I was

[Mesa-dev] [PATCH 7/7] glcpp: wire up glcpp-test to make check

2012-11-08 Thread Matt Turner
--- src/glsl/glcpp/Makefile.am |2 ++ src/glsl/glcpp/tests/glcpp-test | 16 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/glsl/glcpp/Makefile.am b/src/glsl/glcpp/Makefile.am index 87affce..04d8cda 100644 --- a/src/glsl/glcpp/Makefile.am +++ b/src/g

[Mesa-dev] [PATCH 6/7] glcpp/tests: Add tests for multiline #elif

2012-11-08 Thread Matt Turner
--- src/glsl/glcpp/tests/107-multiline-hash-elif.c |7 +++ .../glcpp/tests/107-multiline-hash-elif.c.expected |8 2 files changed, 15 insertions(+), 0 deletions(-) create mode 100644 src/glsl/glcpp/tests/107-multiline-hash-elif.c create mode 100644 src/glsl/glcpp/tests/1

[Mesa-dev] [PATCH 5/7] glcpp/tests: Add test for multiline #if

2012-11-08 Thread Matt Turner
--- src/glsl/glcpp/tests/106-multiline-hash-if.c |6 ++ .../glcpp/tests/106-multiline-hash-if.c.expected |7 +++ 2 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 src/glsl/glcpp/tests/106-multiline-hash-if.c create mode 100644 src/glsl/glcpp/tests/106-m

[Mesa-dev] [PATCH 4/7] glcpp/tests: Add test for multiline #line

2012-11-08 Thread Matt Turner
--- src/glsl/glcpp/tests/105-multiline-hash-line.c |5 + .../glcpp/tests/105-multiline-hash-line.c.expected |6 ++ 2 files changed, 11 insertions(+), 0 deletions(-) create mode 100644 src/glsl/glcpp/tests/105-multiline-hash-line.c create mode 100644 src/glsl/glcpp/tests/105-m

[Mesa-dev] [PATCH 3/7] glcpp/tests: Add test to check #line followed by code

2012-11-08 Thread Matt Turner
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51802 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51506 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41152 --- .../glcpp/tests/104-hash-line-followed-by-code.c |2 ++ .../104-hash-line-followed-by-code.c.expected

[Mesa-dev] [PATCH 2/7] glcpp: don't push #line directives into next line

2012-11-08 Thread Matt Turner
From: Fabian Bieler mattst88: Carl and I determined independently of Fabian that the 091 test needed to be modified identically to this, and our patch to fix the test was more complicated. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51506 Reviewed-by: Matt Turner --- Patch 1/7 is "gl

Re: [Mesa-dev] ARB_texture_cube_map_array support (first spin)

2012-11-08 Thread Dave Airlie
Okay I've pushed it all with modification except the r600g patch, which I'll work on a bit more to see if I can incorporate Marek's comments along with GL3.txt and relnotes updates. thanks to Brian and Kenneth for reviewing. Dave. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Dave Airlie
On Fri, Nov 9, 2012 at 10:23 AM, Dave Airlie wrote: + >>> >>> I would prefer if the constant buffers were updated only if the >>> sampler views were updated as well, so that it's not updated in every >>> draw command that has a shader querying the array size. >> >> probably makes sense, I was

Re: [Mesa-dev] [PATCH 1/3] glapi: add GL4x.xml

2012-11-08 Thread Ian Romanick
Why? As far as I can tell, there's no purpose in this until we add support for GL 4.x... and that's quite some time away. This also goes against our policy of not committing support for a piece of functionality until it can actually be enabled at least to a point where some test case could r

Re: [Mesa-dev] Mesa 9.0.1 release

2012-11-08 Thread Mario Kleiner
On 09.11.12 01:21, Ian Romanick wrote: On 11/08/2012 03:03 PM, Mario Kleiner wrote: Is this one: "mesa: Don't glPopAttrib() GL_POINT_SPRITE_COORD_ORIGIN on < OpenGL-2.0" already integrated somewhere? Eh... it doesn't look like that ever got committed to master. Could you annotate it (per Ken'

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Dave Airlie
>>> + >> >> I would prefer if the constant buffers were updated only if the >> sampler views were updated as well, so that it's not updated in every >> draw command that has a shader querying the array size. > > probably makes sense, I was mostly thinking that nobody would use this > that often, an

Re: [Mesa-dev] Mesa 9.0.1 release

2012-11-08 Thread Ian Romanick
On 11/08/2012 03:03 PM, Mario Kleiner wrote: Is this one: "mesa: Don't glPopAttrib() GL_POINT_SPRITE_COORD_ORIGIN on < OpenGL-2.0" already integrated somewhere? Eh... it doesn't look like that ever got committed to master. Could you annotate it (per Ken's suggestion) and push it to master? B

Re: [Mesa-dev] [PATCH] arb_texture_cube_map_array: fix attrib push/pop

2012-11-08 Thread Dave Airlie
On Thu, Nov 8, 2012 at 10:05 AM, Brian Paul wrote: > On 11/07/2012 01:51 PM, Dave Airlie wrote: >> >> On Thu, Nov 8, 2012 at 1:00 AM, Brian Paul wrote: >>> >>> On 11/06/2012 07:56 PM, Dave Airlie wrote: From: Dave Airlie fdo9833 piglit test caught this. >>> >>> >>> >>> Wh

Re: [Mesa-dev] [PATCH 05/10] glsl: add ARB_texture_cube_map_array support

2012-11-08 Thread Dave Airlie
> > While you're correct that the extension spec (as well as GLSL 4.00, 4.10, > and 4.20) only mention textureSize for these two types, I believe it was > simply a typo that got overlooked. The GLSL 4.30 specification adds > textureSize for isamplerCubeArray and usamplerCubeArray as well, and stat

Re: [Mesa-dev] Mesa 9.0.1 release

2012-11-08 Thread Mario Kleiner
Is this one: "mesa: Don't glPopAttrib() GL_POINT_SPRITE_COORD_ORIGIN on < OpenGL-2.0" already integrated somewhere? -mario On 08.11.12 19:54, Ian Romanick wrote: I'd like to release the current tip of the 9.0 branch as Mesa 9.0.1 tomorrow. The set of patches currently on the branch since the

[Mesa-dev] [PATCH] i965/fs: Unify the param pointer allocation for FP/non-FP.

2012-11-08 Thread Eric Anholt
Now that we're using the new backend, we may actually put things into push constants if you have too many uniform values uploaded. Also, correctly account for texture rectangle params and drop the old special case for the 0.0/1.0 params from the old backend. --- src/mesa/drivers/dri/i965/brw_wm.c

Re: [Mesa-dev] [PATCH] i965: Fix slow leak of brw->wm.compile_data->store

2012-11-08 Thread Eric Anholt
Kenneth Graunke writes: > On 11/06/2012 10:47 AM, Eric Anholt wrote: >> We were successfully freeing our compile data at context destroy, but until >> then we were allocating a new store every compile without freeing it. >> /* Allocate the references to the uniforms that will end up in the

[Mesa-dev] [PATCH] i965: Fix AA Line Distance Mode in 3DSTATE_SF on Ivybridge.

2012-11-08 Thread Kenneth Graunke
We were accidentally setting bit 14 in DWord 2 (which is Reserved/MBZ) rather than bit 14 in DWord 3 (which is AA Line Distance Mode). There's also no reason to ever set it to legacy mode; the bit is only used when drawing antialiased lines anyway. Set it unconditionally. NOTE: This is a candida

[Mesa-dev] [PATCH 3/3] glapi: add GL_ARB_draw_buffers_blend to GL 4.0

2012-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mapi/glapi/gen/AMD_draw_buffers_blend.xml |8 +++ src/mapi/glapi/gen/ARB_draw_buffers_blend.xml |9 src/mapi/glapi/gen/GL4x.xml | 25 ++ src/mesa/main/dlist.c | 28 +

[Mesa-dev] [PATCH 2/3] glapi: add ARB_sample_shading and add to GL 4.0

2012-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mapi/glapi/gen/ARB_sample_shading.xml | 19 +++ src/mapi/glapi/gen/GL4x.xml |6 ++ src/mapi/glapi/gen/Makefile.am|1 + src/mapi/glapi/gen/gl_API.xml |3 ++- src/mesa/main/tests/dispatch_sa

[Mesa-dev] [PATCH 1/3] glapi: add GL4x.xml

2012-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mapi/glapi/gen/GL4x.xml| 16 src/mapi/glapi/gen/Makefile.am |3 ++- src/mapi/glapi/gen/gl_API.xml |2 ++ 3 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 src/mapi/glapi/gen/GL4x.xml diff --git a/src/mapi/gla

Re: [Mesa-dev] No luck with tstellar/llvm on HD4890

2012-11-08 Thread Andy Furniss
Andy Furniss wrote: Tom Stellard wrote: On Wed, Nov 07, 2012 at 09:24:13PM +, Andy Furniss wrote: Vincent Lejeune wrote: git seems to have trouble sending my patch to ML atm, can you manually apply it ? It fixes lock up here diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/d

Re: [Mesa-dev] [PATCH] radeon/llvm: keeps frameindex after isel

2012-11-08 Thread Vincent Lejeune
- Mail original - > De : Tom Stellard > À : Vincent Lejeune > Cc : mesa-dev@lists.freedesktop.org > Envoyé le : Jeudi 8 novembre 2012 20h59 > Objet : Re: [Mesa-dev] [PATCH] radeon/llvm: keeps frameindex after isel > > On Tue, Nov 06, 2012 at 09:40:35PM +0100, Vincent Lejeune wrote: >

[Mesa-dev] [Bug 55010] texelFetch(usampler2D) triggers st_glsl_to_tgsi.cpp:673:get_opcode: Assertion `op != 177' failed.

2012-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55010 Andreas Boll changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] radeon/llvm: keeps frameindex after isel

2012-11-08 Thread Tom Stellard
On Tue, Nov 06, 2012 at 09:40:35PM +0100, Vincent Lejeune wrote: > --- > lib/Target/AMDGPU/AMDILISelDAGToDAG.cpp | 11 -- > lib/Target/AMDGPU/R600AllocateMemoryRegs.cpp | 23 ++-- > lib/Target/AMDGPU/R600ISelLowering.cpp | 53 > +++- > lib/Target/AMD

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Dave Airlie
On Thu, Nov 8, 2012 at 11:01 PM, Marek Olšák wrote: > On Tue, Nov 6, 2012 at 11:16 PM, Dave Airlie wrote: >> This contains the evergreen support. >> >> Support is possible on rv670 upwards and the code in here >> should work, but it doesn't and I haven't debugged it to >> figure out why. >> >> Be

Re: [Mesa-dev] [PATCH 1/3] glx: remove glFlush call in glXSwapBuffers

2012-11-08 Thread Marek Olšák
On Thu, Nov 8, 2012 at 7:59 PM, Ian Romanick wrote: > On 11/08/2012 05:48 AM, Marek Olšák wrote: >> >> Flushing here is unnecessary. The drivers which always flush in >> dri2Throttle >> or __DRI2flushExtensionRec::flush are just wasting time here. >> >> st/mesa is updated to do what glFlush does.

Re: [Mesa-dev] [PATCH 1/3] glx: remove glFlush call in glXSwapBuffers

2012-11-08 Thread Ian Romanick
On 11/08/2012 05:48 AM, Marek Olšák wrote: Flushing here is unnecessary. The drivers which always flush in dri2Throttle or __DRI2flushExtensionRec::flush are just wasting time here. st/mesa is updated to do what glFlush does. XXX I guess some other drivers should be updated to flush by themselv

[Mesa-dev] Mesa 9.0.1 release

2012-11-08 Thread Ian Romanick
I'd like to release the current tip of the 9.0 branch as Mesa 9.0.1 tomorrow. The set of patches currently on the branch since the 9.0 release is listed below. I am also going to create a 9.0-staging branch that will live in my personal git repo on fd.o. get-pick-list.sh shows a handful of

Re: [Mesa-dev] [PATCH 1/3] glx: remove glFlush call in glXSwapBuffers

2012-11-08 Thread Marek Olšák
On Thu, Nov 8, 2012 at 3:04 PM, Michel Dänzer wrote: > On Don, 2012-11-08 at 14:48 +0100, Marek Olšák wrote: >> Flushing here is unnecessary. The drivers which always flush in dri2Throttle >> or __DRI2flushExtensionRec::flush are just wasting time here. >> >> st/mesa is updated to do what glFlush

[Mesa-dev] [PATCH 2/2] radeonsi: Implement alpha testing in pixel shader.

2012-11-08 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_pipe.h |2 -- src/gallium/drivers/radeonsi/radeonsi_shader.c | 36 src/gallium/drivers/radeonsi/radeonsi_shader.h |2 ++ src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 1/2] radeonsi: Initialize uses_kill boolean from TGSI info.

2012-11-08 Thread Michel Dänzer
From: Michel Dänzer Fixes discarded pixels incorrectly updating the depth buffer. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeons

Re: [Mesa-dev] [PATCH 2/4] gallium: Add PIPE_SHADER_CAP_INDIRECT_TEMP_ARRAY_ADDR

2012-11-08 Thread Christoph Bumiller
On 08.11.2012 18:16, Tom Stellard wrote: > On Thu, Nov 08, 2012 at 05:45:00PM +0100, Christoph Bumiller wrote: >> On 08.11.2012 16:03, Tom Stellard wrote: >>> On Thu, Nov 08, 2012 at 12:59:06PM +0100, Christoph Bumiller wrote: On 08.11.2012 01:48, Brian Paul wrote: > On 11/05/2012 01:14 PM

Re: [Mesa-dev] [PATCH 2/4] gallium: Add PIPE_SHADER_CAP_INDIRECT_TEMP_ARRAY_ADDR

2012-11-08 Thread Tom Stellard
On Thu, Nov 08, 2012 at 05:45:00PM +0100, Christoph Bumiller wrote: > On 08.11.2012 16:03, Tom Stellard wrote: > > On Thu, Nov 08, 2012 at 12:59:06PM +0100, Christoph Bumiller wrote: > >> On 08.11.2012 01:48, Brian Paul wrote: > >>> On 11/05/2012 01:14 PM, Tom Stellard wrote: > From: Tom Stell

[Mesa-dev] [Bug 56685] [recent build error] glsl_parser.h: No such file or directory

2012-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56685 --- Comment #9 from Fabio Pedretti --- (In reply to comment #5) > Created attachment 69667 [details] [review] > Possible Fix > > Next try ... With this I can successfully compile mesa. -- You are receiving this mail because: You are the assig

Re: [Mesa-dev] [PATCH 2/4] gallium: Add PIPE_SHADER_CAP_INDIRECT_TEMP_ARRAY_ADDR

2012-11-08 Thread Christoph Bumiller
On 08.11.2012 16:03, Tom Stellard wrote: > On Thu, Nov 08, 2012 at 12:59:06PM +0100, Christoph Bumiller wrote: >> On 08.11.2012 01:48, Brian Paul wrote: >>> On 11/05/2012 01:14 PM, Tom Stellard wrote: From: Tom Stellard --- src/gallium/docs/source/screen.rst | 2 ++ >

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Handle TGSI TXB opcode.

2012-11-08 Thread Alex Deucher
On Thu, Nov 8, 2012 at 10:28 AM, Michel Dänzer wrote: > From: Michel Dänzer > > > Signed-off-by: Michel Dänzer For the series: Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/radeonsi_shader.c |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/gallium/driv

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Handle TGSI TXL opcode.

2012-11-08 Thread Tom Stellard
On Thu, Nov 08, 2012 at 04:28:44PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > > Signed-off-by: Michel Dänzer For the series: Reviewed-by: Tom Stellard > --- > src/gallium/drivers/radeonsi/radeonsi_shader.c |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/ga

Re: [Mesa-dev] [PATCH 2/2] AMDGPU: Add intrinsic for sampling with explicit LOD on SI.

2012-11-08 Thread Tom Stellard
On Thu, Nov 08, 2012 at 04:04:10PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > > Signed-off-by: Michel Dänzer For the series: Reviewed-by: Tom Stellard > --- > lib/Target/AMDGPU/SIInstructions.td |9 - > lib/Target/AMDGPU/SIIntrinsics.td |1 + > 2 files changed,

[Mesa-dev] [PATCH 2/2] radeonsi: Handle TGSI TXL opcode.

2012-11-08 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c index 08c4438..c0a504c 100644 --- a

[Mesa-dev] [PATCH 1/2] radeonsi: Handle TGSI TXB opcode.

2012-11-08 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c index f6b5174..08c4438 100644 --- a

[Mesa-dev] [PATCH 1/2] AMDGPU: Add intrinsic for sampling with bias on SI.

2012-11-08 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- lib/Target/AMDGPU/SIInstructions.td |9 - lib/Target/AMDGPU/SIIntrinsics.td |1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/Target/AMDGPU/SIInstructions.td b/lib/Target/AMDGPU/SIInstructions.td inde

[Mesa-dev] [PATCH 2/2] AMDGPU: Add intrinsic for sampling with explicit LOD on SI.

2012-11-08 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- lib/Target/AMDGPU/SIInstructions.td |9 - lib/Target/AMDGPU/SIIntrinsics.td |1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/Target/AMDGPU/SIInstructions.td b/lib/Target/AMDGPU/SIInstructions.td inde

Re: [Mesa-dev] [PATCH 2/4] gallium: Add PIPE_SHADER_CAP_INDIRECT_TEMP_ARRAY_ADDR

2012-11-08 Thread Tom Stellard
On Thu, Nov 08, 2012 at 12:59:06PM +0100, Christoph Bumiller wrote: > On 08.11.2012 01:48, Brian Paul wrote: > > On 11/05/2012 01:14 PM, Tom Stellard wrote: > >> From: Tom Stellard > >> > >> --- > >> src/gallium/docs/source/screen.rst | 2 ++ > >> src/gallium/drivers/r600/r600_pipe.c

Re: [Mesa-dev] [PATCH 3/4] glsl-to-tgsi: Use TGSI_FILE_TEMPORARY_ARRAY for indirect addressing

2012-11-08 Thread Tom Stellard
Hi Brian, Thanks for your review, I've noticed a few problems with this series while working on the R600 LLVM backend. I'll post updated patches that incorporate your comments once I get everything sorted out. On Wed, Nov 07, 2012 at 05:48:38PM -0700, Brian Paul wrote: > On 11/05/2012 01:14 PM,

Re: [Mesa-dev] [PATCH] svga: Fix memory leak in svga_buffer_transfer_map.

2012-11-08 Thread Brian Paul
On 11/08/2012 12:26 AM, Vinson Lee wrote: Fixes resource leak defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/svga/svga_resource_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c b/src/gallium/drivers

Re: [Mesa-dev] [PATCH 1/3] glx: remove glFlush call in glXSwapBuffers

2012-11-08 Thread Michel Dänzer
On Don, 2012-11-08 at 14:48 +0100, Marek Olšák wrote: > Flushing here is unnecessary. The drivers which always flush in dri2Throttle > or __DRI2flushExtensionRec::flush are just wasting time here. > > st/mesa is updated to do what glFlush does. > > XXX I guess some other drivers should be update

[Mesa-dev] [PATCH 3/3] st/dri: implement __DRI2flushExtensionRec::flush_and_throttle

2012-11-08 Thread Marek Olšák
--- .../state_trackers/dri/common/dri_drawable.c | 10 +- .../state_trackers/dri/common/dri_drawable.h |4 src/gallium/state_trackers/dri/drm/dri2.c | 19 --- 3 files changed, 25 insertions(+), 8 deletions(-) diff --git a/src/gallium/state

[Mesa-dev] [PATCH 2/3] glx: add interface for flushing a drawable and throttling at the same time

2012-11-08 Thread Marek Olšák
The motivation is to prevent a double flush in Gallium. Gallium flushes in __DRI2flushExtensionRec::flush and dri2Throttle. This will help consolidate the flushing. --- include/GL/internal/dri_interface.h | 16 +- src/gallium/state_trackers/dri/drm/dri2.c |2 +- sr

[Mesa-dev] [PATCH 1/3] glx: remove glFlush call in glXSwapBuffers

2012-11-08 Thread Marek Olšák
Flushing here is unnecessary. The drivers which always flush in dri2Throttle or __DRI2flushExtensionRec::flush are just wasting time here. st/mesa is updated to do what glFlush does. XXX I guess some other drivers should be updated to flush by themselves if they don't? --- src/glx/glxcmds.c

[Mesa-dev] [PATCH 0/3] Consolidating a triple context flush in SwapBuffers

2012-11-08 Thread Marek Olšák
I have noticed the gallium context is flushed 3 times in SwapBuffers. Two of those flushes end up invoking the radeon CS ioctl, which also adds overhead in the kernel. Anyway, it seems very inefficient and this series tries to consolidate all the flushing in SwapBuffers. The first flush is invo

Re: [Mesa-dev] [PATCH 2/4] gallium: Add PIPE_SHADER_CAP_INDIRECT_TEMP_ARRAY_ADDR

2012-11-08 Thread Christoph Bumiller
On 08.11.2012 01:48, Brian Paul wrote: > On 11/05/2012 01:14 PM, Tom Stellard wrote: >> From: Tom Stellard >> >> --- >> src/gallium/docs/source/screen.rst | 2 ++ >> src/gallium/drivers/r600/r600_pipe.c | 2 ++ >> src/gallium/drivers/radeonsi/radeonsi_pipe.c | 1 + >> src/gal

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Marek Olšák
On Tue, Nov 6, 2012 at 11:16 PM, Dave Airlie wrote: > This contains the evergreen support. > > Support is possible on rv670 upwards and the code in here > should work, but it doesn't and I haven't debugged it to > figure out why. > > Beyond just adding support for the cube map array sampling, > r6

Re: [Mesa-dev] [PATCH] mesa: Fix glGetVertexAttribI[u]iv now that we have real integer attribs.

2012-11-08 Thread Marek Olšák
Reviewed-by: Marek Olšák You can also use the COPY_4V macro like _mesa_GetVertexAttribfvARB does if you want. Marek On Thu, Nov 8, 2012 at 5:59 AM, Kenneth Graunke wrote: > Since cf438f5375e242, we store actual integers for the attribute data. > We just need to reinterpret the GLfloat array as

[Mesa-dev] [Bug 56836] xdemo/texture_from_pixmap failed to create drawable on swrast

2012-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56836 lu hua changed: What|Removed |Added Severity|major |normal Priority|high