On Fri, Nov 9, 2012 at 1:23 AM, Dave Airlie <airl...@gmail.com> wrote: >>>> + >>> >>> I would prefer if the constant buffers were updated only if the >>> sampler views were updated as well, so that it's not updated in every >>> draw command that has a shader querying the array size. >> >> probably makes sense, I was mostly thinking that nobody would use this >> that often, and having it work for the sake of compliance :-), but >> yeah makes sense to only update in that case. > > Just to check should testing the views dirty_mask and returning if its > 0 be correct?
Yeah, testing dirty_mask should be enough. However, dirty_mask is zeroed before the draw packet, so if you don't have a shader using TXQ.z and you decide to do nothing, you will miss the spot where dirty_mask is non-zero. Instead, you can add another mask next to dirty_mask... dirty_constants_mask? which you can set just for the texture targets you are interested in and zero it whenever you want. Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
