Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Kenneth Graunke
On 09/26/2012 10:55 PM, Matt Turner wrote: > On Wed, Sep 26, 2012 at 10:47 PM, Kenneth Graunke > wrote: >> On 09/26/2012 04:09 PM, Matt Turner wrote: >>> On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: Another issue is that the yacc-generated files are not removed by 'make clean',

Re: [Mesa-dev] [PATCH] intel: Fix segfault in intel_texsubimage_tiled_memcpy

2012-09-26 Thread Kenneth Graunke
On 09/26/2012 11:22 AM, Chad Versace wrote: > The function segfaulted when a game called glTexSubImage2D on a texture > with internalformat/format/type = GL_SLUMINANCE8/GL_BGRA/GL_UNSIGNED_BYTE. Wait, is that what it was doing? Specifying a four component format but a single component (and sRGB,

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Matt Turner
On Wed, Sep 26, 2012 at 10:47 PM, Kenneth Graunke wrote: > On 09/26/2012 04:09 PM, Matt Turner wrote: >> On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: >>> Another issue is that the yacc-generated files are not removed by 'make >>> clean', >>> but thats probably on purpose (do the generated

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Kenneth Graunke
On 09/26/2012 04:09 PM, Matt Turner wrote: > On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: >> Another issue is that the yacc-generated files are not removed by 'make >> clean', >> but thats probably on purpose (do the generated files get shipped in the >> release tarball?), >> I should've r

Re: [Mesa-dev] [PATCH] svga: Remove wierd code which forces non-sRGB formats.

2012-09-26 Thread John Kåre Alsaker
glean/readPixSanity is failing. Depth and stencil buffers are read back wrong, while RGBA is fine. On 9/25/12, Brian Paul wrote: > On 09/24/2012 11:09 PM, John Kåre Alsaker wrote: >> On Mon, Sep 24, 2012 at 5:22 PM, Brian Paul > > wrote: >> >> On 09/23/2012 05:44 AM,

Re: [Mesa-dev] [PATCH] mesa: Flag _NEW_VARYING_VP_INPUTS when there's no vertex program.

2012-09-26 Thread Marek Olšák
On Thu, Sep 27, 2012 at 1:53 AM, Ian Romanick wrote: > On 09/18/2012 06:49 PM, Marek Olšák wrote: >> >> Reviewed-by: Marek Olšák >> >> Thanks to your patch, I've got a theory. >> >> i915 doesn't set _MaintainTnlProgram to TRUE, which causes core Mesa >> to set both _TnlProgram and _Current to NUL

[Mesa-dev] [PATCH] i915: Don't leave dangling pointer to i915 context on failure

2012-09-26 Thread Ian Romanick
From: Ian Romanick Otherwise intelDestroyContext would try to dereference the pointer to freed memory. NOTE: This is a candidate for the 9.0 branch. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53618 --- src/mesa/drivers/dri/i915/i915_context.c | 14 +

Re: [Mesa-dev] [PATCH] mesa: Flag _NEW_VARYING_VP_INPUTS when there's no vertex program.

2012-09-26 Thread Ian Romanick
On 09/18/2012 06:49 PM, Marek Olšák wrote: Reviewed-by: Marek Olšák Thanks to your patch, I've got a theory. i915 doesn't set _MaintainTnlProgram to TRUE, which causes core Mesa to set both _TnlProgram and _Current to NULL, therefore _mesa_set_varying_vp_inputs is a no-op. (If _MaintainTnlProg

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Matt Turner
On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: > On 09/26/2012 11:59 PM, Matt Turner wrote: >> I've pushed an automake-gallium2 branch to my repo with a number of >> fixes squashed-in. >> >> git://people.freedesktop.org/~mattst88/mesa automake-gallium2 > > Nice progress! > > I was able to bui

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Török Edwin
On 09/26/2012 11:59 PM, Matt Turner wrote: > I've pushed an automake-gallium2 branch to my repo with a number of > fixes squashed-in. > > git://people.freedesktop.org/~mattst88/mesa automake-gallium2 Nice progress! I was able to build it after reversing the 'if' below. It doesn't load though: l

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Matt Turner
On Mon, Sep 24, 2012 at 2:52 PM, Matt Turner wrote: > This series of 105 patches finishes the automake conversion. > > I don't think the series needs to be reviewed patch by patch, since > large chunks are making nearly identical changes to different > directories. Plus, incorrect changes in the b

Re: [Mesa-dev] [PATCH] radeon/llvm: improve select_cc lowering to generate CND* more often

2012-09-26 Thread Tom Stellard
On Wed, Sep 26, 2012 at 09:33:15PM +0200, Vincent Lejeune wrote: > v2: - Simplify isZero() > - Remove a unused function prototype > - Clean whitespace trails > --- > src/gallium/drivers/r600/r600_llvm.c| 15 + > src/gallium/drivers/radeon/R600ISelLowering.cpp | 89 > ++

[Mesa-dev] [PATCH] radeon/llvm: improve select_cc lowering to generate CND* more often

2012-09-26 Thread Vincent Lejeune
v2: - Simplify isZero() - Remove a unused function prototype - Clean whitespace trails --- src/gallium/drivers/r600/r600_llvm.c| 15 + src/gallium/drivers/radeon/R600ISelLowering.cpp | 89 +++-- src/gallium/drivers/radeon/R600ISelLowering.h | 2 + src

[Mesa-dev] [PATCH v3 1/1] intel: add support for ANGLE_texture_compression_dxt.

2012-09-26 Thread Oliver McFadden
Signed-off-by: Oliver McFadden --- I believe this is approximately v3; after two iterations and the FEATURE_x defines removal. The patch becomes much smaller after that! Hopefully I've addressed everybody's comments but I expect to have missed something... src/glx/glxextensions.h

Re: [Mesa-dev] [PATCH] intel: Fix segfault in intel_texsubimage_tiled_memcpy

2012-09-26 Thread Paul Berry
On 26 September 2012 11:22, Chad Versace wrote: > The function segfaulted when a game called glTexSubImage2D on a texture > with internalformat/format/type = GL_SLUMINANCE8/GL_BGRA/GL_UNSIGNED_BYTE. > > The function only supports MESA_FORMAT_ARGB and returns early if it > detects an unsupporte

Re: [Mesa-dev] [PATCH] radeon/llvm: improve select_cc lowering to generate CND* more often

2012-09-26 Thread Tom Stellard
> > diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > > b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > > index 04469e2..bb37154 100644 > > --- a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > > +++ b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > > @@ -934,6

Re: [Mesa-dev] [PATCH 1/2] i965: Refactor texture swizzle generation into a helper.

2012-09-26 Thread Eric Anholt
Kenneth Graunke writes: > It's going to be reused in a second place soon. Series: Reviewed-by: Eric Anholt pgp8q2xvgUdiK.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

Re: [Mesa-dev] [PATCH 06/10] i965: Reduce maximum GL_ARB_fragment_program instruction count to 1024.

2012-09-26 Thread Ian Romanick
On 09/24/2012 12:06 PM, Kenneth Graunke wrote: On 09/22/2012 02:04 PM, Eric Anholt wrote: I don't know of any programs that would need more than this. The larger programs I've seen have neared 100 instructions. This prevent excessive runtimes of automatic tests that attempt to test up to the e

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Eric Anholt
Matt Turner writes: > On Tue, Sep 25, 2012 at 10:56 AM, Marcin Slusarz > wrote: >> On Tue, Sep 25, 2012 at 10:38:31AM -0700, Matt Turner wrote: >>> On Tue, Sep 25, 2012 at 10:31 AM, Marcin Slusarz >>> wrote: >>> >> Installation is part of the testing procedure, after all. >>> > >>> > No. People

[Mesa-dev] [PATCH] intel: Fix segfault in intel_texsubimage_tiled_memcpy

2012-09-26 Thread Chad Versace
The function segfaulted when a game called glTexSubImage2D on a texture with internalformat/format/type = GL_SLUMINANCE8/GL_BGRA/GL_UNSIGNED_BYTE. The function only supports MESA_FORMAT_ARGB and returns early if it detects an unsupported format. Clearly, its detection condition was insufficien

[Mesa-dev] [PATCH 2/2] dri_util: Use calloc to allocate __DRIcontext

2012-09-26 Thread Ian Romanick
From: Ian Romanick The __DRIcontext contains some pointers, and some drivers check for them to be NULL in some failure paths. Instead of sprinkling NULL assignments across the various drivers, just zero out the whole thing. NOTE: This is a candidate for the 9.0 branch. Signed-off-by: Ian Roman

[Mesa-dev] [PATCH 1/2] i965: Don't leave dangling pointer to brw context on failure

2012-09-26 Thread Ian Romanick
From: Ian Romanick Otherwise intelDestroyContext would try to dereference the pointer to freed memory. v2: Don't call intelDestroyContext if the context already freed due to failure. NOTE: This is a candidate for the 9.0 branch. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.o

Re: [Mesa-dev] [PATCH] radeon/llvm: improve select_cc lowering to generate CND* more often

2012-09-26 Thread Tom Stellard
On Tue, Sep 25, 2012 at 11:45:37PM +0200, Vincent Lejeune wrote: > --- > src/gallium/drivers/radeon/R600ISelLowering.cpp| 90 > +- > src/gallium/drivers/radeon/R600ISelLowering.h | 3 + > src/gallium/drivers/radeon/R600Instructions.td | 38 +++-- > .../driver

Re: [Mesa-dev] [PATCH 06/19] glx: Unifdef some dri_interface.h defines.

2012-09-26 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 10:50 PM, Eric Anholt wrote: > dri_interface.h comes from our tree, so why litter our tree with ifdefs for > older versions of it? Yeah, lets get rid of those, it's a bad habit carried over form the aiglx code. Reviewed-by: Kristian Høgsberg > I left in the DRI_TEX_BUF

[Mesa-dev] [Bug 40611] piglit 17000-consecutive-chars-identifier SIGSEGV

2012-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40611 Ian Romanick changed: What|Removed |Added CC||jlp.b...@gmail.com --- Comment #2 from Ia

[Mesa-dev] [Bug 55352] new account request for freedesktop.org - abdiel janulgue

2012-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55352 Brian Paul changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes

[Mesa-dev] [Bug 55352] new account request for freedesktop.org - abdiel janulgue

2012-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55352 --- Comment #2 from Abdiel Janulgue --- preferred account name: abj -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

[Mesa-dev] [Bug 55352] new account request for freedesktop.org - abdiel janulgue

2012-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55352 --- Comment #1 from Abdiel Janulgue --- Created attachment 67715 --> https://bugs.freedesktop.org/attachment.cgi?id=67715&action=edit gpg public key -- You are receiving this mail because: You are the assignee for the bug. ___

[Mesa-dev] [Bug 55352] New: new account request for freedesktop.org - abdiel janulgue

2012-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55352 Priority: medium Bug ID: 55352 Assignee: mesa-dev@lists.freedesktop.org Summary: new account request for freedesktop.org - abdiel janulgue Severity: normal Classification

Re: [Mesa-dev] Adding support for sRGB framebuffers to EGL

2012-09-26 Thread John Kåre Alsaker
EGL_GAMMA_SRGB_BIT should be changed to a boolean EGL config attribute so it can be optionally sorted by eglChooseConfig. It should be sorted after EGL_COLOR_BUFFER_TYPE and true values would be preferred. This sorting should be optional and is done so compositing window managers can sample the fra

Re: [Mesa-dev] Adding support for sRGB framebuffers to EGL

2012-09-26 Thread John Kåre Alsaker
The way this would interact with ARB_framebuffer_sRGB is that the EGL's surface EGL_GAMMA attribute would be ignored. If a EGL config has the EGL_GAMMA_SRGB_BIT, it is required to support sRGB for the default OpenGL framebuffer. On Tue, Sep 25, 2012 at 5:58 PM, John Kåre Alsaker wrote: > Hello, >