- Original Message -
> Otherwise, version.c doesn't get a dependency on it in a clean build,
> and then it doesn't necessarily get generated before version.c is
> compiled.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50976
Thanks for fixing this.
Reviewed-by: Jakob Bornecr
Otherwise, version.c doesn't get a dependency on it in a clean build,
and then it doesn't necessarily get generated before version.c is
compiled.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50976
---
src/mesa/Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Pauli Nieminen writes:
> ARB_sampler_object is very simple software only extension to support.
> I want to make it mandator extension for Mesa drivers to allow meta
> module to use it.
>
> This patch add support for the extension to nouveau. It is completely
> untested search and replace patch. I
On 06/11/2012 01:14 PM, Eric Anholt wrote:
> On Mon, 11 Jun 2012 10:02:34 -0700 (PDT), Jose Fonseca
> wrote:
>> This breaks the SCons build, which parses src/glsl/Makefile.sources,
>> and can't understand "$(GLSL_SRCDIR)/" as it only supports a simple
>> subset of Make syntax.
>>
>> Is there some
On 11.06.2012 14:32, Alexander von Gluck wrote:
On 11.06.2012 14:04, Jose Fonseca wrote:
- Original Message -
From 44fa55d3f49884c824306504943ca2a1382601f0 Mon Sep 17 00:00:00
2001
* Our binary compatibility is targeted to Pentimum or higher,
these changes ensure we keep proper optim
https://bugs.freedesktop.org/show_bug.cgi?id=50979
Brian Paul changed:
What|Removed |Added
AssignedTo|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes
On 06/11/2012 03:15 PM, Ian Romanick wrote:
On 06/11/2012 07:41 AM, Brian Paul wrote:
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
The YCBCR unpack was reading one RGBA value from 4 bytes of YCBCR
texture. But single pixel is only 2 bytes in the format. After
noticing that error Ville told me
On 06/11/2012 07:41 AM, Brian Paul wrote:
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
The YCBCR unpack was reading one RGBA value from 4 bytes of YCBCR
texture. But single pixel is only 2 bytes in the format. After
noticing that error Ville told me that second chroma sample has to
be average t
On Mon, 11 Jun 2012 09:59:21 +0300, Pauli Nieminen
wrote:
> GL_DEPTH_TEXTURE_MODE isn't meant to be part of sampler state based on
> compatibility profile specifications.
>
> OpenGL specification 4.1 compatibility 20100725 3.9.2:
> "... The values accepted in the pname parameter
> are TEXTURE_WR
On 06/11/2012 05:58 AM, Brad King wrote:
> On 06/05/2012 02:03 PM, Kenneth Graunke wrote:
>> On 06/05/2012 10:59 AM, Brad King wrote:
./autogen.sh --with-gl-lib-name=GL --with-glu-lib-name=GLU
--with-osmesa-lib-name=OSMesa ...
>>>
>>> That looks cleaner to me. Here is a patch for it.
>>
On Mon, 11 Jun 2012 09:07:19 -0600, Brian Paul wrote:
> On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
> > diff --git a/src/mesa/main/macros.h b/src/mesa/main/macros.h
> > index d1df2ce..e05fa14 100644
> > --- a/src/mesa/main/macros.h
> > +++ b/src/mesa/main/macros.h
> > @@ -679,5 +679,8 @@ do {
On Mon, 11 Jun 2012 10:02:34 -0700 (PDT), Jose Fonseca
wrote:
> This breaks the SCons build, which parses src/glsl/Makefile.sources,
> and can't understand "$(GLSL_SRCDIR)/" as it only supports a simple
> subset of Make syntax.
>
> Is there some other way to achieve this effect, without changing
On 11.06.2012 14:04, Jose Fonseca wrote:
- Original Message -
From 44fa55d3f49884c824306504943ca2a1382601f0 Mon Sep 17 00:00:00
2001
* Our binary compatibility is targeted to Pentimum or higher,
these changes ensure we keep proper optimizations
* Fixes strange if statement
'! window
https://bugs.freedesktop.org/show_bug.cgi?id=50979
--- Comment #3 from Alexander von Gluck 2012-06-11
12:19:31 PDT ---
Little additional information:
* xorg foundation member since Jan 2012
* frequent commiter to Haiku project (MIT licensed)
http://cgit.haiku-os.org/haiku/log/?qt=author&q=
https://bugs.freedesktop.org/show_bug.cgi?id=50979
--- Comment #2 from Alexander von Gluck 2012-06-11
12:15:04 PDT ---
Created attachment 62900
--> https://bugs.freedesktop.org/attachment.cgi?id=62900
kallisti5 public gpg key
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?t
https://bugs.freedesktop.org/show_bug.cgi?id=50979
--- Comment #1 from Alexander von Gluck 2012-06-11
12:07:58 PDT ---
Created attachment 62898
--> https://bugs.freedesktop.org/attachment.cgi?id=62898
kallisti5 public ssh key
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?t
https://bugs.freedesktop.org/show_bug.cgi?id=50979
Bug #: 50979
Summary: Request an fdo account
Classification: Unclassified
Product: Mesa
Version: git
Platform: All
OS/Version: other
Status: NEW
Severity: no
- Original Message -
> From 44fa55d3f49884c824306504943ca2a1382601f0 Mon Sep 17 00:00:00
> 2001
>
> * Our binary compatibility is targeted to Pentimum or higher,
> these changes ensure we keep proper optimizations
> * Fixes strange if statement
> '! windows or debug or True'
> ---
>
On Thu, Jun 7, 2012 at 5:20 PM, Alexander von Gluck IV
wrote:
> From 44fa55d3f49884c824306504943ca2a1382601f0 Mon Sep 17 00:00:00 2001
>
> * Our binary compatibility is targeted to Pentimum or higher,
> these changes ensure we keep proper optimizations
> * Fixes strange if statement
> '! windows
https://bugs.freedesktop.org/show_bug.cgi?id=50976
U. Artie Eoff changed:
What|Removed |Added
CC||ullysses.a.e...@intel.com
--
Configure
- Original Message -
> - Original Message -
> > This breaks the SCons build, which parses
> > src/glsl/Makefile.sources,
> > and can't understand "$(GLSL_SRCDIR)/" as it only supports a simple
> > subset of Make syntax.
> >
> > Is there some other way to achieve this effect, withou
2012/6/11 Brian Paul :
> On 06/10/2012 04:57 AM, Andreas Boll wrote:
>>
>> Hi,
>>
>> the following patch series is the first part of cleaning up docs/.
>>
>> Please review and commit.
>
Please commit/push. I don't have commit access.
>
> I'm not an HTML expert but these look ok to me. Can you co
https://bugs.freedesktop.org/show_bug.cgi?id=50976
Darxus changed:
What|Removed |Added
CC||dar...@chaosreigns.com
--
Configure bugmail: h
https://bugs.freedesktop.org/show_bug.cgi?id=50976
Bug #: 50976
Summary: Fails to build with error: git_sha1.h: No such file or
directory
Classification: Unclassified
Product: Mesa
Version: git
Platform: Other
- Original Message -
> This breaks the SCons build, which parses src/glsl/Makefile.sources,
> and can't understand "$(GLSL_SRCDIR)/" as it only supports a simple
> subset of Make syntax.
>
> Is there some other way to achieve this effect, without changing
> src/glsl/Makefile.sources?
Actu
On 06/08/2012 10:18 PM, Kenneth Graunke wrote:
From the GL_ARB_copy_buffer spec:
"An INVALID_VALUE error is generated if any of readoffset, writeoffset,
or size are negative [...]"
Fixes oglconform's copybuffer/negative.CNNegativeValues test.
Signed-off-by: Kenneth Graunke
Reviewed-by: Ian
This breaks the SCons build, which parses src/glsl/Makefile.sources, and can't
understand "$(GLSL_SRCDIR)/" as it only supports a simple subset of Make syntax.
Is there some other way to achieve this effect, without changing
src/glsl/Makefile.sources?
Jose
- Original Message -
> Module
On 06/10/2012 04:57 AM, Andreas Boll wrote:
Hi,
the following patch series is the first part of cleaning up docs/.
Please review and commit.
I'm not an HTML expert but these look ok to me. Can you commit/push
or should I?
Q: are lower-case html tags recommended or the usual convention or
On 06/10/2012 11:42 PM, Eric Anholt wrote:
On Fri, 8 Jun 2012 14:31:52 -0600, Brian Paul wrote:
I've now seen a couple apps that replace a whole texture image with a
glTexImage() call instead of glTexSubImage(). The later is better
because we can skip freeing/allocating texture memory.
This
On Sat, 9 Jun 2012 02:33:20 -0700, Kenneth Graunke
wrote:
> DrawPixels uses the MESA_META_CLAMP_FRAGMENT_COLOR flag to save/restore
> the fragment color clamp mode. This is unnecessary since it never
> alters it. It's also harmful: when the clamp mode is GL_FIXED_ONLY,
> setting this flag caus
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
To allow meta module to use sample objects mesa GL functions need to be
visible and linkable for meta module.
Signed-off-by: Pauli Nieminen
---
src/mesa/main/samplerobj.c |8
src/mesa/main/samplerobj.h | 11 +++
2 files cha
On Sat, 9 Jun 2012 02:33:22 -0700, Kenneth Graunke
wrote:
> The hardware supports this format with no known quirks, so we may as
> well enable it.
>
> Alpha blending is not supported until Sandybridge, but as far as I can
> tell, OpenGL doesn't require alpha blending on SNORM formats. Plus, we
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
swrast needs to pass sampler object into all texture fetching functions
to use correct sampling state when sampler object is bound to the unit.
The changes were made using half manual regular expression replace.
With the patch llvmpipe didn't get any
s/mandator/mandatory/
Reviewed-by: Brian Paul
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
To allow meta acceleration operations to use sampler objects the
ARB_sampler_objects extension needs to be mandator for all drivers.
Because the extension doesn't have any hardware dependencies it is
t
On Sat, 9 Jun 2012 21:48:26 -0700, Kenneth Graunke
wrote:
> Fixes oglconform's tbo/basic.buffer.delete test.
Reviewed-by: Eric Anholt
pgps5cX7D6pB5.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
sRGBDecode state is part of sampler object state but mesa was missing
handlers to access the state. This patch adds the support for required
state changes and queries.
GL_EXT_texture_sRGB_decode issue 4:
"4) Should we add forward-looking support for
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
CompareFailValue is part of Sampler state that needs to be read from
bound sampler object if present.
Signed-off-by: Pauli Nieminen
---
src/mesa/program/prog_statevars.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sr
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
Fixed function fragment shader generator was incorrectly read texture
sampling state directly from texture object. To make sure that
ARB_sampler_object works correctly shader generator has to use the
bound sampler if one exist
Signed-off-by: Pauli Ni
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
Preparation for the mandator support of ARB_shader_object.
I have tested this patch with rv280 only. While only compile testing
radeon changes.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/r200/r200_tex.c | 41 -
On Sat, 9 Jun 2012 18:12:34 -0700, Kenneth Graunke
wrote:
> From the GL_NV_primitive_restart spec:
> "PrimitiveRestartIndexNV is not compiled into display lists, but is
> executed immediately."
>
> Prior to this patch, calls to glPrimitiveRestartIndex would hit the noop
> dispatch stub.
Revie
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
When I build tested radeon changes I noticed two warnings about format
size missmatch in 64bit. I decided to clean them to make relevant
compiler warnings easier to spot.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/radeon/radeon_blit.c |
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
ARB_sampler_object is very simple software only extension to support.
I want to make it mandator extension for Mesa drivers to allow meta
module to use it.
This patch add support for the extension to nouveau. It is completely
untested search and repl
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
Sampler queries are so far made only for enabled texture unit. But if
any code would query sampler before checking texture unit state that
would result to NULL deference.
Making the inline helper easier to use with NULL check makes a lot sense
becaus
On 06/08/2012 11:07 PM, Kenneth Graunke wrote:
Module: Mesa
Branch: master
Commit: 306c9f0c5762ad75e340d22b2405ac11e74d3378
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=306c9f0c5762ad75e340d22b2405ac11e74d3378
Author: Kenneth Graunke
Date: Fri Jun 8 22:03:50 2012 -0700
mesa: Fix
On 06/09/2012 10:48 PM, Kenneth Graunke wrote:
Fixes oglconform's tbo/basic.buffer.delete test.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/bufferobj.c |4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index 846260d..332af3d
On 06/09/2012 07:12 PM, Kenneth Graunke wrote:
From the GL_NV_primitive_restart spec:
"PrimitiveRestartIndexNV is not compiled into display lists, but is
executed immediately."
Prior to this patch, calls to glPrimitiveRestartIndex would hit the noop
dispatch stub.
+2 oglconforms.
Signed-off
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
The ARRAY_SIZE macro is usefull helper that is used already in many
parts of core. But mesa core was missing it. I decided to add it to the
macros.h when I wanted to use it in following patch.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/
One comment below.
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
GL_DEPTH_TEXTURE_MODE isn't meant to be part of sampler state based on
compatibility profile specifications.
OpenGL specification 4.1 compatibility 20100725 3.9.2:
"... The values accepted in the pname parameter
are TEXTURE_WRAP_S
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
gl_texture_image structure always holds size and internal format before
TexImage driver hook is called. Those passing same information in
function parameters only duplicates information making the interface
harder to understand.
Signed-off-by: Pauli
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
DrawElements checks for cound beeing larger than index buffer object.
"count being"
But application can specify offset to buffer leading to buffer overflow
again. ARB_vertex_buffer_object leaves the case undefined but allows
program termination.
On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
The YCBCR unpack was reading one RGBA value from 4 bytes of YCBCR
texture. But single pixel is only 2 bytes in the format. After
noticing that error Ville told me that second chroma sample has to
be average to match video requirements.
Looking at pla
On Mon, Jun 11, 2012 at 8:59 AM, Pauli Nieminen
wrote:
> swrast needs to pass sampler object into all texture fetching functions
> to use correct sampling state when sampler object is bound to the unit.
> The changes were made using half manual regular expression replace.
>
> With the patch llvmpi
On 06/05/2012 02:03 PM, Kenneth Graunke wrote:
> On 06/05/2012 10:59 AM, Brad King wrote:
>>> ./autogen.sh --with-gl-lib-name=GL --with-glu-lib-name=GLU
>>> --with-osmesa-lib-name=OSMesa ...
>>
>> That looks cleaner to me. Here is a patch for it.
>
> Reviewed-by: Kenneth Graunke
>
> If there ar
- Original Message -
> On Fri, Jun 08, 2012 at 09:01:42AM -0700, Jose Fonseca wrote:
> > Oliver,
> >
> > There will be other system values in the future, so instead of
> > passing every value as a different parameter, please define a
> > structure in src/gallium/auxiliary/gallivm/lp_bld_
On Sun, 2012-06-10 at 21:45 +0400, Vadim Girlin wrote:
> On Sun, 2012-06-10 at 10:27 +0200, Christian König wrote:
> > On 10.06.2012 04:07, Vadim Girlin wrote:
> > > Shader variants are stored in the list, the key for lookup is based on the
> > > states that require different hw shaders - currently
Sampler objects are perfect for meta operations.Sampler object
is separate state object that shadows the sampling state in texture
object. With sampler object mipmap can maintain same sampling state for
all subsequent generation requests.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/common
Sampler objects can be used to shadow texture object state without
modifying original application state. Decompression path feels a bit
like path where caching shouldn't happen. But as everything else is
cached already I decided to cache sampler state too.
Signed-off-by: Pauli Nieminen
---
src/m
I noticed following issues when I was reading texture management code in
mesa core.
The first ycbcr unpack patch might be actually fixing deadcode. But I
don't know yet enough about unpack code to know for sure. But at least
glGetTexImage has special case get_tex_ycbcr.
Following TexImage changes
Framebuffer blit needs to setup texture sampling to match application
requested blit operation. Sampler object can be used to avoid changes to
texture object. But caching sampler object doesn't make much sense when
we need to synamically change it based on filtering parameters.
Signed-off-by: Paul
ARB_sampler_object is very simple software only extension to support.
I want to make it mandator extension for Mesa drivers to allow meta
module to use it.
This patch add support for the extension to nouveau. It is completely
untested search and replace patch. I hope someone with old NV hardware
c
To allow meta acceleration operations to use sampler objects the
ARB_sampler_objects extension needs to be mandator for all drivers.
Because the extension doesn't have any hardware dependencies it is
trivial to implement.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/intel/intel_extensi
To allow meta module to use sample objects mesa GL functions need to be
visible and linkable for meta module.
Signed-off-by: Pauli Nieminen
---
src/mesa/main/samplerobj.c |8
src/mesa/main/samplerobj.h | 11 +++
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git
CompareFailValue is part of Sampler state that needs to be read from
bound sampler object if present.
Signed-off-by: Pauli Nieminen
---
src/mesa/program/prog_statevars.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/program/prog_statevars.c
b/src/mesa/progr
When I build tested radeon changes I noticed two warnings about format
size missmatch in 64bit. I decided to clean them to make relevant
compiler warnings easier to spot.
Signed-off-by: Pauli Nieminen
CC: xorg-driver-...@lists.x.org
---
src/mesa/drivers/dri/radeon/radeon_blit.c |4 ++--
1 fi
Preparation for the mandator support of ARB_shader_object.
I have tested this patch with rv280 only. While only compile testing
radeon changes.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/r200/r200_tex.c | 41 --
src/mesa/drivers/dri/r200/r200_tex.h
ARB_sampler_object is very simple software only extension to support.
I want to make it mandator extension for Mesa drivers to allow meta
module to use it.
This patch add support for the extension to nouveau. It is completely
untested search and replace patch. I hope someone with old NV hardware
c
Fixed function fragment shader generator was incorrectly read texture
sampling state directly from texture object. To make sure that
ARB_sampler_object works correctly shader generator has to use the
bound sampler if one exist
Signed-off-by: Pauli Nieminen
---
src/mesa/main/ff_fragment_shader.cp
Preparation for the mandator support of ARB_shader_object. I have tested
this patch with rv280 only. While only compile testing radeon changes.
Does someone want to run piglit tests for radeon too?
Signed-off-by: Pauli Nieminen
CC: xorg-driver-...@lists.x.org
---
src/mesa/drivers/dri/r200/r200_
Avoid INVALID_OPERATION error if decompressing rectangle texture.
Setting mipmap level limits for those textures is error that must not be
hit by meta code to mislead user.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/common/meta.c |6 --
1 file changed, 4 insertions(+), 2 deletion
Sampler queries are so far made only for enabled texture unit. But if
any code would query sampler before checking texture unit state that
would result to NULL deference.
Making the inline helper easier to use with NULL check makes a lot sense
because compiler is likely to combine the checks for t
When I build tested radeon changes I noticed two warnings about format
size missmatch in 64bit. I decided to clean them to make relevant
compiler warnings easier to spot.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/radeon/radeon_blit.c |4 ++--
1 file changed, 2 insertions(+), 2 d
GL_DEPTH_TEXTURE_MODE isn't meant to be part of sampler state based on
compatibility profile specifications.
OpenGL specification 4.1 compatibility 20100725 3.9.2:
"... The values accepted in the pname parameter
are TEXTURE_WRAP_S, TEXTURE_WRAP_T, TEXTURE_WRAP_R, TEXTURE_MIN_-
FILTER, TEXTURE_MAG_
sRGBDecode state is part of sampler object state but mesa was missing
handlers to access the state. This patch adds the support for required
state changes and queries.
GL_EXT_texture_sRGB_decode issue 4:
"4) Should we add forward-looking support for ARB_sampler_objects?
RESOLVED: YES
Size and format information is always stored in gl_texture_image
structure. That makes it preferable to remove duplicate information from
parameters to make interface easier to understand.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/intel/intel_tex.c | 10 +++
src/mesa/dri
DrawElements checks for cound beeing larger than index buffer object.
But application can specify offset to buffer leading to buffer overflow
again. ARB_vertex_buffer_object leaves the case undefined but allows
program termination.
But if we do check the index buffer size it makes sense to check i
GL_DEPTH_TEXTURE_MODE isn't meant to be part of sampler state based on
compatibility profile specifications.
OpenGL specification 4.1 compatibility 20100725 3.9.2:
"... The values accepted in the pname parameter
are TEXTURE_WRAP_S, TEXTURE_WRAP_T, TEXTURE_WRAP_R, TEXTURE_MIN_-
FILTER, TEXTURE_MAG_
sRGBDecode state is part of sampler object state but mesa was missing
handlers to access the state. This patch adds the support for required
state changes and queries.
GL_EXT_texture_sRGB_decode issue 4:
"4) Should we add forward-looking support for ARB_sampler_objects?
RESOLVED: YES
Sampler queries are so far made only for enabled texture unit. But if
any code would query sampler before checking texture unit state that
would result to NULL deference.
Making the inline helper easier to use with NULL check makes a lot sense
because compiler is likely to combine the checks for t
In tune with previous patches. Again there is duplication of information
in function parameters that is good to remove.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 --
src/mesa/main/dd.h |3 ---
src/mesa/main/teximage.c
The ARRAY_SIZE macro is usefull helper that is used already in many
parts of core. But mesa core was missing it. I decided to add it to the
macros.h when I wanted to use it in following patch.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/intel/intel_context.h |3 +--
src/mesa/driv
gl_texture_image structure always holds size and internal format before
TexImage driver hook is called. Those passing same information in
function parameters only duplicates information making the interface
harder to understand.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/intel/intel_
The ARRAY_SIZE macro is usefull helper that is used already in many
parts of core. But mesa core was missing it. I decided to add it to the
macros.h when I wanted to use it in following patch.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/intel/intel_context.h |3 +--
src/mesa/driv
In tune with previous patches. Again there is duplication of information
in function parameters that is good to remove.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 --
src/mesa/main/dd.h |3 ---
src/mesa/main/teximage.c
Size and format information is always stored in gl_texture_image
structure. That makes it preferable to remove duplicate information from
parameters to make interface easier to understand.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/intel/intel_tex.c | 10 +++
src/mesa/dri
gl_texture_image structure always holds size and internal format before
TexImage driver hook is called. Those passing same information in
function parameters only duplicates information making the interface
harder to understand.
Signed-off-by: Pauli Nieminen
---
src/mesa/drivers/dri/intel/intel_
The YCBCR unpack was reading one RGBA value from 4 bytes of YCBCR
texture. But single pixel is only 2 bytes in the format. After
noticing that error Ville told me that second chroma sample has to
be average to match video requirements.
Looking at places where unpack to rgba is called it is possibl
I noticed following issues when I was reading texture management code in
mesa core.
The first ycbcr unpack patch might be actually fixing deadcode. But I
don't know yet enough about unpack code to know for sure. But at least
glGetTexImage has special case get_tex_ycbcr.
I also noticed size check
87 matches
Mail list logo
