On Mon, May 14, 2012 at 11:13 PM, Oliver McFadden
wrote:
> On Mon, May 14, 2012 at 11:46:15AM -0700, Ian Romanick wrote:
>> /* Page 37 (page 47 of the PDF) of the OpenGL ES 2.0.25 spec says:
>> *
>> * "The matrix is specified in column-major order. transpose
>> * mus
On Mon, May 14, 2012 at 11:46:15AM -0700, Ian Romanick wrote:
> On 05/14/2012 04:56 AM, Oliver McFadden wrote:
> > GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
> >
> > http://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
> >
> > Signed-off-by: Oliver McFadden
> > ---
> >
On 14 May 2012 16:50, Ian Romanick wrote:
> On 05/14/2012 02:13 PM, Paul Berry wrote:
>
>> Just to update the list: I had an in-person meeting with Eric, Ian, and
>> Ken today to discuss the design of the patch series and decide what to
>> do about it. We agreed to go ahead and push the patches
I took a little tour of the Intel oglconform failures, and found some
easy fixes. Enjoy.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
---
src/mesa/main/texobj.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
index 365169d..a471bad 100644
--- a/src/mesa/main/texobj.c
+++ b/src/mesa/main/texobj.c
@@ -558,7 +558,8 @@ _mesa_test_texobj_completeness( const stru
Fixes piglit glsl-1.30/execution/switch/fs-uint.
---
src/glsl/ast_to_hir.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 4521e86..45ffa16 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -3599,7
Otherwise, an incomplete framebuffer could have a NULL
_ColorReadBuffer and we'd deref that.
---
src/mesa/main/readpix.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
index 31acfcb..1381110 100644
--- a/src/mesa
It's an implied argument, and I don't think being explicit about it
helps.
---
src/glsl/ast_to_hir.cpp | 35 ++-
1 file changed, 14 insertions(+), 21 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 45ffa16..4a52788 100644
--- a/s
The comment quotes spec saying that only scalar integers are allowed,
but we only checked for integer.
Fixes piglit switch-expression-const-ivec2.vert
---
src/glsl/ast_to_hir.cpp |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to
Fixes piglit GL_ARB_shader_objeccts/getactiveuniform-beginend.
---
src/mesa/main/uniform_query.cpp |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp
index 08d330a..f5d998f 100644
--- a/src/mesa/main/uniform_query.cpp
+++ b/sr
I managed to completely trash it in 22d81f15.
---
src/glsl/ast_to_hir.cpp | 545 +++
1 file changed, 263 insertions(+), 282 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 86bb874..01b1025 100644
--- a/src/glsl/ast_to_
Fixes assertion failure in piglit:
vs-mat2-struct-assignment.shader_test
vs-mat2-array-assignment.shader_test
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
b/src/mesa/dri
I noticed this while unindenting the code.
---
src/glsl/ast_to_hir.cpp |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 01b1025..bc32abb 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -3731,7 +
On 05/14/2012 02:13 PM, Paul Berry wrote:
Just to update the list: I had an in-person meeting with Eric, Ian, and
Ken today to discuss the design of the patch series and decide what to
do about it. We agreed to go ahead and push the patches to master as
is, and to make further improvements as ti
On 05/13/2012 07:00 AM, Jordan Justen wrote:
v2:
* change non-gallium drivers to not enable NV_primitive_restart
by default. (this matches the current mesa behavior.)
* gallium drivers will continue to use software primitivie restart
where needed and will always declare the NV_primiti
On 05/13/2012 07:00 AM, Jordan Justen wrote:
vbo_sw_primitive_restart implements primitive restart in software
by splitting primitive draws apart.
This is based on similar support in mesa/state_tracker/st_draw.c.
Signed-off-by: Jordan Justen
---
src/mesa/SConscript |1 +
On 05/13/2012 07:06 AM, Jordan Justen wrote:
If the primitive restart index and the primitive type can
be handled by the cut index feature, then use the hardware
to handle the primitive restart feature.
The VBO module's software handling of primitive restart is
used as a fall back.
Signed-off-b
On 05/13/2012 07:06 AM, Jordan Justen wrote:
For newer hardware we disable the VBO module's software handling
of primitive restart. We now handle primitive restarts in
brw_handle_primitive_restart.
The initial version of brw_handle_primitive_restart simply calls
vbo_sw_primitive_restart, and the
This patch implements clipping and scissoring of the destination rect
for blits that use the blorp engine (e.g. MSAA blits).
---
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 72 --
1 files changed, 67 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965
When drawing to a FBO, the viewport wasn't always set correctly. It
was fine in the usual case of the viewport dims matching the surface
dims but broken otherwise.
I'll post a new piglit test which exercises this.
---
src/gallium/drivers/svga/svga_state_framebuffer.c | 31 -
On Thu, 10 May 2012 16:10:15 -0700, Kenneth Graunke
wrote:
> Total instructions: 18210 -> 17836
> 49/163 programs affected (30.1%)
> 12888 -> 12514 instructions in affected programs (2.9% reduction)
>
> This reduces Lightsmark's "Scale down filter" shader from 395
> instructions to 283, a whoppi
Just to update the list: I had an in-person meeting with Eric, Ian, and Ken
today to discuss the design of the patch series and decide what to do about
it. We agreed to go ahead and push the patches to master as is, and to
make further improvements as time goes on.
Specific improvements that were
On 14 May 2012 11:06, Ian Romanick wrote:
> On 05/14/2012 07:30 AM, Paul Berry wrote:
>
>> I'm trying to figure out how glBlitFramebuffer() is supposed to behave
>> when the source rectangle exceeds the bounds of the read framebuffer.
>> For example, if the read framebuffer has width 4 and height
Paul Berry writes:
> This patch adds .gitignore files to ignore the makefiles generated by
> the gallium pipe loader and the clover OpenCL state tracker.
Reviewed-by: Francisco Jerez
> ---
> src/gallium/auxiliary/pipe-loader/.gitignore |1 +
> src/gallium/state_trackers/clover/.gitignore |
Tom Stellard writes:
> On Mon, May 14, 2012 at 05:19:10PM +0200, Francisco Jerez wrote:
>> Tom Stellard writes:
>>
>> > On Sun, May 13, 2012 at 04:10:50PM +0200, Francisco Jerez wrote:
>> >> Tom Stellard writes:
>> >>[...]
>> >> > I guess this might be able to work, but I'm not really sure why
On 05/14/2012 04:56 AM, Oliver McFadden wrote:
GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
http://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
Signed-off-by: Oliver McFadden
---
src/mesa/main/uniform_query.cpp | 10 ++
1 files changed, 10 insertions(+),
On 05/14/2012 07:30 AM, Paul Berry wrote:
I'm trying to figure out how glBlitFramebuffer() is supposed to behave
when the source rectangle exceeds the bounds of the read framebuffer.
For example, if the read framebuffer has width 4 and height 1, and the
draw framebuffer has width 100 and height 1
On Mon, May 14, 2012 at 05:19:10PM +0200, Francisco Jerez wrote:
> Tom Stellard writes:
>
> > On Sun, May 13, 2012 at 04:10:50PM +0200, Francisco Jerez wrote:
> >> Tom Stellard writes:
> >>
> >> > On Sun, May 13, 2012 at 12:40:43AM +0200, Francisco Jerez wrote:
> >> >>[...]
> >> >> I can think
On Fri, 11 May 2012 14:25:45 -0700, Ian Romanick wrote:
> On 05/10/2012 04:10 PM, Kenneth Graunke wrote:
> > This lets you omit some ampersands and is more idiomatic C++. Using
> > const also marks the function as not altering either register (which
> > was obvious, but nice to enforce).
>
> I'm
On 05/14/2012 10:59 AM, Brian Paul wrote:
On 05/14/2012 10:44 AM, Marek Olšák wrote:
On Mon, May 14, 2012 at 4:40 PM, Brian Paul wrote:
On 05/12/2012 10:11 AM, Marek Olšák wrote:
It may fail with an unsupported format, but that's not an allowed
case
where
RenderbufferStorage may fail.
I've
On 05/14/2012 10:44 AM, Marek Olšák wrote:
On Mon, May 14, 2012 at 4:40 PM, Brian Paul wrote:
On 05/12/2012 10:11 AM, Marek Olšák wrote:
It may fail with an unsupported format, but that's not an allowed case
where
RenderbufferStorage may fail.
I've read your comment several times but I sti
On Mon, May 14, 2012 at 4:40 PM, Brian Paul wrote:
> On 05/12/2012 10:11 AM, Marek Olšák wrote:
>>
>> It may fail with an unsupported format, but that's not an allowed case
>> where
>> RenderbufferStorage may fail.
>
>
> I've read your comment several times but I still can't quite understand the
>
This patch adds .gitignore files to ignore the makefiles generated by
the gallium pipe loader and the clover OpenCL state tracker.
---
src/gallium/auxiliary/pipe-loader/.gitignore |1 +
src/gallium/state_trackers/clover/.gitignore |1 +
src/gallium/targets/opencl/.gitignore|1 +
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(non-matrix uniform)
Program received signal SIGFPE, Arithmetic exception.
0x in brw_prepare_vertices (brw=0x...) at
brw_draw_upload.c:571
571 delta = d / brw->vb.current_buffers[i].stride;
Occurs when g
Tom Stellard writes:
> On Sun, May 13, 2012 at 04:10:50PM +0200, Francisco Jerez wrote:
>> Tom Stellard writes:
>>
>> > On Sun, May 13, 2012 at 12:40:43AM +0200, Francisco Jerez wrote:
>> >>[...]
>> >> I can think of two different ways this could work (your solution would
>> >> be somewhere in
https://bugs.freedesktop.org/show_bug.cgi?id=40920
José Fonseca changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugs.freedesktop.org/show_bug.cgi?id=49915
Brian Paul changed:
What|Removed |Added
AssignedTo|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes
On 05/12/2012 10:11 AM, Marek Olšák wrote:
It may fail with an unsupported format, but that's not an allowed case where
RenderbufferStorage may fail.
I've read your comment several times but I still can't quite
understand the whole issue.
The intention was that AllocStorage() should never fa
On Mon, May 14, 2012 at 08:01:07AM -0600, Brian Paul wrote:
> On 05/14/2012 07:56 AM, Oliver McFadden wrote:
> > On Mon, May 14, 2012 at 07:50:34AM -0600, Brian Paul wrote:
>
> >> IMO, for trivial fixes like that you don't need to post v2 patches.
> >> Just commit with fixes.
> >
> > Oh, at the mo
I'm trying to figure out how glBlitFramebuffer() is supposed to behave when
the source rectangle exceeds the bounds of the read framebuffer. For
example, if the read framebuffer has width 4 and height 1, and the draw
framebuffer has width 100 and height 100, what should be the result of
these two
https://bugs.freedesktop.org/show_bug.cgi?id=49915
--- Comment #2 from Oliver McFadden 2012-05-14 07:30:47
PDT ---
Created attachment 61626
--> https://bugs.freedesktop.org/attachment.cgi?id=61626
GPG public key
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
-
https://bugs.freedesktop.org/show_bug.cgi?id=49915
--- Comment #1 from Oliver McFadden 2012-05-14 07:29:47
PDT ---
Created attachment 61625
--> https://bugs.freedesktop.org/attachment.cgi?id=61625
SSH public key
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
-
https://bugs.freedesktop.org/show_bug.cgi?id=49915
Bug #: 49915
Summary: Account request
Classification: Unclassified
Product: Mesa
Version: unspecified
Platform: Other
OS/Version: All
Status: NEW
Severity: n
On 05/14/2012 07:56 AM, Oliver McFadden wrote:
On Mon, May 14, 2012 at 07:50:34AM -0600, Brian Paul wrote:
IMO, for trivial fixes like that you don't need to post v2 patches.
Just commit with fixes.
Oh, at the moment I'm still sorting out my fd.o Intel account, need to
request commit access
On 05/13/2012 08:00 AM, Jordan Justen wrote:
When PrimitiveRestartInSoftware is set, the VBO module will handle
primitive restart scenarios before calling the vbo->draw_prims
drawing function.
Signed-off-by: Jordan Justen
---
src/mesa/vbo/vbo_exec_array.c | 35 +--
On Mon, May 14, 2012 at 07:50:34AM -0600, Brian Paul wrote:
> On 05/14/2012 07:45 AM, Oliver McFadden wrote:
> > On Mon, May 14, 2012 at 07:26:10AM -0600, Brian Paul wrote:
> >> On 05/14/2012 05:56 AM, Oliver McFadden wrote:
> >>> GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
> >>>
>
On 05/13/2012 08:00 AM, Jordan Justen wrote:
vbo_sw_primitive_restart implements primitive restart in software
by splitting primitive draws apart.
This is based on similar support in mesa/state_tracker/st_draw.c.
Signed-off-by: Jordan Justen
---
src/mesa/SConscript |1 +
On 05/14/2012 07:45 AM, Oliver McFadden wrote:
On Mon, May 14, 2012 at 07:26:10AM -0600, Brian Paul wrote:
On 05/14/2012 05:56 AM, Oliver McFadden wrote:
GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
http://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
Signed-off-by:
Signed-off-by: Oliver McFadden
Reviewed-by: Brian Paul
---
src/mesa/main/version.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index 607230b..90afecb 100644
--- a/src/mesa/main/version.c
+++ b/src/mesa/mai
GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
http://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
Signed-off-by: Oliver McFadden
Reviewed-by: Brian Paul
---
src/mesa/main/uniform_query.cpp | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --g
On Mon, May 14, 2012 at 07:26:10AM -0600, Brian Paul wrote:
> On 05/14/2012 05:56 AM, Oliver McFadden wrote:
> > GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
> >
> > http://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
> >
> > Signed-off-by: Oliver McFadden
> > ---
> >
On 05/14/2012 05:56 AM, Oliver McFadden wrote:
GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
http://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
Signed-off-by: Oliver McFadden
---
src/mesa/main/uniform_query.cpp | 10 ++
1 files changed, 10 insertions(+),
On Mon, May 14, 2012 at 12:14 PM, Christoph Bumiller
wrote:
> On 14.05.2012 09:25, Jose Fonseca wrote:
>> Looks good. Thanks Vinson.
>>
>> Joe
>
> Actually, all the user_buffer pointers have a comment "/**< pointer to a
> user buffer if buffer == NULL */", so you wouldn't actually have to
> initia
- Original Message -
> On 14.05.2012 09:25, Jose Fonseca wrote:
> > Looks good. Thanks Vinson.
> >
> > Joe
>
> Actually, all the user_buffer pointers have a comment "/**< pointer
> to a
> user buffer if buffer == NULL */", so you wouldn't actually have to
> initialize them if buffer is gua
Signed-off-by: Oliver McFadden
---
src/mesa/main/version.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index 607230b..90afecb 100644
--- a/src/mesa/main/version.c
+++ b/src/mesa/main/version.c
@@ -259,7 +25
GL_INVALID_VALUE is generated if transpose is not GL_FALSE.
http://www.khronos.org/opengles/sdk/docs/man/xhtml/glUniform.xml
Signed-off-by: Oliver McFadden
---
src/mesa/main/uniform_query.cpp | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/unifor
On 14.05.2012 09:25, Jose Fonseca wrote:
> Looks good. Thanks Vinson.
>
> Joe
Actually, all the user_buffer pointers have a comment "/**< pointer to a
user buffer if buffer == NULL */", so you wouldn't actually have to
initialize them if buffer is guaranteed to be non-NULL, and checking for
user_b
Looks good. Thanks Vinson.
Joe
- Original Message -
> Fix uninitialized scalar variable defects reported by Coverity.
>
> Signed-off-by: Vinson Lee
> ---
> src/gallium/auxiliary/vl/vl_vertex_buffers.c |4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/gallium/auxiliar
58 matches
Mail list logo
