From: Eric Anholt
We have lexer recognition of a bunch of our types based on the
handling. This code was mapping those recognized tokens to an enum
and then to a string of their name. Just drop the enums and provide
the string directly in the parser.
Reviewed-by: Ian Romanick
Reviewed-by: Ken
Nothing actually relied on them being mutable, and there was at least
one cast which discarded const qualifiers. The next patch would have
introduced many more.
Casting away const qualifiers should be avoided if at all possible.
Signed-off-by: Kenneth Graunke
---
src/glsl/ast.h
On 03/29/2012 02:37 PM, Eric Anholt wrote:
We have lexer recognition of a bunch of our types based on the
handling. This code was mapping those recognized tokens to an enum
and then to a string of their name. Just drop the enums and provide
the string directly in the parser.
---
src/glsl/ast.
Hi,
last time I was wondering about thread safety in Mesa 8.0 build with
llvm=no - this configuration seems to be working with the lock patch.
Now I am testing 8.0 branch with LLVM 3.0 (with scons script fix
a1482b21cb438c271cf20e7d52cb9e4e0537344c - stop me if it is not
supposed to work)
I have
When SPRITE_POINT_ENABLE bit is set, the texture coord would be
replaced, and this is only needed when we called something like
glTexEnvi(GL_POINT_SPRITE, GL_COORD_REPLACE, GL_TRUE).
And more, we currently handle varying inputs as texture coord,
we would be careful when setting this bit and set i
On 03/28/2012 10:58 AM, Eric Anholt wrote:
This gets the texture buffer object support to the point of running
and passing the piglit core tests other than deprecated formats on
i965.
Patch 2 is the glapi regen (I want the time back I've lost to
regen failure this week).
Patch 13 we may want to
On 03/29/2012 02:59 PM, Eric Anholt wrote:
The samplerBuffer type will be undefined in !glsl 1.40, and the
keyword is marked as reserved. The [iu]samplerBuffer types are not
marked as reserved pre-1.40, so they don't have separate tokens and
fall through to normal type handling.
My recollectio
On 03/29/2012 02:37 PM, Eric Anholt wrote:
We have lexer recognition of a bunch of our types based on the
handling. This code was mapping those recognized tokens to an enum
and then to a string of their name. Just drop the enums and provide
the string directly in the parser.
I like this. Ass
On 03/29/2012 02:59 PM, Matt Turner wrote:
On Thu, Mar 29, 2012 at 5:37 PM, Eric Anholt wrote:
We have lexer recognition of a bunch of our types based on the
handling. This code was mapping those recognized tokens to an enum
and then to a string of their name. Just drop the enums and provide
On Thu, Mar 29, 2012 at 5:37 PM, Eric Anholt wrote:
> We have lexer recognition of a bunch of our types based on the
> handling. This code was mapping those recognized tokens to an enum
> and then to a string of their name. Just drop the enums and provide
> the string directly in the parser.
> -
The samplerBuffer type will be undefined in !glsl 1.40, and the
keyword is marked as reserved. The [iu]samplerBuffer types are not
marked as reserved pre-1.40, so they don't have separate tokens and
fall through to normal type handling.
---
Good catch on my silly addition of tokens that never got
We have lexer recognition of a bunch of our types based on the
handling. This code was mapping those recognized tokens to an enum
and then to a string of their name. Just drop the enums and provide
the string directly in the parser.
---
src/glsl/ast.h | 66 +---
On 03/29/2012 10:41 AM, Kenneth Graunke wrote:
On 03/28/2012 11:43 PM, Vinson Lee wrote:
Fixes a Coverity resource leak defect.
NOTE: This is a candidate for the 8.0 branch.
Signed-off-by: Vinson Lee
---
src/glsl/link_uniforms.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/lin
https://bugs.freedesktop.org/show_bug.cgi?id=48057
--- Comment #1 from Dave Airlie 2012-03-29 11:27:13
PDT ---
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b78a77f979b21a84aecb6fa4f19a2ed51a48c306
is the fix in master needs to be picked
--
Configure bugmail: https://bugs.freedesktop.org/u
https://bugs.freedesktop.org/show_bug.cgi?id=48057
Bug #: 48057
Summary: use of uninitialized variables by read_builtins()
Classification: Unclassified
Product: Mesa
Version: 8.0
Platform: Other
OS/Version: All
Status:
On 03/28/2012 11:43 PM, Vinson Lee wrote:
Fixes a Coverity resource leak defect.
NOTE: This is a candidate for the 8.0 branch.
Signed-off-by: Vinson Lee
---
src/glsl/link_uniforms.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.c
On 03/29/2012 09:58 AM, Eric Anholt wrote:
On Wed, 28 Mar 2012 20:33:06 -0700, Kenneth Graunke
wrote:
Aside from ir_call, our IR is cleanly split into two classes:
- Statements (typeless; used for side effects, control flow)
- Values (deeply nestable, pure, typed expression trees)
diff --git a
On Wed, 28 Mar 2012 23:43:30 -0700, Vinson Lee wrote:
> Fixes a Coverity resource leak defect.
I'm betting coverity is pointing out a case where this is sometimes
leaked, but not every time, while you're freeing it every time.
pgpmiJpUky7fj.pgp
Description: PGP signature
___
On Wed, 28 Mar 2012 20:32:59 -0700, Kenneth Graunke
wrote:
> I finally resurrected this work I started back in September. I think
> I've included most of the old feedback, and done a bunch more cleaning.
Patches 2,4,5,6,8,9 are also:
Reviewed-by: Eric Anholt
> The one outstanding concern I h
On Wed, 28 Mar 2012 20:33:06 -0700, Kenneth Graunke
wrote:
> Aside from ir_call, our IR is cleanly split into two classes:
> - Statements (typeless; used for side effects, control flow)
> - Values (deeply nestable, pure, typed expression trees)
> diff --git a/src/glsl/ir_basic_block.cpp b/src/gls
https://bugs.freedesktop.org/show_bug.cgi?id=48052
Bug #: 48052
Summary: [softpipe] depth-cube-map fails
Classification: Unclassified
Product: Mesa
Version: git
Platform: Other
OS/Version: All
Status: NEW
Sev
Now that we have everything in place we can finally make it official
and announce it:
XDC2012 will take place from September 19th to September 21th in Nuernberg,
Germany at the SUSE headquarter buidling.
Matthias Hopf, Luc Verhaegen and I will be orgainzing this event.
The initial wiki page for
https://bugs.freedesktop.org/show_bug.cgi?id=47649
Kristian Høgsberg changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
On Thu, Mar 29, 2012 at 12:07:46AM -0700, Jose Fonseca wrote:
> Looks good to me.
>
> It's disabled by default, which is important because upstream doesn't really
> support shared llvm libs -- it's something that distros are doing on their
> initiative.
>
> Also note that this will saves disk a
https://bugs.freedesktop.org/show_bug.cgi?id=47878
--- Comment #6 from Alexandre Demers 2012-03-29
05:22:03 PDT ---
(In reply to comment #5)
> It at least sounds like a good idea if vdpau and va have a separate
> installation-dir parameter to give xvmc one also.
>
> I just doesn't want to do th
https://bugs.freedesktop.org/show_bug.cgi?id=47649
--- Comment #5 from Fabio Pedretti 2012-03-29 03:53:13
PDT ---
> But maybe give this patch a try:
The patch fixes the issue indeed, thanks.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving t
https://bugs.freedesktop.org/show_bug.cgi?id=47878
--- Comment #5 from Christian König 2012-03-29
01:00:43 PDT ---
It at least sounds like a good idea if vdpau and va have a separate
installation-dir parameter to give xvmc one also.
I just doesn't want to do the patch myself, so if you want to
On Don, 2012-03-29 at 00:07 -0700, Jose Fonseca wrote:
>
> Also note that this will saves disk at the expense of runtime memory
> -- as the shared LLVM library will contain the _whole_ LLVM, and not
> just the components targets needed, and given that there is usually
> only xxx_dri.so module on a
Looks good to me.
It's disabled by default, which is important because upstream doesn't really
support shared llvm libs -- it's something that distros are doing on their
initiative.
Also note that this will saves disk at the expense of runtime memory -- as the
shared LLVM library will contain
29 matches
Mail list logo
