On Wed, 28 Mar 2012 20:32:59 -0700, Kenneth Graunke <kenn...@whitecape.org> wrote: > I finally resurrected this work I started back in September. I think > I've included most of the old feedback, and done a bunch more cleaning.
Patches 2,4,5,6,8,9 are also: Reviewed-by: Eric Anholt <e...@anholt.net> > The one outstanding concern I have is IR->Mesa and IR->TGSI: both seem > to support function calls, but I'm not sure how that all works. IMHO > Mesa IR really shouldn't support them---we should just rely on the GLSL > compiler's inliner. I'm incredibly skeptical that the code in IR->Mesa > actually works, since it has a comment that functions other than main() > should never been seen. Maybe that's just old. Can we delete this? There may exist code in ir_to_mesa, but I don't think that code has been run, nor do I expect the Mesa optimization passes to do anything good to programs using the CAL opcode.
pgpPcsBQycz2z.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
