[Mesa-dev] [PATCH 10/10] i965/vs: Return a dummy value when visiting ir_texture.

2011-09-08 Thread Eric Anholt
While the program won't successfully link in the end, this avoids possible assertion failure in the driver during linking if this->result isn't initialized with something already. --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --

[Mesa-dev] [PATCH 07/10] mesa: Add a context flag indicating whether two-sided lighting should happen.

2011-09-08 Thread Eric Anholt
The 965 driver was ignoring the VERTEX_PROGRAM_TWO_SIDE flag and only looking at fixed-function state. --- src/mesa/main/mtypes.h |2 ++ src/mesa/main/state.c | 18 +- 2 files changed, 19 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtyp

[Mesa-dev] [PATCH 09/10] i965: When only BFC is written, use BFC as the color.

2011-09-08 Thread Eric Anholt
Fixes piglit vertex-program-two-side back. --- src/mesa/drivers/dri/i965/gen6_sf_state.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_sf_state.c b/src/mesa/drivers/dri/i965/gen6_sf_state.c index bb8bc83..4482e9c 100644 --- a/src/m

[Mesa-dev] [PATCH 08/10] i965: Respect the VERTEX_PROGRAM_TWO_SIDE flag for shaders.

2011-09-08 Thread Eric Anholt
Fixes piglit: vertex-program-two-side vertex-program-two-side primary vertex-program-two-side secondary --- src/mesa/drivers/dri/i965/brw_vs_constval.c |6 +++--- src/mesa/drivers/dri/i965/gen6_sf_state.c |5 +++-- src/mesa/drivers/dri/i965/gen7_sf_state.c |6 ++ 3 files change

[Mesa-dev] [PATCH 06/10] i965/vs: Add support for compute-to-MRF.

2011-09-08 Thread Eric Anholt
Removes 1.8% of the instructions from 97% of the vertex shaders in shader-db. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 177 +++ src/mesa/drivers/dri/i965/brw_vec4.h|1 + src/mesa/drivers/dri/i965/brw_vec4_emit.cpp |1 + 3 files changed, 179 inserti

[Mesa-dev] [PATCH 05/10] i965/vs: Do VUE writes using the MRF file instead of hardware register.

2011-09-08 Thread Eric Anholt
We'll only do compute-to-MRF on accesses to this file. --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 83f543f

[Mesa-dev] [PATCH 03/10] i965/vs: Add a function for how many MRFs get written as part of a SEND.

2011-09-08 Thread Eric Anholt
This will be used for compute-to-mrf, which needs to know when MRFs get overwritten. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 37 src/mesa/drivers/dri/i965/brw_vec4.h |2 + 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers

[Mesa-dev] [PATCH 02/10] i965/vs: Remove dead fields of src_reg.

2011-09-08 Thread Eric Anholt
These were copy and pasted from the FS, and are never used. --- src/mesa/drivers/dri/i965/brw_vec4.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index 3f116ee..0f85cdb 100644 --- a/src/mesa/d

[Mesa-dev] [PATCH 04/10] i965/vs: Handle destinations in the MRF file.

2011-09-08 Thread Eric Anholt
We've been referencing MRFs through the HW_REG file so far, but that makes it harder to handle compute-to-MRF and similar optimizations. --- src/mesa/drivers/dri/i965/brw_vec4_emit.cpp |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_

[Mesa-dev] [PATCH 01/10] i965/vs: Add support for simple algebraic optimizations.

2011-09-08 Thread Eric Anholt
We generate silly code for array access, and it's easier to generally support the cleanup than to specifically avoid the bad code in each place we might generate it. Removes 4.6% of instructions from 41.6% of shaders in shader-db, particularly savage2/hon and unigine. --- src/mesa/drivers/dri/i96

[Mesa-dev] two-side fixes, i965 new-VS optimization

2011-09-08 Thread Eric Anholt
For those that don't care for i965, there's patch 7/10 to look at, to go along with the proposed vertex-program-two-side piglit test. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] mesa: Add support for Begin/EndConditionalRender in display lists.

2011-09-08 Thread Eric Anholt
Fixes piglit nv_conditional_render-dlist. --- src/mesa/main/dlist.c | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 6e075b4..a80cfdc 100644 --- a/src/mesa/main/dlist.c +++ b/sr

[Mesa-dev] [PATCH 2/3] mesa: Throw an error instead of asserting for condrender with query == 0.

2011-09-08 Thread Eric Anholt
>From the NV_conditional_render spec: BeginQuery sets the active query object name for the query type given by to . If BeginQuery is called with an of zero, if the active query object name for is non-zero, if is the active query object name for any query type, or if is the ac

[Mesa-dev] [PATCH 3/3] mesa: Throw an error when starting conditional render on an active query.

2011-09-08 Thread Eric Anholt
>From the NV_conditional_render spec: BeginQuery sets the active query object name for the query type given by to . If BeginQuery is called with an of zero, if the active query object name for is non-zero, if is the active query object name for any query type, or if is the ac

Re: [Mesa-dev] [RFC] [PATCH 2/2] i965: setup the edge flag enable bit in VE on SNB+

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 09:25:30PM -0700, Kenneth Graunke wrote: > On 09/08/2011 06:59 PM, Yuanhan Liu wrote: > > On Thu, Sep 08, 2011 at 08:39:46AM -0700, Eric Anholt wrote: > >> On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu > >> wrote: > >>> BTW, this patch fix the oglc pntrast fail on SNB(ha

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 09:12:44PM -0700, Kenneth Graunke wrote: > On 09/08/2011 07:56 PM, Yuanhan Liu wrote: > > There is already comments show how to detect a null texture. Fix the > > code to match the comments. > > > > This would fix the oglc divzero(basic.texQOrWEqualsZero) and > > divzero(ba

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #6 from Alexandre Demers 2011-09-08 22:13:10 PDT --- Review of attachment 50992: --> (https://bugs.freedesktop.org/review?bug=40729&attachment=50992) Need to replace "struct pipe_present_control ctrl;" by "struct native_present_con

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #5 from Alexandre Demers 2011-09-08 22:10:52 PDT --- OK, I think I got it working. You must have meant to replace "pipe" by "native" at line 1109. Doing this fixed your patch and allowed me to build without error. -- Configure bugm

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
On Fri, Sep 09, 2011 at 10:56:36AM +0800, Yuanhan Liu wrote: > There is already comments show how to detect a null texture. Fix the > code to match the comments. > > This would fix the oglc divzero(basic.texQOrWEqualsZero) and > divzero(basic.texTrivialPrim) test case fail. > > Signed-off-by: Yua

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #4 from Alexandre Demers 2011-09-08 22:03:17 PDT --- (In reply to comment #3) > (In reply to comment #2) > > src/dxgi_native.cpp: In member function ‘virtual HRESULT > > GalliumDXGISwapChain::Present(UINT, UINT)’: > > src/dxgi_native

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #3 from Chia-I Wu 2011-09-08 21:56:10 PDT --- (In reply to comment #2) > src/dxgi_native.cpp: In member function ‘virtual HRESULT > GalliumDXGISwapChain::Present(UINT, UINT)’: > src/dxgi_native.cpp:1109:31: error: aggregate > ‘Gallium

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #2 from Alexandre Demers 2011-09-08 21:41:56 PDT --- Not quite yet: g++ -c -I. -I../../../../../src/gallium/include -I../../../../../src/gallium/auxiliary -I../../../../../src/gallium/drivers -I../../../../../include -Iinclude -I../

Re: [Mesa-dev] [RFC] [PATCH 2/2] i965: setup the edge flag enable bit in VE on SNB+

2011-09-08 Thread Kenneth Graunke
On 09/08/2011 06:59 PM, Yuanhan Liu wrote: > On Thu, Sep 08, 2011 at 08:39:46AM -0700, Eric Anholt wrote: >> On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu >> wrote: >>> BTW, this patch fix the oglc pntrast fail on SNB(haven't tested it on >>> IVB yet). >> >> Could you include a piglit test for

[Mesa-dev] [PATCH] intel: Remove pointless boolean return value from *_miptree_layout.

2011-09-08 Thread Kenneth Graunke
i915_miptree_layout, i945_miptree_layout, and brw_miptree_layout always just return GL_TRUE, so there's really no point to it. Change them to void functions and remove the (dead) error checking code. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i915/i915_tex_layout.c|8 ++

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Kenneth Graunke
On 09/08/2011 07:56 PM, Yuanhan Liu wrote: > There is already comments show how to detect a null texture. Fix the > code to match the comments. > > This would fix the oglc divzero(basic.texQOrWEqualsZero) and > divzero(basic.texTrivialPrim) test case fail. > > Signed-off-by: Yuanhan Liu > --- >

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #1 from Chia-I Wu 2011-09-08 21:01:08 PDT --- Created an attachment (id=50992) View: https://bugs.freedesktop.org/attachment.cgi?id=50992 Review: https://bugs.freedesktop.org/review?bug=40729&attachment=50992 fix the build error Y

[Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
There is already comments show how to detect a null texture. Fix the code to match the comments. This would fix the oglc divzero(basic.texQOrWEqualsZero) and divzero(basic.texTrivialPrim) test case fail. Signed-off-by: Yuanhan Liu --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c |2 +- 1

Re: [Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 01:16:23PM -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/08/2011 03:16 AM, Yuanhan Liu wrote: > > If user call glTexImage1D with width = 0 and height = 0(the last > > level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart,

Re: [Mesa-dev] [PATCH] glsl: Clarify error message about whole-array assignment in GLSL 1.10.

2011-09-08 Thread Paul Berry
On 8 September 2011 18:06, Eric Anholt wrote: > On Thu, 08 Sep 2011 12:57:31 -0700, Ian Romanick > wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 09/07/2011 12:51 PM, Eric Anholt wrote: > > > Previously, it would produce: > > > > > > Failed to compile FS: 0:6(7): error:

Re: [Mesa-dev] [RFC] [PATCH 2/2] i965: setup the edge flag enable bit in VE on SNB+

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 08:39:46AM -0700, Eric Anholt wrote: > On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu > wrote: > > This patch is just for RFC, as I am not sure it's the right way to setup > > the edge flag enable bit in Vertex Element struture. Setting up this > > bit, according to Bspec

Re: [Mesa-dev] [PATCH] glsl: Clarify error message about whole-array assignment in GLSL 1.10.

2011-09-08 Thread Eric Anholt
On Thu, 08 Sep 2011 12:57:31 -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/07/2011 12:51 PM, Eric Anholt wrote: > > Previously, it would produce: > > > > Failed to compile FS: 0:6(7): error: non-lvalue in assignment > > > > and now it produces: > > > >

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 21:43, schrieb Ian Romanick: > On 09/08/2011 12:18 PM, Roland Scheidegger wrote: >> Am 08.09.2011 21:03, schrieb Roland Scheidegger: >>> Am 08.09.2011 19:53, schrieb Ian Romanick: On 09/06/2011 03:21 PM, Roland Scheidegger wrote: > Am 06.09.2011 22:13, schrieb Ian Romanick: >

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 23:13, schrieb Marek Olšák: > On Thu, Sep 8, 2011 at 9:03 PM, Roland Scheidegger wrote: >> Am 08.09.2011 19:53, schrieb Ian Romanick: >>> On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: > From: Ian Romanick > > Core Mesa

[Mesa-dev] [Bug 40729] New: d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 Summary: d3d1x build error: any interface changes lately? Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Severity: major Priority: medium

[Mesa-dev] [PATCH 3/3] i965/fs: Implement texelFetch() on Gen4.

2011-09-08 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_emit.cpp|5 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 15 +++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 2/3] i965/fs: Implement texelFetch() on Ivybridge.

2011-09-08 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index d413bc4..31a2297 10064

[Mesa-dev] [PATCH 1/3] i965/fs: Implement texelFetch() on Ironlake and Sandybridge.

2011-09-08 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h |2 ++ src/mesa/drivers/dri/i965/brw_fs.cpp |1 + src/mesa/drivers/dri/i965/brw_fs.h |1 + src/mesa/drivers/dri/i965/brw_fs_emit.cpp|4 src/mesa/drivers/dri/i965/brw_fs_visit

[Mesa-dev] [PATCH 0/3] i965 texelFetch/TXF support

2011-09-08 Thread Kenneth Graunke
These patches implement texelFetch/TXF via the "ld" sampler message on all i965 platforms. I've tested it on Broadwater, Cantiga, Sandybridge, and Ivybridge. Pretty sure I tested on Ironlake too, but a while ago. Piglit tests fs-texelFetch-2D and fs-texelFetchOffset-2D pass now. Huge thanks to D

Re: [Mesa-dev] New VS by default.

2011-09-08 Thread Kenneth Graunke
On 09/07/2011 01:03 PM, Eric Anholt wrote: > With the core GLSL fixups I just sent out plus this patch series, I > think it's ready to turn on by default. piglit is non-regressing, and > the oglconform I've tested is overall better (but not perfect), and I > think it will fix one actual bug report

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Marek Olšák
On Thu, Sep 8, 2011 at 9:03 PM, Roland Scheidegger wrote: > Am 08.09.2011 19:53, schrieb Ian Romanick: >> On 09/06/2011 03:21 PM, Roland Scheidegger wrote: >>> Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian Romanick Core Mesa already does the dispatch offset remapping for eve

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Eric Anholt
On Thu, 08 Sep 2011 20:13:45 +0200, Roland Scheidegger wrote: > Am 08.09.2011 19:59, schrieb Eric Anholt: > > On Thu, 08 Sep 2011 10:53:45 -0700, Ian Romanick > > wrote: > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> On 09/06/2011 03:21 PM, Roland Scheidegger wrote: > >>> EXT

Re: [Mesa-dev] New VS by default.

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/07/2011 01:03 PM, Eric Anholt wrote: > With the core GLSL fixups I just sent out plus this patch series, > I think it's ready to turn on by default. piglit is > non-regressing, and the oglconform I've tested is overall better > (but not perfect)

Re: [Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2011 03:16 AM, Yuanhan Liu wrote: > If user call glTexImage1D with width = 0 and height = 0(the last > level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart, > 0, 0, format, type, pixel) > > It would generate a SIGSEGV fault. As i9

Re: [Mesa-dev] [PATCH 12/20] intel: Silence "intel/intel_fbo.h:105:4: warning: comparison of unsigned expression < 0 is always false"

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:59:02 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > The test was of an enum, attIndex, which should be unsigned. The > explicit check for < 0 was replaced with a cast to unsigned in an > assertion that attIndex is less than the size of the array it will be > used

Re: [Mesa-dev] [PATCH 10/20] intel: Silence several "warning: unused parameter"

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:59:00 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > The internalFormat, format, and type parameters were not used by > either try_pbo_upload or try_pbo_zcopy, so remove them. The width > parameter was also not used by try_pbo_zcopy (because it doesn't > actually c

Re: [Mesa-dev] [PATCH 09/20] intel: Silence "warning: unused parameter ‘depth0’"

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:59 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > The depth0 parameter was not used in intel_miptree_create_for_region, > so remove it. All of the places that call this function, pass 1 for > that parameter, and the place where it looks like it should have been

Re: [Mesa-dev] [PATCH 08/20] intel: Silence "warning: unused parameter ‘target’"

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:58 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > The GLenum target parameter was not used in intel_copy_texsubimage, so > remove it. We should also stop having all 3 callers look up the internalFormat from the texImage->InternalFormat and pass it in. pgp5c7qs

Re: [Mesa-dev] [PATCH 06/20] intel: Silence "warning: unused parameter ‘fb’"

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:56 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > The gl_framebuffer was not used in intel_draw_buffer, so remove it. Reviewed-by: Eric Anholt pgpon7SjIctA3.pgp Description: PGP signature ___ mesa-dev mailing list m

Re: [Mesa-dev] [PATCH 04/20] intel: Silence several "warning: unused parameter"

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:54 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > --- > src/mesa/drivers/dri/intel/intel_buffer_objects.c | 47 > ++--- > 1 files changed, 31 insertions(+), 16 deletions(-) > > diff --git a/src/mesa/drivers/dri/intel/intel_buffer_objects.c >

Re: [Mesa-dev] [PATCH 03/20] intel: Silence many "intel_batchbuffer.h:97:39: warning: comparison between signed and unsigned integer expressions"

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:53 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > --- > src/mesa/drivers/dri/intel/intel_batchbuffer.h |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/drivers/dri/intel/intel_batchbuffer.h > b/src/mesa/drivers/dri/inte

Re: [Mesa-dev] [PATCH] glsl: Clarify error message about whole-array assignment in GLSL 1.10.

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/07/2011 12:51 PM, Eric Anholt wrote: > Previously, it would produce: > > Failed to compile FS: 0:6(7): error: non-lvalue in assignment > > and now it produces: > > Failed to compile FS: 0:5(7): error: whole array assignment is not > allowed i

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2011 12:18 PM, Roland Scheidegger wrote: > Am 08.09.2011 21:03, schrieb Roland Scheidegger: >> Am 08.09.2011 19:53, schrieb Ian Romanick: >>> On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: >>>

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 21:03, schrieb Roland Scheidegger: > Am 08.09.2011 19:53, schrieb Ian Romanick: >> On 09/06/2011 03:21 PM, Roland Scheidegger wrote: >>> Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian Romanick Core Mesa already does the dispatch offset remapping for every fu

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 19:53, schrieb Ian Romanick: > On 09/06/2011 03:21 PM, Roland Scheidegger wrote: >> Am 06.09.2011 22:13, schrieb Ian Romanick: >>> From: Ian Romanick >>> >>> Core Mesa already does the dispatch offset remapping for every >>> function that could possibly ever be supported. There's no

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 19:59, schrieb Eric Anholt: > On Thu, 08 Sep 2011 10:53:45 -0700, Ian Romanick wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 09/06/2011 03:21 PM, Roland Scheidegger wrote: >>> EXT_blend_equation_separate allows some unholy combinations which the >>> r200 (possib

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Eric Anholt
On Thu, 08 Sep 2011 10:53:45 -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/06/2011 03:21 PM, Roland Scheidegger wrote: > > EXT_blend_equation_separate allows some unholy combinations which the > > r200 (possibly other hw too) can't handle correctly. Namely

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/06/2011 03:21 PM, Roland Scheidegger wrote: > Am 06.09.2011 22:13, schrieb Ian Romanick: >> From: Ian Romanick >> >> Core Mesa already does the dispatch offset remapping for every >> function that could possibly ever be supported. There's no ne

Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 09:08, schrieb Marek Olšák: > 2011/9/7 Roland Scheidegger : >> That said I'm not really sure why pipe_sampler_view and pipe_surface >> actually have a context pointer in them, since they are only supposed to >> be used with the context in which they were created I think those >> shoul

Re: [Mesa-dev] [RFC] [PATCH 2/2] i965: setup the edge flag enable bit in VE on SNB+

2011-09-08 Thread Eric Anholt
On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu wrote: > This patch is just for RFC, as I am not sure it's the right way to setup > the edge flag enable bit in Vertex Element struture. Setting up this > bit, according to Bspec, need do: > 1. Edge flags are supported for the following primitives

[Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Yuanhan Liu
If user call glTexImage1D with width = 0 and height = 0(the last level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart, 0, 0, format, type, pixel) It would generate a SIGSEGV fault. As i945_miptree_layout_2d didn't handle this special case. More info are commented in line in this patch.

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:53 PM, Benjamin Franzke wrote: > 2011/9/8 Chia-I Wu : >> On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke >> wrote: >>> First thanks for taking this on. >>> >>> There are some things I'd like to have addtionally/differently: >>> >>> Supported shm formats are exposed via a

Re: [Mesa-dev] [PATCH 5/5] st/egl: add premultiplied alpha support to wayland

2011-09-08 Thread Benjamin Franzke
2011/9/8 Chia-I Wu : > On Thu, Sep 8, 2011 at 3:13 PM, Benjamin Franzke > wrote: >> 2011/9/8 Chia-I Wu : >>> From: Chia-I Wu >>> >>> Return true for NATIVE_PARAM_PREMULTIPLIED_ALPHA when all formats with >>> alpha support premultiplied alpha.  Currently, it means when argb32 and >>> argb32_pre ar

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Benjamin Franzke
2011/9/8 Chia-I Wu : > On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke > wrote: >> First thanks for taking this on. >> >> There are some things I'd like to have addtionally/differently: >> >> Supported shm formats are exposed via a "format" event as well >> (like the supported drm formats), so th

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:41 PM, Chia-I Wu wrote: > On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke > wrote: >> First thanks for taking this on. >> >> There are some things I'd like to have addtionally/differently: >> >> Supported shm formats are exposed via a "format" event as well >> (like the

Re: [Mesa-dev] [PATCH 5/5] st/egl: add premultiplied alpha support to wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:13 PM, Benjamin Franzke wrote: > 2011/9/8 Chia-I Wu : >> From: Chia-I Wu >> >> Return true for NATIVE_PARAM_PREMULTIPLIED_ALPHA when all formats with >> alpha support premultiplied alpha.  Currently, it means when argb32 and >> argb32_pre are both supported. >> --- >>  ..

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke wrote: > First thanks for taking this on. > > There are some things I'd like to have addtionally/differently: > > Supported shm formats are exposed via a "format" event as well > (like the supported drm formats), so the config creation logic is the

Re: [Mesa-dev] [PATCH 5/5] st/egl: add premultiplied alpha support to wayland

2011-09-08 Thread Benjamin Franzke
2011/9/8 Chia-I Wu : > From: Chia-I Wu > > Return true for NATIVE_PARAM_PREMULTIPLIED_ALPHA when all formats with > alpha support premultiplied alpha.  Currently, it means when argb32 and > argb32_pre are both supported. > --- >  .../state_trackers/egl/wayland/native_drm.c        |    8 ++-- >

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Benjamin Franzke
First thanks for taking this on. There are some things I'd like to have addtionally/differently: Supported shm formats are exposed via a "format" event as well (like the supported drm formats), so the config creation logic is the same for drm and shm, and I think it can remain in native_wayland.c

Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-08 Thread Marek Olšák
2011/9/7 Roland Scheidegger : > That said I'm not really sure why pipe_sampler_view and pipe_surface > actually have a context pointer in them, since they are only supposed to > be used with the context in which they were created I think those > shouldn't actually exist - surface_destroy and sample