On Mon, 29 Aug 2011 14:59:00 -0700, "Ian Romanick" <i...@freedesktop.org> wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > The internalFormat, format, and type parameters were not used by > either try_pbo_upload or try_pbo_zcopy, so remove them. The width > parameter was also not used by try_pbo_zcopy (because it doesn't > actually copy anything), so remove it too.
The current structure of this code is so hateful I can't bring myself to say anything about whether changing the current code is good or bad. I have a dream that one call would try to make a surface (miptree/region) out of the PBO, then we'd see about whether it matches up nicely and zero-copy/blit using that. That would be reusable for texsubimage, which is currently awful in this respect.
pgpYVaepyVNYb.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
