Re: [LyX/master] Add conversion routine for format 612.

2022-12-07 Thread Jean-Marc Lasgouttes
Le 05/12/2022 à 19:50, Richard Kimberly Heck a écrit : commit 4966da6864df0f53a12fe1453ce749452431df88 Author: Richard Kimberly Heck Date: Mon Dec 5 14:45:40 2022 -0500 Add conversion routine for format 612. I forgot that this is needed, because the new parameter is written to

Re: [LyX/master] C++11 compilation fix

2022-12-07 Thread Jean-Marc Lasgouttes
Le 06/12/2022 à 16:17, Jean-Marc Lasgouttes a écrit : commit f3f478c2fbcf89302ccadeb30aac413a40039d12 Author: Jean-Marc Lasgouttes Date: Tue Dec 6 17:12:45 2022 +0100 C++11 compilation fix for (iter = refs_.begin(); iter != refs_.end(); ++iter) { // first

Re: [LyX/master] C++11 compilation fix

2022-12-07 Thread Jean-Marc Lasgouttes
Le 07/12/2022 à 17:21, Richard Kimberly Heck a écrit : On 12/7/22 11:04, Jean-Marc Lasgouttes wrote: Le 06/12/2022 à 16:17, Jean-Marc Lasgouttes a écrit : commit f3f478c2fbcf89302ccadeb30aac413a40039d12 Author: Jean-Marc Lasgouttes Date:   Tue Dec 6 17:12:45 2022 +0100 C++11 compilation

Re: [LyX/master] Add conversion routine for format 612.

2022-12-07 Thread Jean-Marc Lasgouttes
Le 07/12/2022 à 17:19, Richard Kimberly Heck a écrit : I see a lot of   lyx2lyx warning: noprefix "false" in the console when loading files. Is this a forgotten debug message ? I was assuming that should be there, but perhaps it's not a problem if it isn't? Maybe we don't even need this conv

Re: [LyX/master] C++11 compilation fix

2022-12-07 Thread Jean-Marc Lasgouttes
Le 07/12/2022 à 17:44, Jürgen Spitzmüller a écrit : Am Mittwoch, dem 07.12.2022 um 17:04 +0100 schrieb Jean-Marc Lasgouttes: This elicited the answer "Huh?" from Jürgen, but sent to the lyx-cvs list, so only Riki and I saw it. Could I have a authoritative answer to the question

Re: [LyX/master] C++11 compilation fix

2022-12-07 Thread Jean-Marc Lasgouttes
Le 07/12/2022 à 18:29, Jürgen Spitzmüller a écrit : Am Mittwoch, dem 07.12.2022 um 18:15 +0100 schrieb Jean-Marc Lasgouttes: My comment that it is a C++11 thing is probably wrong. I did not check what level of standard allows QPair without specialization. This issue was the reason why std::pair

Re: Fwd: [Review requested] New DocBook layout parameter

2022-12-24 Thread Jean-Marc Lasgouttes
Le 22/12/2022 à 04:45, Thibaut Cuvelier a écrit : Dear list, To solve https://www.lyx.org/trac/ticket/12612 , I needed a new layout parameter for DocBook to generate some content based on paragraph labels. It draws heavily from LyXHTML code: makeEnvironm

Compilation failure with c++11 (string_view)

2023-01-03 Thread Jean-Marc Lasgouttes
With master, I cannot compile in c++11 mode: ../../master/src/mathed/InsetMathDecoration.cpp:191:22: error: ‘string_view’ has not been declared 191 | Attributes(bool o, string_view entity) | ^~~ Indeed, std::string_view is a c++17 thing. JMarc -- lyx-dev

Re: [LyX/master] Fix compilation problem

2023-01-05 Thread Jean-Marc Lasgouttes
Le 05/01/2023 à 05:10, Richard Kimberly Heck a écrit : The point of string_view is to avoid a copy here. Even with the use of const &, a copy has to be made of the original constant string, a const char *. Would it be OK to use instead: +        Attributes(bool o, const char * entity) ?? I th

Re: [LyX/master] Improve LaTeX version checking

2023-01-08 Thread Jean-Marc Lasgouttes
Le 19/12/2022 à 14:20, Juergen Spitzmueller a écrit : commit 029adfa28cedf921ee7ee4709422441705d93520 Author: Juergen Spitzmueller Date: Mon Dec 19 15:15:41 2022 +0100 Improve LaTeX version checking Instead of having to add and individually test the versions to check for

Re: [LyX/master] InsetIndex: make a condition more bullet-proof, a nullptr could be dereferenced.

2023-01-08 Thread Jean-Marc Lasgouttes
Le 08/01/2023 à 22:39, Richard Kimberly Heck a écrit : On 1/8/23 15:21, Thibaut Cuvelier wrote: commit 2d56c01dcfaf04744ab6d854af3965919cc07b82 Author: Thibaut Cuvelier Date:   Sun Jan 8 22:19:39 2023 +0100 InsetIndex: make a condition more bullet-proof, a nullptr could be dereferenced.

Re: LyX 1.0

2023-01-10 Thread Jean-Marc Lasgouttes
Le 10/01/2023 à 11:23, Patrick Dupre a écrit : Yes, I can share it. Not sure about the exact result ! Hi there, This LyX 1.0 file from Patrick is not readable with current versions. Experiments show that lyx2lyx first complains about a malformed file when converting to LyX 1.4. I do not kn

Re: Work around AMS book unicode issue?

2023-01-10 Thread Jean-Marc Lasgouttes
Le 10/01/2023 à 03:42, Scott Kostyshak a écrit : The attached patch works around an AMS book unicode issue, as discussed here: https://tex.stackexchange.com/questions/671116/how-to-find-and-fix-the-origin-of-invalid-unicode-character-generated-by-lyx Disadvantage of the workaround is the ad

Re: [LyX/master] Improve LaTeX version checking

2023-01-10 Thread Jean-Marc Lasgouttes
Le 08/01/2023 à 19:49, Jean-Marc Lasgouttes a écrit : For some reason (maybe because I am in C++11 mode) the eatLine() does not grab the potential second part of the line, but the package name in the next line. OK, ignore that. It turns out I had an old version of chkconfig.ltx in my ~/.lyx

Re: [LyX/master] Improve LaTeX version checking

2023-01-10 Thread Jean-Marc Lasgouttes
Le 10/01/2023 à 17:26, Jürgen Spitzmüller a écrit : Am Sonntag, dem 08.01.2023 um 19:49 +0100 schrieb Jean-Marc Lasgouttes: Is there a reason why we need that instead of comparing dates as string? Something like if (package_date >= "2015/09/01") { [...

Re: [LyX/master] Improve LaTeX version checking

2023-01-10 Thread Jean-Marc Lasgouttes
We have lexicographic ordering, right? https://en.cppreference.com/w/cpp/string/basic_string/operator_cmp How would we sort strings otherwise? JMarc Le 10 janvier 2023 18:34:15 GMT+01:00, "Jürgen Spitzmüller" a écrit : >Maybe I miss something obvious, but I thought strings can only be >compa

Re: Beta 2?

2023-01-10 Thread Jean-Marc Lasgouttes
Right. Something I will ask for soon is permission for upgrading included boost on devel and stable. It is not possible to build stable without lots of warnings these days. JMarc Le 10 janvier 2023 21:50:06 GMT+01:00, Richard Kimberly Heck a écrit : >Seem like a good time to do beta 2? > >R

Re: [LyX/master] Improve LaTeX version checking

2023-01-11 Thread Jean-Marc Lasgouttes
Le 10/01/2023 à 16:08, Jean-Marc Lasgouttes a écrit : Le 08/01/2023 à 19:49, Jean-Marc Lasgouttes a écrit : For some reason (maybe because I am in C++11 mode) the eatLine() does not grab the potential second part of the line, but the package name in the next line. OK, ignore that. It turns

Re: [LyX/master] Improve LaTeX version checking

2023-01-11 Thread Jean-Marc Lasgouttes
Le 11/01/2023 à 06:10, Jürgen Spitzmüller a écrit : Still, I think the current method is more convenient, since the day can almost always be omitted (ad we could even make the month optional, defaulting to 1 as well. As you prefer. I still think that using the explicit date in out code has the

Re: Beta 2 Tarballs

2023-01-12 Thread Jean-Marc Lasgouttes
Le 11/01/2023 à 19:44, Richard Kimberly Heck a écrit : Here:     http://ftp.lyx.org/pub/lyx/devel/lyx-2.4/ Please produce binaries. What git commit is this? Not a 2022-12-11 version as configure.ac says, I guess, but tagging it may be useful. JMarc -- lyx-devel mailing list lyx-devel@lis

Re: Unassigned buffer_ member in Inset::dispatch()

2023-01-13 Thread Jean-Marc Lasgouttes
Le 13/01/2023 à 17:18, Scott Kostyshak a écrit : I didn't have devel mode on. Would it make sense to add an assert? That will be helpful to figure out how to reproduce. I can add it locally, but is there a reason we don't have it added in the code? i.e., see attached patch. I would rather advi

Re: 2.3.7 GUI is mess on some debian system

2023-01-21 Thread Jean-Marc Lasgouttes
ursor is. The menus become unusable. Nevertheless also the characters and words in the file also appear, disappear and overlap. " We worked out with Stefano on the culprit and tracked it down to the commit: commit 8b6460e4f2d4040e3df41ef0abc70cbbe14ad875 Author: Jean-Marc Lasgouttes Date:  

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-01-26 Thread Jean-Marc Lasgouttes
Le 26/01/2023 à 02:05, Pavel Sanda a écrit : On Thu, Jan 26, 2023 at 01:23:55AM +0100, Pavel Sanda wrote: I can reproduce it only when not running under gdb. It also seem impossible to reproduce when compiling with debug symbols. Without them reproducibility seems to depends on the exact traje

Re: Another Crash with SIGSEGV signal on LyX-2.4.0-beta2 (macOS Ventura)

2023-01-28 Thread Jean-Marc Lasgouttes
Le 28/01/2023 à 03:49, 黃皇男 a écrit : To whom it may be concerned: Machine: Apple Macbook Air 15 Intel OS:Ventura 13.2 I think it happens when OS turn the dark into light mode Hello, Huang-Nan: The best solution to get answer is to send your message to lyx-devel@lists.lyx.org Others: pleas

Fwd: Crash with SIGSEGV signal on LyX-2.4.0-beta2

2023-01-28 Thread Jean-Marc Lasgouttes
Hi again, This is related to my previous message. Again, please keep Huang-Nan in the loop. JMarc Message transféré Sujet : Crash with SIGSEGV signal on LyX-2.4.0-beta2 Date : Fri, 27 Jan 2023 18:16:44 +0800 De :黃皇男 Pour : lyx-d...@lists.lyx.org To whom it

Re: 2.3.7 GUI is mess on some debian system

2023-01-28 Thread Jean-Marc Lasgouttes
Le 22/01/2023 à 03:36, Stefano Simonucci a écrit : What is your environment (Wayland/X11, Gnome/KDE/...)? X11 Mate Thanks, this was supposed to work, although I do not have any experience in Mate. What is the Qt version? stefano@debsim:~/prova/lyx$ dpkg --get-selections |  grep -e qt M

Re: 2.3.7 GUI is mess on some debian system

2023-01-29 Thread Jean-Marc Lasgouttes
Le 28/01/2023 à 19:53, Jean-Marc Lasgouttes a écrit : Le 22/01/2023 à 03:36, Stefano Simonucci a écrit : Do you use HiDPI on your system? I don't know. How I can know it? HiDPI is used for monitors with really high resolution, where text and UI would be too small. On plain Ubuntu,

Re: Translation with variables

2023-01-31 Thread Jean-Marc Lasgouttes
Le 31/01/2023 à 11:02, Daniel a écrit : How do I make a string with a variable translatable? Say in English I have "Press " + X + " to find." But for a translation to other languages it might not be sufficient to translate "Press " and " to find." and string them together in the same way as

Re: Work area scrolling from outliner

2023-01-31 Thread Jean-Marc Lasgouttes
Le 30/01/2023 à 10:41, Andrew Parsloe a écrit : LyX 2.4.0-beta2 on windows 10. I've attached a mwe. Load the mwe and reduce the height of the work area as in the screenshot. Click on Second in the outliner. The screen scrolls to display the heading Second in the work area. Now click on Third

Re: Modules excluded

2023-02-02 Thread Jean-Marc Lasgouttes
Le 02/02/2023 à 17:42, Daniel a écrit : If I understood it correctly, the case is: - Want to add: A - Already added: C, D - A depends on B - B excludes C - C depends on D LyX suggests: Add B and remove C? [Yes] [No] But probably it is the implementation that would be the issue. The problem i

Re: Modules excluded

2023-02-02 Thread Jean-Marc Lasgouttes
Le 02/02/2023 à 23:12, Daniel a écrit : The problem is when the depencies/exclusion graph contains furstrated loops. Something like - one has B, which provides feature "foo" - want to insert A, which requires C - C is incompatible with B - of course the solution is to install D instead of B, be

Re: Beta 2?

2023-02-05 Thread Jean-Marc Lasgouttes
Le 10/01/2023 à 22:52, Jean-Marc Lasgouttes a écrit : Right. Something I will ask for soon is permission for upgrading included boost on devel and stable. It is not possible to build stable without lots of warnings these days. So, I upgraded boost to 1.81 (latest) in master and 1.75 in

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-02-06 Thread Jean-Marc Lasgouttes
Le 06/02/2023 à 13:32, Pavel Sanda a écrit : Unfortunately valgrind changes speed of painting and I can't reproduce it then. But I am able to run it with any lyxer debug ouput or check potential patch if you have some idea... JMarc, do you have idea for a potential patch? P You are wise to pi

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-02-06 Thread Jean-Marc Lasgouttes
Le 06/02/2023 à 15:02, Jean-Marc Lasgouttes a écrit : Le 06/02/2023 à 13:32, Pavel Sanda a écrit : Unfortunately valgrind changes speed of painting and I can't reproduce it then. But I am able to run it with any lyxer debug ouput or check potential patch if you have some idea... JMar

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-02-06 Thread Jean-Marc Lasgouttes
Le 06/02/2023 à 15:50, Pavel Sanda a écrit : Indeed: insets/InsetInfo.cpp (1246): validate() -> build() lyx: SIGSEGV signal caught! What about this? I expect display glitches. JMarc diff --git a/src/insets/InsetInfo.cpp b/src/insets/InsetInfo.cpp index 46d656c817..f2d3b93ad8 100644 --- a/src/

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-02-06 Thread Jean-Marc Lasgouttes
Le 06/02/2023 à 16:46, Pavel Sanda a écrit : On Mon, Feb 06, 2023 at 04:34:07PM +0100, Jean-Marc Lasgouttes wrote: Le 06/02/2023 ?? 15:50, Pavel Sanda a écrit : Indeed: insets/InsetInfo.cpp (1246): validate() -> build() lyx: SIGSEGV signal caught! What about this? I expect display glitc

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-02-06 Thread Jean-Marc Lasgouttes
Le 06/02/2023 à 16:34, Jean-Marc Lasgouttes a écrit : Le 06/02/2023 à 15:50, Pavel Sanda a écrit : Indeed: insets/InsetInfo.cpp (1246): validate() -> build() lyx: SIGSEGV signal caught! What about this? I expect display glitches. I pushed it to master. JMarc -- lyx-devel mailing list

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-02-07 Thread Jean-Marc Lasgouttes
Le 07/02/2023 à 12:21, Pavel Sanda a écrit : The alternative to what I did would be to count "dirty" insets at global level and only draw when count is zero. However, it strikes me as fragile. We do not want to end up in a state where LyX does not display anything after some point, do we? For th

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-02-07 Thread Jean-Marc Lasgouttes
Le 06/02/2023 à 22:46, Pavel Sanda a écrit : Yes. When I load the file the insetinfo shows its information. After fraction of second editor/toolbar somewhat blinks (that's normal, I think its when previews are initially loaded/shown into the document view). At this moment it used to crash. Now it

Re: Line breaking on beta2

2023-02-12 Thread Jean-Marc Lasgouttes
Le 12/02/2023 à 10:36, Daniel a écrit : Oddly enough I cannot. It happened while I was working on a text. (And I checked a couple of times that there was no extra space inserted.) But I seem unable to reproduce it as well. Unfortunately, I don't know what kind of context is needed for it to hap

Re: Line breaking on beta2

2023-02-12 Thread Jean-Marc Lasgouttes
Le 12/02/2023 à 17:39, Daniel a écrit : Done at https://www.lyx.org/trac/ticket/12660. Thanks ! JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: QRegExp is deprecated in qt6

2023-02-12 Thread Jean-Marc Lasgouttes
Le 12/02/2023 à 21:08, Scott Kostyshak a écrit : Master branch I see. Indeed it seems there's still instances of it. I wonder if in earlier Qt 6 versions it was a warning so that is why it used to work? Is there a reason why we could not get rid of QRegExp now that Qt4 is gone? JMarc -- lyx

Re: QRegExp is deprecated in qt6

2023-02-13 Thread Jean-Marc Lasgouttes
Le 12/02/2023 à 22:04, Scott Kostyshak a écrit : On Sun, Feb 12, 2023 at 09:35:19PM +0100, Jean-Marc Lasgouttes wrote: Le 12/02/2023 à 21:08, Scott Kostyshak a écrit : Master branch I see. Indeed it seems there's still instances of it. I wonder if in earlier Qt 6 versions it was a warni

Re: QRegExp is deprecated in qt6

2023-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2023 à 11:58, Jean-Marc Lasgouttes a écrit : Le 12/02/2023 à 22:04, Scott Kostyshak a écrit : On Sun, Feb 12, 2023 at 09:35:19PM +0100, Jean-Marc Lasgouttes wrote: Le 12/02/2023 à 21:08, Scott Kostyshak a écrit : Master branch I see. Indeed it seems there's still instances of

Re: QRegExp is deprecated in qt6

2023-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2023 à 12:11, Jean-Marc Lasgouttes a écrit : This compiles fine, but I'd rather wait for Kornel, who is our local QRegExp expert. From what I have seen with a quick search, some changes are needed to make it compile, but mostly it is search and replace. I did not find war

Re: QRegExp is deprecated in qt6

2023-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2023 à 13:07, Kornel Benko a écrit : Am Mon, 13 Feb 2023 12:16:23 +0100 schrieb Jean-Marc Lasgouttes : Le 13/02/2023 à 12:11, Jean-Marc Lasgouttes a écrit : This compiles fine, but I'd rather wait for Kornel, who is our local QRegExp expert. From what I have seen with a

Re: QRegExp is deprecated in qt6

2023-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2023 à 14:47, Jean-Marc Lasgouttes a écrit : No problem. I changed already long time ago to use QRegularExpression only in lyxfind.cpp. Indeed! So we should get rid of QRegexp now. Riki, would that be OK? What I have in mind is that whatever bug with this newer code will be found

Re: QRegExp is deprecated in qt6

2023-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit : Riki, would that be OK? What I have in mind is that whatever bug with this newer code will be found earlier if more users are running it. Yes, fine with me. OK, thanks. I have been waiting to talk about next steps until we have some idea

Re: [LyX/master] French docs: remove unicode thin spaces

2023-02-19 Thread Jean-Marc Lasgouttes
Le 18/02/2023 à 21:40, Scott Kostyshak a écrit : commit 07a7e847d6d4af4b19d4daa5066b192cac2bc07f Author: Scott Kostyshak Date: Sat Feb 18 16:40:50 2023 -0500 French docs: remove unicode thin spaces This feels wrong. French typography does require these thin spaces. What should have be

Re: [LyX/master] French docs: remove unicode thin spaces

2023-02-19 Thread Jean-Marc Lasgouttes
Le 19/02/2023 à 17:31, Scott Kostyshak a écrit : On Sun, Feb 19, 2023 at 01:12:54PM +0100, Jean-Marc Lasgouttes wrote: Le 18/02/2023 à 21:40, Scott Kostyshak a écrit : commit 07a7e847d6d4af4b19d4daa5066b192cac2bc07f Author: Scott Kostyshak Date: Sat Feb 18 16:40:50 2023 -0500 French

Re: Editing cursor behind the inset (2.4)

2023-02-20 Thread Jean-Marc Lasgouttes
Le 19/02/2023 à 18:34, Pavel Sanda a écrit : On Sun, Feb 19, 2023 at 11:28:44AM -0500, Scott Kostyshak wrote: On Sun, Feb 19, 2023 at 04:52:04PM +0100, Pavel Sanda wrote: Hi, create new document in 2.4, insert note. The editing cursor stays pixel behind the actual inset and remains there as I

Re: Line breaking on beta2

2023-02-20 Thread Jean-Marc Lasgouttes
Le 16/02/2023 à 06:18, Andrew Parsloe a écrit : Perhaps it is the same phenomenon at work when a reference is followed immediately by a full stop, and the line breaks between the reference and full stop. See attached screenshot and file, where full stops start the second and last lines of the p

Re: [LyX/master] Remove space between button and text with inlines collapsible insets

2023-02-20 Thread Jean-Marc Lasgouttes
seems to intersect the border (the real position is that it's at the last position inside the "On Slide" inset). Indeed, cursor needed to be adapted. Is this patch OK for you ? JMarc From 6bf92c5edff747369f66cddbc6ecf8f26d114951 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasg

Re: QRegExp is deprecated in qt6

2023-02-20 Thread Jean-Marc Lasgouttes
library. Is it useful for anything beyond QRegExp? JMarcFrom 9393fa38ece8853aa2f277d33423fdafd555d69a Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Mon, 20 Feb 2023 17:38:59 +0100 Subject: [PATCH] Remove use of QregExp QRegexp has been replaced with QRegularExpression in Qt5. Now that we

Re: [LyX/master] Remove space between button and text with inlines collapsible insets

2023-02-20 Thread Jean-Marc Lasgouttes
Le 20/02/2023 à 17:53, Scott Kostyshak a écrit : On Mon, Feb 20, 2023 at 05:17:32PM +0100, Jean-Marc Lasgouttes wrote: Le 10/02/2023 à 05:24, Scott Kostyshak a écrit : Does cursor position need to be adapted for some reason? I attach two screenshots. "bad.png" is a screenshot with t

Re: [LyX/master] Remove space between button and text with inlines collapsible insets

2023-02-20 Thread Jean-Marc Lasgouttes
Le 20/02/2023 à 17:53, Scott Kostyshak a écrit : On Mon, Feb 20, 2023 at 05:17:32PM +0100, Jean-Marc Lasgouttes wrote: Le 10/02/2023 à 05:24, Scott Kostyshak a écrit : Does cursor position need to be adapted for some reason? I attach two screenshots. "bad.png" is a screenshot with t

Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Jean-Marc Lasgouttes
Le 21/02/2023 à 17:01, Scott Kostyshak a écrit : On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: commit 9bdc0dab31337fd6788d587127842eb3558881ae Author: Jean-Marc Lasgouttes Date: Wed Feb 20 12:01:44 2019 +0100 Honor Update::SinglePar properly The

Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Jean-Marc Lasgouttes
Le 21/02/2023 à 18:08, Scott Kostyshak a écrit : Could you put that to trac, so that I can track it? Done: https://www.lyx.org/trac/ticket/12674 I the set milestone to 2.4.0 since it's a regression, but it is a very minor issue and I don't imagine many at all will come across it and even if th

Re: [LyX/master] Remove space between button and text with inlines collapsible insets

2023-02-22 Thread Jean-Marc Lasgouttes
Le 16/02/2023 à 04:40, Scott Kostyshak a écrit : Another git bisect lead me here. When I open the attached file, the space between the two branch insets shortens if I move the cursor. Is it better now ? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listi

Re: Editing cursor behind the inset (2.4)

2023-02-22 Thread Jean-Marc Lasgouttes
Le 19/02/2023 à 16:52, Pavel Sanda a écrit : Hi, create new document in 2.4, insert note. The editing cursor stays pixel behind the actual inset and remains there as I continue writing. This should be fixed now. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/ma

Re: Unassigned buffer_ member in Inset::dispatch()

2023-02-28 Thread Jean-Marc Lasgouttes
Le 27 février 2023 19:31:55 GMT+01:00, Scott Kostyshak a écrit : >> Attached is an example file to reproduce with the following steps: >> >> 1. Select one of the fractions. >> 2. Type \omeqcolorC. >> 3. Press , . >> >> I get the following: >> >> Unassigned buffer_ member in Inset::dispatch()

Re: Unassigned buffer_ member in Inset::dispatch()

2023-03-01 Thread Jean-Marc Lasgouttes
Le 28 février 2023 21:00:44 GMT+01:00, Scott Kostyshak a écrit : >On Tue, Feb 28, 2023 at 10:20:24AM +0100, Jean-Marc Lasgouttes >> >Ping. Shall I make a trac ticket? >> > >> >Scott >> >> Yes please. > >Done here: https://www.lyx.org/trac/tick

Re: QRegExp is deprecated in qt6

2023-03-02 Thread Jean-Marc Lasgouttes
Le 20/02/2023 à 17:47, Jean-Marc Lasgouttes a écrit : Le 13/02/2023 à 21:29, Richard Kimberly Heck a écrit : Indeed! So we should get rid of QRegexp now. Riki, would that be OK? What I have in mind is that whatever bug with this newer code will be found earlier if more users are running it

Re: QRegExp is deprecated in qt6

2023-03-02 Thread Jean-Marc Lasgouttes
Le 02/03/2023 à 17:17, Scott Kostyshak a écrit : With CMake build I get /usr2/src/lyx/lyx-git/src/frontends/qt/GuiKeySymbol.cpp:28:10: fatal error: QTextCodec: No such file or directory 28 | #include | ^~~~ compilation terminated. if I remove the QtCore5Compat parts.

Re: QRegExp is deprecated in qt6

2023-03-02 Thread Jean-Marc Lasgouttes
Le 02/03/2023 à 23:10, Stephan Witt a écrit : Am 02.03.2023 um 22:44 schrieb Richard Kimberly Heck : On 3/2/23 12:29, Stephan Witt wrote: ATM, Qt6 is unusable on Mac because of bug 12641. :( Does this just mean you can't build with Qt6? Or is this a blocker for release? No, this means I c

Re: QRegExp is deprecated in qt6

2023-03-02 Thread Jean-Marc Lasgouttes
Le 02/03/2023 à 17:41, Jean-Marc Lasgouttes a écrit : Luckily it seems that GuiKeySymbol is the only code that uses QTextCodec. Luckily enough, the code in there is inside #if 0 ... #endif :) JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx

Re: QRegExp is deprecated in qt6

2023-03-03 Thread Jean-Marc Lasgouttes
Le 02/03/2023 à 23:32, Jean-Marc Lasgouttes a écrit : Le 02/03/2023 à 17:41, Jean-Marc Lasgouttes a écrit : Luckily it seems that GuiKeySymbol is the only code that uses QTextCodec. Luckily enough, the code in there is inside #if 0 ... #endif :) This is gone now. JMarc -- lyx-devel

Re: 2.4 Crash (was: Updated LaTeXConfig.lyx (bxjsclasses added))

2023-03-03 Thread Jean-Marc Lasgouttes
Le 03/03/2023 à 12:21, Pavel Sanda a écrit : I can confirm that both crashes seem to be gone with 00c39208ac65. Thanks for checking. Note that it just pretends to be fixed, the real issue is still lurking. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/

Re: QRegExp is deprecated in qt6

2023-03-03 Thread Jean-Marc Lasgouttes
Le 02/03/2023 à 15:57, Jean-Marc Lasgouttes a écrit : This patch removes all traces of QRegExp. It will obviously need testing, but this is already the code used with Qt6. Riki, is this OK to apply? No complaints -> I did it. I can revert if needed. Other special Qt6 code I would like

Re: QRegExp is deprecated in qt6

2023-03-05 Thread Jean-Marc Lasgouttes
Le 03/03/2023 à 19:56, Enrico Forestieri a écrit : Any reason for not doing it? Go for it. I have a doubt about this one. Are you sure that we do not care about fw? #if QT_VERSION < 0x06 const int fw = style()->pixelMetric(QStyle::PM_MenuPanelWidth, 0, this); layout_->set

Re: [LyX/master] When a displayed inset is aligned left, align it left

2023-03-06 Thread Jean-Marc Lasgouttes
Le 06/03/2023 à 12:02, José Matos a écrit : Previous disclaimer: What I am sending is not result of the change above but I it noticed because when updating the code src/TextMetrics.cpp had to compiled again. There I saw this warning that follows attached: warning: possibly dangling reference to

Re: Font translations

2023-03-07 Thread Jean-Marc Lasgouttes
Le 07/03/2023 à 14:44, Pavel Sanda a écrit : Hi, I am noticing that we have 100+ translation strings for font names. Should we burden our translators with this database which can't be translated in general? (Little to translate unless you push for partial translations of substrings like light/m

Re: [LyX/master] When a displayed inset is aligned left, align it left

2023-03-08 Thread Jean-Marc Lasgouttes
Le 08/03/2023 à 14:29, Pavel Sanda a écrit : So let's test the next week :) The alternative to reporting to gcc is using +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wdangling-reference" our_code_triggering_warning +#pragma GCC diagnostic pop Or use -Wno-dangling-referenc

Re: [LyX/master] When a displayed inset is aligned left, align it left

2023-03-08 Thread Jean-Marc Lasgouttes
Le 08/03/2023 à 18:48, Jean-Marc Lasgouttes a écrit : Le 08/03/2023 à 14:29, Pavel Sanda a écrit : So let's test the next week :) The alternative to reporting to gcc is using +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wdangling-reference"    our_code_tri

Re: Include Python3 in the Windows installer

2023-03-10 Thread Jean-Marc Lasgouttes
Le 10/03/2023 à 22:21, Yu Jin a écrit : all the win* imports from lyxpreview_tools.py fail, but those are in a try-except block What do we gain when they ar present? It might be important enough to warrant having those modules. prefs2prefs imports also fail, but looks like prefs2prefs.py is

Re: [LyX/master] Remove two remaining snippets from the QRegExp era.

2023-03-11 Thread Jean-Marc Lasgouttes
Le 11/03/2023 à 23:01, Scott Kostyshak a écrit : I see, so my system is not recommended but it seems this issue should be fixed for someone with Qt 5.6. I'll do that ASAP. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Remove two remaining snippets from the QRegExp era.

2023-03-12 Thread Jean-Marc Lasgouttes
Le 11/03/2023 à 23:14, Jean-Marc Lasgouttes a écrit : Le 11/03/2023 à 23:01, Scott Kostyshak a écrit : I see, so my system is not recommended but it seems this issue should be fixed for someone with Qt 5.6. I'll do that ASAP. Is it better now? JMarc -- lyx-devel mailing list lyx-

Re: [LyX/master] Remove two remaining snippets from the QRegExp era.

2023-03-12 Thread Jean-Marc Lasgouttes
Le 12/03/2023 à 14:49, Scott Kostyshak a écrit : On Sun, Mar 12, 2023 at 01:16:10PM +0100, Jean-Marc Lasgouttes wrote: Le 11/03/2023 à 23:14, Jean-Marc Lasgouttes a écrit : Le 11/03/2023 à 23:01, Scott Kostyshak a écrit : I see, so my system is not recommended but it seems this issue should

Re: Elipses

2023-03-15 Thread Jean-Marc Lasgouttes
Le 15/03/2023 à 04:42, Richard Kimberly Heck a écrit : Would it be worth adding 'special handling' for "..." the way we do "---"? Are there other things in this ballpark we could handle? If we go this way, we might want to make this configurable, as it is in math currently. A nice way to mak

Re: Elipses

2023-03-15 Thread Jean-Marc Lasgouttes
Le 15/03/2023 à 04:42, Richard Kimberly Heck a écrit : Would it be worth adding 'special handling' for "..." the way we do "---"? Are there other things in this ballpark we could handle? You question motivated me to improve the screen rendering of ellipsis. I did not use the unicode character

Re: Elipses

2023-03-15 Thread Jean-Marc Lasgouttes
Le 15/03/2023 à 18:22, Jürgen Spitzmüller a écrit : It is easy to insert an ellipsis via shortcut, isn't it? It was not usable with a french keyboard, but it is now :) JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Include ".vs" in gitignore?

2023-03-18 Thread Jean-Marc Lasgouttes
Le 18/03/2023 à 12:18, Yu Jin a écrit : Can we do that? Visual Studio always creates some files in the '.vs' subfolder when I open the repository with it. I guess we can. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Unicode characters in mathed

2023-04-01 Thread Jean-Marc Lasgouttes
Hello, A relative has been using LyX recently, and it is interesting to see how the use is different from what I would do. In particular, instead of typing \neq in mathed, why not copy and paste a ≠ from some PDF or HTML page? When doing this, two things happen : 1/ on screen, there is no s

Re: Unicode characters in mathed

2023-04-01 Thread Jean-Marc Lasgouttes
Le 01/04/2023 à 20:57, Scott Kostyshak a écrit : On Sat, Apr 01, 2023 at 03:09:58PM +0200, Jean-Marc Lasgouttes wrote: Would another possibility be to prompt the user? I'm not sure what a friendly prompt would be though since many LyX users do not know what unicode is. I could try to wo

Re: Unicode characters in mathed

2023-04-06 Thread Jean-Marc Lasgouttes
Le 03/04/2023 à 00:36, Enrico Forestieri a écrit : So how should I solve problem 1/ ? I see 3 solutions a/ replace ≠ with a \neq directly in the document at input time; we might not want to do that in case we eventually use unicode in math too b/ replace ≠ with a \neq on screen only c/ keep the

Re: Unicode characters in mathed

2023-04-13 Thread Jean-Marc Lasgouttes
Le 13/04/2023 à 16:29, Kornel Benko a écrit : Would be nice to have a list of these math-commands which can map to unicode. (Not all are in file unicodesymbols). This is important for advanced find too. And in lib/symbols ? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists

Re: Cursor in front of image half invisible

2023-04-13 Thread Jean-Marc Lasgouttes
t in front of the image) Is this patch better? Note that graphics insets margins are much tighter in 2.4 than 2.3; feel free to complain about it. JMarc From 6edae9dfd415493d4f3d49832a498933da474561 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Thu, 13 Apr 2023 23:44:53 +0200 Sub

Re: Cursor in front of image half invisible

2023-04-14 Thread Jean-Marc Lasgouttes
Le 14/04/2023 à 10:21, Pavel Sanda a écrit : It is better in the sense that it does not look outright buggy, but it still looks weird. When I added another +1 pixel is looks tight but OK-ish, +2 even better IMHO. Where do you add pixels? In left/right offset? One reason I had for making this

Re: Cursor in front of image half invisible

2023-04-27 Thread Jean-Marc Lasgouttes
Le 27/04/2023 à 17:54, Pavel Sanda a écrit : On Fri, Apr 14, 2023 at 10:43:31PM +0200, Pavel Sanda wrote: Is your proposal to have at least leftOffset == rightOffset == 2 ? I am proposing to have at least 2 pixels ahead of the graphics inset, not sure what that means in InsetGraphics.h languag

Re: What is missing for LyX 2.4?

2023-05-02 Thread Jean-Marc Lasgouttes
Le 02/05/2023 à 12:09, Pavel Sanda a écrit : Technically, what we need is to finish 1) sort out remaining bugs with 2.4 target in trac 2) review/ sort out TODOs in wiki https://wiki.lyx.org/Devel/LyX24Road 2) annouce string freeze to and ask translators to do their job What is the status of the

Re: Cursor in front of image half invisible

2023-05-02 Thread Jean-Marc Lasgouttes
Le 27/04/2023 à 19:53, Jean-Marc Lasgouttes a écrit : Go ahead. I'll create a special subclass of InsetGraphics for use with InsetInfo. done. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: What is missing for LyX 2.4?

2023-05-04 Thread Jean-Marc Lasgouttes
Le 04/05/2023 à 03:39, Richard Kimberly Heck a écrit : The big issue is the OSX shortcut bug, which I'm still not clear about. I don't think anything else is a must-have. This one can be solved for now by building with Qt5, right? Is there anything good enough on Qt6 for macOS that makes this

Re: What is missing for LyX 2.4?

2023-05-04 Thread Jean-Marc Lasgouttes
Le 02/05/2023 à 16:12, Pavel Sanda a écrit : One thing I'd like to do before release is to merge Text.cpp Text2.cpp and Text3.cpp into a single file. It is so annoying to try to guess in which file something is defined. Would somebody be against this ? I was wondering myself if we should merge

Re: OK to move Fullscreen preferences?

2023-05-05 Thread Jean-Marc Lasgouttes
Le 05/05/2023 à 18:12, Scott Kostyshak a écrit : Yuriy has a patch here: https://www.lyx.org/trac/ticket/12124#comment:2 Any objection? It's a bit weird that we have Editing > Control and then inside of that we have another "Editing" section and "Fullscreen" section. To me that's a signal

Re: New warning (or at least I only noticed it now)

2023-05-05 Thread Jean-Marc Lasgouttes
Le 21/11/2022 à 08:34, José Matos a écrit : Hi, I have been compiling and running 2.4 compiled with the latest preview of gcc 13. I got a new warning: "note: the temporary was destroyed at the end of the full expression" I managed to solve cleanly the ones related to Converter class at 3ae5

Re: OK to move Fullscreen preferences?

2023-05-05 Thread Jean-Marc Lasgouttes
Le 05/05/2023 à 19:26, Jean-Marc Lasgouttes a écrit : Le 05/05/2023 à 18:12, Scott Kostyshak a écrit : Yuriy has a patch here:    https://www.lyx.org/trac/ticket/12124#comment:2 Any objection? It's a bit weird that we have Editing > Control and then inside of that we have another

Re: Long string not ended by EndPreamble

2023-05-06 Thread Jean-Marc Lasgouttes
Le 06/05/2023 à 14:06, lorenzobertin...@gmail.com a écrit : Dear list, since at least a year I've been getting the following after validating a local layout in document preferences: Do you managed to find the particular code that causes issues? The way these long strings work is as follow: * t

Re: Long string not ended by EndPreamble

2023-05-06 Thread Jean-Marc Lasgouttes
Le 06/05/2023 à 21:30, Richard Kimberly Heck a écrit : I see the warning when opening Document> Settings. Still happens with some content in between, too. It seems to happen if there's nothing after the "EndPreamble". If I add just a comment, for example, it does away. Is the test !pimpl_->is

Re: New warning (or at least I only noticed it now)

2023-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/2023 à 03:14, Scott Kostyshak a écrit : I still think that these warning are more annoying than useful. I don't understand the underlying issues well enough. But in this case, shall we disable these instances with #pragma ? The other solution may be to declare first the argument as

Re: Size of document settings dialog

2023-05-08 Thread Jean-Marc Lasgouttes
Le 08/05/2023 à 17:26, Pavel Sanda a écrit : Hi, the document settings dialog quite grew in vertical size for 2.4 mainly due to the formats pane and I think we should shrink it back. Why is this called Formats and not Output, BTW? I also think that a subpanel Output Options, with TeX/XHTML/D

  1   2   3   4   5   6   7   8   9   10   >