Re: list of problems with the new InsetCommandparams

2007-10-15 Thread Richard Heck
Richard Heck wrote: Uwe Stöhr wrote: There are still two cases where InsetCommandParams crashes. I added them to http://wiki.lyx.org/Devel/RegressionListSVN Could you please have a look at them. Both are there since my Url -> Hyperlink patch but I can't figure out what the problem is as I onl

Re: list of problems with the new InsetCommandparams

2007-10-15 Thread Richard Heck
Uwe Stöhr wrote: There are still two cases where InsetCommandParams crashes. I added them to http://wiki.lyx.org/Devel/RegressionListSVN Could you please have a look at them. Both are there since my Url -> Hyperlink patch but I can't figure out what the problem is as I only renamed "url" to "

Re: list of problems with the new InsetCommandparams

2007-10-13 Thread Uwe Stöhr
Uwe Stöhr schrieb: There are still two cases where InsetCommandParams crashes. One has gone after a complete recompilation of my tree. regards Uwe

Re: list of problems with the new InsetCommandparams

2007-10-13 Thread Uwe Stöhr
There are still two cases where InsetCommandParams crashes. I added them to http://wiki.lyx.org/Devel/RegressionListSVN Could you please have a look at them. Both are there since my Url -> Hyperlink patch but I can't figure out what the problem is as I only renamed "url" to "href" in InsetComman

Re: list of problems with the new InsetCommandparams

2007-10-13 Thread Richard Heck
Uwe Stöhr wrote: - This entry in InsertUrl.cpp InsetUrl::InsetUrl(InsetCommandParams const & p) : InsetCommand(p, "url") {} leads to a crash in InsetCommandparams.cpp line 46. Because when the user uses the hyperlink checkbox in the URL-dialog, the inset Type has changed - what is correct a

list of problems with the new InsetCommandparams

2007-10-12 Thread Uwe Stöhr
- This entry in InsertUrl.cpp InsetUrl::InsetUrl(InsetCommandParams const & p) : InsetCommand(p, "url") {} leads to a crash in InsetCommandparams.cpp line 46. Because when the user uses the hyperlink checkbox in the URL-dialog, the inset Type has changed - what is correct and wanted.

Re: [patch] new InsetCommandParams

2006-11-06 Thread Georg Baum
Ozgur Ugras BARAN wrote: > On 11/4/06, Georg Baum >> I did some testing and changes and put it in. >> I discovered that the latest version of the nomencl package has a chnaged >> interface, therefore I used that instead of the old one. It is possible >> to support the old one, too, but I don't thi

Re: [patch] new InsetCommandParams

2006-11-06 Thread Ozgur Ugras BARAN
On 11/4/06, Georg Baum <[EMAIL PROTECTED]> wrote: Am Freitag, 3. November 2006 12:23 schrieb Ozgur Ugras BARAN: > Georg, I have updated your patch as you can see in the attachments. I > find this way easier. I think you will find it easier to review, too. > > The draft documentations is also atta

Re: [patch] new InsetCommandParams

2006-11-04 Thread Georg Baum
Am Freitag, 3. November 2006 12:23 schrieb Ozgur Ugras BARAN: > Georg, I have updated your patch as you can see in the attachments. I > find this way easier. I think you will find it easier to review, too. > > The draft documentations is also attached. I have written it > considering the new User

Re: [patch] new InsetCommandParams

2006-11-03 Thread José Matos
On Friday 03 November 2006 11:35 am, Ozgur Ugras BARAN wrote: > It is not that big. I will send the patch and you decide, whether it > can go in or not. If it can not go in, we can put it in trunk after > the release of 1.5. Thank you. -- José Abílio

Re: [patch] new InsetCommandParams

2006-11-03 Thread Ozgur Ugras BARAN
On 11/2/06, José Matos <[EMAIL PROTECTED]> wrote: On Thursday 02 November 2006 12:15 pm, Georg Baum wrote: > Ozgur Ugras BARAN wrote: > > > > Oh, this is bad news, since I have almost completed the multiple indices > > stuff.. Do you have the code? :-) Yes I do.. At least 80% of it :)) I can

Re: [patch] new InsetCommandParams

2006-11-03 Thread Ozgur Ugras BARAN
Georg, I have updated your patch as you can see in the attachments. I find this way easier. I think you will find it easier to review, too. The draft documentations is also attached. I have written it considering the new User Guide (UserGuideNV.lyx). Consider this as the section 5.8. And, don't

Re: [patch] new InsetCommandParams

2006-11-02 Thread José Matos
On Thursday 02 November 2006 12:15 pm, Georg Baum wrote: > Ozgur Ugras BARAN wrote: > > > > Oh, this is bad news, since I have almost completed the multiple indices > > stuff.. Do you have the code? :-) > You can be lucky that the nomencl stuff is allowed at all. I am following the spirit of

Re: [patch] new InsetCommandParams

2006-11-02 Thread Georg Baum
Ozgur Ugras BARAN wrote: > On 11/2/06, Georg Baum > <[EMAIL PROTECTED]> wrote: >> Shortly after you went on holiday a freeze was announced, and nothing new >> was allowed to go in. Fortunately Jose (the 1.5.0 release manager) agreed >> to put the nomencl stuff in. >> > > Oh, this is bad news, sin

Re: [patch] new InsetCommandParams

2006-11-02 Thread Ozgur Ugras BARAN
On 11/2/06, Georg Baum <[EMAIL PROTECTED]> wrote: Am Mittwoch, 1. November 2006 15:38 schrieb Ozgur Ugras BARAN: > By the way, I haven't seen nomencl commit in svn. Is something > missing, or do you need new diff? Shortly after you went on holiday a freeze was announced, and nothing new was allo

Re: [patch] new InsetCommandParams

2006-11-02 Thread Georg Baum
And the patch...Index: src/LyXAction.C === --- src/LyXAction.C (Revision 15688) +++ src/LyXAction.C (Arbeitskopie) @@ -366,6 +366,8 @@ void LyXAction::init() { LFUN_WINDOW_NEW, "window-new", NoBuffer }, { LFUN_WINDOW_CLOSE, "wind

Re: [patch] new InsetCommandParams

2006-11-02 Thread Georg Baum
Am Mittwoch, 1. November 2006 15:38 schrieb Ozgur Ugras BARAN: > By the way, I haven't seen nomencl commit in svn. Is something > missing, or do you need new diff? Shortly after you went on holiday a freeze was announced, and nothing new was allowed to go in. Fortunately Jose (the 1.5.0 release m

Re: [patch] new InsetCommandParams

2006-10-25 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> Thank you very much! (You must be watching the svn logs very Michael> very carefully.) Not very carefully, but I do look at all of them (especially to see what could be used in 1.4 too). JMarc

Re: [patch] new InsetCommandParams

2006-10-24 Thread Georg Baum
Am Dienstag, 24. Oktober 2006 16:15 schrieb Jean-Marc Lasgouttes: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> Can somebody add him to the credits stuff please? I don't know > Georg> how that works. > > I did it (also for the new Galician translator). Thanks. > Please ch

Re: [patch] new InsetCommandParams

2006-10-24 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: Also, Michael, you should not change CREDITS directly, but edit generate_contributions.py. I propagated your latest change. Thank you very much! (You must be watching the svn logs very very carefully.) Michael

Re: [patch] new InsetCommandParams

2006-10-24 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Can somebody add him to the credits stuff please? I don't know Georg> how that works. I did it (also for the new Galician translator). Please check that I did it right (I kind of guessed the alphabetic ordering). Also, Michael, you s

Re: [patch] new InsetCommandParams

2006-10-21 Thread Georg Baum
Am Donnerstag, 19. Oktober 2006 08:44 schrieb Ozgur Ugras BARAN: > The diff is already in the tgz file (x.diff). It contains necessary > makefile changes and also insetbase changes. > > Oh the licencing.. of course.. > > I hereby declare that, I grant permission for all my past and future > contr

Re: [patch] new InsetCommandParams

2006-10-20 Thread Ozgur Ugras BARAN
Stupid me, I forgot the file... :) Here it is. On 10/20/06, Ozgur Ugras BARAN <[EMAIL PROTECTED]> wrote: Here is the updated nomencl files. I will be away for the next week for holidays. Everybody enjoy Denmark.. Ugras nom.tgz Description: GNU Zip compressed data

Re: [patch] new InsetCommandParams

2006-10-20 Thread Ozgur Ugras BARAN
Here is the updated nomencl files. I will be away for the next week for holidays. Everybody enjoy Denmark.. Ugras

Re: [patch] new InsetCommandParams

2006-10-20 Thread Ozgur Ugras BARAN
OK.. here we go.. The diff is against rev 15393. I made a couple of updates after your commit. ugras On 10/20/06, Georg Baum <[EMAIL PROTECTED]> wrote: Am Freitag, 20. Oktober 2006 10:39 schrieben Sie: > Sure.. Is there something similar that I can put instead of > > lyx::from_utf8(Glib::locale

Re: [patch] new InsetCommandParams

2006-10-19 Thread Georg Baum
Ozgur Ugras BARAN wrote: > this diff removes most of the get/set command function calls from the > lyx code. I didn't touch cite stuff, as we decided. Thanks. Could you please rework the patch to use qstring_to_ucs4() instead of lyx::utf8_to_ucs4(fromqstr()) ? Georg

Re: [patch] new InsetCommandParams

2006-10-19 Thread Ozgur Ugras BARAN
this diff removes most of the get/set command function calls from the lyx code. I didn't touch cite stuff, as we decided. On 10/19/06, Ozgur Ugras BARAN <[EMAIL PROTECTED]> wrote: By the way, I am starting to cleanup of get/set options/contents stuff from Lyx code (excluding cite related files)

Re: [patch] new InsetCommandParams

2006-10-18 Thread Ozgur Ugras BARAN
By the way, I am starting to cleanup of get/set options/contents stuff from Lyx code (excluding cite related files). However, tomorrow I am going to holidays for a week. I will send you the patch as much as I can finish. I can do the rest as I return back form holidays. ugras

Re: [patch] new InsetCommandParams

2006-10-18 Thread Ozgur Ugras BARAN
The diff is already in the tgz file (x.diff). It contains necessary makefile changes and also insetbase changes. Oh the licencing.. of course.. I hereby declare that, I grant permission for all my past and future contributions to LyX project under the Gnu General Public Licence version 2 or late

Re: [patch] new InsetCommandParams

2006-10-18 Thread Georg Baum
Georg Baum wrote: > Ozgur Ugras BARAN wrote: > >> Here we go... >> >> I can't compile for gtk no more due to fontmetrics issues, therefore >> gtk frontend haven't been tested. I have tested it before the >> corresponding svn commit, and it was working. > > That is no problem. > > You forgot a

Re: [patch] new InsetCommandParams

2006-10-18 Thread Georg Baum
Ozgur Ugras BARAN wrote: > Here we go... > > I can't compile for gtk no more due to fontmetrics issues, therefore > gtk frontend haven't been tested. I have tested it before the > corresponding svn commit, and it was working. That is no problem. You forgot a diff of the makefiles and insetbase.

Re: [patch] new InsetCommandParams

2006-10-18 Thread Ozgur Ugras BARAN
Here we go... I can't compile for gtk no more due to fontmetrics issues, therefore gtk frontend haven't been tested. I have tested it before the corresponding svn commit, and it was working. Ugras On 10/17/06, Georg Baum <[EMAIL PROTECTED]> wrote: It is in now. Am Sonntag, 15. Oktober 2006 1

Re: [patch] new InsetCommandParams

2006-10-17 Thread Georg Baum
It is in now. Am Sonntag, 15. Oktober 2006 18:02 schrieb Georg Baum: > I have to check the parameter names of the cite commands, I believe that > some need to be swapped. That was not necessary. > The command parser in lyx2lyx has also to be > changed to something that understands nesting. I'

Re: [patch] new InsetCommandParams

2006-10-16 Thread Ozgur Ugras BARAN
On 10/16/06, Georg Baum <[EMAIL PROTECTED]> wrote: Ozgur Ugras BARAN wrote: > well, quite a diff.. > > Giving a unique name for each params is a good idea. I didn't dare to > touch getOptions() etc. functions since they are called everywhere. I > see that you are bold enough. :) Thanks for the p

Re: [patch] new InsetCommandParams

2006-10-16 Thread Georg Baum
Ozgur Ugras BARAN wrote: > well, quite a diff.. > > Giving a unique name for each params is a good idea. I didn't dare to > touch getOptions() etc. functions since they are called everywhere. I > see that you are bold enough. :) Thanks for the patch. I can > participate by getting rid of those ge

Re: [patch] new InsetCommandParams

2006-10-16 Thread Ozgur Ugras BARAN
(directWrite): ditto * src/insets/insetbibitem.C (InsetBibitem::read): Use InsetCommand::read * src/insets/insetref.C (InsetRef::latex): Use new InsetCommandParams interface * src/mathed/InsetMathHull.C (InsetMathHull::doDispatch): ditto * sr

[patch] new InsetCommandParams

2006-10-15 Thread Georg Baum
Adjust to InsetCommandParams changes * src/insets/insetbibitem.[Ch] (write): Remove, not needed anymore (directWrite): ditto * src/insets/insetbibitem.C (InsetBibitem::read): Use InsetCommand::read * src/insets/insetref.C (InsetRef::latex

Re: new insetcommandparams

2006-10-03 Thread Ozgur Ugras BARAN
On 10/2/06, Georg Baum <[EMAIL PROTECTED]> wrote: Ozgur Ugras BARAN wrote: > On 9/30/06, Georg Baum > <[EMAIL PROTECTED]> wrote: >> This is a specialization, but I think we should keep it generic and >> simple. InsetCommandParams would just store a number of parameters, and >> the LaTeX command

Re: new insetcommandparams

2006-10-02 Thread Georg Baum
Ozgur Ugras BARAN wrote: > On 9/30/06, Georg Baum > <[EMAIL PROTECTED]> wrote: >> This is a specialization, but I think we should keep it generic and >> simple. InsetCommandParams would just store a number of parameters, and >> the LaTeX command generated from then would simply be >> \command{para

Re: new insetcommandparams

2006-10-02 Thread Ozgur Ugras BARAN
On 9/30/06, Georg Baum <[EMAIL PROTECTED]> wrote: Am Freitag, 29. September 2006 10:01 schrieb Ozgur Ugras BARAN: > Thanks a lot for reviewing the code. I will be more careful about > formatting. Here are some some answers: > > - What I mean with the nested command support is something like: >

Re: new insetcommandparams

2006-10-02 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> - Indeed implementing map was easier than implementing the >> multimap. But I couldn't imagine if a parameter can apply multiple >> times or not. Then I tried to stay in the safe side. Speculating >> again, take the index command.. An inde

Re: new insetcommandparams

2006-09-30 Thread Georg Baum
Am Freitag, 29. September 2006 10:01 schrieb Ozgur Ugras BARAN: > Thanks a lot for reviewing the code. I will be more careful about > formatting. Here are some some answers: > > - What I mean with the nested command support is something like: > \command {\command{content}} > An example i

Re: new insetcommandparams

2006-09-29 Thread Ozgur Ugras BARAN
Thanks a lot for reviewing the code. I will be more careful about formatting. Here are some some answers: - What I mean with the nested command support is something like: \command {\command{content}} An example is basic index command : \index { entry @{\myformat {entry}} }. I see that thi

Re: new insetcommandparams

2006-09-28 Thread Georg Baum
Oops, I forgot the changed files. Here they are. Georg /** * \file insetcommandparams.C * This file is part of LyX, the document processor. * Licence details can be found in the file COPYING. * * \author Angus Leeming * * Full author contact details are available in file CREDITS. */ #inc

Re: new insetcommandparams

2006-09-28 Thread Georg Baum
> After the development, the scanCommand() becomes obsolete. However, > insetBibitem uses scan command directly. Therefore, I will keep it > there until the development approved. Then I can update insetBibitem > to use new insetcommandparams. > > Well.. I hope what I have done here compli

new insetcommandparams

2006-09-27 Thread Ozgur Ugras BARAN
ested command support, since it would be much easier when we migrate to the XML format. After the development, the scanCommand() becomes obsolete. However, insetBibitem uses scan command directly. Therefore, I will keep it there until the development approved. Then I can update insetBibitem to us