Re: #11317: Allow easier keyboard use of citation dialog

2018-09-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.09.2018, 18:04 +0100 schrieb David Hugh-Jones: > Usually, hitting return presses OK, but not in this case. Hitting > return adds a citation, when one is selected. One solution (not > necessarily the right one) would be to make hitting return press OK > when a citation is not sele

Re: #11317: Allow easier keyboard use of citation dialog

2018-09-28 Thread David Hugh-Jones
Usually, hitting return presses OK, but not in this case. Hitting return adds a citation, when one is selected. One solution (not necessarily the right one) would be to make hitting return press OK when a citation is not selected.

Re: #11317: Allow easier keyboard use of citation dialog

2018-09-28 Thread David Hugh-Jones
Sorry. The Alt + O + enter keyboard shortcut doesn't select and press the "OK" button. There may be another way to do this, but I have tried and haven't found it. Forms on the Mac aren't always as keyboard-friendly as they might be, is my impression.

Re: #11317: Allow easier keyboard use of citation dialog

2018-09-28 Thread David Hugh-Jones
Sounds OK... I didn’t discover that though, in several years! -- Sent from Gmail Mobile

Re: [LyX/master] Filter in citation dialog is not respected when reloading databaze.

2018-03-01 Thread Richard Heck
On 03/01/2018 06:52 PM, Pavel Sanda wrote: > Pavel Sanda wrote: >> commit 3cb271cedad2e75c8f8e1860119d6b326d90c186 >> Author: Pavel Sanda >> Date: Fri Mar 2 00:49:15 2018 +0100 >> >> Filter in citation dialog is not respected when reloading datab

Re: [LyX/master] Filter in citation dialog is not respected when reloading databaze.

2018-03-01 Thread Pavel Sanda
Pavel Sanda wrote: > commit 3cb271cedad2e75c8f8e1860119d6b326d90c186 > Author: Pavel Sanda > Date: Fri Mar 2 00:49:15 2018 +0100 > > Filter in citation dialog is not respected when reloading databaze. > --- > src/frontends/qt4/GuiCitation.cpp |1 + > 1 fil

Re: Whitespacing in listing of citation dialog (master)

2017-10-11 Thread Richard Heck
On 10/11/2017 11:33 AM, Pavel Sanda wrote: > Jürgen Spitzmüller wrote: >> Can you post a screenshot? It is larger, since it's a different widget >> (QTableView vs. QListView), but not twice as big. See attached screenshot. >> >> The reason is that for biblatex, we need additional columns in the rig

Re: Whitespacing in listing of citation dialog (master)

2017-10-11 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Can you post a screenshot? It is larger, since it's a different widget > (QTableView vs. QListView), but not twice as big. See attached screenshot. > > The reason is that for biblatex, we need additional columns in the right > widget in order to enter and edit per-item

Re: Whitespacing in listing of citation dialog (master)

2017-10-11 Thread Jürgen Spitzmüller
2017-10-11 16:45 GMT+02:00 Pavel Sanda : > Hi, > > what I see in the current master is that the item height in left list of > available citations has (normal) height of about the text size while the > size > of item in the right list of selected citations is twice as big with huge > whitespacing a

Whitespacing in listing of citation dialog (master)

2017-10-11 Thread Pavel Sanda
Hi, what I see in the current master is that the item height in left list of available citations has (normal) height of about the text size while the size of item in the right list of selected citations is twice as big with huge whitespacing around the text. Is this intention or bug? Pavel

Re: Insert Citation Dialog Kudos

2017-05-25 Thread Jürgen Spitzmüller
Am Donnerstag, den 25.05.2017, 21:58 -0600 schrieb Joel Kulesza: > After some time working with it, my thanks to Jürgen for reworking > the Insert -> Citation dialog. I find this **much** more pleasant to > use than previously. Thank you. Glad to hear that. Jürgen > > - J

Insert Citation Dialog Kudos

2017-05-25 Thread Joel Kulesza
After some time working with it, my thanks to Jürgen for reworking the Insert -> Citation dialog. I find this **much** more pleasant to use than previously. - Joel

Re: [LyX/master] Citation dialog redesign

2016-11-25 Thread Scott Kostyshak
On Fri, Nov 25, 2016 at 10:34:45PM +0100, Guillaume Munch wrote: > Le 25/11/2016 à 21:04, Scott Kostyshak a écrit : > > I think that "Search as you type" should be default because (1) this is > > consistent with similar dialogs such as the cross-reference dialog and > > the search in LyX preference

Re: [LyX/master] Citation dialog redesign

2016-11-25 Thread Guillaume Munch
Le 25/11/2016 à 21:04, Scott Kostyshak a écrit : I think that "Search as you type" should be default because (1) this is consistent with similar dialogs such as the cross-reference dialog and the search in LyX preferences/document settings and (2) there is no "search" button as there was in the p

Re: [LyX/master] Citation dialog redesign

2016-11-25 Thread Scott Kostyshak
On Fri, Sep 16, 2016 at 09:21:19AM +0200, Juergen Spitzmueller wrote: > commit 824e24ca60c511e48d94b039ef3a04163b847d3a > Author: Juergen Spitzmueller > Date: Fri Sep 16 09:21:04 2016 +0200 > > Citation dialog redesign I am liking this new design! One comment: I think that

Re: lyx crashes in citation dialog

2011-01-28 Thread Edwin Leuven
Leuven wrote: > i'll rebuild my tree... and still crashing...

Re: lyx crashes in citation dialog

2011-01-28 Thread Edwin Leuven
On Fri, Jan 28, 2011 at 12:31, Pavel Sanda wrote: > not here. maybe specific recipy? not really, i use natbib and a bibtex file. then i just enter the beginning of a key i am looking for in the search box, hit enter and get the crash with this message: Exception: regular expression error i'll r

Re: lyx crashes in citation dialog

2011-01-28 Thread Pavel Sanda
Edwin Leuven wrote: > when i type something in the search box and hit enter not here. maybe specific recipy? p

Re: lyx crashes in citation dialog

2011-01-28 Thread Vincent van Ravesteijn
Op 28-1-2011 12:19, Edwin Leuven schreef: when i type something in the search box and hit enter am i alone? ed. Yes, you are. Vincent

lyx crashes in citation dialog

2011-01-28 Thread Edwin Leuven
when i type something in the search box and hit enter am i alone? ed.

Re: [PATCH] Citation Dialog Fixes

2009-12-06 Thread Pavel Sanda
Richard Heck wrote: > Sorry. Here's the whole file. i resave it in 4.4 designer and commited, check it work for you. pavel

Re: [PATCH] Citation Dialog Fixes

2009-12-05 Thread Richard Heck
On 12/05/2009 06:14 PM, Pavel Sanda wrote: Richard Heck wrote: Can somebody check the following, for trunk, and let me know if it compiles with whatever minimum Qt version we use? If so, actually, and it looks OK then just commit it, too. The idea here is to make the citation dialog small

Re: [PATCH] Citation Dialog Fixes

2009-12-05 Thread Pavel Sanda
Richard Heck wrote: > > Can somebody check the following, for trunk, and let me know if it compiles > with whatever minimum Qt version we use? If so, actually, and it looks OK > then just commit it, too. The idea here is to make the citation dialog > small enough to fit on

[PATCH] Citation Dialog Fixes

2009-12-05 Thread Richard Heck
Can somebody check the following, for trunk, and let me know if it compiles with whatever minimum Qt version we use? If so, actually, and it looks OK then just commit it, too. The idea here is to make the citation dialog small enough to fit on an 800px height screen, such as on my Eee 1000

Re: the citation dialog

2008-04-29 Thread Juergen Spitzmueller
Edwin Leuven wrote: > wasn't referring to the preview window either ;) but rather the > available/selected boxes... These could be shrinked with the same hack, if everything else fails. I'd prefer a proper solution, though. Jürgen

Re: the citation dialog

2008-04-29 Thread Edwin Leuven
Juergen Spitzmueller wrote: I forced the preview window to be smaller, which was a bit difficult (I needed some hardcoding). wasn't referring to the preview window either ;) but rather the available/selected boxes... Feel free to jump in. i might once my longtable headache is over...

Re: the citation dialog

2008-04-29 Thread rgheck
Abdelrazak Younes wrote: Leuven, E. wrote: seems to have grown lately. perhaps someone can put it on a diet? Here is some suggestion: - the preview dialog does not have to be so big by default. I know, there are some items with abstract etc, but a vertical scrollbar will be sufficient for t

Re: the citation dialog

2008-04-29 Thread Juergen Spitzmueller
Edwin Leuven wrote: > wasn't referring to the new line, but rather that the listviews seem too > big... I forced the preview window to be smaller, which was a bit difficult (I needed some hardcoding). Feel free to jump in. Jürgen

Re: the citation dialog

2008-04-29 Thread Andre Poenitz
On Tue, Apr 29, 2008 at 02:54:29PM +0200, Leuven, E. wrote: > seems to have grown lately. perhaps someone can put it on a diet? > > as an aside: do we need something like the attached since the > selection manager is created without a parent? Otherwise it would leak. But passing a QObject parent

Re: the citation dialog

2008-04-29 Thread Abdelrazak Younes
Leuven, E. wrote: seems to have grown lately. perhaps someone can put it on a diet? Here is some suggestion: - the preview dialog does not have to be so big by default. I know, there are some items with abstract etc, but a vertical scrollbar will be sufficient for those. - it would be nice i

Re: the citation dialog

2008-04-29 Thread Edwin Leuven
rgheck wrote: Leuven, E. wrote: seems to have grown lately. perhaps someone can put it on a diet? It got a new line, because of the need to disable "Search as You Type", at least selectively. Then Jurgen re-organized it a bit. But of course you can re-organize it, too. ;-) wasn't referring

Re: the citation dialog

2008-04-29 Thread rgheck
Leuven, E. wrote: seems to have grown lately. perhaps someone can put it on a diet? It got a new line, because of the need to disable "Search as You Type", at least selectively. Then Jurgen re-organized it a bit. But of course you can re-organize it, too. ;-) as an aside: do we need somethi

the citation dialog

2008-04-29 Thread Leuven, E.
seems to have grown lately. perhaps someone can put it on a diet? as an aside: do we need something like the attached since the selection manager is created without a parent? Index: src/frontends/qt4/GuiCitation.cpp === --- src/fro

Re: [PATCH] Citation Dialog Broken in Trunk

2007-09-13 Thread Andre Poenitz
On Fri, Sep 14, 2007 at 02:08:10AM -0400, Richard Heck wrote: > > This seems to solve the problem. I'll commit if there's no objection. > > By the way, there's a lot of mismatch now between filenames and > classnames. E.g., the class defined in GuiCitation.cpp is > GuiCitationDialog. Which way

[PATCH] Citation Dialog Broken in Trunk

2007-09-13 Thread Richard Heck
This seems to solve the problem. I'll commit if there's no objection. By the way, there's a lot of mismatch now between filenames and classnames. E.g., the class defined in GuiCitation.cpp is GuiCitationDialog. Which way should this be resolved? Richard -- ==

Re: Citation Dialog Broken in Trunk

2007-09-13 Thread Richard Heck
Richard Heck wrote: As said. I have some idea what's wrong here, but it may be a more general problem, so someone else should have a look. Open the citation dialog. Nothing's there! Now hit restore, and it's all there. The problem is that nothing is calling Gu

Citation Dialog Broken in Trunk

2007-09-13 Thread Richard Heck
As said. I have some idea what's wrong here, but it may be a more general problem, so someone else should have a look. Open the citation dialog. Nothing's there! Now hit restore, and it's all there. The problem is that nothing is calling GuiCitationDialog::initialiseParams(

Re: [PATCH] Bug 4121: Citation dialog bug

2007-08-13 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: This addresses some bugs involving the mouse in the citation dialog. One was reported as 4121; the other is one I've seen, where clicking in the left pane causes a multi-element selection. This is because the selection model is being rese

Re: [PATCH] Bug 4121: Citation dialog bug

2007-08-13 Thread Abdelrazak Younes
Richard Heck wrote: This addresses some bugs involving the mouse in the citation dialog. One was reported as 4121; the other is one I've seen, where clicking in the left pane causes a multi-element selection. This is because the selection model is being reset too often. Could you elab

Re: [PATCH] Bug 4121: Citation dialog bug

2007-08-13 Thread Richard Heck
Anyone? Richard Heck wrote: This addresses some bugs involving the mouse in the citation dialog. One was reported as 4121; the other is one I've seen, where clicking in the left pane causes a multi-element selection. This is because the selection model is being reset too often.

[PATCH] Bug 4121: Citation dialog bug

2007-08-13 Thread Richard Heck
This addresses some bugs involving the mouse in the citation dialog. One was reported as 4121; the other is one I've seen, where clicking in the left pane causes a multi-element selection. OK to commit? Richard -- == Rich

Re: [PATCH-FINAL-really] Bugs 3741 and 3756: Citation Dialog Bugs

2007-06-01 Thread José Matos
On Friday 01 June 2007 16:47:19 Richard Heck wrote: > Now seeking to commit. OK. > Richard -- José Abílio

[PATCH-FINAL-really] Bugs 3741 and 3756: Citation Dialog Bugs

2007-06-01 Thread Richard Heck
Wrong diff The attached patch addresses these bugs http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 in a way that is compatible with earlier discussion with Abdel and now with some improvements due to Lars and Andre. Here's what it does:

[PATCH-FINAL] Bugs 3741 and 3756: Citation Dialog Bugs

2007-06-01 Thread Richard Heck
The attached patch addresses these bugs http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 in a way that is compatible with earlier discussion with Abdel and now with some improvements due to Lars and Andre. Here's what it does: * In the "Availab

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, May 31, 2007 at 10:08:18PM +0200, Lars Gullik Bjønnes wrote: | > Richard Heck <[EMAIL PROTECTED]> writes: | > | > | Andre Poenitz wrote: | > | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: | > | > | > | >>> I tried to do someth

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 10:08:18PM +0200, Lars Gullik Bjønnes wrote: > Richard Heck <[EMAIL PROTECTED]> writes: > > | Andre Poenitz wrote: > | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > | > > | >>> I tried to do something like this so I didn't have the same code in two > | >

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 04:02:42PM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > > > >>>I tried to do something like this so I didn't have the same code in two > >>>places: > >>>QModelIndex & QCitationDialog::getSelectedIndex(

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 04:01:32PM -0400, Richard Heck wrote: > Peter Kümmel wrote: > >Richard Heck wrote: > > > >>I tried to do something like this so I didn't have the same code in two > >>places: > >>QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { > >> QModelIndexList const sel

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Lars Gullik Bjønnes
Richard Heck <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: | > | >>> I tried to do something like this so I didn't have the same code in two | >>> places: | >>> QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { | >

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Andre Poenitz wrote: On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: I tried to do something like this so I didn't have the same code in two places: QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { QModelIndexList const selIdx = availableLV->selectionMode

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Peter Kümmel wrote: Richard Heck wrote: I tried to do something like this so I didn't have the same code in two places: QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { QModelIndexList const selIdx = availableLV->selectionModel()->selectedIndexes(); if (selIdx.em

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > > I tried to do something like this so I didn't have the same code in two > > places: > > QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { > > QModelIndexList const selIdx = > > availableLV->selectionModel()->se

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Peter Kümmel
Richard Heck wrote: > > Still seeking comment on this patch, or permission to commit. > > = > > The attached patch addresses these bugs > http://bugzilla.lyx.org/show_bug.cgi?id=3741 > http://bugzilla.lyx.org/show_bug.cgi?id=3756 > in a way that is compatible with earlier discussion with A

[PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Still seeking comment on this patch, or permission to commit. = The attached patch addresses these bugs http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 in a way that is compatible with earlier discussion with Abdel. Here's what it does: * In

Re: [PATCH] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 06:07:50PM -0400, Richard Heck wrote: > Andre Poenitz wrote: > > On Wed, May 30, 2007 at 03:59:15PM -0400, Richard Heck wrote: > > > >> + if (obj == availableLV) { > >> + if (event->type() != QEvent::KeyPress) > >> + return QObject::eventFilter(

Re: [PATCH] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-30 Thread Richard Heck
Andre Poenitz wrote: > On Wed, May 30, 2007 at 03:59:15PM -0400, Richard Heck wrote: > >> +if (obj == availableLV) { >> +if (event->type() != QEvent::KeyPress) >> +return QObject::eventFilter(obj, event); >> +QKeyEvent * keyEvent = static_cast(even

Re: [PATCH] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 03:59:15PM -0400, Richard Heck wrote: > + if (obj == availableLV) { > + if (event->type() != QEvent::KeyPress) > + return QObject::eventFilter(obj, event); > + QKeyEvent * keyEvent = static_cast(event); > + int cons

[PATCH] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-30 Thread Richard Heck
The attached patch addresses these bugs http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 in a way that is compatible with earlier discussion with Abdel. Here's what it does: * In the "Available" list, double clicking or hitting Enter adds the ci

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-29 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: Not OK from me for 3756. I prefer to have the "double-click" bug provided that I still have the "Enter" feature. Maybe it is possible to distinguish between the two action though... I'll have a look at this. The behavior you desc

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-29 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >>> Not OK from me for 3756. I prefer to have the "double-click" bug >>> provided that I still have the "Enter" feature. Maybe it is possible >>> to distinguish between the two action though... >> I'll have a look at this. The behavior you describe mak

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-29 Thread Richard Heck
Roger Mc Murtrie wrote: > Abdelrazak Younes wrote: >> Richard Heck wrote: >>> How double-clicking behaves shouldn't depend upon whether >>> something's already in the selected citations box. >> I "implemented" this bug because I wanted to be able to insert a >> Citation with the keyboard only (hitt

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-29 Thread Roger Mc Murtrie
Abdelrazak Younes wrote: Richard Heck wrote: This patch addresses these bugs: http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 The latter is more a policy question, but the bug report seems right to me: How double-clicking behaves shouldn't depend up

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-28 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: This patch addresses these bugs: http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 The latter is more a policy question, but the bug report seems right to me: How double-clicking behaves sho

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-28 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> This patch addresses these bugs: >> http://bugzilla.lyx.org/show_bug.cgi?id=3741 >> http://bugzilla.lyx.org/show_bug.cgi?id=3756 >> The latter is more a policy question, but the bug report seems right to >> me: How double-clicking behaves shouldn't

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-28 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Richard Heck wrote: This patch addresses these bugs: http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 The latter is more a policy question, but the bug report seems right to me: How double-clicking behaves shouldn't depend upon wh

Re: [PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-28 Thread Abdelrazak Younes
Richard Heck wrote: This patch addresses these bugs: http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 The latter is more a policy question, but the bug report seems right to me: How double-clicking behaves shouldn't depend upon whether something's already

[PATCH] Bugs 3741 and 3756: Minor Citation Dialog Bugs

2007-05-28 Thread Richard Heck
This patch addresses these bugs: http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 The latter is more a policy question, but the bug report seems right to me: How double-clicking behaves shouldn't depend upon whether something's already in the selected citati

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-22 Thread Richard Heck
José Matos wrote: > On Saturday 21 April 2007 11:30:40 am Michael Gerz wrote: > >> Has this been fixed in the meantime? Maybe I missed an svn commit... >> > No. I asked Richard to wait for beta-2 release, the patch will go after. > > At least that is my understanding. :-) > Yes, and

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-21 Thread Bernhard Roider
i was off for a week... Richard Heck wrote: This turns out not to matter, as entryDelim must be a leftover from some previous code: ... this is correct indeed. Bernhard Richard Abdelrazak Younes wrote: Richard Heck wrote: And oh by the way, can someone check this bit: if

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-21 Thread José Matos
On Saturday 21 April 2007 11:30:40 am Michael Gerz wrote: > > Has this been fixed in the meantime? Maybe I missed an svn commit... No. I asked Richard to wait for beta-2 release, the patch will go after. At least that is my understanding. :-) > Michael -- José Abílio

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-21 Thread Michael Gerz
Abdelrazak Younes schrieb: Richard Heck wrote: And oh by the way, can someone check this bit: if (ch == '(') entryDelim = ')'; -else if (ch == '{') entryDelim = ')'; +else if (ch == '{') entryDelim = '}'; It had previous been: else if (ch = '{') entryDe

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-19 Thread Richard Heck
This turns out not to matter, as entryDelim must be a leftover from some previous code: It's set but never read---which is why no problem ever occurred here---so it can just be deleted.But I'll wait a bit before committing, in case Bernhard has a different view. Richard Abdelrazak Younes wrote:

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: And oh by the way, can someone check this bit: if (ch == '(') entryDelim = ')'; - else if (ch == '{') entryDelim = ')'; + else if (ch == '{') entryDelim = '}'; It had previous been: else if (ch = '{') en

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Edwin Leuven
Richard Heck wrote: The cause of the problem here is in the new BibTeX parser. The attached patch seems to solve this issue. Comments welcome. works for me, thanks! And see? This time it really is attached. and amazingly fast (sure you're sick? ;-)

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Richard Heck
Sorry for all the mail. Come to notice, in fact entryDelim is never read. So this can probably go. Richard Richard Heck wrote: > And oh by the way, can someone check this bit: > > >> if (ch == '(') entryDelim = ')'; >> -else if (ch == '{') entryDelim

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Richard Heck
And oh by the way, can someone check this bit: > if (ch == '(') entryDelim = ')'; > - else if (ch == '{') entryDelim = ')'; > + else if (ch == '{') entryDelim = '}'; > It had previous been: else if (ch = '{') entryDelim = ')'. That'

[PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Richard Heck
Edwin Leuven wrote: > Richard Heck wrote: >> Everything seems to have gone lowercase there, and in the output, though >> that seems to work nonetheless. Odd that. > 1.4 preserves case when saving. loading such a document now gives me > the problem. > > i think bibtex ignores case in the keys but i

Re: case mismatch in citation dialog

2007-04-18 Thread Edwin Leuven
Richard Heck wrote: Everything seems to have gone lowercase there, and in the output, though that seems to work nonetheless. Odd that. 1.4 preserves case when saving. loading such a document now gives me the problem. i think bibtex ignores case in the keys but i am not sure...

Re: case mismatch in citation dialog

2007-04-18 Thread Richard Heck
Everything seems to have gone lowercase there, and in the output, though that seems to work nonetheless. Odd that. I'd have thought bibtex keys were case sensitive. Guess not. Richard Edwin Leuven wrote: > i have a doc with bibtex citation such as > > DupontDupond2005 > > this now turns up in th

case mismatch in citation dialog

2007-04-18 Thread Edwin Leuven
i have a doc with bibtex citation such as DupontDupond2005 this now turns up in the available keys as dupontdupond2005 and no longer matches, and i get [DupontDupond2005] in the text. output is fine. perhaps someone knows where to put an ascii_lowercase() before i spend an hour looking?

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-07 Thread Bennett Helm
On Jan 7, 2007, at 1:05 PM, Jürgen Spitzmüller wrote: Jürgen Spitzmüller wrote: but I'll see now that it doesn't work yet if you hit ESC. I'll investigate. Bennett, please try the attached. Jürgen <3068-2.diff> That fixes it. Thanks! Bennett

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-07 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > but I'll see now > that it doesn't work yet if you hit ESC. I'll investigate. Bennett, please try the attached. Jürgen Index: src/frontends/qt4/QCitationDialog.C === --- src/frontends/qt4/QCitationDialog.C

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-07 Thread Jürgen Spitzmüller
Bennett Helm wrote: > 1. Start LyX, and create a new (blank) document. While keeping this   > blank document open, create a new document with a bibliography. In   > this second document, bring up the insert citation dialog, but cancel   > (without actually inserting anything). >

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-07 Thread Bennett Helm
ribe what you're actually doing? I now see that it's a partial but incomplete fix. Try this procedure. 1. Start LyX, and create a new (blank) document. While keeping this blank document open, create a new document with a bibliography. In this second document, bring up the insert citatio

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-07 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Put it in. I've done that now, since the fix is obvious to me. Bennett, please check again. Jürgen

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-07 Thread Jürgen Spitzmüller
Bennett Helm wrote: > > The attached patch fixes that bug, but I'm not sure it is the right   > > approach. > > Doesn't work for me; I get no change in behavior. Are you sure? It clearly fixes the problem for me. Can you please describe what you're actually doing? Jürgen

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-06 Thread Bennett Helm
On Jan 6, 2007, at 11:36 AM, Jürgen Spitzmüller wrote: The attached patch fixes that bug, but I'm not sure it is the right approach. Doesn't work for me; I get no change in behavior. Bennett

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-06 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: The attached patch fixes that bug, but I'm not sure it is the right approach. The problem is that bibkeysInfo_ is not cleared. This used to happen in ControlCitation::clearParams() that is called from Dialog::hide(). However, seems that Dialog::hide() as well as Dial

Re: [patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-06 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > I wonder, however, if similar problems are not to be found > the other dialogs, since clearParams() is implemented there as well and > should certainly be triggered. What I wanted to say is: clearParams() is implemented in the corresponding _insets_ and should be trigg

[patch] Bug 3068: Citation dialog: bad list of available citations

2007-01-06 Thread Jürgen Spitzmüller
The attached patch fixes that bug, but I'm not sure it is the right approach. The problem is that bibkeysInfo_ is not cleared. This used to happen in ControlCitation::clearParams() that is called from Dialog::hide(). However, seems that Dialog::hide() as well as Dialog::OKButton() etc. are not

Re: Bugs in the citation dialog

2006-12-16 Thread Michael Gerz
Edwin Leuven wrote: should be fixed. can u try? Looks good! Could you also check the shortcut for "&Find", please? It doesn't work. Michael

Re: Bugs in the citation dialog

2006-12-15 Thread Edwin Leuven
Michael Gerz wrote: Some new bugs: * Citation dialog: Create some citation; open the citation dialog a second time for another new citation => the selected entry from the first citations is already selected for the second citation (which is wrong) * Citation dialog: If you use the cur

Bugs in the citation dialog

2006-12-12 Thread Michael Gerz
Some new bugs: * Citation dialog: Create some citation; open the citation dialog a second time for another new citation => the selected entry from the first citations is already selected for the second citation (which is wrong) * Citation dialog: If you use the cursor up/down keys to bro

Re: citation dialog

2006-11-16 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Sun, Nov 12, 2006 at 12:58:10PM +0100, Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> >> > On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: >> >> Hehe I'd love to come back... I hope to find some time soon (more than >> >> the one needed to occas

Re: citation dialog

2006-11-16 Thread Andre Poenitz
On Sun, Nov 12, 2006 at 12:58:10PM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: > >> Hehe I'd love to come back... I hope to find some time soon (more than > >> the one needed to occasionally lurk on the list at l

Re: citation dialog

2006-11-12 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: >>> Hehe I'd love to come back... I hope to find some time soon (more than >>> the one needed to occasionally lurk on the list at least!) >>> >>> Btw, it seems that you guys

Re: citation dialog

2006-11-12 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: >> Hehe I'd love to come back... I hope to find some time soon (more than >> the one needed to occasionally lurk on the list at least!) >> >> Btw, it seems that you guys are doing a wonderful job with 1.5!

Re: citation dialog

2006-11-12 Thread Andre Poenitz
On Fri, Nov 10, 2006 at 10:15:56PM +0100, Alfredo Braunstein wrote: > Hehe I'd love to come back... I hope to find some time soon (more than the > one needed to occasionally lurk on the list at least!) > > Btw, it seems that you guys are doing a wonderful job with 1.5! Looks like you haven't even

Re: citation dialog

2006-11-11 Thread Alfredo Braunstein
Georg Baum wrote: > Am Donnerstag, 9. November 2006 16:09 schrieb Jean-Marc Lasgouttes: >> > "Alfredo" == Alfredo Braunstein >> > <[EMAIL PROTECTED]> writes: >> >> Alfredo> PS: there's a surprising (good) amount of activity on this >> Alfredo> list! >> >> Hello Alfredo, >> >> Do you fee

Re: citation dialog

2006-11-09 Thread Georg Baum
Am Donnerstag, 9. November 2006 16:09 schrieb Jean-Marc Lasgouttes: > > "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: > > Alfredo> PS: there's a surprising (good) amount of activity on this > Alfredo> list! > > Hello Alfredo, > > Do you feel like coming back to have fun with us

  1   2   3   >