This seems to solve the problem. I'll commit if there's no objection.

By the way, there's a lot of mismatch now between filenames and classnames. E.g., the class defined in GuiCitation.cpp is GuiCitationDialog. Which way should this be resolved?

Richard

--
==================================================================
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==================================================================
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto

Index: GuiCitation.h
===================================================================
--- GuiCitation.h	(revision 20269)
+++ GuiCitation.h	(working copy)
@@ -98,9 +98,6 @@
 	GuiSelectionManager * selectionManager;
 
 	///
-	bool initialiseParams(std::string const & data);
-
-	///
 	void init();
 
 	/// Available keys
Index: GuiCitation.cpp
===================================================================
--- GuiCitation.cpp	(revision 20269)
+++ GuiCitation.cpp	(working copy)
@@ -147,6 +147,7 @@
 
 void GuiCitationDialog::showView()
 {
+	init();
 	findLE->clear();
 	availableLV->setFocus();
 	QDialog::show();
@@ -191,6 +192,7 @@
 
 void GuiCitationDialog::updateView()
 {
+	init();
 	fillFields();
 	fillEntries();
 	updateDialog();
@@ -487,15 +489,6 @@
 }
 
 
-bool GuiCitationDialog::initialiseParams(std::string const & data)
-{
-	if (!controller().initialiseParams(data))
-		return false;
-	init();
-	return true;
-}
-
-
 void GuiCitationDialog::init()
 {
 	// Make the list of all available bibliography keys

Reply via email to