On Tue, Sep 16, 2003 at 04:46:09PM +, Angus Leeming spake thusly:
>
> Martin Vermeer wrote:
> > Angus, I find that I have to add #include "lyxfont.h" to paragraph.C
> > to get it to compile.
>
> Really? How odd. What is the error?
> Anyway, I have committed the fix.
>
> --
> Angus
This:
Martin Vermeer wrote:
> Angus, I find that I have to add #include "lyxfont.h" to paragraph.C
> to get it to compile.
Really? How odd. What is the error?
Anyway, I have committed the fix.
--
Angus
On Tue, Sep 16, 2003 at 09:33:37AM +, Angus Leeming spake thusly:
...
> Good. I have changed the setXYZ member functions of LyXFont to return void
> (from LyXFont &), as André suggested and am recompiling. I'll commit once
> I've proved that all is still Ok.
Angus, I find that I have to a
Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
>
> | I have shown a reduction in dependencies on LColor.h of 60 object
> | files. Does that count?
>
> Dependencies are nice... but when you begin to confront typesafety it
> is not so nice anymore.
Agreed.
>>> But I am a
Andre Poenitz wrote:
> On Tue, Sep 16, 2003 at 09:04:39AM +, Angus Leeming wrote:
>> > But I am a bit ambivalent as well. Also things like this typically
>> > make ripple effects in the rest of the code as well: You will have to
>> > change a lot of other "Color" to int as well, or add casts.
Angus Leeming <[EMAIL PROTECTED]> writes:
| I have shown a reduction in dependencies on LColor.h of 60 object
| files. Does that count?
Dependencies are nice... but when you begin to confront typesafety it
is not so nice anymore.
>> But I am a bit ambivalent as well. Also things like this typica
On Tue, Sep 16, 2003 at 09:04:39AM +, Angus Leeming wrote:
> > But I am a bit ambivalent as well. Also things like this typically
> > make ripple effects in the rest of the code as well: You will have to
> > change a lot of other "Color" to int as well, or add casts.
>
> Not true. I am talking
Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | On Mon, Sep 15, 2003 at 10:31:08PM +, Angus Leeming wrote:
>>> If a pimpl-ing of LyXFont would have unacceptable performance
>>> implications, we could nonetheless get that #include "LColor.h" out of
>>> the lyxfont.
Andre Poenitz <[EMAIL PROTECTED]> writes:
| On Mon, Sep 15, 2003 at 10:31:08PM +, Angus Leeming wrote:
>> If a pimpl-ing of LyXFont would have unacceptable performance
>> implications, we could nonetheless get that #include "LColor.h" out of
>> the lyxfont.h header file by storing 'color' as a
On Mon, Sep 15, 2003 at 10:31:08PM +, Angus Leeming wrote:
> If a pimpl-ing of LyXFont would have unacceptable performance
> implications, we could nonetheless get that #include "LColor.h" out of
> the lyxfont.h header file by storing 'color' as an int.
>
> Is such a strategy acceptable?
Com
Angus Leeming wrote:
> If a pimpl-ing of LyXFont would have unacceptable performance implications,
> we could nonetheless get that #include "LColor.h" out of the lyxfont.h
> header file by storing 'color' as an int. Ie
> Is such a strategy acceptable?
As motivation, this simple change reduces th
11 matches
Mail list logo
