Andre Poenitz wrote:
> On Tue, Sep 16, 2003 at 09:04:39AM +0000, Angus Leeming wrote:
>> > But I am a bit ambivalent as well. Also things like this typically
>> > make ripple effects in the rest of the code as well: You will have to
>> > change a lot of other "Color" to int as well, or add casts.
>>
>> Not true. I am talking only about the storage of the LColor::color variable
>> (which is private). Its accessor functions return/accept EnumLColor vars.
>> It all just works perfectly.
>>
>> EnumLColor LyXFont::color() const {
>> return static_cast<LColor::color>(bits.color);
>> }
>>
>> LyXFont & LyXFont::setColor(EnumLColor c) {
>> bits.color = int(c);
>> return *this;
>> }
>
> Btw: do we ever need this return value?
>
> I.e. wouldn't
>
> void LyXFont::setColor(EnumLColor c) {
> bits.color = int(c);
> }
>
> do in most/all cases?
grep suggests that the return value is never used. I'll make the change and
commit the above.
--
Angus
