Angus Leeming wrote: > If a pimpl-ing of LyXFont would have unacceptable performance implications, > we could nonetheless get that #include "LColor.h" out of the lyxfont.h > header file by storing 'color' as an int. Ie > Is such a strategy acceptable?
As motivation, this simple change reduces the number of dependencies on LColor.h from 238 to 172. The only two remaining header files #including "LColor.h" are inset.h and insettext.h (136 and 54 dependencies, respectively). Both these classes store an LColor::color instance. Both could do as I suggest for lyxfont.h, above, which would reduce the dependencies on LColor.h to just those files that require it. Regards, Angus ps. I attach the lyxfont.h patch, for reference. A
lyxfont.diff.gz
Description: GNU Zip compressed data
