Angus Leeming <[EMAIL PROTECTED]> writes:
| I have shown a reduction in dependencies on LColor.h of 60 object
| files. Does that count?
Dependencies are nice... but when you begin to confront typesafety it
is not so nice anymore.
>> But I am a bit ambivalent as well. Also things like this typically
>> make ripple effects in the rest of the code as well: You will have to
>> change a lot of other "Color" to int as well, or add casts.
>
| Not true. I am talking only about the storage of the LColor::color variable
| (which is private). Its accessor functions return/accept EnumLColor vars. It
| all just works perfectly.
Right.... then I have ca. no objections.
| EnumLColor LyXFont::color() const {
| return static_cast<LColor::color>(bits.color);
| }
Why the static cast?
LColor::color(bits.color);
should do it.
--
Lgb
