Re: Fullscreen mode (new patch)

2008-03-31 Thread Pavel Sanda
> > Bennett, i have an idea. if you still suffer from the focusing problem, > > can you try this patch? > > > It looks like I'm slow and you've already applied this patch, right? no, i have commited fix for a different issue. >In any > case, focus coming out of fullscreen mode hadn't been work

Re: Fullscreen mode (new patch)

2008-03-31 Thread Bennett Helm
On Sun, Mar 30, 2008 at 6:14 PM, Pavel Sanda <[EMAIL PROTECTED]> wrote: > > 1. When coming out of fullscreen mode, the normal window returns, but it > > does not automatically take focus as it should. > > Bennett, i have an idea. if you still suffer from the focusing problem, > can you try this pa

Re: Fullscreen mode (new patch)

2008-03-30 Thread Pavel Sanda
> 1. When coming out of fullscreen mode, the normal window returns, but it > does not automatically take focus as it should. Bennett, i have an idea. if you still suffer from the focusing problem, can you try this patch? pavel diff --git a/src/frontends/qt4/GuiView.cpp b/src/frontends/qt4/GuiVie

Re: Fullscreen mode (new patch)

2008-02-22 Thread Bennett Helm
On Feb 22, 2008, at 1:33 PM, Pavel Sanda wrote: I have encountered a couple other problems that seem directly related to fullscreen mode: 1. When coming out of fullscreen mode, the normal window returns, but it does not automatically take focus as it should. Bennett, is that focus thing o

Re: Fullscreen mode (new patch)

2008-02-22 Thread Pavel Sanda
> > I have encountered a couple other problems that seem directly related to > > fullscreen mode: > > > > 1. When coming out of fullscreen mode, the normal window returns, but it > > does not automatically take focus as it should. Bennett, is that focus thing ok in the current trunk? > > pavel

Re: Fullscreen mode (new patch)

2008-02-19 Thread Abdelrazak Younes
Pavel Sanda wrote: I have encountered a couple other problems that seem directly related to fullscreen mode: 1. When coming out of fullscreen mode, the normal window returns, but it does not automatically take focus as it should. hmm, it does here. i guess that will be some qt thing on mac.

Re: Fullscreen mode (new patch)

2008-02-19 Thread Bennett Helm
On Feb 19, 2008, at 9:14 PM, Pavel Sanda wrote: It's not a focus problem (and screen-recenter and mouse selection doesn't affect it). Playing around a little more, I find that the arrow keys are recognized and the insertion point changes accordingly, but the cursor does not move on screen.

Re: Fullscreen mode (new patch)

2008-02-19 Thread Pavel Sanda
> It's not a focus problem (and screen-recenter and mouse selection doesn't > affect it). Playing around a little more, I find that the arrow keys are > recognized and the insertion point changes accordingly, but the cursor does > not move on screen. So, after pressing down-arrow several times,

Re: Fullscreen mode (new patch)

2008-02-19 Thread Bennett Helm
On Feb 19, 2008, at 8:22 PM, Pavel Sanda wrote: The added preferences all seem to work well. The only oddity I've noticed concerns "Toggle tabbar". When this is selected and there are multiple tabs in normal mode, switching to fullscreen mode properly hides the tabs. But (staying in fullscr

Re: Fullscreen mode (new patch)

2008-02-19 Thread Pavel Sanda
> The added preferences all seem to work well. The only oddity I've noticed > concerns "Toggle tabbar". When this is selected and there are multiple tabs > in normal mode, switching to fullscreen mode properly hides the tabs. But > (staying in fullscreen mode) selecting File > New brings up the

Re: Fullscreen mode (new patch)

2008-02-19 Thread Bennett Helm
On Feb 19, 2008, at 4:56 PM, Pavel Sanda wrote: A final question/request (which may go beyond what you want to do, so feel free to ignore it): especially with widescreen monitors (standard on Macs), fullscreen mode as currently implemented results in unreadably long lines. Would it be possi

Re: Fullscreen mode (new patch)

2008-02-19 Thread Pavel Sanda
> A final question/request (which may go beyond what you want to do, so feel > free to ignore it): especially with widescreen monitors (standard on Macs), > fullscreen mode as currently implemented results in unreadably long lines. > Would it be possible to define line length (or % of screen wid

Re: Fullscreen mode #2

2008-02-19 Thread Pavel Sanda
> > > >> i need to call some kind of redraw when comming back from fullscreen > > > >> mode > > > >> (scrollbar needs some update and probably recomputation). > > > > > > > > I don't really understand why you need that as a redraw should be > > > > triggered > > > > automatically following a res

Re: Fullscreen mode #2

2008-02-19 Thread Pavel Sanda
> > >> i need to call some kind of redraw when comming back from fullscreen mode > > >> (scrollbar needs some update and probably recomputation). > > > > > > I don't really understand why you need that as a redraw should be > > > triggered > > > automatically following a resize event (which you g

Re: Fullscreen mode #2

2008-02-19 Thread Andre Poenitz
On Tue, Feb 19, 2008 at 11:12:37AM +0100, Abdelrazak Younes wrote: > Pavel Sanda wrote: 1. more workareas handling needs to be added (toolbars toggling wont work with them now) >> this seems to be tricky. Abdel, would it be complicated to have one >> toolbars >> info per workarea? > > Y

Re: Fullscreen mode #2

2008-02-19 Thread Pavel Sanda
> >> i need to call some kind of redraw when comming back from fullscreen mode > >> (scrollbar needs some update and probably recomputation). > > > > I don't really understand why you need that as a redraw should be triggered > > automatically following a resize event (which you get if you come ba

Re: Fullscreen mode #2

2008-02-19 Thread Pavel Sanda
>> i need to call some kind of redraw when comming back from fullscreen mode >> (scrollbar needs some update and probably recomputation). > > I don't really understand why you need that as a redraw should be triggered > automatically following a resize event (which you get if you come back from >

Re: Fullscreen mode #2

2008-02-19 Thread Abdelrazak Younes
Pavel Sanda wrote: this seems to be tricky. Abdel, would it be complicated to have one toolbars info per workarea? Yes, very complicated and not good. The toolbars are part of a main window i.e. GuiView. But perhaps you mean one toolbar by view? yes, view is what i actually wanted. OK. I

Re: Fullscreen mode #2

2008-02-19 Thread Pavel Sanda
>> this seems to be tricky. Abdel, would it be complicated to have one >> toolbars >> info per workarea? > > Yes, very complicated and not good. The toolbars are part of a main window > i.e. GuiView. But perhaps you mean one toolbar by view? yes, view is what i actually wanted. >In which case

Re: Fullscreen mode #2

2008-02-19 Thread Abdelrazak Younes
Pavel Sanda wrote: 1. more workareas handling needs to be added (toolbars toggling wont work with them now) this seems to be tricky. Abdel, would it be complicated to have one toolbars info per workarea? Yes, very complicated and not good. The toolbars are part of a main window i.e. GuiView.

Re: Fullscreen mode #2

2008-02-19 Thread Pavel Sanda
>> 1. more workareas handling needs to be added (toolbars toggling wont work >> with them now) this seems to be tricky. Abdel, would it be complicated to have one toolbars info per workarea? i seem to be lost in gui hierarchy - why there are two nested loops in fullscreen initialization - one ove

Re: Fullscreen mode #2

2008-02-18 Thread Abdelrazak Younes
Pavel Sanda wrote: hola, because more people didnt like the 'handy' way (TM) of ui toggling i introduced some gui interface and thus F11 and users configuration should be basically usable now. i know about two issues currently: 1. more workareas handling needs to be added (toolbars toggling wo

Re: Fullscreen mode (new patch)

2008-02-11 Thread Pavel Sanda
> I agree I was not very clear and maybe that things are not very clear > in my mind :) But I do not like this approach of toggling "by hand" > the toolbars and menubar. It does not feel right (says the man who > does not code). the vision here is to have: 1) all these bundled in one single comma

Re: Fullscreen mode (new patch)

2008-02-11 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Pavel Sanda <[EMAIL PROTECTED]> writes: I think this is the main problem with using fullscreen as it is envisionned here. A useful fullscreen needs more thought (maybe a different workarea that does fullscreen plus some extra whistles?) i dont follow you here. whats

Re: Fullscreen mode (new patch)

2008-02-11 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: >> I think this is the main problem with using fullscreen as it is >> envisionned here. A useful fullscreen needs more thought (maybe a >> different workarea that does fullscreen plus some extra whistles?) > > i dont follow you here. whats the main problem?

Re: Fullscreen mode (new patch)

2008-02-10 Thread Pavel Sanda
> > A final question/request (which may go beyond what you want to do, so > > feel free to ignore it): especially with widescreen monitors > > (standard on Macs), fullscreen mode as currently implemented results > > in unreadably long lines. Would it be possible to define line length > > (or % of s

Re: Fullscreen mode (new patch)

2008-02-10 Thread Jean-Marc Lasgouttes
Bennett Helm <[EMAIL PROTECTED]> writes: > Wouldn't a zoom/dpi trick result in not simply fewer characters per > line but also fewer lines per screen? That would seem to defeat one > of the purposes of going full screen: to maximize the number of lines. Or rather do not change the width of lines

Re: Fullscreen mode (new patch)

2008-02-10 Thread Jean-Marc Lasgouttes
Bennett Helm <[EMAIL PROTECTED]> writes: > A final question/request (which may go beyond what you want to do, so > feel free to ignore it): especially with widescreen monitors > (standard on Macs), fullscreen mode as currently implemented results > in unreadably long lines. Would it be possible to

Re: Fullscreen mode (new patch)

2008-02-09 Thread Pavel Sanda
> By the way Pavel, could you add a binding to "ui-toggle fullscreen". F11 is > key used by Firefox for the toggling, as much as a standard as it gets. I there is still one thing missing to give proper shortcut for fullscreen switching. we need to remember the visibility of all toolbars, so we c

Re: Fullscreen mode (new patch)

2008-02-09 Thread Abdelrazak Younes
Abdelrazak Younes wrote: I've done this change. The left and right margin are set to one fourth of the screen width for now, the result is good with my 1024 wide screen but I don't really know if makes sense for smaller or bigger screen. Someone had an idea about a fixed width per font size i

Re: Fullscreen mode (new patch)

2008-02-09 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Pavel Sanda wrote: I think an adjustment of the zoom and/or dpi settings while in fullscreen should do the trick. what should that dpi thing do? i just tried now to set different values, I think it must be used in combination of the zoom factor. but nothing happens

Re: Fullscreen mode (new patch)

2008-02-09 Thread Abdelrazak Younes
Pavel Sanda wrote: I think an adjustment of the zoom and/or dpi settings while in fullscreen should do the trick. what should that dpi thing do? i just tried now to set different values, I think it must be used in combination of the zoom factor. but nothing happens with my screen or fonts.

Re: Fullscreen mode (new patch)

2008-02-09 Thread Hans Meine
On Samstag 09 Februar 2008, Pavel Sanda wrote: > >I think an adjustment of the zoom and/or dpi settings while in > >fullscreen should do the trick. > > what should that dpi thing do? i just tried now to set different values, > but nothing happens with my screen or fonts. but i dont understand what

Re: Fullscreen mode (new patch)

2008-02-09 Thread Bennett Helm
On Feb 9, 2008, at 8:45 AM, Pavel Sanda wrote: Bennett, try whether "ui-toggle fullscreen" hide the global menu by chance... pavel It does work, and the menubar nicely appears automatically when the mouse goes to the top of the screen. Nice work! I that intentional Pavel? If yes, I am im

Re: Fullscreen mode (new patch)

2008-02-09 Thread Pavel Sanda
>> Bennett, try whether "ui-toggle fullscreen" hide the global menu by >> chance... >>> >>> pavel >> >> It does work, and the menubar nicely appears automatically when the >> mouse goes to the top of the screen. Nice work! > >I that intentional Pavel? If yes, I am impressed :-) i just

Re: Fullscreen mode

2008-02-09 Thread Abdelrazak Younes
Pavel Sanda wrote: dynamic_cast(d.current_work_area_)->setFrameStyle( QFrame::NoFrame); this line work, we got rid of 1mm margin. still 2 pixel border remain, it has to be from guiview? Or from your window manager? no certainly not. but i found a trick - to give setcon

Re: Fullscreen mode (new patch)

2008-02-09 Thread Abdelrazak Younes
Bennett Helm wrote: On Feb 8, 2008, at 5:44 PM, Pavel Sanda wrote: Bennett, try whether "ui-toggle fullscreen" hide the global menu by chance... pavel It does work, and the menubar nicely appears automatically when the mouse goes to the top of the screen. Nice work! I that intentional Pa

Re: Fullscreen mode (new patch)

2008-02-08 Thread Andre Poenitz
On Fri, Feb 08, 2008 at 11:44:20PM +0100, Pavel Sanda wrote: > - break; > + case LFUN_UI_TOGGLE: { > + string const arg = cmd.getArg(0); > + if (arg == "statusbar") > + > statusBar()->setVisible(!st

Re: Fullscreen mode (new patch)

2008-02-08 Thread Pavel Sanda
> There are a couple glitches I discovered in a few minutes of testing. > First, ui-toggle fullscreen does not work unless a document is open. (Is > that intentional?) i know about it, but its not intentional :) i was lazy to change it because whats the point of fullscreen when no file is opened

Re: Fullscreen mode (new patch)

2008-02-08 Thread Bennett Helm
On Feb 8, 2008, at 5:44 PM, Pavel Sanda wrote: Bennett, try whether "ui-toggle fullscreen" hide the global menu by chance... pavel It does work, and the menubar nicely appears automatically when the mouse goes to the top of the screen. Nice work! There are a couple glitches I discovered

Re: Fullscreen mode (new patch)

2008-02-08 Thread Pavel Sanda
>>> I guess that keeping trace of the menuBar pointer (via a static variable >>> outside the ctor) and try to hide it could work. >>> >>> One has to try... >> so to complete this menubar hiddening under mac and window decoration >> under ms win >> should be done. do you think its part of lyx assi

Re: Fullscreen mode

2008-02-08 Thread Pavel Sanda
> > > dynamic_cast(d.current_work_area_)->setFrameStyle( > > > QFrame::NoFrame); > > > > this line work, we got rid of 1mm margin. > > still 2 pixel border remain, it has to be from guiview? > > Or from your window manager? no certainly not. but i found a trick - to give setcontents

Re: Fullscreen mode

2008-02-08 Thread Andre Poenitz
On Fri, Feb 08, 2008 at 09:02:42PM +0100, Pavel Sanda wrote: > slowly approaching the final destination :) > > > void GuiView::setFullScreen() > > { > > menuBar()->hide(); > > statusBar()->hide(); > > dynamic_cast(this)->setFrameStyle(QFrame::NoFrame); > > this line seqfaults. guiview

Re: Fullscreen mode

2008-02-08 Thread Pavel Sanda
slowly approaching the final destination :) > void GuiView::setFullScreen() > { > menuBar()->hide(); > statusBar()->hide(); > dynamic_cast(this)->setFrameStyle(QFrame::NoFrame); this line seqfaults. guiview inherits QFrame? > dynamic_cast(d.current_work_area_)->setFrameSt

Re: Fullscreen mode

2008-02-07 Thread Abdelrazak Younes
Pavel Sanda wrote: I don't know for sure but I guess it should be done within LyX. For Mac, the method I've outlined above should probably work. I see that Firefox is able to hide all window decoration under Windows so I guess it is possible to do it for LyX too. thats worth studying, becaus

Re: Fullscreen mode

2008-02-07 Thread Pavel Sanda
> I don't know for sure but I guess it should be done within LyX. For Mac, > the method I've outlined above should probably work. I see that Firefox is > able to hide all window decoration under Windows so I guess it is possible > to do it for LyX too. thats worth studying, because firefox is

Re: Fullscreen mode

2008-02-07 Thread Abdelrazak Younes
Pavel Sanda wrote: I guess that keeping trace of the menuBar pointer (via a static variable outside the ctor) and try to hide it could work. One has to try... so to complete this menubar hiddening under mac and window decoration under ms win should be done. do you think its part of lyx assig

Re: Fullscreen mode

2008-02-07 Thread Pavel Sanda
> I guess that keeping trace of the menuBar pointer (via a static variable > outside the ctor) and try to hide it could work. > > One has to try... so to complete this menubar hiddening under mac and window decoration under ms win should be done. do you think its part of lyx assignment or should

Re: Fullscreen mode

2008-02-06 Thread Richard Heck
Abdelrazak Younes wrote: Pavel Sanda wrote: Why not just using hide()/show() intead of filling/emptying the menubar? hide method hides ... i was searching for it in docs and havent found, now i see they are inherited. next time i drop reading manuals and try hide() directly in code ;) I se

Re: Fullscreen mode

2008-02-06 Thread Abdelrazak Younes
Bennett Helm wrote: On Feb 6, 2008, at 12:01 PM, Pavel Sanda wrote: You could also introduce LFUN_STATUSBAR_TOGGLE by the way if you want to achieve real full screen. does the following patch looks more sensible to you? pavel I just tried it, but menubar hiding doesn't work on Mac. (Statusb

Re: Fullscreen mode

2008-02-06 Thread Pavel Sanda
>>> You could also introduce LFUN_STATUSBAR_TOGGLE by the way if you want to >>> achieve real full screen. >> >> does the following patch looks more sensible to you? >> pavel > > I just tried it, but menubar hiding doesn't work on Mac. (Statusbar hiding > does.) Is this a Qt/Mac limitation? i rem

Re: Fullscreen mode

2008-02-06 Thread Bennett Helm
On Feb 6, 2008, at 12:01 PM, Pavel Sanda wrote: You could also introduce LFUN_STATUSBAR_TOGGLE by the way if you want to achieve real full screen. does the following patch looks more sensible to you? pavel I just tried it, but menubar hiding doesn't work on Mac. (Statusbar hiding does.)

Re: Fullscreen mode

2008-02-06 Thread Pavel Sanda
> Yes but I guess it could be a bit shorter: nice ;) i will commit it. pavel

Re: Fullscreen mode

2008-02-06 Thread Abdelrazak Younes
Pavel Sanda wrote: You could also introduce LFUN_STATUSBAR_TOGGLE by the way if you want to achieve real full screen. does the following patch looks more sensible to you? Yes but I guess it could be a bit shorter: @@ -1524,6 +1525,15 @@ bool GuiView::dispatch(FuncRequest const & cmd)

Re: Fullscreen mode

2008-02-06 Thread Pavel Sanda
> You could also introduce LFUN_STATUSBAR_TOGGLE by the way if you want to > achieve real full screen. does the following patch looks more sensible to you? pavel diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp index d93c74f..ac0bc2f 100644 --- a/src/LyXAction.cpp +++ b/src/LyXAction.cpp @@ -10

Re: Fullscreen mode

2008-02-06 Thread Abdelrazak Younes
Pavel Sanda wrote: Why not just using hide()/show() intead of filling/emptying the menubar? hide method hides ... i was searching for it in docs and havent found, now i see they are inherited. next time i drop reading manuals and try hide() directly in code ;) I see :-) A good advice is to re

Re: Fullscreen mode

2008-02-06 Thread Pavel Sanda
> Why not just using hide()/show() intead of filling/emptying the menubar? hide method hides ... i was searching for it in docs and havent found, now i see they are inherited. next time i drop reading manuals and try hide() directly in code ;) > You could also introduce LFUN_STATUSBAR_TOGGLE by t

Re: Fullscreen mode

2008-02-06 Thread Abdelrazak Younes
Pavel Sanda wrote: hi, its not the first time the issue of fullscreen mode of lyx when editing document is raised on dev list and in bugzilla we have enh request too. i think that if we are not supporting it directly it would be very easy to add minimalistic support for advanced users, which wi