Pavel Sanda wrote:
1. more workareas handling needs to be added (toolbars toggling wont work
with them now)
this seems to be tricky. Abdel, would it be complicated to have one toolbars
info per workarea?
Yes, very complicated and not good. The toolbars are part of a main
window i.e. GuiView. But perhaps you mean one toolbar by view? In which
case the toolbars are already independent AFAIK. Not sure about that
really, maybe the ToolbarBackend is not 'multiview aware'? That would be
bad.
> i seem to be lost in gui hierarchy - why there are two
nested loops in fullscreen initialization - one over tabworkarea second over
guiworkarea. whats their relation and why dont we have just one vector
representing opened tabs?
The reason why we have a vector of tabworkarea instead of one is because
the code is ready for "split view" i.e. two visible work areas inside
the same window separated either vertically of horizontally. I will add
this information in the documentation in 'Application.h' (did you read
it by the way?).
currently, the moment one window gets in fullscreen without toolbars the other
windows lose toolbars too. (maybe its not too much harm, because there is no
point in using fullscreen and other windows simultaneously).
int BufferView::rightMargin() const
{
- if (!full_screen_ || width_ < max_row_width + 20)
+ if (!full_screen_)
return 10;
Hum, I put the additional test in case the outliner is opened and the
available width is smaller. In this case you
ahh, comment needed :) i wondered why the second part of condition...
Yes a comment is probably needed, could you do it as part of your patch
please?
- return (width_ - max_row_width) / 2;
+ return (width_ - (lyxrc.full_screen_width * width_) / 100) / 2;
Why a proportional width? I think the max width in pixel is more sensible.
this is obviously clash of philosophies :) i like to have full width of screen
used.
Then just disable the fullscreen mode in BufferView?
width in pixels means i need to find resolution and fix it for any display
i want to work. but i understand you want to have paper-like width.
the question is how to solve this - to have combobox with fullwidth/paperwidth
instead of percents?
That would be an option. But I reckon that people like you would prefer
to use the full width anyway so I would propose instead a check box
'Limit text screen width' that will enable/disable the width edit box.
Abdel.
