Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-06 Thread Abdelrazak Younes
Leuven, E. wrote: Excellent Edwin, you're a master! what are u then? :-) I know, I should RTFM but what is the trick? cast a magic spell i learned from harry potter himself. some - second rate wizards - have claimed that selecting the base widget (clicking on it) and then layout in a g

RE: Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-06 Thread Leuven, E.
> Excellent Edwin, you're a master! what are u then? > I know, I should RTFM but what is the trick? cast a magic spell i learned from harry potter himself. some - second rate wizards - have claimed that selecting the base widget (clicking on it) and then layout in a grid (ctrl+5) also works un

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-06 Thread Abdelrazak Younes
Leuven, E. wrote: something like the attached? Excellent Edwin, you're a master! I know, I should RTFM but what is the trick? Abdel.

RE: Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-06 Thread Leuven, E.
> Edwin! I knew I forgot someone in my call for help ;-) i am not much help these days, but i still manage to lurk ;-)

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-06 Thread Abdelrazak Younes
Leuven, E. wrote: Edwin! I knew I forgot someone in my call for help ;-) something like the attached? I'll try that, thanks. Abdel.

RE: Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-06 Thread Leuven, E.
something like the attached? -Original Message- From: news on behalf of Abdelrazak Younes Sent: Tue 3/6/07 16:11 To: lyx-devel@lists.lyx.org Subject: Re: [Patch] TOC Dialog crashes with empty toc list José Matos wrote: > On Monday 05 March 2007 6:27:26 pm Abdelrazak Younes wr

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Abdelrazak Younes
Bernhard Roider wrote: Abdelrazak Younes wrote: Bernhard Roider wrote: Hello, i found a crash when one of the buttons in the TOC dialog is pressed if the TOC is empty. The attached patch disables the buttons if there are no entries in the TOC dialog. To be safe it also adds a test to the bu

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Bernhard Roider
Abdelrazak Younes wrote: Bernhard Roider wrote: Hello, i found a crash when one of the buttons in the TOC dialog is pressed if the TOC is empty. The attached patch disables the buttons if there are no entries in the TOC dialog. To be safe it also adds a test to the button handler functions w

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread José Matos
On Monday 05 March 2007 6:27:26 pm Abdelrazak Younes wrote: > >   How much time do you need? > > A few days... Granted. :-) > >   I suggested the freeze with a very small window of commit time > > remaining. I am aware that it is not nice to change the rules in the > > middle of the game, that

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Abdelrazak Younes
José Matos wrote: On Monday 05 March 2007 4:47:31 pm Abdelrazak Younes wrote: Hello Bernhard, I don't know if you are planning to commit this one but I wanted to let you know that I integrated your changes already in my local tree. I am basically rewriting a good part of this code and I hope th

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread José Matos
On Monday 05 March 2007 4:47:31 pm Abdelrazak Younes wrote: > Hello Bernhard, > > I don't know if you are planning to commit this one but I wanted to let > you know that I integrated your changes already in my local tree. I am > basically rewriting a good part of this code and I hope that it will b

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Abdelrazak Younes
Bernhard Roider wrote: Hello, i found a crash when one of the buttons in the TOC dialog is pressed if the TOC is empty. The attached patch disables the buttons if there are no entries in the TOC dialog. To be safe it also adds a test to the button handler functions whether the list has entrie

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Lars Gullik Bjønnes wrote: | > | > Bernhard Roider <[EMAIL PROTECTED]> writes: | > | | > | @@ -150,9 +153,12 @@ | > | > | void QTocDialog

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Lars Gullik Bjønnes wrote: | > | > Bernhard Roider <[EMAIL PROTECTED]> writes: | > | | > | @@ -150,9 +153,12 @@ | > | > | void QTocDialog::on_moveDownPB_clicked() | >

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Bernhard Roider <[EMAIL PROTECTED]> writes: | | > | @@ -150,9 +153,12 @@ | > | void QTocDialog::on_moveDownPB_clicked() | > | { | > same comment | | Same comment to what? So you didn'

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Bernhard Roider <[EMAIL PROTECTED]> writes: | | > | @@ -150,9 +153,12 @@ | > | void QTocDialog::on_moveDownPB_clicked() | > | { | > same comment | | Same comment to what? So you didn't read the patch did you? | Wh

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-04 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Bernhard Roider <[EMAIL PROTECTED]> writes: | @@ -150,9 +153,12 @@ | void QTocDialog::on_moveDownPB_clicked() | { same comment Same comment to what? | @@ -160,9 +166,12 @@ | void QTocDialog::on_moveInPB_clicked() | { same comment ditto | @@ -170,9 +17

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-04 Thread Bernhard Roider
Lars Gullik Bjønnes wrote: A space after '&' as well please. Also; can list be a const reference? it can be a const reference --> new patch attached - now really Does the enableButtons() have a default arg? If that is our own function I think it should be removed so that have to use true/

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-04 Thread Bernhard Roider
Lars Gullik Bjønnes wrote: A space after '&' as well please. Also; can list be a const reference? it can be a const reference --> new patch attached Does the enableButtons() have a default arg? If that is our own function I think it should be removed so that have to use true/false explict

Re: [Patch] TOC Dialog crashes with empty toc list

2007-03-03 Thread Lars Gullik Bjønnes
Bernhard Roider <[EMAIL PROTECTED]> writes: | Hello, | | i found a crash when one of the buttons in the TOC dialog is pressed | if the TOC is empty. The attached patch disables the buttons if there | are no entries in the TOC dialog. To be safe it also adds a test to | the button handler function