Re: Questions regarding compiler warnings

On Thu, Feb 13, 2020 at 06:28:05PM +0100, Jean-Marc Lasgouttes wrote: > >I can replace asserts with explicit checks if you agree. > >Or completely delete those checks because for most of them getStatus won't > >let > >you in without buffer anyway. > > Either solution will be OK. And do not forget

Re: Questions regarding compiler warnings

On Thu, Feb 13, 2020 at 10:39:29PM +0100, Stephan Witt wrote: > Am 13.02.2020 um 19:05 schrieb Scott Kostyshak : > > > > On Wed, Feb 12, 2020 at 08:45:56PM +0100, Stephan Witt wrote: > > > >> See the attached nice picture… > > > > This picture is great! Did you create it manually or is there som

Re: Questions regarding compiler warnings

Am 13.02.2020 um 19:05 schrieb Scott Kostyshak : > > On Wed, Feb 12, 2020 at 08:45:56PM +0100, Stephan Witt wrote: > >> See the attached nice picture… > > This picture is great! Did you create it manually or is there some sort > of magical static analysis tool that does this? It’s the result of

Re: Questions regarding compiler warnings

On Wed, Feb 12, 2020 at 08:45:56PM +0100, Stephan Witt wrote: > See the attached nice picture… This picture is great! Did you create it manually or is there some sort of magical static analysis tool that does this? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-d

Re: Questions regarding compiler warnings

Le 13/02/2020 à 18:16, Pavel Sanda a écrit : On Wed, Feb 12, 2020 at 08:53:14PM +0100, Jean-Marc Lasgouttes wrote: 3. NULL pointer usage In GuiView::dispatchVC are different buffer pointer variables used. Sometimes there is an explicit check for NULL value. Sometimes there is an assertion with

Re: Questions regarding compiler warnings

On Wed, Feb 12, 2020 at 08:53:14PM +0100, Jean-Marc Lasgouttes wrote: > >3. NULL pointer usage > > > >In GuiView::dispatchVC are different buffer pointer variables used. > >Sometimes there is an explicit check for NULL value. > >Sometimes there is an assertion with break or return for release build

Re: Questions regarding compiler warnings

Le 12/02/2020 à 21:17, Stephan Witt a écrit : I don’t know what I’m talking about either. But, perhaps std::mem_fn is a possible replacement? https://en.cppreference.com/w/cpp/utility/functional/mem_fn I tried it, but it does not seems to work with std::not1. JMarc 2. various memory leak w

Re: Questions regarding compiler warnings

Am 12.02.2020 um 20:53 schrieb Jean-Marc Lasgouttes : > > Le 12/02/2020 à 20:45, Stephan Witt a écrit : >> Hi all, >> I've recently upgraded some parts of my tool box. I’m seeing new warnings >> now. >> 1. deprecated warning (removed with C++17?) >> lyx/src/insets/InsetCommandParams.cpp:596:9: wa

Re: Questions regarding compiler warnings

Le 12/02/2020 à 20:45, Stephan Witt a écrit : Hi all, I've recently upgraded some parts of my tool box. I’m seeing new warnings now. 1. deprecated warning (removed with C++17?) lyx/src/insets/InsetCommandParams.cpp:596:9: warning: 'mem_fun_ref' is deprecated I already answered this one :)

Re: [LyX/master] Fix #10858 compiler warnings.

Le 25/06/2018 à 04:43, Richard Kimberly Heck a écrit : I do not know much about this drawT/metricsT code. My guess is that it never got finished. I do not remember seeing it work. Making an ascii representation of a formula is a big job. Should we just remove that code then? I have been tempt

Re: [LyX/master] Fix #10858 compiler warnings.

c02a >>>> Author: Richard Heck >>>> Date:   Fri Dec 15 23:41:32 2017 -0500 >>>> >>>> Fix #10858 compiler warnings. >>>> --- >>>>   src/mathed/InsetMathHull.cpp |   16 +++- >>>>   src/support/gzstr

Re: [LyX/master] Fix #10858 compiler warnings.

Le 01/05/2018 à 17:58, Richard Heck a écrit : On 05/01/2018 11:27 AM, Scott Kostyshak wrote: On Sat, Dec 16, 2017 at 04:41:40AM +, Richard Heck wrote: commit b954f478e31e640f292f865a5c41c65565e5c02a Author: Richard Heck Date: Fri Dec 15 23:41:32 2017 -0500 Fix #10858 compiler

Re: [LyX/master] Fix #10858 compiler warnings.

gt; Date: Fri Dec 15 23:41:32 2017 -0500 > >> > >> Fix #10858 compiler warnings. > >> --- > >> src/mathed/InsetMathHull.cpp | 16 +++- > >> src/support/gzstream.cpp |2 +- > >> 2 files changed, 8 insertions(+), 10 deletio

Re: [LyX/master] Fix #10858 compiler warnings.

On 05/01/2018 11:27 AM, Scott Kostyshak wrote: > On Sat, Dec 16, 2017 at 04:41:40AM +, Richard Heck wrote: >> commit b954f478e31e640f292f865a5c41c65565e5c02a >> Author: Richard Heck >> Date: Fri Dec 15 23:41:32 2017 -0500 >> >> Fix #10858 compile

Re: [LyX/master] Fix #10858 compiler warnings.

On Sat, Dec 16, 2017 at 04:41:40AM +, Richard Heck wrote: > commit b954f478e31e640f292f865a5c41c65565e5c02a > Author: Richard Heck > Date: Fri Dec 15 23:41:32 2017 -0500 > > Fix #10858 compiler warnings. > --- > src/mathed/InsetMathHull.cpp | 16 +++---

Re: [LyX/master] Fix #10894 compiler warnings.

t : >> >> commit 71005d6c1079637d7127defc372a5aa4d62092b0 >> Author: Richard Heck >> Date: Sat Dec 16 00:59:07 2017 -0500 >> >> Fix #10894 compiler warnings. >> --- >> src/insets/InsetCitation.cpp |4 ++-- >>

Re: [LyX/master] Fix #10894 compiler warnings.

hard Heck >> Date: Sat Dec 16 00:59:07 2017 -0500 >> >> Fix #10894 compiler warnings. >> --- >> src/insets/InsetCitation.cpp |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/inset

Re: [LyX/master] Fix #10894 compiler warnings.

On 12/16/2017 04:52 AM, Jean-Marc Lasgouttes wrote: > Le 16 décembre 2017 06:59:12 GMT+01:00, Richard Heck > a écrit : > > commit 71005d6c1079637d7127defc372a5aa4d62092b0 > Author: Richard Heck > Date: Sat Dec 16 00:59:07 2017 -0500 > > Fix

Re: [LyX/master] Fix #10863 compiler warnings.

On 12/16/2017 02:37 AM, Kornel Benko wrote: > Am Samstag, 16. Dezember 2017 um 07:03:34, schrieb Pavel Sanda >> Richard Heck wrote: >>> commit b684ec39eaaf7d5b0270bf8109b8e281fa8c5d9f >>> Author: Richard Heck >>> Date: Fri Dec 15 23:50:23 2017 -0500 >

Re: [LyX/master] Fix #10894 compiler warnings.

Le 16 décembre 2017 06:59:12 GMT+01:00, Richard Heck a écrit : >commit 71005d6c1079637d7127defc372a5aa4d62092b0 >Author: Richard Heck >Date: Sat Dec 16 00:59:07 2017 -0500 > >Fix #10894 compiler warnings. >--- > src/insets/InsetCitation.cpp |4 ++-- > 1 files cha

Re: [LyX/master] Fix #10863 compiler warnings.

Am Samstag, 16. Dezember 2017 um 07:03:34, schrieb Pavel Sanda > Richard Heck wrote: > > commit b684ec39eaaf7d5b0270bf8109b8e281fa8c5d9f > > Author: Richard Heck > > Date: Fri Dec 15 23:50:23 2017 -0500 > > > > Fix #10863 compiler warnings. > > --

Re: [LyX/master] Fix #10863 compiler warnings.

Richard Heck wrote: > commit b684ec39eaaf7d5b0270bf8109b8e281fa8c5d9f > Author: Richard Heck > Date: Fri Dec 15 23:50:23 2017 -0500 > > Fix #10863 compiler warnings. > --- > src/mathed/MathParser.cpp | 12 +--- > 1 files changed, 5 insertions(+), 7 deleti

Re: new compiler warnings in today's master

Am 18.10.2016 um 01:08 schrieb Guillaume Munch: Thanks for the report. This should be fixed now. Please tell me if there are still warnings now. Hi Guillaume, many thanks, the warnings went away. regards Uwe p.s. if possible please only cite what you are referring to in your replies. This

Re: new compiler warnings in today's master

Le 17/10/2016 à 01:49, Uwe Stöhr a écrit : Hi Guillaume, your recent changes introduced these new compiler warning: GuiViewSource.cpp D:\LyXGit\Master\src\TexRow.h(51): warning C4099: 'lyx::TextEntry': type name first seen using 'class' now seen using 'struct' (compiling source file D:\LyXGit\M

new compiler warnings in today's master

Hi Guillaume, your recent changes introduced these new compiler warning: GuiViewSource.cpp D:\LyXGit\Master\src\TexRow.h(51): warning C4099: 'lyx::TextEntry': type name first seen using 'class' now seen using 'struct' (compiling source file D:\LyXGit\Master\src\frontends\qt4\GuiView.cpp) [D:\

Re: 5 more compiler warnings in master

Le 02/07/2016 20:28, Uwe Stöhr a écrit : I understand the compiler warnings but it is not easy for me to decide if a truncation of values was intended or not. I mean if it is intended one should use int().(…) Hi Uwe, you are right, asking somebody to fix a warning when they are not familiar

Re: 5 more compiler warnings in master

On 07/02/2016 02:28 PM, Uwe Stöhr wrote: > Am 02.07.2016 um 20:15 schrieb Richard Heck: > >> All harmless. >> >> In future, you can fix these sorts of warnings easily. > > I understand the compiler warnings but it is not easy for me to decide > if a truncation of v

Re: 5 more compiler warnings in master

Am 02.07.2016 um 20:15 schrieb Richard Heck: All harmless. In future, you can fix these sorts of warnings easily. I understand the compiler warnings but it is not easy for me to decide if a truncation of values was intended or not. I mean if it is intended one should use int(). Since this

Re: 5 more compiler warnings in master

On 07/02/2016 11:42 AM, Uwe Stöhr wrote: > Since I am now able to compile master again with the latest MSVC 2015 > compiler, I get these new warnings: > > D:\LyXGit\Master\src\Changes.cpp(562): warning C4244: 'initializing': > conversion from 'double' to 'int', possible loss of data > [D:\LyXGit\Ma

5 more compiler warnings in master

Since I am now able to compile master again with the latest MSVC 2015 compiler, I get these new warnings: D:\LyXGit\Master\src\Changes.cpp(562): warning C4244: 'initializing': conversion from 'double' to 'int', possible loss of data [D:\LyXGit\Master\compile-2015\src\LyX.vcxproj] D:\LyXGit\M

Re: int64 compiler warnings

Am 07.03.2016 um 22:27 schrieb Georg Baum: > - The wanted type is always 64bit => use boost::int64_t for signed values and boost::uint64_t for unsigned values (MSVC does not have std::int64_t or ::it64_t, at least not in the 2010 version) Many thanks for having a look. MSVC 2015 has this: htt

Re: int64 compiler warnings

Jean-Marc Lasgouttes wrote: > Le 07/03/2016 13:21, Alex Vergara Gil a écrit : >> Best way for this is to use native int as integer variables and you >> forget about it, this works even on windows, so instead of int use >> long and thats it: http://en.cppreference.com/w/cpp/language/types > > In t

Re: int64 compiler warnings

Le 07/03/2016 13:59, Jean-Marc Lasgouttes a écrit : Le 07/03/2016 13:21, Alex Vergara Gil a écrit : Best way for this is to use native int as integer variables and you forget about it, this works even on windows, so instead of int use long and thats it: http://en.cppreference.com/w/cpp/language/

Re: int64 compiler warnings

Le 07/03/2016 13:21, Alex Vergara Gil a écrit : Best way for this is to use native int as integer variables and you forget about it, this works even on windows, so instead of int use long and thats it: http://en.cppreference.com/w/cpp/language/types In this case one would want a 64 bit type, an

Re: int64 compiler warnings

rit : >> Although it is not pressing, I tried to compile LyX as 64bit application >> and this works, except of one error I just reported. >> There are of course some compiler warnings. Fixing them is of course >> also not pressing but maybe it is worth it to do it now for a LyX

Re: int64 compiler warnings

Le 07/03/2016 04:14, Uwe Stöhr a écrit : Although it is not pressing, I tried to compile LyX as 64bit application and this works, except of one error I just reported. There are of course some compiler warnings. Fixing them is of course also not pressing but maybe it is worth it to do it now for

int64 compiler warnings

Although it is not pressing, I tried to compile LyX as 64bit application and this works, except of one error I just reported. There are of course some compiler warnings. Fixing them is of course also not pressing but maybe it is worth it to do it now for a LyX 2.2 that can be compiled as 64bit

Re: new compiler warnings in master

Jürgen Spitzmüller wrote: > Perhaps: > hyphen -> softhyphen > slash -> breakableslash > > to make their semantics more explicit. Good idea, I did it like that. Georg

Re: new compiler warnings in master

2015-03-22 18:27 GMT+01:00 Georg Baum: > This would look like the attached. Before I commit: Any wishes for other > names? > Perhaps: hyphen -> softhyphen slash -> breakableslash to make their semantics more explicit. Jürgen > > > Georg

Re: new compiler warnings in master

Le 22/03/15 18:27, Georg Baum a écrit : Georg Baum wrote: OK, I will change it. But since the LyX file format really has nothing to do with LaTeX (except for math), I will remove all backslashes and {} pairs from InsetSpecialChar. BTW, LaTeX2E is not the only one which is different. This woul

Re: new compiler warnings in master

Georg Baum wrote: > OK, I will change it. But since the LyX file format really has nothing to > do with LaTeX (except for math), I will remove all backslashes and {} > pairs from InsetSpecialChar. BTW, LaTeX2E is not the only one which is > different. This would look like the attached. Before I c

Re: Re: new compiler warnings in master

On Friday 20 March 2015 21:57:43 Georg Baum wrote: > OK, I will change it. But since the LyX file format really has nothing to do > with LaTeX (except for math), I will remove all backslashes and {} pairs > from InsetSpecialChar. BTW, LaTeX2E is not the only one which is different. > > > Georg

Re: new compiler warnings in master

Jean-Marc Lasgouttes wrote: > Le 18/03/15 20:27, Georg Baum a écrit : >> Oops! Thanks for the fix. >> >> Why do you think that the LyX file format needs to follow the LaTeX >> restrictions? IMHO it does not need to match (therefore I did not include >> the {} in the LyX file format, which is done

Re: new compiler warnings in master

On 18/03/2015 11:39, Jean-Marc Lasgouttes wrote: Le 18/03/2015 08:30, Uwe Stöhr a écrit : Within the last 2 weeks a commit lead to these new compiler warnings: (The same that I constantly report here. I am wondering why the appear so often with recent commits.) The warnings should be gone now

Re: new compiler warnings in master

Le 18/03/15 20:27, Georg Baum a écrit : Oops! Thanks for the fix. Why do you think that the LyX file format needs to follow the LaTeX restrictions? IMHO it does not need to match (therefore I did not include the {} in the LyX file format, which is done for other special characters). Well, it r

Re: new compiler warnings in master

Jean-Marc Lasgouttes wrote: > Georg, note that there was an error for LaTeX 2e (\LaTeX2e instead of > \LaTeXe). I fixed it in LaTeX output, but I suspect that we should > change the file format too for consistency sake. Oops! Thanks for the fix. Why do you think that the LyX file format needs to

Re: new compiler warnings in master

Le 18/03/2015 08:30, Uwe Stöhr a écrit : Within the last 2 weeks a commit lead to these new compiler warnings: (The same that I constantly report here. I am wondering why the appear so often with recent commits.) The warnings should be gone now. Please confirm. THis uses integer arithmetic

Re: new compiler warnings in master

Le 18/03/2015 08:30, Uwe Stöhr a écrit : Within the last 2 weeks a commit lead to these new compiler warnings: (The same that I constantly report here. I am wondering why the appear so often with recent commits.) It's my fault. I will fix this. JMarc ..\..\..\src\i

new compiler warnings in master

Within the last 2 weeks a commit lead to these new compiler warnings: (The same that I constantly report here. I am wondering why the appear so often with recent commits.) ..\..\..\src\insets\InsetSpecialChar.cpp(57): warning C4244: '=': convesion from 'double' to 

Re: [parch] silence boost compiler warnings

2014-04-01 12:42 GMT+02:00 Vincent van Ravesteijn: > Wouldn't "git log" not be enough to see which patches we applied ? > Practically for sure. I was just unsure what the policy is with embedded 3rd-party code. Jürgen > > Vincent >

Re: [parch] silence boost compiler warnings

On Tue, Apr 1, 2014 at 12:14 PM, Jürgen Spitzmüller wrote: > 2014-04-01 11:41 GMT+02:00 Vincent van Ravesteijn: > > What about scheduling Juergen's patch to some 2.1.x release (maybe not >>> 2.1.1). >>> >>> JMarc >>> >> >> Looks sensible. >> > > I propose I apply this to my own working branch an

Re: [parch] silence boost compiler warnings

2014-04-01 11:41 GMT+02:00 Vincent van Ravesteijn: > What about scheduling Juergen's patch to some 2.1.x release (maybe not >> 2.1.1). >> >> JMarc >> > > Looks sensible. > I propose I apply this to my own working branch and see if problems arise. Then we could commit it early in the 2.1.2 or 2.1.

Re: [parch] silence boost compiler warnings

On Tue, Apr 1, 2014 at 11:28 AM, Jean-Marc Lasgouttes wrote: > 01/04/2014 11:07, Vincent van Ravesteijn: > >> On Tue, Apr 1, 2014 at 11:00 AM, Jürgen Spitzmüller > > wrote: >> I propose to commit this to 2.2-staging. The compiler noise is >> really annoying. An altern

Re: [parch] silence boost compiler warnings

01/04/2014 11:07, Vincent van Ravesteijn: On Tue, Apr 1, 2014 at 11:00 AM, Jürgen Spitzmüller mailto:sp...@lyx.org>> wrote: I propose to commit this to 2.2-staging. The compiler noise is really annoying. An alternative is an update of our boost sources. These warnings are fixed upstre

Re: [parch] silence boost compiler warnings

On Tue, Apr 1, 2014 at 11:00 AM, Jürgen Spitzmüller wrote: > The attached patch gets rid of these annoying gcc 4.8 compiler warnings > pointing to boost (usued typedefs etc.). I have collected the fixed both > from boost itself [1] and from the patchset used by Fedora for their boost

[parch] silence boost compiler warnings

The attached patch gets rid of these annoying gcc 4.8 compiler warnings pointing to boost (usued typedefs etc.). I have collected the fixed both from boost itself [1] and from the patchset used by Fedora for their boost RPMs [2]. I propose to commit this to 2.2-staging. The compiler noise is

Re: compiler warnings in trunk

On 10/04/2011 11:12 AM, Andre Poenitz wrote: On Sun, Apr 10, 2011 at 10:31:47AM -0400, Richard Heck wrote: On 04/09/2011 06:46 PM, Julien Rioux wrote: I always saw those two warnings (paraphrased): Lexer.cpp:197 may be used uninitialized void Lexer::Pimpl::verifyTable() { // [...]

Re: compiler warnings in trunk

On Sun, Apr 10, 2011 at 10:31:47AM -0400, Richard Heck wrote: > On 04/09/2011 06:46 PM, Julien Rioux wrote: > >I always saw those two warnings (paraphrased): > >Lexer.cpp:197 may be used uninitialized void Lexer::Pimpl::verifyTable() { // [...] if (table <- this line?

Re: compiler warnings in trunk

On 04/09/2011 06:46 PM, Julien Rioux wrote: I always saw those two warnings (paraphrased): Lexer.cpp:197 may be used uninitialized Server.cpp:1018 ignoring return value of write(...) The Lexer one has been there forever. I'm not sure why we get it, and I'm certainly not sure why removing the a

compiler warnings in trunk

I always saw those two warnings (paraphrased): Lexer.cpp:197 may be used uninitialized Server.cpp:1018 ignoring return value of write(...) I have looked into these two warnings to learn a bit more on cpp. For the first one, I could remove the warning by removing the anonymous namespace, but I

New Compiler Warnings...

... I get here. * CompileC src/mathed/MathData.cpp normal i386 c++ com.apple.compilers.gcc.4_2 src/mathed/MathData.cpp: In member function 'void lyx::MathData::detachMacroParameters(lyx::DocIterator*, size_t)': src/mathed/MathData.cpp:508: warning: negative integer implicitly converted to unsig

Re: Fix compiler warnings in pedantic mode

Am 16.12.2010 um 09:47 schrieb Abdelrazak Younes: > On 12/16/2010 07:25 AM, Stephan Witt wrote: >> Am 16.12.2010 um 00:44 schrieb Pavel Sanda: >> >> >>> Stephan Witt wrote: >>> Index: src/frontends/Clipboard.h === >

Re: Fix compiler warnings in pedantic mode

On 12/16/2010 07:25 AM, Stephan Witt wrote: Am 16.12.2010 um 00:44 schrieb Pavel Sanda: Stephan Witt wrote: Index: src/frontends/Clipboard.h === --- src/frontends/Clipboard.h (Revision 36891) +++ src/frontends/Clipboar

Re: Fix compiler warnings in pedantic mode

Am 15.12.2010 um 23:16 schrieb Jean-Marc Lasgouttes: > Le 15/12/2010 22:36, Stephan Witt a écrit : >> I tried to compile LyX with -pedantic option. >> >> Most warnings are easy to fix. See the attached patch. > > The patch looks correct, except for some of the casts in .m files (but > they can p

Re: Fix compiler warnings in pedantic mode

Am 16.12.2010 um 00:44 schrieb Pavel Sanda: > Stephan Witt wrote: >> Index: src/frontends/Clipboard.h >> === >> --- src/frontends/Clipboard.h(Revision 36891) >> +++ src/frontends/Clipboard.h(Arbeitskopie) >> @@ -39,7 +

Re: Fix compiler warnings in pedantic mode

Stephan Witt wrote: > Index: src/frontends/Clipboard.h > === > --- src/frontends/Clipboard.h (Revision 36891) > +++ src/frontends/Clipboard.h (Arbeitskopie) > @@ -39,7 +39,7 @@ > LinkBackGraphicsType, > EmfG

Re: Fix compiler warnings in pedantic mode

On Wed, Dec 15, 2010 at 11:16:34PM +0100, Jean-Marc Lasgouttes wrote: > Le 15/12/2010 22:36, Stephan Witt a écrit : > >I tried to compile LyX with -pedantic option. > > > >Most warnings are easy to fix. See the attached patch. > > The patch looks correct, except for some of the casts in .m files (

Re: Fix compiler warnings in pedantic mode

Le 15/12/2010 22:36, Stephan Witt a écrit : I tried to compile LyX with -pedantic option. Most warnings are easy to fix. See the attached patch. The patch looks correct, except for some of the casts in .m files (but they can probably not be avoided). But one isn't that easy: src/frontends/q

Fix compiler warnings in pedantic mode

I tried to compile LyX with -pedantic option. Most warnings are easy to fix. See the attached patch. But one isn't that easy: src/frontends/qt4/GuiProgressView.cpp: In member function 'void lyx::frontend::GuiProgressView::debugSelectionChanged()': src/frontends/qt4/GuiProgressView.cpp:149: warn

Re: Compiler Warnings

Stephan Witt writes: > Apropos... > > What about this? Looks good. JMarc

Compiler Warnings

Apropos... What about this? Stephan Index: src/mathed/InsetMathHull.cpp === --- src/mathed/InsetMathHull.cpp(Revision 34630) +++ src/mathed/InsetMathHull.cpp(Arbeitskopie) @@ -1469,7 +1469,7 @@ case LFUN_MATH

Re: Compiler warnings (session.h)

I think this one is for you: In file included from /home/software/lyx-trunk/src/bufferlist.C:20: /home/software/lyx-trunk/src/session.h:40: warning: `class lyx::SessionSection' has virtual functions but non-virtual destructor OK. I will give them an empty one. Cheers, Bo

Compiler warnings (session.h)

Bo, I think this one is for you: In file included from /home/software/lyx-trunk/src/bufferlist.C:20: /home/software/lyx-trunk/src/session.h:40: warning: `class lyx::SessionSection' has virtual functions but non-virtual destructor /home/software/lyx-trunk/src/session.h:52: warning: `class l

[PATCH] Compiler warnings

Not nice: vspace.C: In member function `const std::string VSpace::asLatexCommand(const BufferParams&) const': vspace.C:478: Warnung: control reaches end of non-void function vspace.C: In member function `int VSpace::inPixels(const BufferView&) const': vspace.C:514: Warnung: control reaches en

Re: Squash compiler warnings

Andre Poenitz wrote: However, I think we can completely remove the parameters as they are never used (in all functions with the same name). Well spotted. As it stands the cursor will get a BufferView * argument on construction and keep this all the time as member. So the patch should be safe. So

Re: Squash compiler warnings

On Fri, Nov 21, 2003 at 02:45:35PM +0100, Michael Schmitt wrote: > Hi Angus, > > you fixed a couple of compiler warnings ("unused parameters") by simply > removing the names of corresponding function parameters. > > However, I think we can completely remove the par

Squash compiler warnings

Hi Angus, you fixed a couple of compiler warnings ("unused parameters") by simply removing the names of corresponding function parameters. However, I think we can completely remove the parameters as they are never used (in all functions with the same name). I prepared a small

Re: Compiler warnings (harmless)

On Thu, Jul 17, 2003 at 08:56:23AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Thu, Jul 17, 2003 at 02:47:33AM +0200, Lars Gullik Bjønnes wrote: > | > | No 'å' in TeX after booting. Face it. You are forgotten in troll land. > | > > | > No go explain the

Re: Compiler warnings (harmless)

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, Jul 17, 2003 at 02:47:33AM +0200, Lars Gullik Bjønnes wrote: | > | No 'å' in TeX after booting. Face it. You are forgotten in troll land. | > | > No go explain the '^?' to me. | | ASCII 127 in the source there... | | Ok, in this case we might

Re: Compiler warnings (harmless)

On Thu, Jul 17, 2003 at 02:47:33AM +0200, Lars Gullik Bjønnes wrote: > | No 'å' in TeX after booting. Face it. You are forgotten in troll land. > > No go explain the '^?' to me. ASCII 127 in the source there... Ok, in this case we might use the 127 literally. Andre' -- Those who desire to giv

Re: Compiler warnings (harmless)

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Jul 16, 2003 at 05:37:28PM +0200, Lars Gullik Bjønnes wrote: | > | Actually, looking at the 'fix', if this stops the wrning then it is | > | indeed brain dead: | > | | > | - theCatcode['\\'] = catEscape; | > | + theCatcode[int('\\')

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 05:21:56PM +0100, Angus Leeming wrote: > >> > >> I'm going to try and book a flight tonight. If it's not too > >> expensive this late then I'll see you in Chemnitz. > > > > RyanAir Stansted <-> Altenburg 30 GPB (24-29 July) > > > > > http://www.bookryanair.com/skyl

Re: Compiler warnings (harmless)

Andre Poenitz wrote: > On Wed, Jul 16, 2003 at 05:00:43PM +0100, Angus Leeming wrote: >> > Hello Angus. What about your plans for next week btw? >> >> I'm going to try and book a flight tonight. If it's not too >> expensive this late then I'll see you in Chemnitz. > > RyanAir Stansted <-> A

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 05:28:21PM +0200, Andre Poenitz wrote: > > http://gcc.gnu.org/ml/gcc/2003-03/msg00822.html > > First answer is wrong for C++, 'c' has type 'char'... I know, as I pointed out ... > Come on, leave the cruft in, and do something serious. Testing the > noupdate patch for ins

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 05:00:43PM +0100, Angus Leeming wrote: > > Hello Angus. What about your plans for next week btw? > > I'm going to try and book a flight tonight. If it's not too > expensive this late then I'll see you in Chemnitz. RyanAir Stansted <-> Altenburg 30 GPB (24-29 July)

Re: Compiler warnings (harmless)

Andre Poenitz wrote: > On Wed, Jul 16, 2003 at 04:42:50PM +0100, Angus Leeming wrote: >> > Then, for $DEITY's sake, change it the way you like. >> >> Why so scratchy? > > Because we've already spend much more time on that issue than it is > worth while more serious stuff lies dormant. > >> I wa

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 04:42:50PM +0100, Angus Leeming wrote: > > Then, for $DEITY's sake, change it the way you like. > > Why so scratchy? Because we've already spend much more time on that issue than it is worth while more serious stuff lies dormant. > I was only saying hello. Hello Angus.

Re: Compiler warnings (harmless)

Andre Poenitz wrote: > On Wed, Jul 16, 2003 at 04:21:54PM +0100, Angus Leeming wrote: >> Andre Poenitz wrote: >> >> Elsewhere, wouldn't >> >> void MathCursor::selPaste(lyx::size_type n) >> >> be better than using size_t here? >> > >> > Why? vector<>::size_type is required to be size_t, n

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 05:42:37PM +0200, Andre' Poenitz wrote: > This is the _initial_ set of TeX's cat codes. They have not changed > during the last twenty years and it is Don Knuth's emphatically > expressed will that they won't change ever. > > No 'å' in TeX after booting. Face it. You are f

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 05:37:28PM +0200, Lars Gullik Bjønnes wrote: > | Actually, looking at the 'fix', if this stops the wrning then it is > | indeed brain dead: > | > | - theCatcode['\\'] = catEscape; > | + theCatcode[int('\\')] = catEscape; > | > > except when somebody tries: >

Re: Compiler warnings (harmless)

Angus Leeming <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | | > sigh | > | > This is completely legal code. | > | > I've committed a 'fix' nevertheless, just to shut up the compiler. | | Incidentally, what is it really trying to do? Warn us that the | subscript is signed and so might b

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 04:21:54PM +0100, Angus Leeming wrote: > Andre Poenitz wrote: > >> Elsewhere, wouldn't > >> void MathCursor::selPaste(lyx::size_type n) > >> be better than using size_t here? > > > > Why? vector<>::size_type is required to be size_t, not > > lyx::size_type... > >

Re: Compiler warnings (harmless)

Andre Poenitz wrote: >> Elsewhere, wouldn't >> void MathCursor::selPaste(lyx::size_type n) >> be better than using size_t here? > > Why? vector<>::size_type is required to be size_t, not > lyx::size_type... But you are hiding the fact that you store the stuff in a vector yet should stil

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 04:17:36PM +0100, John Levon wrote: > On Wed, Jul 16, 2003 at 05:07:45PM +0200, Andre Poenitz wrote: > > > In either case, we use only positive 7 bit values there. > > Well, assuming ascii ... > > Even so, I did ask about this, to no avail : > > http://gcc.gnu.org/ml/gcc

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 04:14:18PM +0100, Jose' Matos wrote: > On Wednesday 16 July 2003 16:07, Andre Poenitz wrote: > > > > In either case, we use only positive 7 bit values there. So the > > message _is_ braindead. > > Oh, do you mean that ISO C++ requires that '\\' is always less than > 12

Re: Compiler warnings (harmless)

John Levon wrote: > On Wed, Jul 16, 2003 at 03:36:42PM +0100, Angus Leeming wrote: > >> Incidentally, what is it really trying to do? Warn us that the >> subscript is signed and so might be negative? > > No, it's warning that "char" may be signed /or/ unsigned, and that's > platform dependent. >

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 05:07:45PM +0200, Andre Poenitz wrote: > In either case, we use only positive 7 bit values there. Well, assuming ascii ... Even so, I did ask about this, to no avail : http://gcc.gnu.org/ml/gcc/2003-03/msg00822.html I suspect because testing for positiveness would make

Re: Compiler warnings (harmless)

On Wednesday 16 July 2003 16:07, Andre Poenitz wrote: > > In either case, we use only positive 7 bit values there. > So the message _is_ braindead. Oh, do you mean that ISO C++ requires that '\\' is always less than 127? Ok, I think I stepped that part. ;-) I know that weird IBM charset, EBC

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 04:05:03PM +0100, John Levon wrote: > On Wed, Jul 16, 2003 at 03:36:42PM +0100, Angus Leeming wrote: > > > Incidentally, what is it really trying to do? Warn us that the > > subscript is signed and so might be negative? > > No, it's warning that "char" may be signed /or/

Re: Compiler warnings (harmless)

On Wed, Jul 16, 2003 at 03:36:42PM +0100, Angus Leeming wrote: > Andre Poenitz wrote: > > > sigh > > > > This is completely legal code. > > > > I've committed a 'fix' nevertheless, just to shut up the compiler. > > Incidentally, what is it really trying to do? Warn us that the > subscript is s

  1   2   >