However, I think we can completely remove the parameters as they are never used (in all functions with the same name).
Well spotted.
As it stands the cursor will get a BufferView * argument on construction and keep this all the time as member. So the patch should be safe.
So please apply the patch.
There is a similar "problem" with methods "open" and "close" in the insets directory. IMHO the status of a collapsable inset (open/closed) should be independent from a particular buffer.
Indeed.
The update() is unneeded nowadays, and the bv->buffer()->markDirty();
should be handled by the LFUN handler calling status. Probably LFUN_INSET_TOGGLE in text3.C and/or lyxfunc.C.
I will try to prepare a patch.
Michael
