Le 16 décembre 2017 06:59:12 GMT+01:00, Richard Heck <rgh...@lyx.org> a écrit :
>commit 71005d6c1079637d7127defc372a5aa4d62092b0
>Author: Richard Heck <rgh...@lyx.org>
>Date:   Sat Dec 16 00:59:07 2017 -0500
>
>    Fix #10894 compiler warnings.
>---
> src/insets/InsetCitation.cpp |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/insets/InsetCitation.cpp
>b/src/insets/InsetCitation.cpp
>index 8377796..236dda2 100644
>--- a/src/insets/InsetCitation.cpp
>+++ b/src/insets/InsetCitation.cpp
>@@ -253,8 +253,8 @@ docstring InsetCitation::toolTip(BufferView const &
>bv, int, int) const
>       docstring tip;
>       tip += "<ol>";
>       int count = 0;
>-      for (docstring const & key : keys) {
>-              docstring const key_info = bi.getInfo(key, buffer(), ci);
>+      for (docstring const & kit : keys) {
>+              docstring const key_info = bi.getInfo(kit, buffer(), ci);
>               // limit to reasonable size.
>               if (count > 9 && keys.size() > 11) {
>                       tip.push_back(0x2026);// HORIZONTAL ELLIPSIS

I do not think that we should use 'it' in variable names in range-based for(). 
These are not iterators, but variables.

JMarc

Reply via email to