Le 13/02/2020 à 18:16, Pavel Sanda a écrit :
On Wed, Feb 12, 2020 at 08:53:14PM +0100, Jean-Marc Lasgouttes wrote:
3. NULL pointer usage
In GuiView::dispatchVC are different buffer pointer variables used.
Sometimes there is an explicit check for NULL value.
Sometimes there is an assertion with break or return for release builds.
This looks inconsistent.
This is inconsistent indeed.
I can replace asserts with explicit checks if you agree.
Or completely delete those checks because for most of them getStatus won't let
you in without buffer anyway.
Either solution will be OK. And do not forget #11725 ;)
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
