Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Georg Baum
Abdelrazak Younes wrote: > You have a point here... It is maybe better to do everything within the > frontend because Input Methods are a frontend thing to start with. The > problem is to draw the line as to what the kernel should know about what > is displayed on screen. IMO: As much as necessar

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Lars Gullik Bjønnes wrote: Setting underline as dashes or setting text in reverseVideo. Shouldn't that be user visible features. Does LateX support dashed underline? If yes, is it easy to implement? Maybe with the soul package, I don't know. Is t

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Georg Baum
Abdelrazak Younes wrote: > Lars Gullik Bjønnes wrote: >> Setting underline as dashes or setting text in reverseVideo. Shouldn't >> that be user visible features. > > Does LateX support dashed underline? If yes, is it easy to implement? Maybe with the soul package, I don't know. > Is > there so

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Setting underline as dashes or setting text in reverseVideo. Shouldn't that be user visible features. Does LateX support dashed underline? If yes, is it easy to implement? Is there somebody willing to implement it right now? If the answer to one question is no, then

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread 岩見昌範
05 Mar 2007 15:14:02 +0100, Lars Gullik Bjønnes <[EMAIL PROTECTED]>: Setting underline as dashes or setting text in reverseVideo. Shouldn't that be user visible features. If we wait or not, depends on if this is going to be a user settable feature(s). If the user should be able to do it it m

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Jose, Lars, objection? | > Not that two featrues are ins this one: | > - reverse video | > - dashedUnderline | | Man, I have barely enough time to sup

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Jose, Lars, objection? Not that two featrues are ins this one: - reverse video - dashedUnderline Man, I have barely enough time to support this so don't ask me to do even more. Iwami, if you want to pl

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread 岩見昌範
At the beginning of QLPainter::text() you fill two rectangles: if (f.dashedUnderbar() == LyXFont::ON) fillRectangle(x, y - fi.metrics->maxAscent(), textwidth, fi.metrics->maxHeight(), LColor::background); Why do you need this one? The background is

Re: [PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Jose, Lars, objection? Not that two featrues are ins this one: - reverse video - dashedUnderline (Q: shouldn't these be usevisible?) | Index: frontends/qt4/QLPainter.C | =

[PATCH] minimal dashed underline support (was Re: Add cjk support)

2007-03-05 Thread Abdelrazak Younes
岩見昌範 wrote: I wanted a patch for _on_the_spot_ support that was as minimal as possible; that is to say that did not draw things by itself. As it is now, support_dashed_underline.patch must be applied _before_ support_on_the_spot.patch and I wanted the opposite. But maybe what I am asking is not f

Re: Add cjk support

2007-03-04 Thread 岩見昌範
Hum it seems that you misunderstood me. Surely because I did not make myself clear :-( I am sorry to have not been unable to take meaning of a passage into consideration. Since I am not so good at English. I wanted a patch for _on_the_spot_ support that was as minimal as possible; that is to s

Re: Add cjk support

2007-03-04 Thread Abdelrazak Younes
岩見昌範 wrote: Hi. The patch was split in two according to the instruction of Mr. Abdel. "support_dashed_underline.patch" is a patch to support "dashed underline" and "reverse video". Moreover, "support_on_the_spot.patch" is a patch to support "on the spot" in cjk. Hum it seems that you misunder

Re: Add cjk support

2007-03-03 Thread 岩見昌範
Hi, Mr. Lars, Thank your for your some advice. The patch corrected according to your advice is appended. I'd really like a more descriptive name for the preedit string instead of just 'text2'. 'preedString' perhaps? (or 'preedText') Ahh 'text3' :-) Better name please. When the source was re

Re: Add cjk support

2007-03-03 Thread Lars Gullik Bjønnes
"ä«»Ï" <[EMAIL PROTECTED]> writes: | Hi. | | The patch was split in two according to the instruction of Mr. Abdel. | | "support_dashed_underline.patch" is a patch to | support "dashed underline" and "reverse video". | Moreover, "support_on_the_spot.patch" is a patch to support "on the | spot" in

Re: Add cjk support

2007-03-03 Thread 岩見昌範
Hi. The patch was split in two according to the instruction of Mr. Abdel. "support_dashed_underline.patch" is a patch to support "dashed underline" and "reverse video". Moreover, "support_on_the_spot.patch" is a patch to support "on the spot" in cjk. -- M. Iwami support_dashed_underline.patc

Re: Add cjk support

2007-03-02 Thread Abdelrazak Younes
岩見昌範 wrote: So, if I understand you correctly, this is the only thing that your patch change? Yes, This patch enables the use of input method by "On the spot" (on Windows). What about the Underbar and DotUnderbar methods? Is this a way to have a horizontal cursor that span the character wid

Re: Add cjk support

2007-03-02 Thread 岩見昌範
So, if I understand you correctly, this is the only thing that your patch change? Yes, This patch enables the use of input method by "On the spot" (on Windows). What about the Underbar and DotUnderbar methods? Is this a way to have a horizontal cursor that span the character width? The preed

Re: Add cjk support

2007-03-02 Thread Abdelrazak Younes
岩見昌範 wrote: I've applied the patch, and find out that the patch changes the inputmethod style from "off the spot"(current default inputmethod style of lyx1.5.0beta1) to "on the spot". Other than that, I cannot see any difference up to now. Cghan, Thank you for your test. Mr. Iwami, can you t

Re: Add cjk support

2007-03-02 Thread 岩見昌範
I've applied the patch, and find out that the patch changes the inputmethod style from "off the spot"(current default inputmethod style of lyx1.5.0beta1) to "on the spot". Other than that, I cannot see any difference up to now. Cghan, Thank you for your test. Mr. Iwami, can you tell us what

Re: Add cjk support

2007-03-02 Thread 한창길
Hello, - Original Message - >> From: Abdelrazak Younes <[EMAIL PROTECTED]> >> To: lyx-devel@lists.lyx.org >> Date: 2007-03-01 21:34:06 >> Subject: Re: Add cjk support >> >> >> Cghan, are you reading this? Your experience would help I

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread 岩見昌範
The patch file corrected according to the instruction of Lars is appended. And I am developing on windows, and how it operates on other OS is not understood though it forgot to say. Someone, please offer information. -- M. Iwami cjk_support.patch Description: Binary data

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread 岩見昌範
02 Mar 2007 01:59:05 +0100, Lars Gullik Bjønnes <[EMAIL PROTECTED]>: "ä«»Ï" <[EMAIL PROTECTED]> writes: Lgb, Thank you, for your informative and helpful indication. Some Answers follow. Does line_onoffdash really draw a dottet underline? Or a dashed underline? either line_onoffdash needs to c

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread Lars Gullik Bjønnes
"ä«»Ï" <[EMAIL PROTECTED]> writes: | Oh, Moreover, it had been forgotten to append the file. | Index: src/frontends/Painter.C === --- src/frontends/Painter.C (revision 17389) +++ src/frontends/Painter.C (working copy) @@ -97

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread 岩見昌範
Oh, Moreover, it had been forgotten to append the file. -- M. Iwami cjk_support.patch Description: Binary data

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread 岩見昌範
Abdel, Thank yor for some advice. An easy comment was added to inputMethodEvent and inputMethodQuery for the time being. Please point out the place not understood easily. Please test, and feed back this patch to China, Japan or Korea by all means. -- M. Iwami

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread 岩見昌範
Problem is that I don't know what is intended :-) Indeed... I've tried to read the patch but I fail to understand what it does. Could you add some comments please? OK, try to add comment. Cghan, are you reading this? Your experience would help I am sure... The problem is not brought up or

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread Abdelrazak Younes
岩見昌範 wrote: 2007/3/1, Abdelrazak Younes <[EMAIL PROTECTED]>: I am forwarding this mail to the devel list. Please don't forget to put it in copy next time. I am not sure I understand correctly what you mean. I was asking about what problems does your patch solve not about the patch implementation

Re: [Fwd: Re: Add cjk support]

2007-03-01 Thread 岩見昌範
2007/3/1, Abdelrazak Younes <[EMAIL PROTECTED]>: I am forwarding this mail to the devel list. Please don't forget to put it in copy next time. I am not sure I understand correctly what you mean. I was asking about what problems does your patch solve not about the patch implementation details. A

[Fwd: Re: Add cjk support]

2007-03-01 Thread Abdelrazak Younes
I am forwarding this mail to the devel list. Please don't forget to put it in copy next time. I am not sure I understand correctly what you mean. I was asking about what problems does your patch solve not about the patch implementation details. Anyway, I will try to review the patch but it see

Re: Add cjk support

2007-03-01 Thread Abdelrazak Younes
岩見昌範 wrote: Hello, every LyX developers. Hi, I'm Masanori Iwami from Japan. I made the patch for CJK support. Please check the patch and commit svn tree. You forgot to attach the path. // Known problem: this patch is not follow object-orientation. For example, // QLPainter::text is ca

Add cjk support

2007-03-01 Thread 岩見昌範
Hello, every LyX developers. I'm Masanori Iwami from Japan. I made the patch for CJK support. Please check the patch and commit svn tree. // Known problem: this patch is not follow object-orientation. For example, // QLPainter::text is called directly in GuiWorkArea::inputMethodEvent. -- M. Iw