Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Jose, Lars, objection?
Not that two featrues are ins this one:
- reverse video
- dashedUnderline
Man, I have barely enough time to support this so don't ask me to do
even more. Iwami, if you want to please Lars, split my version of the
patch in two (I won't do it).
(Q: shouldn't these be usevisible?)
I can't parse this.
| Index: frontends/qt4/QLPainter.C
| ===================================================================
| switch (ls) {
| case line_solid: pen.setStyle(Qt::SolidLine); break;
| case line_onoffdash: pen.setStyle(Qt::DotLine); break;
Hmm... but Qt::DotLine is wrong... it should have been Qt::DashLine
shouldn't it? (How come DotLine was choosen for line_ofoffdash?)
I don't know. It was like this in the original qt2 frontend I guess.
| Index: lyxfont.C
| ===================================================================
| --- lyxfont.C (revision 17409)
| +++ lyxfont.C (working copy)
| @@ -278,6 +278,18 @@
| }
|
Some of the font changes feel/look wrong...
First of all dashedUnderbar is just a special case of underbar and
they are not even possible at the same time (or shouldn't be). I think
that both underbar and dashedUnderbar needs to change type. F.ex. to
an "enum UnderBarType".
enum UnderBarType {
no_bar,
line_bar,
dash_bar
};
or something.
Do you want to do this now? The underbar property is used in many place;
this kind of surgery can wait for 1.6 IMHO.
Abdel.
