Re: [patch] par->pit

2004-11-29 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sat, Nov 27, 2004 at 05:14:31PM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | On Wed, Nov 24, 2004 at 10:45:19PM +0100, Lars Gullik Bjønnes wrote: >> >> I do not like the pit_type name at all. From what I can

Re: [patch] par->pit

2004-11-29 Thread Andre Poenitz
On Sat, Nov 27, 2004 at 05:14:31PM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Wed, Nov 24, 2004 at 10:45:19PM +0100, Lars Gullik Bjønnes wrote: > >> I do not like the pit_type name at all. From what I can see this is > >> really some kind of offset. So p

Re: [patch] par->pit

2004-11-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Nov 24, 2004 at 10:45:19PM +0100, Lars Gullik Bjønnes wrote: >> I do not like the pit_type name at all. From what I can see this is >> really some kind of offset. So perhaps par_offset_type or just >> offset_type or par_offset is better. > | I;'d

Re: [patch] par->pit

2004-11-27 Thread Andre Poenitz
On Wed, Nov 24, 2004 at 10:45:19PM +0100, Lars Gullik Bjønnes wrote: > I do not like the pit_type name at all. From what I can see this is > really some kind of offset. So perhaps par_offset_type or just > offset_type or par_offset is better. I;'d agree everything that has the same lenght as 'pos_

Re: [patch] par->pit

2004-11-24 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > | I'll commit this briefly. > > You should go ahead, despite my comments. Ok. > I do not like the pit_type name at all. From what I can see this is > really some kind of offset. So perhaps par_offset_type or just > offset_type or par_offset is better. Yes, I agree.

Re: [patch] par->pit

2004-11-24 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | This patch renames CursorSlice::par() and LCursor::par() to pit() and | lyx::par_type to lyx::pit_type, and was part of Andre's original coord | patch. > | I'll commit this briefly. You should go ahead, despite my comments. I do not like the pit_t

[patch] par->pit

2004-11-24 Thread Alfredo Braunstein
This patch renames CursorSlice::par() and LCursor::par() to pit() and lyx::par_type to lyx::pit_type, and was part of Andre's original coord patch. I'll commit this briefly. Regards, Alfredo parpit.diff.gz Description: GNU Zip compressed data