Jürgen Spitzmüller wrote:
Uwe Stöhr wrote:
That the dialog is not opened has always been very annoying for me,
therefore I tried to fix this.
For me, it is annoying if it is always opened.
What do others think?
I think this depends a lot on the type of text being indexed.
Some wil
Jürgen Spitzmüller wrote:
Uwe Stöhr wrote:
That the dialog is not opened has always been very annoying for me,
therefore I tried to fix this.
For me, it is annoying if it is always opened.
What do others think?
I think I agree with you. I personally never change the text so I
remember bein
Uwe Stöhr wrote:
> For me, it is annoying if it is always opened.
OK, but have you already indexed some documents?
Yes, otherwise I wouldn't comment.
The larger the number of index entries the more it will annoy you.
I admit that my document were not large...
Abdel.
Jürgen Spitzmüller wrote:
Jürgen Spitzmüller wrote:
Furthermore, it doesn't fix bug 2907: C-i still doesn't open the inset's
dialog. Do fix this (which also applies to url, nomenclature and others),
you'd need the change LFUN_NEXT_INSET_TOGGLE or LFUN_INSET_TOGGLE,
respectively. But then. you ha
Uwe Stöhr <[EMAIL PROTECTED]> writes:
>> I'd prefer 2 lfuns.
>
> But then users have to edit the bind file to switch between the
> functions. This is not user friendly. chaning an option in the prefs
> is intuitive and quicker.
No, I would propose two keyboard bindings. Menus are not relevant,
si
> I'd prefer 2 lfuns.
But then users have to edit the bind file to switch between the functions. This is not user
friendly. chaning an option in the prefs is intuitive and quicker.
regards Uwe
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes:
> I have tested (a bit) and it works for me. The only thing that could
> happen is that inset->edit() is called somewhere which would now
> open the dialog unintentionally (which was the case in Text3.cpp).
>
> So I guess I'll check for such instances
Jean-Marc Lasgouttes wrote:
> > How about the attached?
>
> It looks good to me (but I have no time to try it out).
I have tested (a bit) and it works for me. The only thing that could happen is
that inset->edit() is called somewhere which would now open the dialog
unintentionally (which was the
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes:
>> I see. I'll have a look.
>
> How about the attached?
It looks good to me (but I have no time to try it out).
JMarc
Jürgen Spitzmüller wrote:
> > Sorry indeed. InsetCommand should maybe have something like
> > InsetGraphics:
> > void InsetGraphics::edit(Cursor & cur, bool)
> > {
> > InsetGraphicsMailer(*this).showDialog(&cur.bv());
> > }
> >
> > (and then should use it when handling MOUSE_RELEASE).
>
> I
Jean-Marc Lasgouttes wrote:
> Sorry indeed. InsetCommand should maybe have something like
> InsetGraphics:
> void InsetGraphics::edit(Cursor & cur, bool)
> {
> InsetGraphicsMailer(*this).showDialog(&cur.bv());
> }
>
> (and then should use it when handling MOUSE_RELEASE).
I see. I'll have a
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes:
> Jean-Marc Lasgouttes wrote:
>> You should definitely not use these xxx_CODE tests. This is wrong in
>> 99% of cases. Test whether inset->editable() == IS_EDITABLE and then
>> call inset->edit(). The code will be much shorter IMO.
>
> Doesn't seem to
Uwe Stöhr <[EMAIL PROTECTED]> writes:
> Concerning the dialog display, I think different types of text
> requires a different action. So the only solution I see is to have an
> option in the preferences where the user can switch between display or
> not.
I'd prefer 2 lfuns.
JMarc
>> Not that besides the many sub level entries you also have many entries
>> at top level that consists of more than one word. So also in these
>> cases, you have to modify the index entry in the dialog.
>
> You just select the string and insert an index entry.
I didn't know this. I'll add this i
Jean-Marc Lasgouttes wrote:
> You should definitely not use these xxx_CODE tests. This is wrong in
> 99% of cases. Test whether inset->editable() == IS_EDITABLE and then
> call inset->edit(). The code will be much shorter IMO.
Doesn't seem to work. Inset->edit() doesn't open the dialog (not surpri
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes:
> Jürgen Spitzmüller wrote:
>> Furthermore, it doesn't fix bug 2907: C-i still doesn't open the inset's
>> dialog. Do fix this (which also applies to url, nomenclature and others),
>> you'd need the change LFUN_NEXT_INSET_TOGGLE or LFUN_INSET_TOGGLE,
Uwe Stöhr wrote:
> OK, but have you already indexed some documents?
Sure.
> The larger the number of index entries the more it will annoy you.
I guess we simply index different types of text.
Jürgen
Uwe Stöhr <[EMAIL PROTECTED]> writes:
>> When you create an index you have in 90% of the cases to modify the entry.
>>
>> where do you get the statistics from?
>
> See the new UserGuide or EmbeddedObjects manual. Only about 10% of the
> entries are exactly the one word that is in front of the inde
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes:
>> The fix I sent increases the workflow a lot and I don't know why this was
>> removed in LyX 1.4.x.
>
> I think we even had a request for this.
Yes. Not everybody has the same use of indices. So some people
complained that closing the dialog everyt
On Sep 10, 2007, at 7:57 AM, Jürgen Spitzmüller wrote:
Uwe Stöhr wrote:
That the dialog is not opened has always been very annoying for me,
therefore I tried to fix this.
For me, it is annoying if it is always opened.
What do others think?
I think the 90% figure for modifying index entries
> For me, it is annoying if it is always opened.
OK, but have you already indexed some documents?
The larger the number of index entries the more it will annoy you.
regards Uwe
Uwe Stöhr wrote:
> That the dialog is not opened has always been very annoying for me,
> therefore I tried to fix this.
For me, it is annoying if it is always opened.
What do others think?
Jürgen
> When you create an index you have in 90% of the cases to modify the entry.
>
> where do you get the statistics from?
See the new UserGuide or EmbeddedObjects manual. Only about 10% of the entries are exactly the one
word that is in front of the index entry box.
Not that besides the many sub le
Uwe Stöhr wrote:
> When you create an index you have in 90% of the cases to modify the entry.
where do you get the statistics from?
> In indexes you group entries, therefore you have lots of second and
> third-level entries like e.g.
>
> Figures ! Floats
Not always.
> I indexed a lot the last t
> However, I think this is the wrong approach: it opens the index dialog
> unnecessarily (i.e., if the word-at-cursor is filled in, which is often the
> desired behaviour, and closing the dialog each and every time is annoying).
When you create an index you have in 90% of the cases to modify the
Jürgen Spitzmüller wrote:
> Furthermore, it doesn't fix bug 2907: C-i still doesn't open the inset's
> dialog. Do fix this (which also applies to url, nomenclature and others),
> you'd need the change LFUN_NEXT_INSET_TOGGLE or LFUN_INSET_TOGGLE,
> respectively. But then. you have to take care that
Uwe Stöhr wrote:
> Attached is a batch for bug 2907
> http://bugzilla.lyx.org/show_bug.cgi?id=2907
>
> It shows the index dialog like in LyX 1.3.x and previous.
>
> The code is stolen from LFUN_NOMENCL_INSERT and works as expected.
> If there are no objections, can this go into branch?
If any, I w
On Mon, Sep 10, 2007 at 12:44:56AM +0200, Uwe Stöhr wrote:
> Attached is a batch for bug 2907
> http://bugzilla.lyx.org/show_bug.cgi?id=2907
>
> It shows the index dialog like in LyX 1.3.x and previous.
>
> The code is stolen from LFUN_NOMENCL_INSERT and works as expected.
> If there are no objec
Attached is a batch for bug 2907
http://bugzilla.lyx.org/show_bug.cgi?id=2907
It shows the index dialog like in LyX 1.3.x and previous.
The code is stolen from LFUN_NOMENCL_INSERT and works as expected.
If there are no objections, can this go into branch?
regards Uwe
Index: Text3.cpp
==
29 matches
Mail list logo
