[EMAIL PROTECTED] (Jürgen Spitzmüller) writes: > Jürgen Spitzmüller wrote: >> Furthermore, it doesn't fix bug 2907: C-i still doesn't open the inset's >> dialog. Do fix this (which also applies to url, nomenclature and others), >> you'd need the change LFUN_NEXT_INSET_TOGGLE or LFUN_INSET_TOGGLE, >> respectively. But then. you have to take care that all-insets-toggle >> doesn't pop up the dialogs as well. > > The attached patch would do this (probably it can be simplified a bit).
You should definitely not use these xxx_CODE tests. This is wrong in 99% of cases. Test whether inset->editable() == IS_EDITABLE and then call inset->edit(). The code will be much shorter IMO. This is how it used to work in the old days, and then someone argued that toggling and editing is different. For example, we do not have a shortcut to display the float inset dialog. JMarc
