Re: [patch] esint support

> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Monday 13 November 2006 1:33 pm, Jean-Marc Lasgouttes wrote: >> Would it be possible to declare updateLabels in InsetBase instead >> of special casing insetinclude? It would be useful in other cases. >> >> This would mean that the ma

Re: [patch] esint support

On Monday 13 November 2006 1:33 pm, Jean-Marc Lasgouttes wrote: > Would it be possible to declare updateLabels in InsetBase instead of > special casing insetinclude? It would be useful in other cases. > > This would mean that the main updatelabels should be moved to > InsetText::updateLabels and do

Re: [patch] esint support

On Saturday 11 November 2006 1:45 pm, Georg Baum wrote: > I consider this now stable enough and ready for 1.5.0. What do you think > José? And what about the esint stuff? Yes on both accounts. :-) > Georg -- José Abílio

Re: [patch] esint support

> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> This would mean that the main updatelabels should be moved to >> InsetText::updateLabels and do a simple loop over the paragraph >> list. Abdelrazak> Yes. Would you do it? ;-) ;) First I'll try to see if I can find time to a

Re: [patch] esint support

Jean-Marc Lasgouttes wrote: "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> As I wrote I do not like that. I updated my version after your Georg> changes, and here it is. The patch lloks bigger than it really Georg> is, because most of the changes are renamed toc stuff. I also Georg> s

Re: [patch] esint support

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> As I wrote I do not like that. I updated my version after your Georg> changes, and here it is. The patch lloks bigger than it really Georg> is, because most of the changes are renamed toc stuff. I also Georg> solved the problem of non-

Re: [patch] esint support

Georg Baum wrote: Am Samstag, 11. November 2006 03:05 schrieb Abdelrazak Younes: Abdelrazak Younes wrote: I wonder if this addToToc() method is a good idea at all... I'd prefer the TocBackend to it himself. InsetInclude doesn't need to know how to do that. The same goes for InsetFloat and Inse

Re: [patch] esint support

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> Here is a patch that does that for InsetInclude. This is cleaner >> IMHO even if the special cases in TocBackend are still ugly. Georg> I like the solution with addToToc better. In general we tried Georg> to remove as much as possible spe

Re: [patch] esint support

Am Samstag, 11. November 2006 14:59 schrieb Abdelrazak Younes: > Georg Baum wrote: > > I changed the stuff in InsetInclude to not load the document anymore. That > > speeds up loading of the master a lot. Of course the included docs are now > > only shown in the navigate menu if they are alread

Re: [patch] esint support

Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I was partly wrong. While disabling these methods Abdelrazak> definitely helps (with the attached patch), the csrss.exe Abdelrazak> problem and the poor typing perform

Re: [patch] esint support

Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I was partly wrong. While disabling these methods Abdelrazak> definitely helps (with the attached patch), the csrss.exe Abdelrazak> problem and the poor typing performance at the end the doc Ab

Re: [patch] esint support

Georg Baum wrote: Am Samstag, 11. November 2006 03:05 schrieb Abdelrazak Younes: Abdelrazak Younes wrote: I wonder if this addToToc() method is a good idea at all... I'd prefer the TocBackend to it himself. InsetInclude doesn't need to know how to do that. The same goes for InsetFloat and Inse

Re: [patch] esint support

Georg Baum wrote: Am Samstag, 11. November 2006 03:05 schrieb Abdelrazak Younes: I wonder if this addToToc() method is a good idea at all... I'd prefer the TocBackend to it himself. InsetInclude doesn't need to know how to do that. The same goes for InsetFloat and InsetWrap I guess. It is a g

Re: [patch] esint support

Am Samstag, 11. November 2006 03:05 schrieb Abdelrazak Younes: > Abdelrazak Younes wrote: > > I wonder if this addToToc() method is a good idea at all... I'd prefer > > the TocBackend to it himself. InsetInclude doesn't need to know how to > > do that. The same goes for InsetFloat and InsetWrap I

Re: [patch] esint support

Am Samstag, 11. November 2006 03:05 schrieb Abdelrazak Younes: > > I wonder if this addToToc() method is a good idea at all... I'd prefer > > the TocBackend to it himself. InsetInclude doesn't need to know how to > > do that. The same goes for InsetFloat and InsetWrap I guess. It is a good idea

Re: [patch] esint support

Am Freitag, 10. November 2006 22:39 schrieb Abdelrazak Younes: > Because the plan is to move toc.[Ch] altogether. We can then rename > TocBackend to something else if you want. I don't care about the name as long as the code speaks for itself. > > I do neither understand why TocBackend is not in

Re: [patch] esint support

> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I was partly wrong. While disabling these methods Abdelrazak> definitely helps (with the attached patch), the csrss.exe Abdelrazak> problem and the poor typing performance at the end the doc Abdelrazak> is still there.

Re: [patch] esint support

Abdelrazak Younes wrote: Georg Baum wrote: Am Donnerstag, 9. November 2006 13:40 schrieb Abdelrazak Younes: Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: This patch adds support for the esint package: Georg, could you post an updated patch for the multi-document toc? I neve

Re: [patch] esint support

Enrico Forestieri wrote: On Sat, Nov 11, 2006 at 01:47:38AM +0100, Abdelrazak Younes wrote: I was partly wrong. While disabling these methods definitely helps (with the attached patch), the csrss.exe problem and the poor typing performance at the end the doc is still there. Abdel, csrss.exe

Re: [patch] esint support

Georg Baum wrote: Am Donnerstag, 9. November 2006 13:40 schrieb Abdelrazak Younes: Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: This patch adds support for the esint package: Georg, could you post an updated patch for the multi-document toc? I never had it in 1.5 so far. If

Re: [patch] esint support

On Sat, Nov 11, 2006 at 01:47:38AM +0100, Abdelrazak Younes wrote: > I was partly wrong. While disabling these methods definitely helps (with > the attached patch), the csrss.exe problem and the poor typing > performance at the end the doc is still there. Abdel, csrss.exe takes a lot of cpu in

Re: [patch] esint support

Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: But all in all, I think counter code, as crude as it may be, is almost fast enough for our needs. Abdelrazak> Not on windows. And I really suspect that this is the main Abdelra

Re: [patch] esint support

Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: But all in all, I think counter code, as crude as it may be, is almost fast enough for our needs. Abdelrazak> Not on windows. And I really suspect that this is the main Abdelrazak> cause of our trouble

Re: [patch] esint support

> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> But all in all, I think counter code, as crude as it may be, is >> almost fast enough for our needs. Abdelrazak> Not on windows. And I really suspect that this is the main Abdelrazak> cause of our trouble in the math test docu

Re: [patch] esint support

Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> The TocBackend as well as the different updateLabels() Abdelrazak> functions should disappear once we tracks labels correctly Abdelrazak> on paragraph creation/deletion. I have planned to do th

Re: [patch] esint support

> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> The TocBackend as well as the different updateLabels() Abdelrazak> functions should disappear once we tracks labels correctly Abdelrazak> on paragraph creation/deletion. I have planned to do that Abdelrazak> when I get

Re: [patch] esint support

Georg Baum wrote: Am Freitag, 10. November 2006 21:14 schrieb Abdelrazak Younes: Georg Baum wrote: Why was it not possible to extend the classes in toc.h with the new functionality? Because there was no class in toc.h, only global functions that were called each time the navigate menu or an it

Re: [patch] esint support

Am Freitag, 10. November 2006 21:14 schrieb Abdelrazak Younes: > Georg Baum wrote: > > Why was it not possible to extend the classes in toc.h with the new > > functionality? > > Because there was no class in toc.h, only global functions that were > called each time the navigate menu or an item of

Re: [patch] esint support

Abdelrazak Younes wrote: Abdelrazak Younes wrote: toc.h is just there to keep the interface with MenuBackend. I didn't feel like cleaning this at the time. and insetfloatlist and insettoc... I wonder why I left that rotten... Now I remember... That's because, at the time, I was sooo scared

Re: [patch] esint support

Abdelrazak Younes wrote: toc.h is just there to keep the interface with MenuBackend. I didn't feel like cleaning this at the time. and insetfloatlist and insettoc... I wonder why I left that rotten... Abdel.

Re: [patch] esint support

Georg Baum wrote: Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> It is already ugly, adding one more special test to 3 existing Georg> ones is only a little bit uglier :-) FYI, most of the ugliness was due to the support of qt3 a

Re: [patch] esint support

Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: >>> "Georg" == Georg Baum >>> <[EMAIL PROTECTED]> >>> writes: >> >> Georg> It is already ugly, adding one more special test to 3 existing >> Georg> ones is only a little bit uglier :-) > > FYI, most of the ugliness was due to the

Re: [patch] esint support

Georg Baum wrote: Am Donnerstag, 9. November 2006 13:40 schrieb Abdelrazak Younes: Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: This patch adds support for the esint package: Georg, could you post an updated patch for the multi-document toc? I never had it in 1.5 so far. If

Re: [patch] esint support

Jean-Marc Lasgouttes wrote: "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> It is already ugly, adding one more special test to 3 existing Georg> ones is only a little bit uglier :-) FYI, most of the ugliness was due to the support of qt3 and gtk (I didn't want to break the toc cont

Re: [patch] esint support

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> It is already ugly, adding one more special test to 3 existing Georg> ones is only a little bit uglier :-) The goal should be to remove those ugly tests altogether. This would also allow to have special numbering code for notes and br

Re: [patch] esint support

Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> Thanks, here is the patch. In the 1.4 version I was able to > Georg> make addToToc a virtual function of InsetBase, but in trunk > Georg> that is not possible anymore because it would cre

Re: [patch] esint support

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Thanks, here is the patch. In the 1.4 version I was able to Georg> make addToToc a virtual function of InsetBase, but in trunk Georg> that is not possible anymore because it would create a circular Georg> include dependency (insetbase.

Re: [patch] esint support

I forgot one file in the patch. Georg Index: src/MenuBackend.C === --- src/MenuBackend.C (Revision 15835) +++ src/MenuBackend.C (Arbeitskopie) @@ -35,6 +35,8 @@ #include "lyx_main.h" // for lastfiles #include "lyxfunc.h" #include

Re: [patch] esint support

Am Donnerstag, 9. November 2006 13:40 schrieb Abdelrazak Younes: > Georg Baum wrote: > > Abdelrazak Younes wrote: > > > >> Georg Baum wrote: > >>> This patch adds support for the esint package: > >> Georg, could you post an updated patch for the multi-document toc? > > > > I never had it in 1.5 s

Re: [patch] esint support

Georg Baum schrieb: > Am Donnerstag, 9. November 2006 15:18 schrieb Herbert Voss: >> Georg Baum schrieb: >>> - load the wasysym package automatically if esint gets loaded, since > esint >>> redefines the integrals in a consistent way >>> (http://bugzilla.lyx.org/show_bug.cgi?id=1942). >> where is

Re: [patch] esint support

Am Donnerstag, 9. November 2006 15:18 schrieb Herbert Voss: > Georg Baum schrieb: > > - load the wasysym package automatically if esint gets loaded, since esint > > redefines the integrals in a consistent way > > (http://bugzilla.lyx.org/show_bug.cgi?id=1942). > > where is the sense to load wasys

Re: [patch] esint support

Georg Baum schrieb: > This patch adds support for the esint package: > > - new header flag for esint (can be off, auto, on). Since the package is > quite new (tetex doew not have it, but texlive), and because some people > might like the different look of wasysym integrals (or define their own) it

Re: [patch] esint support

Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: This patch adds support for the esint package: Georg, could you post an updated patch for the multi-document toc? I never had it in 1.5 so far. If you can tell me what happened to updateCounters() and where I can find the replacem

Re: [patch] esint support

Abdelrazak Younes wrote: > Georg Baum wrote: >> This patch adds support for the esint package: > > Georg, could you post an updated patch for the multi-document toc? I never had it in 1.5 so far. If you can tell me what happened to updateCounters() and where I can find the replacement code I can

Re: [patch] esint support

Georg Baum wrote: This patch adds support for the esint package: Georg, could you post an updated patch for the multi-document toc? Thanks in advance, Abdel.