Georg Baum wrote:
Am Samstag, 11. November 2006 03:05 schrieb Abdelrazak Younes:
Abdelrazak Younes wrote:
I wonder if this addToToc() method is a good idea at all... I'd prefer the TocBackend to it himself. InsetInclude doesn't need to know how to do that. The same goes for InsetFloat and InsetWrap I guess.
Here is a patch that does that for InsetInclude. This is cleaner IMHO even if the special cases in TocBackend are still ugly.

As I wrote I do not like that. I updated my version after your changes, and here it is. The patch lloks bigger than it really is, because most of the changes are renamed toc stuff. I also solved the problem of non-working setBuffer by switching to the existing view of the other buffer instead. I changed the stuff in InsetInclude to not load the document anymore. That speeds up loading of the master a lot. Of course the included docs are now only shown in the navigate menu if they are already loaded by other means, but that is a good compromise IMO.

I consider this now stable enough and ready for 1.5.0. What do you think José? And what about the esint stuff?

Did Jose answer that yet? Both patches should go in before the first alpha IMO.

Abdel.

Reply via email to