Re: [Patch] fix grid lines in AMS arrays

Am Freitag, 1. April 2005 10:34 schrieb Jean-Marc Lasgouttes: > Why is reCordUndo needed? I understand you copied the code, but I do > not see any need for it... I don't know. > Also, I am not sure I agree that deDispatch needs to have this entry. > In theory, doDispatch should never be invoked

Re: [Patch] fix grid lines in AMS arrays

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Updated and tested patch attached. Since getStatus and Georg> doDispatch should handle the same lfuns I also implemented the Georg> missing doDispatch methods. This is going in unless I get a no. Minor nit: +void MathSplitInset::doDi

Re: [Patch] fix grid lines in AMS arrays

Martin Vermeer wrote: > On Thu, Mar 31, 2005 at 09:52:57AM +0200, Jean-Marc Lasgouttes wrote: >> > "Georg" == Georg Baum >> > <[EMAIL PROTECTED]> >> > writes: >> >> Georg> I thought the reason for using the istringstream was to get rid >> Georg> of whitespace or other stuff that might

Re: [Patch] fix grid lines in AMS arrays

On Thu, Mar 31, 2005 at 09:52:57AM +0200, Jean-Marc Lasgouttes wrote: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> Martin Vermeer wrote: > >> Looks great, except that Jean-Marc is right: you can still in three > >> places replace > >> > >> istringstream is(cmd.argument); s

Re: [Patch] fix grid lines in AMS arrays

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Martin Vermeer wrote: >> Looks great, except that Jean-Marc is right: you can still in three >> places replace >> >> istringstream is(cmd.argument); string s; is >> s; >> >> by simply >> >> string const s = cmd.argument; Georg> I t

Re: [Patch] fix grid lines in AMS arrays

Georg Baum <[EMAIL PROTECTED]> writes: | Martin Vermeer wrote: > >> Looks great, except that Jean-Marc is right: you can still in three >> places replace >> >> istringstream is(cmd.argument); >> string s; >> is >> s; >> >> by simply >> >> string const s = cmd.argument; > | I thought the reason

Re: [Patch] fix grid lines in AMS arrays

Martin Vermeer wrote: > On Wed, Mar 30, 2005 at 05:57:02PM +0200, Georg Baum wrote: >> I thought the reason for using the istringstream was to get rid of >> whitespace or other stuff that might be in cmd.argument after the first >> word. Is that wrong? And if we get rid of it here we should get r

Re: [Patch] fix grid lines in AMS arrays

On Wed, Mar 30, 2005 at 05:57:02PM +0200, Georg Baum wrote: > Martin Vermeer wrote: > > > Looks great, except that Jean-Marc is right: you can still in three > > places replace > > > > istringstream is(cmd.argument); > > string s; > > is >> s; > > > > by simply > > > > string const s = cmd.argu

Re: [Patch] fix grid lines in AMS arrays

Martin Vermeer wrote: > Looks great, except that Jean-Marc is right: you can still in three > places replace > > istringstream is(cmd.argument); > string s; > is >> s; > > by simply > > string const s = cmd.argument; I thought the reason for using the istringstream was to get rid of whitespace

Re: [Patch] fix grid lines in AMS arrays

> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: Don't use N_("...") here, use Angus> _("..."). >> No, we do use N_() here, because we want to pass the message in >> english to the lyxserver. Translation is done later, except that we >> do not do it cur

Re: [Patch] fix grid lines in AMS arrays

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> No, we do use N_() here, because we want to pass the message in >> english to the lyxserver. Translation is done later, except that we >> do not do it currently :) I'll send a patch later. Georg> ?? Last

Re: [Patch] fix grid lines in AMS arrays

On Wed, 2005-03-30 at 15:10, Georg Baum wrote: > Martin Vermeer wrote: > > > > > Patch attached, please review. > > It looks good, except for the strange indentation of some closing braces. I > corrected that and merged it with my infoize fixes. I think that both > should go in. > > > Georg

Re: [Patch] fix grid lines in AMS arrays

Jean-Marc Lasgouttes wrote: > No, we do use N_() here, because we want to pass the message in > english to the lyxserver. Translation is done later, except that we do > not do it currently :) I'll send a patch later. ?? Last time I asked the same question Lars answered that these strings are part

Re: [Patch] fix grid lines in AMS arrays

Jean-Marc Lasgouttes wrote: Angus> Don't use N_("...") here, use _("..."). No, we do use N_() here, because we want to pass the message in english to the lyxserver. Translation is done later, except that we do not do it currently :) I'll send a patch later. Ach. So if someone were to add anything t

Re: [Patch] fix grid lines in AMS arrays

> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Martin Vermeer wrote: >> Patch attached, please review. + flag.message(bformat( + N_("Can't >> add vertical grid lines in '%1$s'"), + name_)); Angus> Don't use N_("...") here, use _("..."). No, we do use N_() here, because we want

Re: [Patch] fix grid lines in AMS arrays

Martin Vermeer wrote: > > Patch attached, please review. It looks good, except for the strange indentation of some closing braces. I corrected that and merged it with my infoize fixes. I think that both should go in. GeorgIndex: src/mathed/ChangeLog

Re: [Patch] fix grid lines in AMS arrays

Martin Vermeer wrote: Patch attached, please review. + flag.message(bformat( + N_("Can't add vertical grid lines in '%1$s'"), + name_)); Don't use N_("...") here, use _("..."). N_("...") expands to "...". I.e., no translation

Re: [Patch] fix grid lines in AMS arrays

> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Patch attached, please review. Why do you need an istringstream instead of just using the argument? JMarc

[Patch] fix grid lines in AMS arrays

Patch attached, please review. - Martin Index: ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/ChangeLog,v retrieving revision 1.480 diff -u -r1.480 ChangeLog --- ChangeLog 30 Mar 2005 09:05:30 - 1.480 +++ Cha