On Thu, Mar 31, 2005 at 09:52:57AM +0200, Jean-Marc Lasgouttes wrote: > >>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> Martin Vermeer wrote: > >> Looks great, except that Jean-Marc is right: you can still in three > >> places replace > >> > >> istringstream is(cmd.argument); string s; is >> s; > >> > >> by simply > >> > >> string const s = cmd.argument; > > Georg> I thought the reason for using the istringstream was to get rid > Georg> of whitespace or other stuff that might be in cmd.argument > Georg> after the first word. Is that wrong? And if we get rid of it > Georg> here we should get rid of it in all the other insets, too (not > Georg> necessarily now)... > > Then you can use FuncRequest::getArg(1). I am not sure it has the best > possible implementation, but at least this is a consistent interface. > > JMarc
Should we at this point just add a comment to this effect at a strategic location, e.g., math_gridinset? - Martin
pgphLEobzWyZN.pgp
Description: PGP signature
