Re: [Patch] Re: Crash when closing document

2007-06-01 Thread christian . ridderstrom
On Thu, 31 May 2007, Andre Poenitz wrote: On Thu, May 31, 2007 at 09:53:31PM +0200, Alfredo Braunstein wrote: Andre Poenitz wrote: I know the rules and I am sometimes even follow them. You do? There are some rules that are really hard to break... Is that the rule about not following rul

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Edwin Leuven
Andre Poenitz wrote: We want to get 1.5 out of the door. we all agree on that one Multiple views make LyX crash. Nobody is seemingly able to fix it in a reasonable time frame. you provided a reproducable way to crash lyx (being the responsible grown-up you are ;) let's see whether abdel or

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:53:31PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > I know the rules and I am sometimes even follow them. > > You do? There are some rules that are really hard to break... Andre'

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > I know the rules and I am sometimes even follow them. You do? > I said 'I will prepare a patch', not 'I will disable multiple views'. I know, just teasing you. :-) A/

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Thu, May 31, 2007 at 09:35:25PM +0200, Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> >> > We want to get 1.5 out of the door. Multiple views make LyX crash. >> > Nobody is seemingly able to fix it in a reasonable time frame. >> > So the only sensibly solution is t

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:35:25PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > We want to get 1.5 out of the door. Multiple views make LyX crash. > > Nobody is seemingly able to fix it in a reasonable time frame. > > So the only sensibly solution is to disable the feature. Note t

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:30:29PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Best thing I can do now is to plead guilty on either not reading your > > patch or not noticing the added signal. In any case the signal can't > > be left in. So either someone comes up with a real fi

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > We want to get 1.5 out of the door. Multiple views make LyX crash. > Nobody is seemingly able to fix it in a reasonable time frame. > So the only sensibly solution is to disable the feature. Note that > I said 'disable', not 'remove'. I proposed a reasonable fix avoid the c

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > Best thing I can do now is to plead guilty on either not reading your > patch or not noticing the added signal. In any case the signal can't > be left in. So either someone comes up with a real fix or I'll prepare > a patch to remove the signal and disable multiple views at

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 07:13:49PM +0200, Edwin Leuven wrote: > Andre Poenitz wrote: > >So either someone comes up with a real fix > > you're volunteering andre? No. If it were that easy I propbably would have found the time to do so when I had more time then now. > >or I'll prepare a patch to r

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, May 31, 2007 at 06:55:38PM +0200, Abdelrazak Younes wrote: I _never_ said that Angus endorsed the patch, just that he helped me. I just said that *nobody* commented the approach, period. Which in the time of an upcoming release plainly means 'rejected'. Accepte

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 06:55:38PM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >>>Also "fully" and "patch" does not help. And not "angus", "2007", > >>>"abdel" (or "signal") and a lot of other combinations. > > > >I also see that Angus solved your C++ related problem. No less, no > >mo

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Edwin Leuven
Andre Poenitz wrote: So either someone comes up with a real fix you're volunteering andre? or I'll prepare a patch to remove the signal and disable multiple views at the weekend. small kids act like this with their even smaller brothers...

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Abdelrazak Younes
Andre Poenitz wrote: Also "fully" and "patch" does not help. And not "angus", "2007", "abdel" (or "signal") and a lot of other combinations. I also see that Angus solved your C++ related problem. No less, no more. Specifically it does not comment on the general sanity of the signal-in-InsetBase

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:04:11AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Wed, May 30, 2007 at 11:39:16PM +0200, Abdelrazak Younes wrote: > >>I proposed the patch last week and it was available for comment for a > >>few days. I even had some help from Angus so I don't think t

RE: [Patch] Re: Crash when closing document

2007-05-31 Thread christian . ridderstrom
On Thu, 31 May 2007, Leuven, E. wrote: Andre Poenitz wrote: On Wed, May 30, 2007 at 11:39:16PM +0200, Abdelrazak Younes wrote: I proposed the patch last week and it was available for comment for a few days. I even had some help from Angus so I don't think this thread went unoticed. Look for so

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Had you any intentions to make a wider audience aware of these >> side-effects? Abdelrazak> Anybody who tried the multiview with the same Buffer has Abdelrazak> certainly noticed that. I noticed, Alfredo noticed, JMarc Abdelr

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, May 30, 2007 at 11:39:16PM +0200, Abdelrazak Younes wrote: I proposed the patch last week and it was available for comment for a few days. I even had some help from Angus so I don't think this thread went unoticed. Look for something with [FULLY WORKING PATCH] in th

RE: [Patch] Re: Crash when closing document

2007-05-31 Thread Leuven, E.
Andre Poenitz wrote: > On Wed, May 30, 2007 at 11:39:16PM +0200, Abdelrazak Younes wrote: >> I proposed the patch last week and it was available for comment for >> a few days. I even had some help from Angus so I don't think this >> thread went unoticed. Look for something with [FULLY WORKING PATCH

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 11:39:16PM +0200, Abdelrazak Younes wrote: > I proposed the patch last week and it was available for comment for a > few days. I even had some help from Angus so I don't think this thread > went unoticed. Look for something with [FULLY WORKING PATCH] in the subject. "2007

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, May 30, 2007 at 08:37:09AM +0200, Abdelrazak Younes wrote: Andre Poenitz wrote: On Tue, May 29, 2007 at 10:11:16PM +0200, Stefan Schimanski wrote: I enabled stdlib-debug and then were surprised about the slowness. Some profiling was full of signal/slot stuff in co

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, May 30, 2007 at 02:30:37PM +0200, Abdelrazak Younes wrote: Alfredo Braunstein wrote: Abdelrazak Younes wrote: I am not sure that registering every single DocIterator would be any more efficient that my signal/slot solution. At the end you will have to go through a

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, May 30, 2007 at 05:44:39PM +0200, Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: Abdelrazak> I won't say random because as you found out you can Abdelrazak> predict the behaviour. After I have edited during 10 minutes in one part of the document, the locati

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, May 30, 2007 at 05:46:46PM +0200, Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: These problems do not mean that you implemented badly, just that it is a bigger task than you thought. An by the way, the additional work required to properly handling these cur

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 09:27:18PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Wed, May 30, 2007 at 03:26:04PM +0200, Alfredo Braunstein wrote: > >> Just a though... why do we need the invalidation signals at all? > >> ...couldn't we go in fixIfBroken from the top to the tip o

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Wed, May 30, 2007 at 03:26:04PM +0200, Alfredo Braunstein wrote: >> Just a though... why do we need the invalidation signals at all? >> ...couldn't we go in fixIfBroken from the top to the tip of the >> DocIterator checking that there is an inset an the given position in

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 08:16:12PM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > > I did not think of that :-(. That could work indeed. I don't have the > > time to implement this right now, maybe this could be the occasion of a > > patch from you to signal that your come back is

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, May 30, 2007 at 02:37:43PM +0200, Jean-Marc Lasgouttes wrote: | > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > Abdelrazak> I agree but it's more work than my signal based solution | > Abdelrazak> which is assured t

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 05:46:46PM +0200, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: > > >These problems do not mean that you implemented badly, just that it is > >a bigger task than you thought. > > An by the way, the additional work required to properly handling these > cursors is

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 05:44:39PM +0200, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: > >Abdelrazak> I won't say random because as you found out you can > >Abdelrazak> predict the behaviour. > > > >After I have edited during 10 minutes in one part of the document, the > >location in the

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Martin Vermeer
On Wed, 30 May 2007 19:20:50 +0200 Andre Poenitz <[EMAIL PROTECTED]> wrote: ... > > > > >an in-inset Dimension cache (12 bytes) > > > > About the same situation as above. > > Again wrong. The most commonly used math inset (InsetMathChar) > had no dimension cache. For a very good reason that

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 03:26:04PM +0200, Alfredo Braunstein wrote: > Just a though... why do we need the invalidation signals at all? ...couldn't > we go in fixIfBroken from the top to the tip of the DocIterator checking > that there is an inset an the given position in the paragraph, and that the

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > I did not think of that :-(. That could work indeed. I don't have the > time to implement this right now, maybe this could be the occasion of a > patch from you to signal that your come back is real? :-) My come back? What, did I accidentally left? ;-) A/

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 02:42:14PM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > > Alfredo Braunstein wrote: > >> Abdelrazak Younes wrote: > >> > >>> I am not sure that registering every single DocIterator would be any > >>> more efficient that my signal/slot solution. At the en

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 02:37:43PM +0200, Jean-Marc Lasgouttes wrote: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> I agree but it's more work than my signal based solution > Abdelrazak> which is assured to work in all cases. I tell you what, in > Abdelrazak

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 02:30:37PM +0200, Abdelrazak Younes wrote: > Alfredo Braunstein wrote: > >Abdelrazak Younes wrote: > > > >>I am not sure that registering every single DocIterator would be any > >>more efficient that my signal/slot solution. At the end you will have to > >>go through a table

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Andre Poenitz
On Wed, May 30, 2007 at 08:37:09AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Tue, May 29, 2007 at 10:11:16PM +0200, Stefan Schimanski wrote: > >>I enabled stdlib-debug and then were surprised about the slowness. > >>Some profiling was full of signal/slot stuff in copying cursor

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> As I said and using Alfredo's words, I was well aware of Abdelrazak> this side-effect and I already accepted it. It would be Abdelrazak> nice to properly track the cursor location but personall

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> As I said and using Alfredo's words, I was well aware of Abdelrazak> this side-effect and I already accepted it. It would be Abdelrazak> nice to properly track the cursor location but personally Abdelrazak> I can live

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: These problems do not mean that you implemented badly, just that it is a bigger task than you thought. An by the way, the additional work required to properly handling these cursors is basically *nothing* compared to what I've done to support multipleviews ;-) A

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak> I won't say random because as you found out you can Abdelrazak> predict the behaviour. After I have edited during 10 minutes in one part of the document, the location in the other place will really seem random. Abdelrazak> We could think of the solution

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> But of course, this is not the correct solution, Abdelrazak> This is as good as one can make it ;-), at least it is Abdelrazak> better than the old Cursor::fixIsBroken() don't you Abdelrazak> reckon? Sure, but I think that,

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: For instance, put a cursor inside an inset, then in another window add or remove some text before the inset so the position of the inset changes... no destruction occurs, but is the cursor still valid? (sorry don't have svn to check here.) No,

[PATCH] Saves some memory bits (was Re: [Patch] Re: Crash when closing document)

2007-05-30 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Alfredo Braunstein wrote: Abdelrazak Younes wrote: I am not sure that registering every single DocIterator would be any more efficient that my signal/slot solution. At the end you will have to go through a table. Small remark: note that not all DocIterators need to b

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >>> Alfredo Braunstein wrote: Abdelrazak Younes wrote: > I am not sure that registering every single DocIterator would be any > more efficient that my signal/slot solution. At the end you will ha

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> No, and that is the purpose of the new method Abdelrazak> DocIterator::FixIfBroken(). This will first validate the Abdelrazak> validity of the CursorSlice (thus the existence of the Abdelrazak>

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: >> "Abdelrazak" == Abdelrazak Younes >> <[EMAIL PROTECTED]> writes: > > Abdelrazak> No, and that is the purpose of the new method > Abdelrazak> DocIterator::FixIfBroken(). This will first validate the > Abdelrazak> validity of the CursorSlice (thus the existenc

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> No, and that is the purpose of the new method Abdelrazak> DocIterator::FixIfBroken(). This will first validate the Abdelrazak> validity of the CursorSlice (thus the existence of the Abdelrazak> insets) then the validit

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Alfredo Braunstein wrote: Abdelrazak Younes wrote: I am not sure that registering every single DocIterator would be any more efficient that my signal/slot solution. At the end you will have to go through a table. Small remark: note that not

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I agree but it's more work than my signal based solution Abdelrazak> which is assured to work in all cases. I tell you what, in Abdelrazak> order to save the bits Andre is worried about I am go

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >>> I am not sure that registering every single DocIterator would be any >>> more efficient that my signal/slot solution. At the end you will have to >>> go through a table. >> >> Small remark: note that not all

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I agree but it's more work than my signal based solution Abdelrazak> which is assured to work in all cases. I tell you what, in Abdelrazak> order to save the bits Andre is worried about I am going Abdelrazak> to remove

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: I am not sure that registering every single DocIterator would be any more efficient that my signal/slot solution. At the end you will have to go through a table. Small remark: note that not all DocIterators need to be stable (mainly cursors,

Re: [Patch] Re: Crash when closing document

2007-05-30 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > I am not sure that registering every single DocIterator would be any > more efficient that my signal/slot solution. At the end you will have to > go through a table. Small remark: note that not all DocIterators need to be stable (mainly cursors, maybe also bookmarks & e

Re: [Patch] Re: Crash when closing document

2007-05-29 Thread Abdelrazak Younes
Andre Poenitz wrote: On Tue, May 29, 2007 at 10:11:16PM +0200, Stefan Schimanski wrote: I enabled stdlib-debug and then were surprised about the slowness. Some profiling was full of signal/slot stuff in copying cursors Well, I am not complaining about slowness (which hardly can be judged

Re: [Patch] Re: Crash when closing document

2007-05-29 Thread Andre Poenitz
On Tue, May 29, 2007 at 10:11:16PM +0200, Stefan Schimanski wrote: > I enabled stdlib-debug and then were surprised about the slowness. > Some profiling was full of signal/slot stuff in copying cursors Well, I am not complaining about slowness (which hardly can be judged by a non-optimized b

Re: [Patch] Re: Crash when closing document

2007-05-29 Thread José Matos
On Tuesday 29 May 2007 21:11:16 Stefan Schimanski wrote: > > I enabled stdlib-debug and then were surprised about the slowness. > Some profiling was full of signal/slot stuff in copying cursors Profiling with stdlib-debug is unfair and probably useless. :-) > Stefan -- José Abílio

Re: [Patch] Re: Crash when closing document

2007-05-29 Thread Stefan Schimanski
Am 29.05.2007 um 22:03 schrieb Andre Poenitz: On Tue, May 29, 2007 at 07:29:56PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Richard Heck wrote: Can you send me the full backtrace? What you sent suggests that the crash is being caused when the destroyed() signal is sent by the

Re: [Patch] Re: Crash when closing document

2007-05-29 Thread Andre Poenitz
On Tue, May 29, 2007 at 07:29:56PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes wrote: > >Richard Heck wrote: > >>Can you send me the full backtrace? What you sent suggests that the > >>crash is being caused when the destroyed() signal is sent by the new > >>buffer's text inset, and the only

Re: [Patch] Re: Crash when closing document

2007-05-29 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Richard Heck wrote: Can you send me the full backtrace? What you sent suggests that the crash is being caused when the destroyed() signal is sent by the new buffer's text inset, and the only thing that seems to connect to it is the CursorSlice, at lines 45 and 64 of Curs

Re: [Patch] Re: Crash when closing document

2007-05-29 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> Can you send me the full backtrace? What you sent suggests that the >> crash is being caused when the destroyed() signal is sent by the new >> buffer's text inset, and the only thing that seems to connect to it is >> the CursorSlice, at lines 45 and

[Patch] Re: Crash when closing document

2007-05-29 Thread Abdelrazak Younes
Richard Heck wrote: Can you send me the full backtrace? What you sent suggests that the crash is being caused when the destroyed() signal is sent by the new buffer's text inset, and the only thing that seems to connect to it is the CursorSlice, at lines 45 and 64 of CursorSlice.cpp. If that is