Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-25 Thread Bo Peng
On 9/25/07, Pavel Sanda <[EMAIL PROTECTED]> wrote: > > I like your affort to make a GUI for hyperref with pdf-support. I have one > > question: Many of my documents are using ERT to add hyperref and configure > > pdf-options. Are these already detected and converted? > > no, they are not. it may be

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-25 Thread Pavel Sanda
> I like your affort to make a GUI for hyperref with pdf-support. I have one > question: Many of my documents are using ERT to add hyperref and configure > pdf-options. Are these already detected and converted? no, they are not. it may be possible to detect them from preamble of older .lyx files

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-24 Thread Jean-Marc Lasgouttes
Uwe Stöhr a écrit : Jean-Marc Lasgouttes schrieb: Obviously I cannot test with embeddedobjects, but if you have a test file I can try it out here (tetex2). - Why does it not work with tetex 2? Problem of caption package version, if I remember correctly. - Why can't you update to at least

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-24 Thread Stephan Witt
Pavel Sanda schrieb: It does, I put it in. thanks (I don't understand what the "x" does.) it represents default hyperref settings. good night :) I like your affort to make a GUI for hyperref with pdf-support. I have one question: Many of my documents are using ERT to add hyperref and c

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Pavel Sanda
> It does, I put it in. thanks > (I don't understand what the "x" does.) it represents default hyperref settings. good night :) pavel

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Uwe Stöhr
Pavel Sanda schrieb: the following patch should correct this. It does, I put it in. (I don't understand what the "x" does.) regards Uwe

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Pavel Sanda
>> - Minor: when the colorlinks option is set, the option no frames should >> also be set since colorlinks does the same as the no frame option > > Perhaps implementing this only confuses people. So we can leave it as it is agreed > > its rather minor issue - when the user temporarily switch of

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Andre Poenitz
On Sat, Sep 22, 2007 at 03:07:03AM +0200, Pavel Sanda wrote: > > Pavel Sanda schrieb: > > > >> btw disagreement with your last fix > >> - opt += (pdfborder ?'1':'0'); + opt += (pdfborder ?'0':'1'); > >> havent tried but expect it will break elsewhere and also reverts the > >> semantic

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Andre Poenitz
On Fri, Sep 21, 2007 at 11:38:54AM -0400, Richard Heck wrote: > Pavel Sanda wrote: > >>>1. view source dialog is still broken (Can not update). Can anyone fix > >>>it? > >>> > >>i will look. > >> > > > >ahh, i misread your post thinking that pdf stuff broke source dialog, > >which is no

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Uwe Stöhr
As last missing piece for now, I fixed the lyx2lyx stuff: You forgot to increase the fileformat. Therefore you didn't see that your lyx2lyx routine don't work. I fixed now both: http://www.lyx.org/trac/changeset/20448 regards Uwe

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Pavel Sanda
> Dou you use the latest unicodesymbols file from trunk? If so, could you yes > please export the document to latex and rund pdflatex manually to look what this error appears before export. > character is the the problem? there was some way how to jump to the broken charakter in lyx. i wish

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
Uwe Stöhr schrieb: I just found two bugs: - once the fullscreen option is set, it can't be unset. I'll have a look at this. Fixed in http://www.lyx.org/trac/changeset/20442 - Minor: when the colorlinks option is set, the option no frames should also be set since colorlinks does the same as

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Richard Heck
there is additional patch in my stack which improves detection of changed settings in case 'use hyperref' is disabled and which get rid off saving store_option flag. this would however again change fileformat and its not clear to me, whether is good idea to proceed this way. Well, you don't w

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Pavel Sanda
>> there is additional patch in my stack which improves detection of changed >> settings in case 'use hyperref' is disabled and which get rid off saving >> store_option flag. this would however again change fileformat and its >> not clear to me, whether is good idea to proceed this way. > > I don't

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
Pavel Sanda schrieb: the following patch changes bookmark level edit box to spin box. value inside .lyx remained string though, as it would require format change. moreover it adds disabling the whole dialog when 'use hyperref' is not checked. feel free to change dialog gui, as the layout again

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
> Hmm. Its now ok here. Can you try to fix the border in the win version and > send me the patch so I can confirm that here too? I still see what I sent as screenshot and I have no idea how to fix this. regards Uwe

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
Pavel Sanda schrieb: Could you please test this by exporting the German EmbeddedObjects manual I just uploaded to SVN trunk? > Trying to export with pdflatex or ps2pdf (tetex 3.0 here): Caught "normal" exception: boost::filesystem::last_write_time Error: Encoding error ---

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: In case of latex export, the driver "ps2pdf" should be set as hyperref option, in case of pdflatex export, the driver "pdftex" should be used instead. Do we really need to set a driver? I'd think it is automatic. Yes, on new systems, but I don't know how this is

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Pavel Sanda
> > - It is possible to enter there other characters than the allowed > > numbers 0-9. > > > >>> shouldn't be the user responsible ? > >> This could be solved by making it a spin box. > > > > Yes, a spin box is the right choice here. The default should be '1'. the following

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Pavel Sanda
> > But there's one potential problem: I cannot have different options for the > > case a file is exported using latex or pdflatex. I use for example ups, havent look on the start of mail :) > This hangs as a pontetial TODO in our wiki. Lets see whet so lets see, whether we will need it. pa

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Pavel Sanda
> Pavel Sanda schrieb: > >> hyperref should be now before babel... its easy to move & play with those >> few lines so try whats the best. > > I moved it now to a position where I can compile the EmbeddedObjects > manual. This manual uses so many preamble settings and packages, so if this > can be

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: > But there's one potential problem: I cannot have different options for > the case a file is exported using latex or pdflatex. This can be checked inside LaTeXFeatures by looking at runparams().flavor. > In case of latex export, the driver "ps2pdf" should

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
Pavel Sanda schrieb: hyperref should be now before babel... its easy to move & play with those few lines so try whats the best. I moved it now to a position where I can compile the EmbeddedObjects manual. This manual uses so many preamble settings and packages, so if this can be compiled then

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Pavel Sanda
>>> - The dialog is smaller than the form, see the attached image: The >>> aditional options field and the right border are hidden. >> your change make it work under win, but broke right box width under linux. > > I haven't changed anything. The patch to the ui-file only set group styles > and co

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
Pavel Sanda schrieb: - The dialog is smaller than the form, see the attached image: The aditional options field and the right border are hidden. your change make it work under win, but broke right box width under linux. I haven't changed anything. The patch to the ui-file only set group styl

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Pavel Sanda
> - It is possible to enter there other characters than the allowed > numbers 0-9. > >>> shouldn't be the user responsible ? >> This could be solved by making it a spin box. > > Yes, a spin box is the right choice here. The default should be '1'. ok pavel

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-22 Thread Uwe Stöhr
Richard Heck schrieb: - It is possible to enter there other characters than the allowed numbers 0-9. shouldn't be the user responsible ? This could be solved by making it a spin box. Yes, a spin box is the right choice here. The default should be '1'. regards Uwe

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Richard Heck
- There is also no default value (should be "1"). i regarded it as string, which can be empty, i.e. no default value. but we can change it if you disagree. - It is possible to enter there other characters than the allowed numbers 0-9. shouldn't be the user responsible ?

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Uwe Stöhr
Pavel Sanda schrieb: Anyway, as we want to cooperate, I will write some scripts that do the job and give me svn output for you. done. can you please try this version ? :) Works, thanks. Uwe

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Uwe Stöhr
Concerning the current state of the PDF support: There are three remaining open issues: - the bookmark level field is not working: - No matter what you insert, it is converted to "False" or "True". - There is also no default value (should be "1"). - It is possible to enter there other charact

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> > > - the bookmark level field is not working: > > > - No matter what you insert, it is converted to "False" or "True". > > my trunk is in complete rebuild and it will take years.. can you try this > one ? even better follows. hyperref should be now before babel... its easy to move & play wit

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> Anyway, as we want to cooperate, I will write some scripts that do the job > and give me svn output for you. done. can you please try this version ? :) pavel Index: src/frontends/qt4/ui/PDFSupportUi.ui === --- src/frontends/qt4/ui/P

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> Pavel Sanda schrieb: > >> btw disagreement with your last fix >> - opt += (pdfborder ?'1':'0'); + opt += (pdfborder ?'0':'1'); >> havent tried but expect it will break elsewhere and also reverts the >> semantics. > > This fix is correct: the option is "no border", therefore when it

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Uwe Stöhr
Pavel Sanda schrieb: btw disagreement with your last fix - opt += (pdfborder ?'1':'0'); + opt += (pdfborder ?'0':'1'); havent tried but expect it will break elsewhere and also reverts the semantics. This fix is correct: the option is "no border", therefore when it is checked, the

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> - The dialog is smaller than the form, see the attached image: The > aditional options field and the right border are hidden. your change make it work under win, but broke right box width under linux. so next iteration, diffed against last state. pavel Index: src/frontends/qt4/ui/PDFSupportUi.u

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> > - the bookmark level field is not working: > > - No matter what you insert, it is converted to "False" or "True". my trunk is in complete rebuild and it will take years.. can you try this one ? > > - There is also no default value (should be "1"). i regarded it as string, which can be empt

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> Concerning the current state of the PDF support: > > There are three remaining open issues: thanks for report. > - the bookmark level field is not working: > - No matter what you insert, it is converted to "False" or "True". > - There is also no default value (should be "1"). > - It is poss

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> Pavel Sanda schrieb: > >> I _do_ send them as an attachment _always_. If some web archives corrupt >> it, its not my fault. But I can CC you which should solve this issue. > > Yes I see now that mail-archive.com has some problems recently. I studied meanwhile why it is so; there is way how to b

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Richard Heck
Uwe Stöhr wrote: But you already use it to check out the SVN repository. No, he's using git, which is a different kind of VCS. In this case, the advantage is that it's easy to maintain a local repository, to apply VC to your own work. To do that with svn, the easiest way is to create a branch,

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Uwe Stöhr
Pavel Sanda schrieb: I _do_ send them as an attachment _always_. If some web archives corrupt it, its not my fault. But I can CC you which should solve this issue. Yes I see now that mail-archive.com has some problems recently. I have already written and will continue to write, that the orig

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> > can you be more verbose what you mean or give me some link ? somehow i'm > > reluctant to believe that mutt would break any RFC. > > > > pavel > > http://marc.info/?t=11835435303&r=1&w=2 > > especially http://marc.info/?l=lyx-devel&m=118366121102662&w=2 > > I would not blame mutt, but a

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Bo Peng
> can you be more verbose what you mean or give me some link ? somehow i'm > reluctant to believe that mutt would break any RFC. > > pavel http://marc.info/?t=11835435303&r=1&w=2 especially http://marc.info/?l=lyx-devel&m=118366121102662&w=2 I would not blame mutt, but a line may be needed t

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> > I _do_ send them as an attachment _always_. If some web archives corrupt it, > > its not my fault. But I can CC you which should solve this issue. > > I guess you have the same problem as Abdel once had. Your attachment > should be coded as attachment. can you be more verbose what you mean or

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Bo Peng
> I _do_ send them as an attachment _always_. If some web archives corrupt it, > its not my fault. But I can CC you which should solve this issue. I guess you have the same problem as Abdel once had. Your attachment should be coded as attachment. Cheers, Bo

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> Pavel Sanda wrote: >>> or directly the SVN programm to create diffs? >> Because I don't use it. > > How do you update your tree then? git-svn rebase pavel

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Abdelrazak Younes
Pavel Sanda wrote: or directly the SVN programm to create diffs? Because I don't use it. How do you update your tree then? Abdel.

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> >> Pavel, please attach patches the next time as unified diff as email > >> attachment, this makes life much easier. > > > > This seems to be our popular issue :) > > Of course, because I cannot apply your patches but has to copy and paste > them manually. I'm sorry about that. > And I meant

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Uwe Stöhr
>> Pavel, please attach patches the next time as unified diff as email >> attachment, this makes life much easier. > > This seems to be our popular issue :) Of course, because I cannot apply your patches but has to copy and paste them manually. And I meant that whitespace issues can be avoided w

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Richard Heck
Pavel Sanda wrote: 1. view source dialog is still broken (Can not update). Can anyone fix it? i will look. ahh, i misread your post thinking that pdf stuff broke source dialog, which is not the case. seems ControlViewSource::updateContent is not entered at all. This is probab

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> > 1. view source dialog is still broken (Can not update). Can anyone fix it? > > i will look. ahh, i misread your post thinking that pdf stuff broke source dialog, which is not the case. seems ControlViewSource::updateContent is not entered at all. pavel

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Pavel Sanda
> I tried to play with the PDF property feature. > > 1. view source dialog is still broken (Can not update). Can anyone fix it? i will look. > 2. I only checked two items but your hyperref output has two lines of > options. Can you remove some of them that are using their default > values? i wa

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Andre Poenitz
On Fri, Sep 21, 2007 at 03:53:52AM +0200, Pavel Sanda wrote: > can you add this small polish ? > pavel > diff --git a/src/PDFOptions.cpp b/src/PDFOptions.cpp > index d16b9cd..0bf5a0d 100644 > --- a/src/PDFOptions.cpp > +++ b/src/PDFOptions.cpp > @@ -76,7 +76,7 @@ void PDFOptions::writeFile(ostream

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-21 Thread Andre Poenitz
On Fri, Sep 21, 2007 at 02:43:48AM +0200, Pavel Sanda wrote: > >- less than 80 - \epsilon chars per line. > > >- no tabs after the first non-tab on the line. > > > - Two empty lines between function definitions. > > > - includes roughly from most-specific to least-specific. In any case > > "ou

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Bo Peng
I tried to play with the PDF property feature. 1. view source dialog is still broken (Can not update). Can anyone fix it? 2. I only checked two items but your hyperref output has two lines of options. Can you remove some of them that are using their default values? 3. Should other items be disab

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Pavel Sanda
> If some other problem appears after fixing this, I'll investigate. yes and with this patch the hyperref support should be in a state i saw on my local branch few days ago. thanks to all the people helping in merge. enjoy :) pavel ps: Uwe, is the following patch usable by your svn ? diff --gi

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Pavel Sanda
> By the way, if you use svn diff in your local tree to prepare the patch, no i don't use svn, hard to maintain your own repository with it. > you'll get one in a form that's easier for people to use---and not have to > maintain two local copies, either. Otherwise, we have to strip the "a/". p

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Richard Heck
Pavel Sanda wrote: can you add this small polish ? Done. By the way, if you use svn diff in your local tree to prepare the patch, you'll get one in a form that's easier for people to use---and not have to maintain two local copies, either. Otherwise, we have to strip the "a/". Oh, and pa

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Pavel Sanda
can you add this small polish ? pavel diff --git a/src/PDFOptions.cpp b/src/PDFOptions.cpp index d16b9cd..0bf5a0d 100644 --- a/src/PDFOptions.cpp +++ b/src/PDFOptions.cpp @@ -76,7 +76,7 @@ void PDFOptions::writeFile(ostream & os) const } -void PDFOptions::writeLaTeX(odocstream &os) const +void

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Richard Heck
hmm. it did for me before i posted. maybe something changed in trunk meanwhile, maybe you forget to add PDFOptions.h/cpp (you forget to commit them). I think I've got it all fixed now, after the work Uwe did---he added those files, and the .ui file. So it at least compiles. If there's mo

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Richard Heck
- no "using" in headers. just to learn, why ? I made this mistake, too. The reason is that it corrupts the namespace of every file in which it is included, which makes it hard to be sure precisely what it is you are "use"ing. - A .cpp must have #include as first include. again

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Pavel Sanda
> Pavel, please attach patches the next time as unified diff as email > attachment, this makes life much easier. This seems to be our popular issue :) AFAIK this patch was unified. There maybe some special parameter for Windows version of svn, to make equivalent of unix "patch --strip 1"? Other p

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Pavel Sanda
>- less than 80 - \epsilon chars per line. >- no tabs after the first non-tab on the line. > - Two empty lines between function definitions. > - includes roughly from most-specific to least-specific. In any case > "ours" before "system" headers/. > - A .cpp must have #include as first includ

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Uwe Stöhr
> A few items: > > - less than 80 - \epsilon chars per line. I fixed some of them. Pavel, please attach patches the next time as unified diff as email attachment, this makes life much easier. > - no tabs after the first non-tab on the line. I fixed some of them. > I'll commit a modified vers

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Andre Poenitz
On Tue, Sep 18, 2007 at 01:53:24AM +0200, Pavel Sanda wrote: > > This one is wrong: you should find a way to add your code to > > lyxpreamble, because as it is you break the line counting (for error > > parsing) that is done a few lines above. Something like: > > didnt know that, now i added a com

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Andre Poenitz
On Thu, Sep 20, 2007 at 02:32:57PM +0200, Pavel Sanda wrote: > > > More comments: > > > > > > > + } else if (token == "\\use_hyperref") { > > > > + lex >> pdfoptions().use_hyperref; > > > > + } else if (token == "\\pdf_title") { > > > > + lex >> pdfoptions()

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-20 Thread Pavel Sanda
> > More comments: > > > > > + } else if (token == "\\use_hyperref") { > > > + lex >> pdfoptions().use_hyperref; > > > + } else if (token == "\\pdf_title") { > > > + lex >> pdfoptions().title; > > > + } else if (token == "\\pdf_author") { > > > + lex >> pdfoptions().author;

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-17 Thread Richard Heck
Pavel Sanda wrote: This one is wrong: you should find a way to add your code to lyxpreamble, because as it is you break the line counting (for error parsing) that is done a few lines above. Something like: didnt know that, now i added a comment and moved the code. look into attachment - is

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-17 Thread Pavel Sanda
> More comments: > > > + } else if (token == "\\use_hyperref") { > > + lex >> pdfoptions().use_hyperref; > > + } else if (token == "\\pdf_title") { > > + lex >> pdfoptions().title; > > + } else if (token == "\\pdf_author") { > > + lex >> pdfoptions().author; >