On Tue, Sep 18, 2007 at 01:53:24AM +0200, Pavel Sanda wrote:
> > This one is wrong: you should find a way to add your code to
> > lyxpreamble, because as it is you break the line counting (for error
> > parsing) that is done a few lines above. Something like:
>
> didnt know that, now i added a comment and moved the code. look into
> attachment - is it ok now ?
Erm. No.
A few items:
- less than 80 - \epsilon chars per line.
- no tabs after the first non-tab on the line.
- spacing was off a few times.
- no "using" in headers.
- no unneeded includes, especially in headers (there was a spurious
#include <debug.h>. Apart from that "our" headers would use "...",
not <...>
- includes roughly from most-specific to least-specific. In any case
"ours" before "system" headers/.
- A .cpp must have #include <config.h> as first include. The patch as-is
does not even link for me.
- Two empty lines between function definitions.
I'll commit a modified version of your patch shortly nevertheless.
Please check that everything still works as intended.
Andre'
PS: Inspite of the comments above: Nice work.
